From: Dmitry Osipenko <digetx@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mikko Perttunen <cyndis@kapsi.fi>
Cc: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 13/36] PM / devfreq: tegra30: Use MC timings for building OPP table
Date: Fri, 28 Aug 2020 11:30:25 +0300 [thread overview]
Message-ID: <a11d60af-3a67-6a76-57ae-7cb9bad13bed@gmail.com> (raw)
In-Reply-To: <2a255211-5426-d78f-d266-cdb958f4c658@samsung.com>
28.08.2020 04:47, Chanwoo Choi пишет:
> Hi,
...
>> Hence the NULL-checking is unnecessary.
>>
>> When I first encountered the of_device_get_match_data(), I was also
>> thinking that adding the NULL-checks is a good idea, but later on
>> somebody pointed out to me (maybe Thierry) that it's unnecessary to do.
>
> OK. Thanks.
>
>>
>>>> +
>>>> + mc = tegra_get_memory_controller(soc_data->mc_compatible);
>>>> + if (IS_ERR(mc))
>>>> + return PTR_ERR(mc);
>>>
>>> You better to add error log.
>>
>> In practice we should get only -EPROBE_DEFER here ever. I'll consider
>> adding the message in the next revision, at least just for consistency.
>
> In order to handle -EPROBE_DEFER, recommend the using of dev_err_probe().
Hello, Chanwoo!
Thank you for the suggestion! I wasn't aware about the dev_err_probe()
until recently and will use this new helper in the v6!
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mikko Perttunen <cyndis@kapsi.fi>
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 13/36] PM / devfreq: tegra30: Use MC timings for building OPP table
Date: Fri, 28 Aug 2020 11:30:25 +0300 [thread overview]
Message-ID: <a11d60af-3a67-6a76-57ae-7cb9bad13bed@gmail.com> (raw)
In-Reply-To: <2a255211-5426-d78f-d266-cdb958f4c658@samsung.com>
28.08.2020 04:47, Chanwoo Choi пишет:
> Hi,
...
>> Hence the NULL-checking is unnecessary.
>>
>> When I first encountered the of_device_get_match_data(), I was also
>> thinking that adding the NULL-checks is a good idea, but later on
>> somebody pointed out to me (maybe Thierry) that it's unnecessary to do.
>
> OK. Thanks.
>
>>
>>>> +
>>>> + mc = tegra_get_memory_controller(soc_data->mc_compatible);
>>>> + if (IS_ERR(mc))
>>>> + return PTR_ERR(mc);
>>>
>>> You better to add error log.
>>
>> In practice we should get only -EPROBE_DEFER here ever. I'll consider
>> adding the message in the next revision, at least just for consistency.
>
> In order to handle -EPROBE_DEFER, recommend the using of dev_err_probe().
Hello, Chanwoo!
Thank you for the suggestion! I wasn't aware about the dev_err_probe()
until recently and will use this new helper in the v6!
Thanks!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-28 8:30 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 0:05 [PATCH v5 00/36] Introduce memory interconnect for NVIDIA Tegra SoCs Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 01/36] clk: Export clk_hw_reparent() Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 02/36] clk: tegra: Remove Memory Controller lock Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 03/36] clk: tegra: Export Tegra20 EMC kernel symbols Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 04/36] memory: tegra20-emc: Make driver modular Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 05/36] memory: tegra30-emc: " Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 06/36] memory: tegra124-emc: " Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 07/36] memory: tegra124-emc: Use devm_platform_ioremap_resource Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 08/36] soc/tegra: fuse: Export tegra_read_ram_code() Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 09/36] memory: tegra20-emc: Initialize MC timings Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 10/36] PM / devfreq: tegra20: Silence deferred probe error Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 11/36] PM / devfreq: tegra30: " Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 12/36] PM / devfreq: tegra20: Use MC timings for building OPP table Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 1:00 ` Chanwoo Choi
2020-08-14 1:00 ` Chanwoo Choi
2020-08-14 0:05 ` [PATCH v5 13/36] PM / devfreq: tegra30: " Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 2:02 ` Chanwoo Choi
2020-08-14 2:02 ` Chanwoo Choi
2020-08-14 16:47 ` Dmitry Osipenko
2020-08-14 16:47 ` Dmitry Osipenko
2020-08-28 1:47 ` Chanwoo Choi
2020-08-28 1:47 ` Chanwoo Choi
2020-08-28 8:30 ` Dmitry Osipenko [this message]
2020-08-28 8:30 ` Dmitry Osipenko
2020-08-14 0:05 ` [PATCH v5 14/36] PM / devfreq: tegra20: Add error messages to tegra_devfreq_target() Dmitry Osipenko
2020-08-14 0:05 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 15/36] PM / devfreq: tegra30: " Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 16/36] PM / devfreq: tegra20: Adjust clocks conversion ratio and polling interval Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 17/36] PM / devfreq: tegra20: Relax Kconfig dependency Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 18/36] dt-bindings: memory: tegra20: mc: Document new interconnect property Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 19/36] dt-bindings: memory: tegra20: emc: " Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 20/36] dt-bindings: memory: tegra30: mc: " Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 21/36] dt-bindings: memory: tegra30: emc: " Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 22/36] dt-bindings: host1x: Document new interconnect properties Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-25 2:09 ` Rob Herring
2020-08-25 2:09 ` Rob Herring
2020-08-14 0:06 ` [PATCH v5 23/36] dt-bindings: memory: tegra20: Add memory client IDs Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 24/36] dt-bindings: memory: tegra30: " Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 25/36] ARM: tegra: Add interconnect properties to Tegra20 device-tree Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 26/36] ARM: tegra: Add interconnect properties to Tegra30 device-tree Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 27/36] memory: tegra-mc: Register as interconnect provider Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-09-09 8:31 ` Georgi Djakov
2020-09-09 8:31 ` Georgi Djakov
2020-09-09 21:15 ` Dmitry Osipenko
2020-09-09 21:15 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 28/36] memory: tegra20-emc: Use devm_platform_ioremap_resource Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 29/36] memory: tegra20-emc: Continue probing if timings are missing in device-tree Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 30/36] memory: tegra20-emc: Register as interconnect provider Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-09-09 8:32 ` Georgi Djakov
2020-09-09 8:32 ` Georgi Djakov
2020-08-14 0:06 ` [PATCH v5 31/36] memory: tegra20-emc: Create tegra20-devfreq device Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 32/36] memory: tegra30-emc: Continue probing if timings are missing in device-tree Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 33/36] memory: tegra30-emc: Register as interconnect provider Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-09-09 8:32 ` Georgi Djakov
2020-09-09 8:32 ` Georgi Djakov
2020-08-14 0:06 ` [PATCH v5 34/36] drm/tegra: dc: Support memory bandwidth management Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 35/36] drm/tegra: dc: Tune up high priority request controls for Tegra20 Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
2020-08-14 0:06 ` [PATCH v5 36/36] drm/tegra: dc: Extend debug stats with total number of events Dmitry Osipenko
2020-08-14 0:06 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a11d60af-3a67-6a76-57ae-7cb9bad13bed@gmail.com \
--to=digetx@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=cyndis@kapsi.fi \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=pdeschrijver@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.