From: Sumit Gupta <sumitg@nvidia.com>
To: Marc Zyngier <maz@kernel.org>, Krishna Reddy <vdumpa@nvidia.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"eric.auger.pro@gmail.com" <eric.auger.pro@gmail.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"jiangkunkun@huawei.com" <jiangkunkun@huawei.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lushenming@huawei.com" <lushenming@huawei.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"tn@semihalf.com" <tn@semihalf.com>,
"vivek.gautam@arm.com" <vivek.gautam@arm.com>,
Vikram Sethi <vsethi@nvidia.com>,
"wangxingang5@huawei.com" <wangxingang5@huawei.com>,
"will@kernel.org" <will@kernel.org>,
"zhangfei.gao@linaro.org" <zhangfei.gao@linaro.org>,
"zhukeqian1@huawei.com" <zhukeqian1@huawei.com>,
Sachin Nikam <Snikam@nvidia.com>, Bibek Basu <bbasu@nvidia.com>,
Shanker Donthineni <sdonthineni@nvidia.com>,
Sumit Gupta <sumitg@nvidia.com>
Subject: Re: [PATCH v14 00/13] SMMUv3 Nested Stage Setup (IOMMU part)
Date: Sat, 24 Apr 2021 16:59:15 +0530 [thread overview]
Message-ID: <a372b4b6-ae34-c618-3569-4d5f5ab760c1@nvidia.com> (raw)
In-Reply-To: <87r1j0rqzk.wl-maz@kernel.org>
>> I have worked around the issue by filtering out the request if the
>> pfn is not valid in __clean_dcache_guest_page(). As the patch
>> wasn't posted in the community, reverted it as well.
>
> That's papering over the real issue, and this mapping path needs
> fixing as it was only ever expected to be called for CoW.
>
> Can you please try the following patch and let me know if that fixes
> the issue for good?
>
Hi Marc,
Thank you for the patch. This patch fixed the crash for me.
For the formal patch, please add:
Tested-by: Sumit Gupta <sumitg@nvidia.com>
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 77cb2d28f2a4..b62dd40a4083 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
> @@ -1147,7 +1147,8 @@ int kvm_set_spte_hva(struct kvm *kvm, unsigned long hva, pte_t pte)
> * We've moved a page around, probably through CoW, so let's treat it
> * just like a translation fault and clean the cache to the PoC.
> */
> - clean_dcache_guest_page(pfn, PAGE_SIZE);
> + if (!kvm_is_device_pfn(pfn))
> + clean_dcache_guest_page(pfn, PAGE_SIZE);
> handle_hva_to_gpa(kvm, hva, end, &kvm_set_spte_handler, &pfn);
> return 0;
> }
>
>
> --
> Without deviation from the norm, progress is not possible.
>
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Gupta <sumitg@nvidia.com>
To: Marc Zyngier <maz@kernel.org>, Krishna Reddy <vdumpa@nvidia.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"vivek.gautam@arm.com" <vivek.gautam@arm.com>,
"will@kernel.org" <will@kernel.org>,
"eric.auger.pro@gmail.com" <eric.auger.pro@gmail.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"wangxingang5@huawei.com" <wangxingang5@huawei.com>,
"jiangkunkun@huawei.com" <jiangkunkun@huawei.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Vikram Sethi <vsethi@nvidia.com>, Bibek Basu <bbasu@nvidia.com>,
"zhangfei.gao@linaro.org" <zhangfei.gao@linaro.org>,
Shanker Donthineni <sdonthineni@nvidia.com>,
Sachin Nikam <Snikam@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lushenming@huawei.com" <lushenming@huawei.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [PATCH v14 00/13] SMMUv3 Nested Stage Setup (IOMMU part)
Date: Sat, 24 Apr 2021 16:59:15 +0530 [thread overview]
Message-ID: <a372b4b6-ae34-c618-3569-4d5f5ab760c1@nvidia.com> (raw)
In-Reply-To: <87r1j0rqzk.wl-maz@kernel.org>
>> I have worked around the issue by filtering out the request if the
>> pfn is not valid in __clean_dcache_guest_page(). As the patch
>> wasn't posted in the community, reverted it as well.
>
> That's papering over the real issue, and this mapping path needs
> fixing as it was only ever expected to be called for CoW.
>
> Can you please try the following patch and let me know if that fixes
> the issue for good?
>
Hi Marc,
Thank you for the patch. This patch fixed the crash for me.
For the formal patch, please add:
Tested-by: Sumit Gupta <sumitg@nvidia.com>
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 77cb2d28f2a4..b62dd40a4083 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
> @@ -1147,7 +1147,8 @@ int kvm_set_spte_hva(struct kvm *kvm, unsigned long hva, pte_t pte)
> * We've moved a page around, probably through CoW, so let's treat it
> * just like a translation fault and clean the cache to the PoC.
> */
> - clean_dcache_guest_page(pfn, PAGE_SIZE);
> + if (!kvm_is_device_pfn(pfn))
> + clean_dcache_guest_page(pfn, PAGE_SIZE);
> handle_hva_to_gpa(kvm, hva, end, &kvm_set_spte_handler, &pfn);
> return 0;
> }
>
>
> --
> Without deviation from the norm, progress is not possible.
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Gupta <sumitg@nvidia.com>
To: Marc Zyngier <maz@kernel.org>, Krishna Reddy <vdumpa@nvidia.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"vivek.gautam@arm.com" <vivek.gautam@arm.com>,
"will@kernel.org" <will@kernel.org>,
"eric.auger.pro@gmail.com" <eric.auger.pro@gmail.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"wangxingang5@huawei.com" <wangxingang5@huawei.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Vikram Sethi <vsethi@nvidia.com>, Bibek Basu <bbasu@nvidia.com>,
"zhangfei.gao@linaro.org" <zhangfei.gao@linaro.org>,
Sumit Gupta <sumitg@nvidia.com>,
Shanker Donthineni <sdonthineni@nvidia.com>,
Sachin Nikam <Snikam@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lushenming@huawei.com" <lushenming@huawei.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [PATCH v14 00/13] SMMUv3 Nested Stage Setup (IOMMU part)
Date: Sat, 24 Apr 2021 16:59:15 +0530 [thread overview]
Message-ID: <a372b4b6-ae34-c618-3569-4d5f5ab760c1@nvidia.com> (raw)
In-Reply-To: <87r1j0rqzk.wl-maz@kernel.org>
>> I have worked around the issue by filtering out the request if the
>> pfn is not valid in __clean_dcache_guest_page(). As the patch
>> wasn't posted in the community, reverted it as well.
>
> That's papering over the real issue, and this mapping path needs
> fixing as it was only ever expected to be called for CoW.
>
> Can you please try the following patch and let me know if that fixes
> the issue for good?
>
Hi Marc,
Thank you for the patch. This patch fixed the crash for me.
For the formal patch, please add:
Tested-by: Sumit Gupta <sumitg@nvidia.com>
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 77cb2d28f2a4..b62dd40a4083 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
> @@ -1147,7 +1147,8 @@ int kvm_set_spte_hva(struct kvm *kvm, unsigned long hva, pte_t pte)
> * We've moved a page around, probably through CoW, so let's treat it
> * just like a translation fault and clean the cache to the PoC.
> */
> - clean_dcache_guest_page(pfn, PAGE_SIZE);
> + if (!kvm_is_device_pfn(pfn))
> + clean_dcache_guest_page(pfn, PAGE_SIZE);
> handle_hva_to_gpa(kvm, hva, end, &kvm_set_spte_handler, &pfn);
> return 0;
> }
>
>
> --
> Without deviation from the norm, progress is not possible.
>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2021-04-24 11:29 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 20:56 [PATCH v14 00/13] SMMUv3 Nested Stage Setup (IOMMU part) Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 01/13] iommu: Introduce attach/detach_pasid_table API Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 02/13] iommu: Introduce bind/unbind_guest_msi Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 03/13] iommu/smmuv3: Allow s1 and s2 configs to coexist Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 04/13] iommu/smmuv3: Get prepared for nested stage support Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 05/13] iommu/smmuv3: Implement attach/detach_pasid_table Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-03-02 8:35 ` Keqian Zhu
2021-03-02 8:35 ` Keqian Zhu
2021-03-02 8:35 ` Keqian Zhu
2021-03-19 13:15 ` Auger Eric
2021-03-19 13:15 ` Auger Eric
2021-03-19 13:15 ` Auger Eric
2021-03-22 6:23 ` Keqian Zhu
2021-03-22 6:23 ` Keqian Zhu
2021-03-22 6:23 ` Keqian Zhu
2021-02-23 20:56 ` [PATCH v14 06/13] iommu/smmuv3: Allow stage 1 invalidation with unmanaged ASIDs Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-03-30 9:17 ` Zenghui Yu
2021-03-30 9:17 ` Zenghui Yu
2021-03-30 9:17 ` Zenghui Yu
2021-04-01 9:38 ` Auger Eric
2021-04-01 9:38 ` Auger Eric
2021-04-01 9:38 ` Auger Eric
2021-04-01 12:37 ` Kunkun Jiang
2021-04-01 12:37 ` Kunkun Jiang
2021-04-01 12:37 ` Kunkun Jiang
2021-04-08 12:30 ` Auger Eric
2021-04-08 12:30 ` Auger Eric
2021-04-08 12:30 ` Auger Eric
2021-04-09 4:48 ` Kunkun Jiang
2021-04-09 4:48 ` Kunkun Jiang
2021-04-09 4:48 ` Kunkun Jiang
2021-04-09 8:31 ` Auger Eric
2021-04-09 8:31 ` Auger Eric
2021-04-09 8:31 ` Auger Eric
2021-04-09 9:43 ` Kunkun Jiang
2021-04-09 9:43 ` Kunkun Jiang
2021-04-09 9:43 ` Kunkun Jiang
2021-02-23 20:56 ` [PATCH v14 07/13] iommu/smmuv3: Implement cache_invalidate Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-03-04 7:55 ` chenxiang (M)
2021-03-04 7:55 ` chenxiang (M)
2021-03-19 17:36 ` Auger Eric
2021-03-19 17:36 ` Auger Eric
2021-03-19 17:36 ` Auger Eric
2021-03-22 6:40 ` [Linuxarm] " chenxiang (M)
2021-03-22 6:40 ` chenxiang (M)
2021-03-22 6:40 ` chenxiang (M)
2021-03-22 9:05 ` Auger Eric
2021-03-22 9:05 ` Auger Eric
2021-03-22 9:05 ` Auger Eric
2021-03-23 1:28 ` chenxiang (M)
2021-03-23 1:28 ` chenxiang (M)
2021-03-23 1:28 ` chenxiang (M)
2021-04-01 6:11 ` Zenghui Yu
2021-04-01 6:11 ` Zenghui Yu
2021-04-01 6:11 ` Zenghui Yu
2021-04-01 12:06 ` Auger Eric
2021-04-01 12:06 ` Auger Eric
2021-04-01 12:06 ` Auger Eric
2021-02-23 20:56 ` [PATCH v14 08/13] dma-iommu: Implement NESTED_MSI cookie Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-04-07 7:39 ` Zenghui Yu
2021-04-07 7:39 ` Zenghui Yu
2021-04-07 7:39 ` Zenghui Yu
2021-04-10 13:34 ` Auger Eric
2021-04-10 13:34 ` Auger Eric
2021-04-10 13:34 ` Auger Eric
2021-02-23 20:56 ` [PATCH v14 09/13] iommu/smmuv3: Nested mode single MSI doorbell per domain enforcement Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 10/13] iommu/smmuv3: Enforce incompatibility between nested mode and HW MSI regions Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 11/13] iommu/smmuv3: Implement bind/unbind_guest_msi Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 12/13] iommu/smmuv3: report additional recoverable faults Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` [PATCH v14 13/13] iommu/smmuv3: Accept configs with more than one context descriptor Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-02-23 20:56 ` Eric Auger
2021-03-30 9:23 ` Zenghui Yu
2021-03-30 9:23 ` Zenghui Yu
2021-03-30 9:23 ` Zenghui Yu
2021-04-01 11:48 ` Auger Eric
2021-04-01 11:48 ` Auger Eric
2021-04-01 11:48 ` Auger Eric
2021-04-01 12:38 ` Shameerali Kolothum Thodi
2021-04-01 12:38 ` Shameerali Kolothum Thodi
2021-04-01 12:38 ` Shameerali Kolothum Thodi
2021-04-01 13:20 ` Auger Eric
2021-04-01 13:20 ` Auger Eric
2021-04-01 13:20 ` Auger Eric
2021-02-25 16:06 ` [PATCH v14 00/13] SMMUv3 Nested Stage Setup (IOMMU part) Auger Eric
2021-02-25 16:06 ` Auger Eric
2021-02-25 16:06 ` Auger Eric
2021-04-22 15:04 ` Sumit Gupta
2021-04-22 15:04 ` Sumit Gupta
2021-04-22 15:04 ` Sumit Gupta
2021-04-23 13:00 ` Jean-Philippe Brucker
2021-04-23 13:00 ` Jean-Philippe Brucker
2021-04-23 13:00 ` Jean-Philippe Brucker
2021-04-23 17:16 ` Sumit Gupta
2021-04-23 17:16 ` Sumit Gupta
2021-04-23 17:16 ` Sumit Gupta
2021-04-23 17:58 ` Krishna Reddy
2021-04-23 17:58 ` Krishna Reddy
2021-04-23 17:58 ` Krishna Reddy
2021-04-23 18:19 ` Sumit Gupta
2021-04-23 18:19 ` Sumit Gupta
2021-04-23 18:19 ` Sumit Gupta
2021-04-24 9:06 ` Marc Zyngier
2021-04-24 9:06 ` Marc Zyngier
2021-04-24 9:06 ` Marc Zyngier
2021-04-24 11:29 ` Sumit Gupta [this message]
2021-04-24 11:29 ` Sumit Gupta
2021-04-24 11:29 ` Sumit Gupta
2021-03-18 0:16 ` Krishna Reddy
2021-03-18 0:16 ` Krishna Reddy
2021-03-18 0:16 ` Krishna Reddy
2021-03-19 13:17 ` Auger Eric
2021-03-19 13:17 ` Auger Eric
2021-03-19 13:17 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a372b4b6-ae34-c618-3569-4d5f5ab760c1@nvidia.com \
--to=sumitg@nvidia.com \
--cc=Snikam@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=bbasu@nvidia.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jiangkunkun@huawei.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=lushenming@huawei.com \
--cc=maz@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sdonthineni@nvidia.com \
--cc=tn@semihalf.com \
--cc=vdumpa@nvidia.com \
--cc=vivek.gautam@arm.com \
--cc=vsethi@nvidia.com \
--cc=wangxingang5@huawei.com \
--cc=will@kernel.org \
--cc=zhangfei.gao@linaro.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.