From: Jingoo Han <jg1.han@samsung.com>
To: "'Antoine Ténart'" <antoine.tenart@free-electrons.com>
Cc: sebastian.hesselbarth@gmail.com, Peter.Chen@freescale.com,
alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH v2 07/12] usb: chipidea: add a generic driver
Date: Tue, 24 Jun 2014 19:51:01 +0900 [thread overview]
Message-ID: <000001cf8f9a$3045f3a0$90d1dae0$%han@samsung.com> (raw)
In-Reply-To: <1403606121-6368-8-git-send-email-antoine.tenart@free-electrons.com>
On Tuesday, June 24, 2014 7:35 PM, Antoine Tenart wrote:
>
> Add a generic ChipIdea driver, with optional PHY and clock, to support
> ChipIdea controllers that doesn't need specific functions.
s/doesn't/don't
>
> Needed for the Marvell Berlin SoCs SUB controllers.
s/SUB/USB
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
> drivers/usb/chipidea/Makefile | 1 +
> drivers/usb/chipidea/ci_hdrc_generic.c | 108 +++++++++++++++++++++++++++++++++
> 2 files changed, 109 insertions(+)
> create mode 100644 drivers/usb/chipidea/ci_hdrc_generic.c
>
> diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
> index 2f099c7df7b5..c705f0fe7a00 100644
> --- a/drivers/usb/chipidea/Makefile
> +++ b/drivers/usb/chipidea/Makefile
> @@ -20,4 +20,5 @@ endif
>
> ifneq ($(CONFIG_OF),)
> obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o ci_hdrc_imx.o
> + obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_generic.o
> endif
> diff --git a/drivers/usb/chipidea/ci_hdrc_generic.c b/drivers/usb/chipidea/ci_hdrc_generic.c
> new file mode 100644
> index 000000000000..27520710a1f7
> --- /dev/null
> +++ b/drivers/usb/chipidea/ci_hdrc_generic.c
[...]
> +
> +MODULE_DESCRIPTION("Generic ChipIdea HDRC USB binding");
> +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
How about "GPL v2"?
Best regards,
Jingoo Han
> --
> 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: jg1.han@samsung.com (Jingoo Han)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/12] usb: chipidea: add a generic driver
Date: Tue, 24 Jun 2014 19:51:01 +0900 [thread overview]
Message-ID: <000001cf8f9a$3045f3a0$90d1dae0$%han@samsung.com> (raw)
In-Reply-To: <1403606121-6368-8-git-send-email-antoine.tenart@free-electrons.com>
On Tuesday, June 24, 2014 7:35 PM, Antoine Tenart wrote:
>
> Add a generic ChipIdea driver, with optional PHY and clock, to support
> ChipIdea controllers that doesn't need specific functions.
s/doesn't/don't
>
> Needed for the Marvell Berlin SoCs SUB controllers.
s/SUB/USB
> Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
> ---
> drivers/usb/chipidea/Makefile | 1 +
> drivers/usb/chipidea/ci_hdrc_generic.c | 108 +++++++++++++++++++++++++++++++++
> 2 files changed, 109 insertions(+)
> create mode 100644 drivers/usb/chipidea/ci_hdrc_generic.c
>
> diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
> index 2f099c7df7b5..c705f0fe7a00 100644
> --- a/drivers/usb/chipidea/Makefile
> +++ b/drivers/usb/chipidea/Makefile
> @@ -20,4 +20,5 @@ endif
>
> ifneq ($(CONFIG_OF),)
> obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o ci_hdrc_imx.o
> + obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_generic.o
> endif
> diff --git a/drivers/usb/chipidea/ci_hdrc_generic.c b/drivers/usb/chipidea/ci_hdrc_generic.c
> new file mode 100644
> index 000000000000..27520710a1f7
> --- /dev/null
> +++ b/drivers/usb/chipidea/ci_hdrc_generic.c
[...]
> +
> +MODULE_DESCRIPTION("Generic ChipIdea HDRC USB binding");
> +MODULE_AUTHOR("Antoine T?nart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
How about "GPL v2"?
Best regards,
Jingoo Han
> --
> 1.9.1
next prev parent reply other threads:[~2014-06-24 10:51 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 10:35 [PATCH v2 00/12] ARM: berlin: USB support Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 01/12] reset: add the Berlin reset controller driver Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 11:13 ` Philipp Zabel
2014-06-24 11:13 ` Philipp Zabel
2014-06-24 12:05 ` Antoine Ténart
2014-06-24 12:05 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 11:14 ` Philipp Zabel
2014-06-24 11:14 ` Philipp Zabel
2014-06-24 11:14 ` Philipp Zabel
2014-06-24 10:35 ` [PATCH v2 03/12] ARM: Berlin: select the reset controller Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 11:14 ` Philipp Zabel
2014-06-24 11:14 ` Philipp Zabel
2014-06-24 11:14 ` Philipp Zabel
2014-06-24 10:35 ` [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-27 15:56 ` Felipe Balbi
2014-06-27 15:56 ` Felipe Balbi
2014-06-27 16:05 ` Antoine Ténart
2014-06-27 16:05 ` Antoine Ténart
2014-06-27 23:04 ` Felipe Balbi
2014-06-27 23:04 ` Felipe Balbi
2014-06-30 14:52 ` Antoine Ténart
2014-06-30 14:52 ` Antoine Ténart
2014-06-30 18:34 ` Felipe Balbi
2014-06-30 18:34 ` Felipe Balbi
2014-06-24 10:35 ` [PATCH v2 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 07/12] usb: chipidea: add a generic driver Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:51 ` Jingoo Han [this message]
2014-06-24 10:51 ` Jingoo Han
2014-06-30 13:39 ` Antoine Ténart
2014-06-30 13:39 ` Antoine Ténart
2014-06-27 3:25 ` Peter Chen
2014-06-27 3:25 ` Peter Chen
2014-06-27 3:41 ` Peter Chen
2014-06-27 3:41 ` Peter Chen
2014-06-30 13:33 ` Antoine Ténart
2014-06-30 13:33 ` Antoine Ténart
2014-07-01 0:21 ` Peter Chen
2014-07-01 0:21 ` Peter Chen
2014-07-01 7:24 ` Antoine Ténart
2014-07-01 7:24 ` Antoine Ténart
2014-07-01 8:55 ` Sebastian Hesselbarth
2014-07-01 8:55 ` Sebastian Hesselbarth
2014-07-01 8:30 ` Peter Chen
2014-07-01 8:30 ` Peter Chen
2014-07-01 10:42 ` Alexandre Belloni
2014-07-01 10:42 ` Alexandre Belloni
2014-07-01 15:18 ` Sergei Shtylyov
2014-07-01 15:18 ` Sergei Shtylyov
2014-07-02 1:10 ` Peter Chen
2014-07-02 1:10 ` Peter Chen
2014-07-15 15:22 ` Antoine Ténart
2014-07-15 15:22 ` Antoine Ténart
2014-07-16 0:32 ` Peter Chen
2014-07-16 0:32 ` Peter Chen
2014-07-03 2:47 ` punnaiah choudary kalluri
2014-07-03 2:47 ` punnaiah choudary kalluri
2014-07-15 15:24 ` Antoine Ténart
2014-07-15 15:24 ` Antoine Ténart
2014-07-16 0:44 ` Peter Chen
2014-07-16 0:44 ` Peter Chen
2014-06-24 10:35 ` [PATCH v2 08/12] Documentation: bindings: add doc for the generic ChipIdea USB driver Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cf8f9a$3045f3a0$90d1dae0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=Peter.Chen@freescale.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.