All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Peter Chen <Peter.Chen@freescale.com>
Cc: "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
	"Alexandre Belloni" <alexandre.belloni@free-electrons.com>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Antoine Ténart" <antoine.tenart@free-electrons.com>,
	"thomas.petazzoni@free-electrons.com"
	<thomas.petazzoni@free-electrons.com>,
	"zmxu@marvell.com" <zmxu@marvell.com>,
	"jszhang@marvell.com" <jszhang@marvell.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 07/12] usb: chipidea: add a generic driver
Date: Tue, 15 Jul 2014 17:22:30 +0200	[thread overview]
Message-ID: <20140715152230.GE1011@kwain> (raw)
In-Reply-To: <1d01427f91084d67bf63721e2267e160@BL2PR03MB226.namprd03.prod.outlook.com>

Hi guys,

On Wed, Jul 02, 2014 at 01:10:00AM +0000, Peter Chen wrote:
> > On 07/01/2014 02:42 PM, Alexandre Belloni wrote:
> > 
> > >>>>> Well, there is nothing specific about the Berlin CI. Some
> > >>>>> subsystems use the 'generic' keyword in these cases. Do you see a
> > >>>>> particular reason I should use some Berlin related compatible here?
> > 
> > >>>> Not must, one suggestion is: can you change the compatible string
> > >>>> to "chipidea-usb-generic"?
> > 
> > >>> I don't know about ChipIdea/ARC/DW's product portfolio but I guess
> > >>> the compatible should also carry '2.0' or 'usb2' in it. Or we just
> > >>> use some version number like 'chipidea,ci13000' or 'chipidea,ci13xxx'.
> > 
> > >> The recommended format for compatible string is:
> > >> "manufacturer,model", I agree with "chipidea,ci13xxx", thanks.
> > 
> > > I think we should probably avoid using wildcards in the compatible
> > > string.
> > 
> >     I'm sure wildcards shouldn't be allowed there. :-)
> 
> Then, what's your guys recommend, how about "chipidea,usb2-generic"?

So what do you think? "chipidea,ci13", "chipidea,usb2-generic" or
something else?

I tend to prefer something without the 'generic' keyword.

After updating the compatible I'll send a v3 based on USB changes
introducing the generic PHY support[1].

[1] https://lkml.org/lkml/2014/7/15/330


Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: antoine.tenart@free-electrons.com (Antoine Ténart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/12] usb: chipidea: add a generic driver
Date: Tue, 15 Jul 2014 17:22:30 +0200	[thread overview]
Message-ID: <20140715152230.GE1011@kwain> (raw)
In-Reply-To: <1d01427f91084d67bf63721e2267e160@BL2PR03MB226.namprd03.prod.outlook.com>

Hi guys,

On Wed, Jul 02, 2014 at 01:10:00AM +0000, Peter Chen wrote:
> > On 07/01/2014 02:42 PM, Alexandre Belloni wrote:
> > 
> > >>>>> Well, there is nothing specific about the Berlin CI. Some
> > >>>>> subsystems use the 'generic' keyword in these cases. Do you see a
> > >>>>> particular reason I should use some Berlin related compatible here?
> > 
> > >>>> Not must, one suggestion is: can you change the compatible string
> > >>>> to "chipidea-usb-generic"?
> > 
> > >>> I don't know about ChipIdea/ARC/DW's product portfolio but I guess
> > >>> the compatible should also carry '2.0' or 'usb2' in it. Or we just
> > >>> use some version number like 'chipidea,ci13000' or 'chipidea,ci13xxx'.
> > 
> > >> The recommended format for compatible string is:
> > >> "manufacturer,model", I agree with "chipidea,ci13xxx", thanks.
> > 
> > > I think we should probably avoid using wildcards in the compatible
> > > string.
> > 
> >     I'm sure wildcards shouldn't be allowed there. :-)
> 
> Then, what's your guys recommend, how about "chipidea,usb2-generic"?

So what do you think? "chipidea,ci13", "chipidea,usb2-generic" or
something else?

I tend to prefer something without the 'generic' keyword.

After updating the compatible I'll send a v3 based on USB changes
introducing the generic PHY support[1].

[1] https://lkml.org/lkml/2014/7/15/330


Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-07-15 15:22 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 10:35 [PATCH v2 00/12] ARM: berlin: USB support Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 01/12] reset: add the Berlin reset controller driver Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 11:13   ` Philipp Zabel
2014-06-24 11:13     ` Philipp Zabel
2014-06-24 12:05     ` Antoine Ténart
2014-06-24 12:05       ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 11:14   ` Philipp Zabel
2014-06-24 11:14     ` Philipp Zabel
2014-06-24 11:14     ` Philipp Zabel
2014-06-24 10:35 ` [PATCH v2 03/12] ARM: Berlin: select the reset controller Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 11:14   ` Philipp Zabel
2014-06-24 11:14     ` Philipp Zabel
2014-06-24 11:14     ` Philipp Zabel
2014-06-24 10:35 ` [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-27 15:56   ` Felipe Balbi
2014-06-27 15:56     ` Felipe Balbi
2014-06-27 16:05     ` Antoine Ténart
2014-06-27 16:05       ` Antoine Ténart
2014-06-27 23:04       ` Felipe Balbi
2014-06-27 23:04         ` Felipe Balbi
2014-06-30 14:52         ` Antoine Ténart
2014-06-30 14:52           ` Antoine Ténart
2014-06-30 18:34           ` Felipe Balbi
2014-06-30 18:34             ` Felipe Balbi
2014-06-24 10:35 ` [PATCH v2 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 07/12] usb: chipidea: add a generic driver Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:51   ` Jingoo Han
2014-06-24 10:51     ` Jingoo Han
2014-06-30 13:39     ` Antoine Ténart
2014-06-30 13:39       ` Antoine Ténart
2014-06-27  3:25   ` Peter Chen
2014-06-27  3:25     ` Peter Chen
2014-06-27  3:41     ` Peter Chen
2014-06-27  3:41       ` Peter Chen
2014-06-30 13:33     ` Antoine Ténart
2014-06-30 13:33       ` Antoine Ténart
2014-07-01  0:21       ` Peter Chen
2014-07-01  0:21         ` Peter Chen
2014-07-01  7:24         ` Antoine Ténart
2014-07-01  7:24           ` Antoine Ténart
2014-07-01  8:55         ` Sebastian Hesselbarth
2014-07-01  8:55           ` Sebastian Hesselbarth
2014-07-01  8:30           ` Peter Chen
2014-07-01  8:30             ` Peter Chen
2014-07-01 10:42             ` Alexandre Belloni
2014-07-01 10:42               ` Alexandre Belloni
2014-07-01 15:18               ` Sergei Shtylyov
2014-07-01 15:18                 ` Sergei Shtylyov
2014-07-02  1:10                 ` Peter Chen
2014-07-02  1:10                   ` Peter Chen
2014-07-15 15:22                   ` Antoine Ténart [this message]
2014-07-15 15:22                     ` Antoine Ténart
2014-07-16  0:32                     ` Peter Chen
2014-07-16  0:32                       ` Peter Chen
2014-07-03  2:47   ` punnaiah choudary kalluri
2014-07-03  2:47     ` punnaiah choudary kalluri
2014-07-15 15:24     ` Antoine Ténart
2014-07-15 15:24       ` Antoine Ténart
2014-07-16  0:44       ` Peter Chen
2014-07-16  0:44         ` Peter Chen
2014-06-24 10:35 ` [PATCH v2 08/12] Documentation: bindings: add doc for the generic ChipIdea USB driver Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart
2014-06-24 10:35 ` [PATCH v2 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Ténart
2014-06-24 10:35   ` Antoine Ténart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140715152230.GE1011@kwain \
    --to=antoine.tenart@free-electrons.com \
    --cc=Peter.Chen@freescale.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=zmxu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.