From: "Alim Akhtar" <alim.akhtar@samsung.com> To: "'Sam Protsenko'" <semen.protsenko@linaro.org>, "'Peter Griffin'" <peter.griffin@linaro.org> Cc: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>, <conor+dt@kernel.org>, <sboyd@kernel.org>, <tomasz.figa@gmail.com>, <s.nawrocki@samsung.com>, <linus.walleij@linaro.org>, <wim@linux-watchdog.org>, <linux@roeck-us.net>, <catalin.marinas@arm.com>, <will@kernel.org>, <arnd@arndb.de>, <olof@lixom.net>, <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>, <cw00.choi@samsung.com>, <tudor.ambarus@linaro.org>, <andre.draszik@linaro.org>, <saravanak@google.com>, <willmcvicker@google.com>, <soc@kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>, <linux-gpio@vger.kernel.org>, <linux-watchdog@vger.kernel.org>, <kernel-team@android.com>, <linux-serial@vger.kernel.org> Subject: RE: [PATCH v5 14/20] pinctrl: samsung: Add gs101 SoC pinctrl configuration Date: Sat, 2 Dec 2023 07:06:53 +0530 [thread overview] Message-ID: <000001da24c0$0b83aab0$228b0010$@samsung.com> (raw) In-Reply-To: <CAPLW+4kBOWFPx3Hr-=UoLWvRxCorzBY9RCOiBhfkKcU0LAa21Q@mail.gmail.com> > -----Original Message----- > From: Sam Protsenko <semen.protsenko@linaro.org> > Sent: Saturday, December 2, 2023 6:10 AM > To: Peter Griffin <peter.griffin@linaro.org> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > mturquette@baylibre.com; conor+dt@kernel.org; sboyd@kernel.org; > tomasz.figa@gmail.com; s.nawrocki@samsung.com; linus.walleij@linaro.org; > wim@linux-watchdog.org; linux@roeck-us.net; catalin.marinas@arm.com; > will@kernel.org; arnd@arndb.de; olof@lixom.net; > gregkh@linuxfoundation.org; jirislaby@kernel.org; > cw00.choi@samsung.com; alim.akhtar@samsung.com; > tudor.ambarus@linaro.org; andre.draszik@linaro.org; > saravanak@google.com; willmcvicker@google.com; soc@kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org; linux- > gpio@vger.kernel.org; linux-watchdog@vger.kernel.org; kernel- > team@android.com; linux-serial@vger.kernel.org > Subject: Re: [PATCH v5 14/20] pinctrl: samsung: Add gs101 SoC pinctrl > configuration > > On Fri, Dec 1, 2023 at 10:11 AM Peter Griffin <peter.griffin@linaro.org> > wrote: > > > > Add support for the pin-controller found on the gs101 SoC used in > > Pixel 6 phones. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > .../pinctrl/samsung/pinctrl-exynos-arm64.c | 159 ++++++++++++++++++ > > drivers/pinctrl/samsung/pinctrl-exynos.c | 2 + > > drivers/pinctrl/samsung/pinctrl-exynos.h | 34 ++++ > > drivers/pinctrl/samsung/pinctrl-samsung.c | 2 + > > drivers/pinctrl/samsung/pinctrl-samsung.h | 1 + > > 5 files changed, 198 insertions(+) > > > > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > > b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > > index cb965cf93705..e1a0668ecb16 100644 > > --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > > +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > > @@ -796,3 +796,162 @@ const struct samsung_pinctrl_of_match_data > fsd_of_data __initconst = { > > .ctrl = fsd_pin_ctrl, > > .num_ctrl = ARRAY_SIZE(fsd_pin_ctrl), > > }; > > + > > +/* > > + * bank type for non-alive type > > + * (CON bit field: 4, DAT bit field: 1, PUD bit field: 4, DRV bit > > +field: 4) > > + * (CONPDN bit field: 2, PUDPDN bit field: 4) */ static struct > > +samsung_pin_bank_type gs101_bank_type_off = { > > + .fld_width = { 4, 1, 4, 4, 2, 4, }, > > + .reg_offset = { 0x00, 0x04, 0x08, 0x0c, 0x10, 0x14, }, }; > > This is just the same as exynos850_bank_type_off (100% duplication). > Here is what I suggest. Now that it's obvious there is some common platform > for moder Exynos SoCs, and it's probably Exynos9, I'd suggest next course of > action (if maintainers agree): > 1. Remove this one > 2. Rename exynos850_bank_type_off to exynos9_bank_type_off > 3. Use it for both gs101 and exynos850 > > Does it make sense? > My opinion is to reuse exynos850 for gs101 (wherever applicable), same philosophy was historically followed in this file. That way (using exynos850 for gs101) things will be simple. Adding exynos9_* is not adding any benefit, rather it create confusion. > > + > > +/* > > + * bank type for alive type > > + * (CON bit field: 4, DAT bit field: 1, PUD bit field: 4, DRV bit > > +field: 4) */ static const struct samsung_pin_bank_type > > +gs101_bank_type_alive = { > > + .fld_width = { 4, 1, 4, 4, }, > > + .reg_offset = { 0x00, 0x04, 0x08, 0x0c, }, }; [...]
WARNING: multiple messages have this Message-ID (diff)
From: "Alim Akhtar" <alim.akhtar@samsung.com> To: "'Sam Protsenko'" <semen.protsenko@linaro.org>, "'Peter Griffin'" <peter.griffin@linaro.org> Cc: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>, <conor+dt@kernel.org>, <sboyd@kernel.org>, <tomasz.figa@gmail.com>, <s.nawrocki@samsung.com>, <linus.walleij@linaro.org>, <wim@linux-watchdog.org>, <linux@roeck-us.net>, <catalin.marinas@arm.com>, <will@kernel.org>, <arnd@arndb.de>, <olof@lixom.net>, <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>, <cw00.choi@samsung.com>, <tudor.ambarus@linaro.org>, <andre.draszik@linaro.org>, <saravanak@google.com>, <willmcvicker@google.com>, <soc@kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>, <linux-gpio@vger.kernel.org>, <linux-watchdog@vger.kernel.org>, <kernel-team@android.com>, <linux-serial@vger.kernel.org> Subject: RE: [PATCH v5 14/20] pinctrl: samsung: Add gs101 SoC pinctrl configuration Date: Sat, 2 Dec 2023 07:06:53 +0530 [thread overview] Message-ID: <000001da24c0$0b83aab0$228b0010$@samsung.com> (raw) In-Reply-To: <CAPLW+4kBOWFPx3Hr-=UoLWvRxCorzBY9RCOiBhfkKcU0LAa21Q@mail.gmail.com> > -----Original Message----- > From: Sam Protsenko <semen.protsenko@linaro.org> > Sent: Saturday, December 2, 2023 6:10 AM > To: Peter Griffin <peter.griffin@linaro.org> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > mturquette@baylibre.com; conor+dt@kernel.org; sboyd@kernel.org; > tomasz.figa@gmail.com; s.nawrocki@samsung.com; linus.walleij@linaro.org; > wim@linux-watchdog.org; linux@roeck-us.net; catalin.marinas@arm.com; > will@kernel.org; arnd@arndb.de; olof@lixom.net; > gregkh@linuxfoundation.org; jirislaby@kernel.org; > cw00.choi@samsung.com; alim.akhtar@samsung.com; > tudor.ambarus@linaro.org; andre.draszik@linaro.org; > saravanak@google.com; willmcvicker@google.com; soc@kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org; linux- > gpio@vger.kernel.org; linux-watchdog@vger.kernel.org; kernel- > team@android.com; linux-serial@vger.kernel.org > Subject: Re: [PATCH v5 14/20] pinctrl: samsung: Add gs101 SoC pinctrl > configuration > > On Fri, Dec 1, 2023 at 10:11 AM Peter Griffin <peter.griffin@linaro.org> > wrote: > > > > Add support for the pin-controller found on the gs101 SoC used in > > Pixel 6 phones. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > .../pinctrl/samsung/pinctrl-exynos-arm64.c | 159 ++++++++++++++++++ > > drivers/pinctrl/samsung/pinctrl-exynos.c | 2 + > > drivers/pinctrl/samsung/pinctrl-exynos.h | 34 ++++ > > drivers/pinctrl/samsung/pinctrl-samsung.c | 2 + > > drivers/pinctrl/samsung/pinctrl-samsung.h | 1 + > > 5 files changed, 198 insertions(+) > > > > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > > b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > > index cb965cf93705..e1a0668ecb16 100644 > > --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > > +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > > @@ -796,3 +796,162 @@ const struct samsung_pinctrl_of_match_data > fsd_of_data __initconst = { > > .ctrl = fsd_pin_ctrl, > > .num_ctrl = ARRAY_SIZE(fsd_pin_ctrl), > > }; > > + > > +/* > > + * bank type for non-alive type > > + * (CON bit field: 4, DAT bit field: 1, PUD bit field: 4, DRV bit > > +field: 4) > > + * (CONPDN bit field: 2, PUDPDN bit field: 4) */ static struct > > +samsung_pin_bank_type gs101_bank_type_off = { > > + .fld_width = { 4, 1, 4, 4, 2, 4, }, > > + .reg_offset = { 0x00, 0x04, 0x08, 0x0c, 0x10, 0x14, }, }; > > This is just the same as exynos850_bank_type_off (100% duplication). > Here is what I suggest. Now that it's obvious there is some common platform > for moder Exynos SoCs, and it's probably Exynos9, I'd suggest next course of > action (if maintainers agree): > 1. Remove this one > 2. Rename exynos850_bank_type_off to exynos9_bank_type_off > 3. Use it for both gs101 and exynos850 > > Does it make sense? > My opinion is to reuse exynos850 for gs101 (wherever applicable), same philosophy was historically followed in this file. That way (using exynos850 for gs101) things will be simple. Adding exynos9_* is not adding any benefit, rather it create confusion. > > + > > +/* > > + * bank type for alive type > > + * (CON bit field: 4, DAT bit field: 1, PUD bit field: 4, DRV bit > > +field: 4) */ static const struct samsung_pin_bank_type > > +gs101_bank_type_alive = { > > + .fld_width = { 4, 1, 4, 4, }, > > + .reg_offset = { 0x00, 0x04, 0x08, 0x0c, }, }; [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-02 1:37 UTC|newest] Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-01 16:09 [PATCH v5 00/20] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 01/20] dt-bindings: soc: samsung: exynos-pmu: Add gs101 compatible Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 02/20] dt-bindings: clock: Add Google gs101 clock management unit bindings Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 20:11 ` Sam Protsenko 2023-12-01 20:11 ` Sam Protsenko 2023-12-03 20:59 ` Peter Griffin 2023-12-03 20:59 ` Peter Griffin 2023-12-06 12:30 ` André Draszik 2023-12-06 12:30 ` André Draszik 2023-12-09 0:10 ` Peter Griffin 2023-12-09 0:10 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 03/20] dt-bindings: soc: google: exynos-sysreg: add dedicated SYSREG compatibles to GS101 Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 04/20] dt-bindings: watchdog: Document Google gs101 watchdog bindings Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 20:13 ` Sam Protsenko 2023-12-01 20:13 ` Sam Protsenko 2023-12-01 16:09 ` [PATCH v5 05/20] dt-bindings: arm: google: Add bindings for Google ARM platforms Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 20:22 ` Sam Protsenko 2023-12-01 20:22 ` Sam Protsenko 2023-12-03 21:13 ` Peter Griffin 2023-12-03 21:13 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 06/20] dt-bindings: pinctrl: samsung: add google,gs101-pinctrl compatible Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 07/20] dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 20:25 ` Sam Protsenko 2023-12-01 20:25 ` Sam Protsenko 2023-12-03 15:11 ` Krzysztof Kozlowski 2023-12-03 15:11 ` Krzysztof Kozlowski 2023-12-03 21:21 ` Peter Griffin 2023-12-03 21:21 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 08/20] dt-bindings: serial: samsung: Add google-gs101-uart compatible Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 09/20] dt-bindings: serial: samsung: Make samsung,uart-fifosize required property Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 16:39 ` Arnd Bergmann 2023-12-01 16:39 ` Arnd Bergmann 2023-12-03 21:31 ` Peter Griffin 2023-12-03 21:31 ` Peter Griffin 2023-12-11 18:26 ` Rob Herring 2023-12-11 18:26 ` Rob Herring 2023-12-03 15:10 ` Krzysztof Kozlowski 2023-12-03 15:10 ` Krzysztof Kozlowski 2023-12-03 21:39 ` Peter Griffin 2023-12-03 21:39 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 10/20] dt-bindings: soc: samsung: usi: add google,gs101-usi compatible Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 20:39 ` Sam Protsenko 2023-12-01 20:39 ` Sam Protsenko 2023-12-03 15:09 ` Krzysztof Kozlowski 2023-12-03 15:09 ` Krzysztof Kozlowski 2023-12-03 21:47 ` Peter Griffin 2023-12-03 21:47 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 11/20] clk: samsung: clk-pll: Add support for pll_{0516,0517,518} Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 12/20] clk: samsung: clk-gs101: Add cmu_top, cmu_misc and cmu_apm support Peter Griffin 2023-12-01 22:40 ` Sam Protsenko 2023-12-05 8:09 ` André Draszik 2023-12-05 8:09 ` André Draszik 2023-12-08 11:35 ` Peter Griffin 2023-12-08 11:35 ` Peter Griffin 2023-12-04 17:51 ` André Draszik 2023-12-04 17:51 ` André Draszik 2023-12-08 14:27 ` Peter Griffin 2023-12-08 14:27 ` Peter Griffin 2023-12-05 7:52 ` André Draszik 2023-12-05 7:52 ` André Draszik 2023-12-08 21:14 ` Peter Griffin 2023-12-08 21:14 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 13/20] pinctrl: samsung: Add filter selection support for alive banks Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 23:55 ` William McVicker 2023-12-01 23:55 ` William McVicker 2023-12-05 19:51 ` Peter Griffin 2023-12-05 19:51 ` Peter Griffin 2023-12-02 0:22 ` Sam Protsenko 2023-12-02 0:22 ` Sam Protsenko 2023-12-05 11:34 ` Peter Griffin 2023-12-05 11:34 ` Peter Griffin 2023-12-05 19:10 ` Peter Griffin 2023-12-05 19:10 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 14/20] pinctrl: samsung: Add gs101 SoC pinctrl configuration Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 23:57 ` William McVicker 2023-12-01 23:57 ` William McVicker 2023-12-02 0:40 ` Sam Protsenko 2023-12-02 0:40 ` Sam Protsenko 2023-12-02 1:36 ` Alim Akhtar [this message] 2023-12-02 1:36 ` Alim Akhtar 2023-12-02 1:58 ` Sam Protsenko 2023-12-02 1:58 ` Sam Protsenko 2023-12-06 11:38 ` Krzysztof Kozlowski 2023-12-06 11:38 ` Krzysztof Kozlowski 2023-12-06 12:47 ` Peter Griffin 2023-12-06 12:47 ` Peter Griffin 2023-12-05 21:24 ` Peter Griffin 2023-12-05 21:24 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 15/20] watchdog: s3c2410_wdt: Add support for WTCON register DBGACK_MASK bit Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 23:59 ` William McVicker 2023-12-01 23:59 ` William McVicker 2023-12-02 0:53 ` Sam Protsenko 2023-12-02 0:53 ` Sam Protsenko 2023-12-05 22:03 ` Peter Griffin 2023-12-05 22:03 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 16/20] watchdog: s3c2410_wdt: Add support for Google gs101 SoC Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 23:59 ` William McVicker 2023-12-01 23:59 ` William McVicker 2023-12-02 1:02 ` Sam Protsenko 2023-12-02 1:02 ` Sam Protsenko 2023-12-05 22:19 ` Peter Griffin 2023-12-05 22:19 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 17/20] tty: serial: samsung: Add gs101 compatible and common fifoszdt_serial_drv_data Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-02 0:01 ` William McVicker 2023-12-02 0:01 ` William McVicker 2023-12-05 22:29 ` Peter Griffin 2023-12-05 22:29 ` Peter Griffin 2023-12-02 1:09 ` Sam Protsenko 2023-12-02 1:09 ` Sam Protsenko 2023-12-05 22:27 ` Peter Griffin 2023-12-05 22:27 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 18/20] arm64: dts: exynos: google: Add initial Google gs101 SoC support Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-02 0:03 ` William McVicker 2023-12-02 0:03 ` William McVicker 2023-12-02 1:54 ` Sam Protsenko 2023-12-02 1:54 ` Sam Protsenko 2023-12-05 7:19 ` Krzysztof Kozlowski 2023-12-05 7:19 ` Krzysztof Kozlowski 2023-12-09 1:00 ` Peter Griffin 2023-12-09 1:00 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 19/20] arm64: dts: exynos: google: Add initial Oriole/pixel 6 board support Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-02 0:03 ` William McVicker 2023-12-02 0:03 ` William McVicker 2023-12-02 2:28 ` Sam Protsenko 2023-12-02 2:28 ` Sam Protsenko 2023-12-09 22:04 ` Peter Griffin 2023-12-09 22:04 ` Peter Griffin 2023-12-01 16:09 ` [PATCH v5 20/20] MAINTAINERS: add entry for Google Tensor SoC Peter Griffin 2023-12-01 16:09 ` Peter Griffin 2023-12-01 22:40 ` [PATCH v5 00/20] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board William McVicker 2023-12-01 22:40 ` William McVicker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='000001da24c0$0b83aab0$228b0010$@samsung.com' \ --to=alim.akhtar@samsung.com \ --cc=andre.draszik@linaro.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=conor+dt@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mturquette@baylibre.com \ --cc=olof@lixom.net \ --cc=peter.griffin@linaro.org \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=saravanak@google.com \ --cc=sboyd@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=soc@kernel.org \ --cc=tomasz.figa@gmail.com \ --cc=tudor.ambarus@linaro.org \ --cc=will@kernel.org \ --cc=willmcvicker@google.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.