From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/4] phy: samsung: ufs: support secondary ufs phy
Date: Thu, 2 Jun 2022 11:26:37 +0900 [thread overview]
Message-ID: <004501d87628$2f65a6b0$8e30f410$@samsung.com> (raw)
In-Reply-To: <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org>
> > + u32 isol_offset;
> > int err = 0;
> >
> > match = of_match_node(samsung_ufs_phy_match, dev->of_node); @@
> > -328,7 +329,11 @@ static int samsung_ufs_phy_probe(struct
> platform_device *pdev)
> > phy->dev = dev;
> > phy->drvdata = drvdata;
> > phy->cfg = (struct samsung_ufs_phy_cfg **)drvdata->cfg;
> > - phy->isol = &drvdata->isol;
> > + phy->isol = (struct pmu_isol *)&drvdata->isol;
>
> No casts are needed for proper code. If you need it - code is not proper.
To change a value of phy->isol, I need to allocate its own isol data and copying whole data from drvdata instead of using drvdata->isol pointer.
Best Regards,
Chanho Park
WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/4] phy: samsung: ufs: support secondary ufs phy
Date: Thu, 2 Jun 2022 11:26:37 +0900 [thread overview]
Message-ID: <004501d87628$2f65a6b0$8e30f410$@samsung.com> (raw)
In-Reply-To: <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org>
> > + u32 isol_offset;
> > int err = 0;
> >
> > match = of_match_node(samsung_ufs_phy_match, dev->of_node); @@
> > -328,7 +329,11 @@ static int samsung_ufs_phy_probe(struct
> platform_device *pdev)
> > phy->dev = dev;
> > phy->drvdata = drvdata;
> > phy->cfg = (struct samsung_ufs_phy_cfg **)drvdata->cfg;
> > - phy->isol = &drvdata->isol;
> > + phy->isol = (struct pmu_isol *)&drvdata->isol;
>
> No casts are needed for proper code. If you need it - code is not proper.
To change a value of phy->isol, I need to allocate its own isol data and copying whole data from drvdata instead of using drvdata->isol pointer.
Best Regards,
Chanho Park
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/4] phy: samsung: ufs: support secondary ufs phy
Date: Thu, 2 Jun 2022 11:26:37 +0900 [thread overview]
Message-ID: <004501d87628$2f65a6b0$8e30f410$@samsung.com> (raw)
In-Reply-To: <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org>
> > + u32 isol_offset;
> > int err = 0;
> >
> > match = of_match_node(samsung_ufs_phy_match, dev->of_node); @@
> > -328,7 +329,11 @@ static int samsung_ufs_phy_probe(struct
> platform_device *pdev)
> > phy->dev = dev;
> > phy->drvdata = drvdata;
> > phy->cfg = (struct samsung_ufs_phy_cfg **)drvdata->cfg;
> > - phy->isol = &drvdata->isol;
> > + phy->isol = (struct pmu_isol *)&drvdata->isol;
>
> No casts are needed for proper code. If you need it - code is not proper.
To change a value of phy->isol, I need to allocate its own isol data and copying whole data from drvdata instead of using drvdata->isol pointer.
Best Regards,
Chanho Park
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-02 2:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220531121922epcas2p1441278a45ff7ed662e6ec3474869bf40@epcas2p1.samsung.com>
2022-05-31 12:19 ` [PATCH 0/4] support secondary ufs for Exynos Auto v9 SoC Chanho Park
2022-05-31 12:19 ` Chanho Park
2022-05-31 12:19 ` Chanho Park
[not found] ` <CGME20220531121922epcas2p15861df56f7253265c591a88244520446@epcas2p1.samsung.com>
2022-05-31 12:19 ` [PATCH 1/4] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Chanho Park
2022-05-31 12:19 ` Chanho Park
2022-05-31 12:19 ` Chanho Park
2022-05-31 13:17 ` Krzysztof Kozlowski
2022-05-31 13:17 ` Krzysztof Kozlowski
2022-05-31 13:17 ` Krzysztof Kozlowski
2022-06-02 2:17 ` Chanho Park
2022-06-02 2:17 ` Chanho Park
2022-06-02 2:17 ` Chanho Park
2022-05-31 22:46 ` Rob Herring
2022-05-31 22:46 ` Rob Herring
2022-05-31 22:46 ` Rob Herring
[not found] ` <CGME20220531121922epcas2p3c37a39cd28f56326c4f3980ac76f3b5c@epcas2p3.samsung.com>
2022-05-31 12:19 ` [PATCH 2/4] phy: samsung: ufs: support secondary ufs phy Chanho Park
2022-05-31 12:19 ` Chanho Park
2022-05-31 12:19 ` Chanho Park
2022-05-31 13:19 ` Krzysztof Kozlowski
2022-05-31 13:19 ` Krzysztof Kozlowski
2022-05-31 13:19 ` Krzysztof Kozlowski
2022-06-02 2:26 ` Chanho Park [this message]
2022-06-02 2:26 ` Chanho Park
2022-06-02 2:26 ` Chanho Park
[not found] ` <CGME20220531121922epcas2p428c51f13e61e06477d96ab4aa6d1377c@epcas2p4.samsung.com>
2022-05-31 12:19 ` [PATCH 3/4] arm64: dts: exynosautov9: add secondary ufs devices Chanho Park
2022-05-31 12:19 ` Chanho Park
2022-05-31 12:19 ` Chanho Park
2022-05-31 13:21 ` Krzysztof Kozlowski
2022-05-31 13:21 ` Krzysztof Kozlowski
2022-05-31 13:21 ` Krzysztof Kozlowski
2022-06-02 2:19 ` Chanho Park
2022-06-02 2:19 ` Chanho Park
2022-06-02 2:19 ` Chanho Park
[not found] ` <CGME20220531121922epcas2p4753a8b704540799711f03d33346fc6ff@epcas2p4.samsung.com>
2022-05-31 12:19 ` [PATCH 4/4] arm64: dts: exynosautov9-sadk: enable " Chanho Park
2022-05-31 12:19 ` Chanho Park
2022-05-31 12:19 ` Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004501d87628$2f65a6b0$8e30f410$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.