* [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
@ 2011-09-26 7:48 Baruch Siach
2011-09-27 21:51 ` Thomas Petazzoni
2011-10-02 6:22 ` Baruch Siach
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2011-09-26 7:48 UTC (permalink / raw)
To: buildroot
The "" string is not equal to the empty string. This fixes build
errors like:
arm-none-linux-gnueabi-gcc: : No such file or directory
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
Changes v1 -> v2:
* Use qstrip as suggested by Thomas Petazzoni
* Add build failure example to commit log for future reference
toolchain/toolchain-external/ext-tool.mk | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
index a357cb9..bf59983 100644
--- a/toolchain/toolchain-external/ext-tool.mk
+++ b/toolchain/toolchain-external/ext-tool.mk
@@ -131,7 +131,8 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI))
# march/mtune/floating point mode needs to be passed to the external toolchain
# to select the right multilib variant
-ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
+TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
+ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
endif
--
1.7.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
2011-09-26 7:48 [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS Baruch Siach
@ 2011-09-27 21:51 ` Thomas Petazzoni
2011-10-02 6:22 ` Baruch Siach
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2011-09-27 21:51 UTC (permalink / raw)
To: buildroot
Baruch,
Le Mon, 26 Sep 2011 10:48:57 +0300,
Baruch Siach <baruch@tkos.co.il> a ?crit :
> The "" string is not equal to the empty string. This fixes build
> errors like:
>
> arm-none-linux-gnueabi-gcc: : No such file or directory
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
For some reason, your patch does not seem to apply on current master.
> # march/mtune/floating point mode needs to be passed to the external toolchain
> # to select the right multilib variant
> -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
Should be use TOOLCHAIN_EXTERNAL_CUSTOM_ARGS in these two lines
instead ?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
2011-09-26 7:48 [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS Baruch Siach
2011-09-27 21:51 ` Thomas Petazzoni
@ 2011-10-02 6:22 ` Baruch Siach
2011-10-02 6:50 ` Baruch Siach
1 sibling, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2011-10-02 6:22 UTC (permalink / raw)
To: buildroot
Hi Buildroot list,
On Mon, Sep 26, 2011 at 10:48:57AM +0300, Baruch Siach wrote:
> The "" string is not equal to the empty string. This fixes build
> errors like:
>
> arm-none-linux-gnueabi-gcc: : No such file or directory
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Ping?
This fixes a real build breakage of the combination of external toolchain and
empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS.
baruch
> ---
> Changes v1 -> v2:
> * Use qstrip as suggested by Thomas Petazzoni
> * Add build failure example to commit log for future reference
>
> toolchain/toolchain-external/ext-tool.mk | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
> index a357cb9..bf59983 100644
> --- a/toolchain/toolchain-external/ext-tool.mk
> +++ b/toolchain/toolchain-external/ext-tool.mk
> @@ -131,7 +131,8 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI))
>
> # march/mtune/floating point mode needs to be passed to the external toolchain
> # to select the right multilib variant
> -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> endif
> --
> 1.7.6.3
>
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
2011-10-02 6:22 ` Baruch Siach
@ 2011-10-02 6:50 ` Baruch Siach
0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2011-10-02 6:50 UTC (permalink / raw)
To: buildroot
Hi Buildroot list,
On Sun, Oct 02, 2011 at 08:22:58AM +0200, Baruch Siach wrote:
> On Mon, Sep 26, 2011 at 10:48:57AM +0300, Baruch Siach wrote:
> > The "" string is not equal to the empty string. This fixes build
> > errors like:
> >
> > arm-none-linux-gnueabi-gcc: : No such file or directory
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Ping?
> This fixes a real build breakage of the combination of external toolchain and
> empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS.
Forget it. This patch is against some local modifications for mine (a patch
that has been posted here a few months ago, but never applied).
Sorry for the noise.
baruch
> > ---
> > Changes v1 -> v2:
> > * Use qstrip as suggested by Thomas Petazzoni
> > * Add build failure example to commit log for future reference
> >
> > toolchain/toolchain-external/ext-tool.mk | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
> > index a357cb9..bf59983 100644
> > --- a/toolchain/toolchain-external/ext-tool.mk
> > +++ b/toolchain/toolchain-external/ext-tool.mk
> > @@ -131,7 +131,8 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI))
> >
> > # march/mtune/floating point mode needs to be passed to the external toolchain
> > # to select the right multilib variant
> > -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> > +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> > +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> > TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> > TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> > endif
> > --
> > 1.7.6.3
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-02 6:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-26 7:48 [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS Baruch Siach
2011-09-27 21:51 ` Thomas Petazzoni
2011-10-02 6:22 ` Baruch Siach
2011-10-02 6:50 ` Baruch Siach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.