All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Finn Thain <fthain@telegraphics.com.au>, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Subject: Re: net/sonic: Fix some resource leaks in error handling paths
Date: Mon, 11 May 2020 10:20:24 +0200	[thread overview]
Message-ID: <00a5237c-13b4-07b5-99ee-8f63d4276fb4@web.de> (raw)
In-Reply-To: <alpine.LNX.2.22.394.2005110845060.8@nippy.intranet>

>> To which commit would you like to refer to for the proposed adjustment
>> of the function “mac_sonic_platform_probe”?
>
> That was my question to you. We seem to be talking past each other.

I have needed a moment to notice your patch as another constructive response
for this code review.

[PATCH v2] net/sonic: Fix some resource leaks in error handling paths
https://lore.kernel.org/r/3eaa58c16dcf313ff7cb873dcff21659b0ea037d.1589158098.git.fthain@telegraphics.com.au/

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Finn Thain <fthain@telegraphics.com.au>, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Subject: Re: net/sonic: Fix some resource leaks in error handling paths
Date: Mon, 11 May 2020 08:20:24 +0000	[thread overview]
Message-ID: <00a5237c-13b4-07b5-99ee-8f63d4276fb4@web.de> (raw)
In-Reply-To: <alpine.LNX.2.22.394.2005110845060.8@nippy.intranet>

>> To which commit would you like to refer to for the proposed adjustment
>> of the function “mac_sonic_platform_probe”?
>
> That was my question to you. We seem to be talking past each other.

I have needed a moment to notice your patch as another constructive response
for this code review.

[PATCH v2] net/sonic: Fix some resource leaks in error handling paths
https://lore.kernel.org/r/3eaa58c16dcf313ff7cb873dcff21659b0ea037d.1589158098.git.fthain@telegraphics.com.au/

Regards,
Markus

  parent reply	other threads:[~2020-05-11  8:20 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  6:15 [PATCH] net/sonic: Fix some resource leaks in error handling paths Markus Elfring
2020-05-09  6:15 ` Markus Elfring
2020-05-09 23:45 ` Finn Thain
2020-05-09 23:45   ` Finn Thain
2020-05-10  5:30   ` Markus Elfring
2020-05-10  5:30     ` Markus Elfring
2020-05-10  8:25     ` Finn Thain
2020-05-10  8:25       ` Finn Thain
2020-05-10  9:07       ` Markus Elfring
2020-05-10  9:07         ` Markus Elfring
2020-05-11  0:28         ` Finn Thain
2020-05-11  0:28           ` Finn Thain
2020-05-11  6:48           ` Markus Elfring
2020-05-11  6:48             ` Markus Elfring
2020-05-12  0:08             ` Finn Thain
2020-05-12  0:08               ` Finn Thain
2020-05-12  6:38               ` Markus Elfring
2020-05-12  6:38                 ` Markus Elfring
2020-05-13  1:14                 ` Finn Thain
2020-05-13  1:14                   ` Finn Thain
2020-05-13  5:07                   ` net/sonic: Software evolution around the application of coding standards Markus Elfring
2020-05-13  5:07                     ` Markus Elfring
2020-05-13 23:16                     ` Finn Thain
2020-05-13 23:16                       ` Finn Thain
2020-05-11  8:20           ` Markus Elfring [this message]
2020-05-11  8:20             ` net/sonic: Fix some resource leaks in error handling paths Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-05-08 17:25 [PATCH] " Christophe JAILLET
2020-05-08 17:25 ` Christophe JAILLET
2020-05-08 23:28 ` Finn Thain
2020-05-08 23:28   ` Finn Thain
2020-05-09  0:57 ` Jakub Kicinski
2020-05-09  0:57   ` Jakub Kicinski
2020-05-09  1:57   ` Finn Thain
2020-05-09  1:57     ` Finn Thain
2020-05-09  2:04     ` Jakub Kicinski
2020-05-09  2:04       ` Jakub Kicinski
2020-05-09  1:54 ` Jakub Kicinski
2020-05-09  1:54   ` Jakub Kicinski
2020-05-09 16:47   ` Christophe JAILLET
2020-05-09 16:47     ` Christophe JAILLET
2020-05-09 18:13     ` Jakub Kicinski
2020-05-09 18:13       ` Jakub Kicinski
2020-05-09 20:31       ` Christophe JAILLET
2020-05-09 20:31         ` Christophe JAILLET
2020-05-09 22:42       ` Joe Perches
2020-05-09 22:42         ` Joe Perches
2020-05-09 23:32         ` David Miller
2020-05-09 23:32           ` David Miller
2020-05-09 23:41           ` Joe Perches
2020-05-09 23:41             ` Joe Perches
2020-05-09 23:52   ` Finn Thain
2020-05-09 23:52     ` Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00a5237c-13b4-07b5-99ee-8f63d4276fb4@web.de \
    --to=markus.elfring@web.de \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=davem@davemloft.net \
    --cc=fthain@telegraphics.com.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.