From: Hans Verkuil <hverkuil@xs4all.nl>
To: Jacopo Mondi
<jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
geert-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org,
mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sakari.ailus-X3B1VOXEql0@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pombredanne-od1rfyK75/E@public.gmane.org
Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies
Date: Fri, 19 Jan 2018 10:47:33 +0000 [thread overview]
Message-ID: <00f1dd19-6420-26ab-0529-a97f2b0de682@xs4all.nl> (raw)
In-Reply-To: <d67c21e5-2488-977b-39d8-561048409209-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
On 01/19/18 11:24, Hans Verkuil wrote:
> On 01/16/18 22:44, Jacopo Mondi wrote:
>> Remove soc_camera framework dependencies from ov772x sensor driver.
>> - Handle clock and gpios
>> - Register async subdevice
>> - Remove soc_camera specific g/s_mbus_config operations
>> - Change image format colorspace from JPEG to SRGB as the two use the
>> same colorspace information but JPEG makes assumptions on color
>> components quantization that do not apply to the sensor
>> - Remove sizes crop from get_selection as driver can't scale
>> - Add kernel doc to driver interface header file
>> - Adjust build system
>>
>> This commit does not remove the original soc_camera based driver as long
>> as other platforms depends on soc_camera-based CEU driver.
>>
>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Un-acked.
I just noticed that this sensor driver has no enum_frame_interval and
g/s_parm support. How would a driver ever know the frame rate of the
sensor without that?
This looks like a bug to me.
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com,
geert@glider.be, mchehab@kernel.org, festevam@gmail.com,
sakari.ailus@iki.fi, robh+dt@kernel.org, mark.rutland@arm.com,
pombredanne@nexb.com
Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies
Date: Fri, 19 Jan 2018 11:47:33 +0100 [thread overview]
Message-ID: <00f1dd19-6420-26ab-0529-a97f2b0de682@xs4all.nl> (raw)
In-Reply-To: <d67c21e5-2488-977b-39d8-561048409209@xs4all.nl>
On 01/19/18 11:24, Hans Verkuil wrote:
> On 01/16/18 22:44, Jacopo Mondi wrote:
>> Remove soc_camera framework dependencies from ov772x sensor driver.
>> - Handle clock and gpios
>> - Register async subdevice
>> - Remove soc_camera specific g/s_mbus_config operations
>> - Change image format colorspace from JPEG to SRGB as the two use the
>> same colorspace information but JPEG makes assumptions on color
>> components quantization that do not apply to the sensor
>> - Remove sizes crop from get_selection as driver can't scale
>> - Add kernel doc to driver interface header file
>> - Adjust build system
>>
>> This commit does not remove the original soc_camera based driver as long
>> as other platforms depends on soc_camera-based CEU driver.
>>
>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Un-acked.
I just noticed that this sensor driver has no enum_frame_interval and
g/s_parm support. How would a driver ever know the frame rate of the
sensor without that?
This looks like a bug to me.
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
To: Jacopo Mondi
<jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
geert-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org,
mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sakari.ailus-X3B1VOXEql0@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pombredanne-od1rfyK75/E@public.gmane.org
Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies
Date: Fri, 19 Jan 2018 11:47:33 +0100 [thread overview]
Message-ID: <00f1dd19-6420-26ab-0529-a97f2b0de682@xs4all.nl> (raw)
In-Reply-To: <d67c21e5-2488-977b-39d8-561048409209-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
On 01/19/18 11:24, Hans Verkuil wrote:
> On 01/16/18 22:44, Jacopo Mondi wrote:
>> Remove soc_camera framework dependencies from ov772x sensor driver.
>> - Handle clock and gpios
>> - Register async subdevice
>> - Remove soc_camera specific g/s_mbus_config operations
>> - Change image format colorspace from JPEG to SRGB as the two use the
>> same colorspace information but JPEG makes assumptions on color
>> components quantization that do not apply to the sensor
>> - Remove sizes crop from get_selection as driver can't scale
>> - Add kernel doc to driver interface header file
>> - Adjust build system
>>
>> This commit does not remove the original soc_camera based driver as long
>> as other platforms depends on soc_camera-based CEU driver.
>>
>> Signed-off-by: Jacopo Mondi <jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
>
> Acked-by: Hans Verkuil <hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Un-acked.
I just noticed that this sensor driver has no enum_frame_interval and
g/s_parm support. How would a driver ever know the frame rate of the
sensor without that?
This looks like a bug to me.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-19 10:47 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 21:44 [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 1/9] dt-bindings: media: Add Renesas CEU bindings Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-17 7:59 ` Sakari Ailus
2018-01-17 7:59 ` Sakari Ailus
2018-01-17 8:35 ` jacopo mondi
2018-01-17 8:35 ` jacopo mondi
2018-01-17 8:55 ` Sakari Ailus
2018-01-17 8:55 ` Sakari Ailus
2018-01-16 21:44 ` [PATCH v6 2/9] include: media: Add Renesas CEU driver interface Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-19 11:20 ` Hans Verkuil
2018-01-19 11:20 ` Hans Verkuil
2018-01-19 12:20 ` Laurent Pinchart
2018-01-19 12:20 ` Laurent Pinchart
2018-01-19 12:25 ` Hans Verkuil
2018-01-19 12:25 ` Hans Verkuil
[not found] ` <4195ec6a-b99d-2fad-3898-9ce9c02fce00-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2018-01-22 0:52 ` Laurent Pinchart
2018-01-22 0:52 ` Laurent Pinchart
2018-01-22 0:52 ` Laurent Pinchart
2018-01-22 9:07 ` Hans Verkuil
2018-01-22 9:07 ` Hans Verkuil
2018-01-21 9:53 ` jacopo mondi
2018-01-21 9:53 ` jacopo mondi
2018-01-21 10:21 ` Hans Verkuil
2018-01-21 10:21 ` Hans Verkuil
2018-01-21 10:23 ` Hans Verkuil
2018-01-21 10:23 ` Hans Verkuil
2018-01-21 17:29 ` jacopo mondi
2018-01-21 17:29 ` jacopo mondi
2018-01-22 9:56 ` Hans Verkuil
2018-01-22 9:56 ` Hans Verkuil
2018-01-19 22:35 ` kbuild test robot
2018-01-19 22:35 ` kbuild test robot
2018-01-19 22:35 ` kbuild test robot
2018-01-20 2:11 ` kbuild test robot
2018-01-20 2:11 ` kbuild test robot
2018-01-20 2:11 ` kbuild test robot
2018-01-16 21:44 ` [PATCH v6 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU) Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-19 10:24 ` Hans Verkuil
2018-01-19 10:24 ` Hans Verkuil
[not found] ` <d67c21e5-2488-977b-39d8-561048409209-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2018-01-19 10:47 ` Hans Verkuil [this message]
2018-01-19 10:47 ` Hans Verkuil
2018-01-19 10:47 ` Hans Verkuil
2018-01-19 11:19 ` Sakari Ailus
2018-01-19 11:19 ` Sakari Ailus
2018-01-19 11:44 ` Hans Verkuil
2018-01-19 11:44 ` Hans Verkuil
[not found] ` <20180119111917.76wosrokgracbdrz-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2018-01-19 12:23 ` Laurent Pinchart
2018-01-19 12:23 ` Laurent Pinchart
2018-01-19 12:23 ` Laurent Pinchart
2018-01-21 9:31 ` jacopo mondi
2018-01-21 9:31 ` jacopo mondi
2018-01-21 10:18 ` Hans Verkuil
2018-01-21 10:18 ` Hans Verkuil
2018-01-16 21:44 ` [PATCH v6 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-16 21:45 ` [PATCH v6 8/9] media: i2c: tw9910: Remove soc_camera dependencies Jacopo Mondi
2018-01-16 21:45 ` Jacopo Mondi
2018-01-16 21:45 ` [PATCH v6 9/9] arch: sh: migor: Use new renesas-ceu camera driver Jacopo Mondi
2018-01-16 21:45 ` Jacopo Mondi
2018-01-19 11:26 ` [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Hans Verkuil
2018-01-19 11:26 ` Hans Verkuil
[not found] ` <6fcd22c1-19a5-e0b7-2b00-961e1cd1ebaa-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2018-01-21 17:49 ` jacopo mondi
2018-01-21 17:49 ` jacopo mondi
2018-01-21 17:49 ` jacopo mondi
2018-01-22 10:00 ` Hans Verkuil
2018-01-22 10:00 ` Hans Verkuil
2018-01-22 10:00 ` Hans Verkuil
2018-01-19 22:12 ` Randy Dunlap
2018-01-19 22:12 ` Randy Dunlap
2018-01-21 17:54 ` jacopo mondi
2018-01-21 17:54 ` jacopo mondi
2018-01-21 18:04 ` Randy Dunlap
2018-01-21 18:04 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00f1dd19-6420-26ab-0529-a97f2b0de682@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=geert-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org \
--cc=jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=pombredanne-od1rfyK75/E@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.