From: Aswath Govindraju <a-govindraju@ti.com> To: Vinod Koul <vkoul@kernel.org> Cc: <linux-can@vger.kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de>, Wolfgang Grandegger <wg@grandegger.com>, Vignesh Raghavendra <vigneshr@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Rob Herring <robh+dt@kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps Date: Fri, 11 Jun 2021 18:12:27 +0530 [thread overview] Message-ID: <0150622f-8543-ac4a-fe18-f22d7862d163@ti.com> (raw) In-Reply-To: <615d3a2a-0dc2-0e87-fdac-e170542d33da@ti.com> Hi Vinod, On 31/05/21 2:04 pm, Aswath Govindraju wrote: > Hi Vinod, > > On 31/05/21 12:48 pm, Vinod Koul wrote: >> On 10-05-21, 10:40, Aswath Govindraju wrote: >>> In some subsystems (eg. CAN, SPI), the max link rate supported can be less >>> than 1 Mbps and if the unit for max_link_rate is Mbps then it can't be >>> used. Therefore, leave the decision of units to be used, to the producer >>> and consumer. >>> >>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> >>> --- >>> include/linux/phy/phy.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >>> index 0ed434d02196..f3286f4cd306 100644 >>> --- a/include/linux/phy/phy.h >>> +++ b/include/linux/phy/phy.h >>> @@ -125,7 +125,7 @@ struct phy_ops { >>> /** >>> * struct phy_attrs - represents phy attributes >>> * @bus_width: Data path width implemented by PHY >>> - * @max_link_rate: Maximum link rate supported by PHY (in Mbps) >>> + * @max_link_rate: Maximum link rate supported by PHY (units to be decided by producer and consumer) >> >> So there are a few users of max_link_rate. It would be better that we >> document all previous users of max_link_rate that unit is in Mbps and >> then modify it here >> > > I was able to see that the max_link_rate attribute was used at, > > drivers/phy/cadence/phy-cadence-torrent.c:2514: > gphy->attrs.max_link_rate = cdns_phy->max_bit_rate; > > and in the bindings there is indication that the units to be used is Mbps. > > Can you please point me if there is any other place that I might have > missed to look at or that might need documentation update? > May I know if this patch series is good to be merged ? Thanks, Aswath > Thanks, > Aswath > >
WARNING: multiple messages have this Message-ID (diff)
From: Aswath Govindraju <a-govindraju@ti.com> To: Vinod Koul <vkoul@kernel.org> Cc: <linux-can@vger.kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de>, Wolfgang Grandegger <wg@grandegger.com>, Vignesh Raghavendra <vigneshr@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Rob Herring <robh+dt@kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps Date: Fri, 11 Jun 2021 18:12:27 +0530 [thread overview] Message-ID: <0150622f-8543-ac4a-fe18-f22d7862d163@ti.com> (raw) In-Reply-To: <615d3a2a-0dc2-0e87-fdac-e170542d33da@ti.com> Hi Vinod, On 31/05/21 2:04 pm, Aswath Govindraju wrote: > Hi Vinod, > > On 31/05/21 12:48 pm, Vinod Koul wrote: >> On 10-05-21, 10:40, Aswath Govindraju wrote: >>> In some subsystems (eg. CAN, SPI), the max link rate supported can be less >>> than 1 Mbps and if the unit for max_link_rate is Mbps then it can't be >>> used. Therefore, leave the decision of units to be used, to the producer >>> and consumer. >>> >>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> >>> --- >>> include/linux/phy/phy.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >>> index 0ed434d02196..f3286f4cd306 100644 >>> --- a/include/linux/phy/phy.h >>> +++ b/include/linux/phy/phy.h >>> @@ -125,7 +125,7 @@ struct phy_ops { >>> /** >>> * struct phy_attrs - represents phy attributes >>> * @bus_width: Data path width implemented by PHY >>> - * @max_link_rate: Maximum link rate supported by PHY (in Mbps) >>> + * @max_link_rate: Maximum link rate supported by PHY (units to be decided by producer and consumer) >> >> So there are a few users of max_link_rate. It would be better that we >> document all previous users of max_link_rate that unit is in Mbps and >> then modify it here >> > > I was able to see that the max_link_rate attribute was used at, > > drivers/phy/cadence/phy-cadence-torrent.c:2514: > gphy->attrs.max_link_rate = cdns_phy->max_bit_rate; > > and in the bindings there is indication that the units to be used is Mbps. > > Can you please point me if there is any other place that I might have > missed to look at or that might need documentation update? > May I know if this patch series is good to be merged ? Thanks, Aswath > Thanks, > Aswath > > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-06-11 12:42 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-10 5:10 [PATCH v6 0/3] CAN TRANSCEIVER: Add support for CAN transceivers Aswath Govindraju 2021-05-10 5:10 ` Aswath Govindraju 2021-05-10 5:10 ` [PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps Aswath Govindraju 2021-05-10 5:10 ` Aswath Govindraju 2021-05-31 7:18 ` Vinod Koul 2021-05-31 7:18 ` Vinod Koul 2021-05-31 8:34 ` Aswath Govindraju 2021-05-31 8:34 ` Aswath Govindraju 2021-06-11 12:42 ` Aswath Govindraju [this message] 2021-06-11 12:42 ` Aswath Govindraju 2021-06-11 13:01 ` Kishon Vijay Abraham I 2021-06-11 13:01 ` Kishon Vijay Abraham I 2021-06-14 5:50 ` Vinod Koul 2021-06-14 5:50 ` Vinod Koul 2021-05-10 5:10 ` [PATCH v6 2/3] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers Aswath Govindraju 2021-05-10 5:10 ` Aswath Govindraju 2021-05-10 5:10 ` [PATCH v6 3/3] phy: phy-can-transceiver: Add support for generic CAN transceiver driver Aswath Govindraju 2021-05-10 5:10 ` Aswath Govindraju
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0150622f-8543-ac4a-fe18-f22d7862d163@ti.com \ --to=a-govindraju@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=kishon@ti.com \ --cc=linux-can@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=lokeshvutla@ti.com \ --cc=mkl@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ --cc=wg@grandegger.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.