All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Aswath Govindraju <a-govindraju@ti.com>,
	linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps
Date: Mon, 14 Jun 2021 11:20:53 +0530	[thread overview]
Message-ID: <YMbuPaSrBZ+W/uKN@vkoul-mobl> (raw)
In-Reply-To: <7913b08e-a71c-d29d-d921-c25a87c0616a@ti.com>

On 11-06-21, 18:31, Kishon Vijay Abraham I wrote:

> >>> So there are a few users of max_link_rate. It would be better that we
> >>> document all previous users of max_link_rate that unit is in Mbps and
> >>> then modify it here
> >>>
> >>
> >> I was able to see that the max_link_rate attribute was used at,
> >>
> >> drivers/phy/cadence/phy-cadence-torrent.c:2514:
> >> gphy->attrs.max_link_rate = cdns_phy->max_bit_rate;
> >>
> >> and in the bindings there is indication that the units to be used is Mbps.
> >>
> >> Can you please point me if there is any other place that I might have
> >> missed to look at or that might need documentation update?
> >>
> 
> The only user seems to be Torrent and max_bit_rate is documented well in
> Torrent.
> 
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

Series Applied, thanks

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Aswath Govindraju <a-govindraju@ti.com>,
	linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps
Date: Mon, 14 Jun 2021 11:20:53 +0530	[thread overview]
Message-ID: <YMbuPaSrBZ+W/uKN@vkoul-mobl> (raw)
In-Reply-To: <7913b08e-a71c-d29d-d921-c25a87c0616a@ti.com>

On 11-06-21, 18:31, Kishon Vijay Abraham I wrote:

> >>> So there are a few users of max_link_rate. It would be better that we
> >>> document all previous users of max_link_rate that unit is in Mbps and
> >>> then modify it here
> >>>
> >>
> >> I was able to see that the max_link_rate attribute was used at,
> >>
> >> drivers/phy/cadence/phy-cadence-torrent.c:2514:
> >> gphy->attrs.max_link_rate = cdns_phy->max_bit_rate;
> >>
> >> and in the bindings there is indication that the units to be used is Mbps.
> >>
> >> Can you please point me if there is any other place that I might have
> >> missed to look at or that might need documentation update?
> >>
> 
> The only user seems to be Torrent and max_bit_rate is documented well in
> Torrent.
> 
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

Series Applied, thanks

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2021-06-14  5:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  5:10 [PATCH v6 0/3] CAN TRANSCEIVER: Add support for CAN transceivers Aswath Govindraju
2021-05-10  5:10 ` Aswath Govindraju
2021-05-10  5:10 ` [PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps Aswath Govindraju
2021-05-10  5:10   ` Aswath Govindraju
2021-05-31  7:18   ` Vinod Koul
2021-05-31  7:18     ` Vinod Koul
2021-05-31  8:34     ` Aswath Govindraju
2021-05-31  8:34       ` Aswath Govindraju
2021-06-11 12:42       ` Aswath Govindraju
2021-06-11 12:42         ` Aswath Govindraju
2021-06-11 13:01         ` Kishon Vijay Abraham I
2021-06-11 13:01           ` Kishon Vijay Abraham I
2021-06-14  5:50           ` Vinod Koul [this message]
2021-06-14  5:50             ` Vinod Koul
2021-05-10  5:10 ` [PATCH v6 2/3] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers Aswath Govindraju
2021-05-10  5:10   ` Aswath Govindraju
2021-05-10  5:10 ` [PATCH v6 3/3] phy: phy-can-transceiver: Add support for generic CAN transceiver driver Aswath Govindraju
2021-05-10  5:10   ` Aswath Govindraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMbuPaSrBZ+W/uKN@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=a-govindraju@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lokeshvutla@ti.com \
    --cc=mkl@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.