From: Dave Hansen <dave.hansen@intel.com> To: "Li, Liang Z" <liang.z.li@intel.com>, Andrea Arcangeli <aarcange@redhat.com> Cc: David Hildenbrand <david@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mhocko@suse.com" <mhocko@suse.com>, "mst@redhat.com" <mst@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "dgilbert@redhat.com" <dgilbert@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration Date: Thu, 15 Dec 2016 07:34:33 -0800 [thread overview] Message-ID: <01886693-c73e-3696-860b-086417d695e1@intel.com> (raw) In-Reply-To: <F2CBF3009FA73547804AE4C663CAB28E3C31D0E6@SHSMSX104.ccr.corp.intel.com> On 12/14/2016 12:59 AM, Li, Liang Z wrote: >> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for >> fast (de)inflating & fast live migration >> >> On 12/08/2016 08:45 PM, Li, Liang Z wrote: >>> What's the conclusion of your discussion? It seems you want some >>> statistic before deciding whether to ripping the bitmap from the ABI, >>> am I right? >> >> I think Andrea and David feel pretty strongly that we should remove the >> bitmap, unless we have some data to support keeping it. I don't feel as >> strongly about it, but I think their critique of it is pretty valid. I think the >> consensus is that the bitmap needs to go. >> >> The only real question IMNHO is whether we should do a power-of-2 or a >> length. But, if we have 12 bits, then the argument for doing length is pretty >> strong. We don't need anywhere near 12 bits if doing power-of-2. > > Just found the MAX_ORDER should be limited to 12 if use length instead of order, > If the MAX_ORDER is configured to a value bigger than 12, it will make things more > complex to handle this case. > > If use order, we need to break a large memory range whose length is not the power of 2 into several > small ranges, it also make the code complex. I can't imagine it makes the code that much more complex. It adds a for loop. Right? > It seems we leave too many bit for the pfn, and the bits leave for length is not enough, > How about keep 45 bits for the pfn and 19 bits for length, 45 bits for pfn can cover 57 bits > physical address, that should be enough in the near feature. > > What's your opinion? I still think 'order' makes a lot of sense. But, as you say, 57 bits is enough for x86 for a while. Other architectures.... who knows?
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com> To: "Li, Liang Z" <liang.z.li@intel.com>, Andrea Arcangeli <aarcange@redhat.com> Cc: David Hildenbrand <david@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mhocko@suse.com" <mhocko@suse.com>, "mst@redhat.com" <mst@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "dgilbert@redhat.com" <dgilbert@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration Date: Thu, 15 Dec 2016 07:34:33 -0800 [thread overview] Message-ID: <01886693-c73e-3696-860b-086417d695e1@intel.com> (raw) In-Reply-To: <F2CBF3009FA73547804AE4C663CAB28E3C31D0E6@SHSMSX104.ccr.corp.intel.com> On 12/14/2016 12:59 AM, Li, Liang Z wrote: >> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for >> fast (de)inflating & fast live migration >> >> On 12/08/2016 08:45 PM, Li, Liang Z wrote: >>> What's the conclusion of your discussion? It seems you want some >>> statistic before deciding whether to ripping the bitmap from the ABI, >>> am I right? >> >> I think Andrea and David feel pretty strongly that we should remove the >> bitmap, unless we have some data to support keeping it. I don't feel as >> strongly about it, but I think their critique of it is pretty valid. I think the >> consensus is that the bitmap needs to go. >> >> The only real question IMNHO is whether we should do a power-of-2 or a >> length. But, if we have 12 bits, then the argument for doing length is pretty >> strong. We don't need anywhere near 12 bits if doing power-of-2. > > Just found the MAX_ORDER should be limited to 12 if use length instead of order, > If the MAX_ORDER is configured to a value bigger than 12, it will make things more > complex to handle this case. > > If use order, we need to break a large memory range whose length is not the power of 2 into several > small ranges, it also make the code complex. I can't imagine it makes the code that much more complex. It adds a for loop. Right? > It seems we leave too many bit for the pfn, and the bits leave for length is not enough, > How about keep 45 bits for the pfn and 19 bits for length, 45 bits for pfn can cover 57 bits > physical address, that should be enough in the near feature. > > What's your opinion? I still think 'order' makes a lot of sense. But, as you say, 57 bits is enough for x86 for a while. Other architectures.... who knows? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-15 15:34 UTC|newest] Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-30 8:43 [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration Liang Li 2016-11-30 8:43 ` [Qemu-devel] " Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` [PATCH kernel v5 1/5] virtio-balloon: rework deflate to add page to a list Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` [Qemu-devel] " Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` [PATCH kernel v5 2/5] virtio-balloon: define new feature bit and head struct Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` [Qemu-devel] " Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` [PATCH kernel v5 3/5] virtio-balloon: speed up inflate/deflate process Liang Li 2016-11-30 8:43 ` [Qemu-devel] " Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` [PATCH kernel v5 4/5] virtio-balloon: define flags and head for host request vq Liang Li 2016-11-30 8:43 ` [Qemu-devel] " Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` [PATCH kernel v5 5/5] virtio-balloon: tell host vm's unused page info Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 8:43 ` [Qemu-devel] " Liang Li 2016-11-30 8:43 ` Liang Li 2016-11-30 19:15 ` Dave Hansen 2016-11-30 19:15 ` Dave Hansen 2016-11-30 19:15 ` [Qemu-devel] " Dave Hansen 2016-11-30 19:15 ` Dave Hansen 2016-12-04 13:13 ` Li, Liang Z 2016-12-04 13:13 ` Li, Liang Z 2016-12-04 13:13 ` [Qemu-devel] " Li, Liang Z 2016-12-04 13:13 ` Li, Liang Z 2016-12-05 17:22 ` Dave Hansen 2016-12-05 17:22 ` [Qemu-devel] " Dave Hansen 2016-12-05 17:22 ` Dave Hansen 2016-12-05 17:22 ` Dave Hansen 2016-12-06 4:47 ` Li, Liang Z 2016-12-06 4:47 ` [Qemu-devel] " Li, Liang Z 2016-12-06 4:47 ` Li, Liang Z 2016-12-06 4:47 ` Li, Liang Z 2016-12-06 8:40 ` [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration David Hildenbrand 2016-12-06 8:40 ` [Qemu-devel] " David Hildenbrand 2016-12-06 8:40 ` David Hildenbrand 2016-12-06 8:40 ` David Hildenbrand 2016-12-07 13:35 ` Li, Liang Z 2016-12-07 13:35 ` [Qemu-devel] " Li, Liang Z 2016-12-07 13:35 ` Li, Liang Z 2016-12-07 13:35 ` Li, Liang Z 2016-12-07 15:34 ` Dave Hansen 2016-12-07 15:34 ` [Qemu-devel] " Dave Hansen 2016-12-07 15:34 ` Dave Hansen 2016-12-09 3:09 ` Li, Liang Z 2016-12-09 3:09 ` [Qemu-devel] " Li, Liang Z 2016-12-09 3:09 ` Li, Liang Z 2016-12-09 3:09 ` Li, Liang Z 2016-12-09 3:09 ` Li, Liang Z 2016-12-07 15:34 ` Dave Hansen 2016-12-07 15:42 ` David Hildenbrand 2016-12-07 15:42 ` [Qemu-devel] " David Hildenbrand 2016-12-07 15:42 ` David Hildenbrand 2016-12-07 15:45 ` Dave Hansen 2016-12-07 15:45 ` [Qemu-devel] " Dave Hansen 2016-12-07 15:45 ` Dave Hansen 2016-12-07 15:45 ` Dave Hansen 2016-12-07 16:21 ` David Hildenbrand 2016-12-07 16:21 ` [Qemu-devel] " David Hildenbrand 2016-12-07 16:21 ` David Hildenbrand 2016-12-07 16:21 ` David Hildenbrand 2016-12-07 16:57 ` Dave Hansen 2016-12-07 16:57 ` Dave Hansen 2016-12-07 16:57 ` [Qemu-devel] " Dave Hansen 2016-12-07 16:57 ` Dave Hansen 2016-12-07 18:38 ` [Qemu-devel] " Andrea Arcangeli 2016-12-07 18:38 ` Andrea Arcangeli 2016-12-07 18:38 ` Andrea Arcangeli 2016-12-07 18:38 ` Andrea Arcangeli 2016-12-07 18:44 ` Dave Hansen 2016-12-07 18:44 ` Dave Hansen 2016-12-07 18:44 ` Dave Hansen 2016-12-07 18:44 ` Dave Hansen 2016-12-07 18:58 ` Andrea Arcangeli 2016-12-07 18:58 ` Andrea Arcangeli 2016-12-07 18:58 ` Andrea Arcangeli 2016-12-07 18:58 ` Andrea Arcangeli 2016-12-07 19:54 ` Dave Hansen 2016-12-07 19:54 ` Dave Hansen 2016-12-07 19:54 ` Dave Hansen 2016-12-07 19:54 ` Dave Hansen 2016-12-07 20:28 ` Andrea Arcangeli 2016-12-07 20:28 ` Andrea Arcangeli 2016-12-07 20:28 ` Andrea Arcangeli 2016-12-07 20:28 ` Andrea Arcangeli 2016-12-09 4:45 ` Li, Liang Z 2016-12-09 4:45 ` Li, Liang Z 2016-12-09 4:45 ` Li, Liang Z 2016-12-09 4:45 ` Li, Liang Z 2016-12-09 4:53 ` Dave Hansen 2016-12-09 4:53 ` Dave Hansen 2016-12-09 4:53 ` Dave Hansen 2016-12-09 4:53 ` Dave Hansen 2016-12-09 5:35 ` Li, Liang Z 2016-12-09 5:35 ` Li, Liang Z 2016-12-09 5:35 ` Li, Liang Z 2016-12-09 5:35 ` Li, Liang Z 2016-12-09 16:42 ` Andrea Arcangeli 2016-12-09 16:42 ` Andrea Arcangeli 2016-12-09 16:42 ` Andrea Arcangeli 2016-12-09 16:42 ` Andrea Arcangeli 2016-12-14 8:20 ` Li, Liang Z 2016-12-14 8:20 ` Li, Liang Z 2016-12-14 8:20 ` Li, Liang Z 2016-12-14 8:20 ` Li, Liang Z 2016-12-14 8:59 ` Li, Liang Z 2016-12-14 8:59 ` Li, Liang Z 2016-12-14 8:59 ` Li, Liang Z 2016-12-14 8:59 ` Li, Liang Z 2016-12-15 15:34 ` Dave Hansen 2016-12-15 15:34 ` Dave Hansen [this message] 2016-12-15 15:34 ` Dave Hansen 2016-12-15 15:34 ` Dave Hansen 2016-12-15 15:54 ` Michael S. Tsirkin 2016-12-15 15:54 ` Michael S. Tsirkin 2016-12-15 15:54 ` Michael S. Tsirkin 2016-12-15 15:54 ` Michael S. Tsirkin 2016-12-16 1:12 ` Li, Liang Z 2016-12-16 1:12 ` Li, Liang Z 2016-12-16 1:12 ` Li, Liang Z 2016-12-16 1:12 ` Li, Liang Z 2016-12-16 15:40 ` Andrea Arcangeli 2016-12-16 15:40 ` Andrea Arcangeli 2016-12-16 15:40 ` Andrea Arcangeli 2016-12-17 11:56 ` Li, Liang Z 2016-12-17 11:56 ` Li, Liang Z 2016-12-17 11:56 ` Li, Liang Z 2016-12-17 11:56 ` Li, Liang Z 2016-12-16 15:40 ` Andrea Arcangeli 2016-12-16 0:48 ` Li, Liang Z 2016-12-16 0:48 ` Li, Liang Z 2016-12-16 0:48 ` Li, Liang Z 2016-12-16 0:48 ` Li, Liang Z 2016-12-16 1:09 ` Dave Hansen 2016-12-16 1:09 ` Dave Hansen 2016-12-16 1:09 ` Dave Hansen 2016-12-16 1:09 ` Dave Hansen 2016-12-16 1:38 ` Li, Liang Z 2016-12-16 1:38 ` Li, Liang Z 2016-12-16 1:38 ` Li, Liang Z 2016-12-16 1:38 ` Li, Liang Z 2016-12-16 1:40 ` Dave Hansen 2016-12-16 1:40 ` Dave Hansen 2016-12-16 1:40 ` Dave Hansen 2016-12-16 1:40 ` Dave Hansen 2016-12-16 1:43 ` Li, Liang Z 2016-12-16 1:43 ` Li, Liang Z 2016-12-16 1:43 ` Li, Liang Z 2016-12-16 1:43 ` Li, Liang Z 2016-12-16 16:01 ` Andrea Arcangeli 2016-12-16 16:01 ` Andrea Arcangeli 2016-12-16 16:01 ` Andrea Arcangeli 2016-12-16 16:01 ` Andrea Arcangeli 2016-12-17 12:39 ` Li, Liang Z 2016-12-17 12:39 ` Li, Liang Z 2016-12-17 12:39 ` Li, Liang Z 2016-12-17 12:39 ` Li, Liang Z 2016-12-07 15:42 ` David Hildenbrand 2016-12-07 13:35 ` Li, Liang Z
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=01886693-c73e-3696-860b-086417d695e1@intel.com \ --to=dave.hansen@intel.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=david@redhat.com \ --cc=dgilbert@redhat.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=kvm@vger.kernel.org \ --cc=liang.z.li@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.