All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sload.f2fs: fix the missing of bit mask for file type
@ 2018-05-03 11:25 Junling Zheng
  2018-05-04 10:03 ` Chao Yu
  2018-05-07  9:44 ` Junling Zheng
  0 siblings, 2 replies; 4+ messages in thread
From: Junling Zheng @ 2018-05-03 11:25 UTC (permalink / raw)
  To: jaegeuk, yuchao0; +Cc: miaoxie, linux-f2fs-devel

Fix the missing of bit mask for the file type bit fields.

Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
Signed-off-by: Sheng Yong <shengyong1@huawei.com>
---
 fsck/sload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fsck/sload.c b/fsck/sload.c
index 2842f2c..1b7a2d1 100644
--- a/fsck/sload.c
+++ b/fsck/sload.c
@@ -157,7 +157,7 @@ static void set_inode_metadata(struct dentry *de)
 
 	de->size = stat.st_size;
 	de->mode = stat.st_mode &
-			(S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO);
+			(S_IFMT|S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO);
 	if (c.fixed_time == -1 && c.from_dir)
 		de->mtime = stat.st_mtime;
 	else
-- 
2.16.2


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] sload.f2fs: fix the missing of bit mask for file type
  2018-05-03 11:25 [PATCH] sload.f2fs: fix the missing of bit mask for file type Junling Zheng
@ 2018-05-04 10:03 ` Chao Yu
  2018-05-07  9:44 ` Junling Zheng
  1 sibling, 0 replies; 4+ messages in thread
From: Chao Yu @ 2018-05-04 10:03 UTC (permalink / raw)
  To: Junling Zheng, jaegeuk; +Cc: miaoxie, linux-f2fs-devel

On 2018/5/3 19:25, Junling Zheng wrote:
> Fix the missing of bit mask for the file type bit fields.
> 
> Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] sload.f2fs: fix the missing of bit mask for file type
  2018-05-03 11:25 [PATCH] sload.f2fs: fix the missing of bit mask for file type Junling Zheng
  2018-05-04 10:03 ` Chao Yu
@ 2018-05-07  9:44 ` Junling Zheng
  2018-05-07 20:06   ` Jaegeuk Kim
  1 sibling, 1 reply; 4+ messages in thread
From: Junling Zheng @ 2018-05-07  9:44 UTC (permalink / raw)
  To: jaegeuk, yuchao0; +Cc: miaoxie, linux-f2fs-devel

Hi, Jaegeuk

Could you please merge this fix into external/f2fs-tools repo for AOSP?
Since we found this bug while using sload feature in Android P :)

Thanks,
Junling

On 2018/5/3 19:25, Junling Zheng wrote:
> Fix the missing of bit mask for the file type bit fields.
> 
> Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
> ---
>  fsck/sload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fsck/sload.c b/fsck/sload.c
> index 2842f2c..1b7a2d1 100644
> --- a/fsck/sload.c
> +++ b/fsck/sload.c
> @@ -157,7 +157,7 @@ static void set_inode_metadata(struct dentry *de)
>  
>  	de->size = stat.st_size;
>  	de->mode = stat.st_mode &
> -			(S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO);
> +			(S_IFMT|S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO);
>  	if (c.fixed_time == -1 && c.from_dir)
>  		de->mtime = stat.st_mtime;
>  	else
> 



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] sload.f2fs: fix the missing of bit mask for file type
  2018-05-07  9:44 ` Junling Zheng
@ 2018-05-07 20:06   ` Jaegeuk Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2018-05-07 20:06 UTC (permalink / raw)
  To: Junling Zheng; +Cc: miaoxie, linux-f2fs-devel

On 05/07, Junling Zheng wrote:
> Hi, Jaegeuk
> 
> Could you please merge this fix into external/f2fs-tools repo for AOSP?
> Since we found this bug while using sload feature in Android P :)

Sure. Will prepare soon.
Thanks,

> 
> Thanks,
> Junling
> 
> On 2018/5/3 19:25, Junling Zheng wrote:
> > Fix the missing of bit mask for the file type bit fields.
> > 
> > Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
> > Signed-off-by: Sheng Yong <shengyong1@huawei.com>
> > ---
> >  fsck/sload.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fsck/sload.c b/fsck/sload.c
> > index 2842f2c..1b7a2d1 100644
> > --- a/fsck/sload.c
> > +++ b/fsck/sload.c
> > @@ -157,7 +157,7 @@ static void set_inode_metadata(struct dentry *de)
> >  
> >  	de->size = stat.st_size;
> >  	de->mode = stat.st_mode &
> > -			(S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO);
> > +			(S_IFMT|S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO);
> >  	if (c.fixed_time == -1 && c.from_dir)
> >  		de->mtime = stat.st_mtime;
> >  	else
> > 
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-07 20:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-03 11:25 [PATCH] sload.f2fs: fix the missing of bit mask for file type Junling Zheng
2018-05-04 10:03 ` Chao Yu
2018-05-07  9:44 ` Junling Zheng
2018-05-07 20:06   ` Jaegeuk Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.