[PATCH v3 00/23] Fix some issues at documentation

[PATCH v3 00/23] Fix some issues at documentation

[Mauro Carvalho Chehab]

Hi Jon,

This series is against today's next (next-20211019) and addresses missing
links to Documentation/*.

The best would be to have the patches applied directly to the trees that
contain the patches that moved/renamed files, and then apply the
remaining ones either later during the merge window or just afterwards,
whatever works best for you.

Regards,
Mauro

Mauro Carvalho Chehab (23):
  visorbus: fix a copyright symbol that was bad encoded
  libbpf: update index.rst reference
  docs: accounting: update delay-accounting.rst reference
  MAINTAINERS: update arm,vic.yaml reference
  MAINTAINERS: update aspeed,i2c.yaml reference
  MAINTAINERS: update faraday,ftrtc010.yaml reference
  MAINTAINERS: update ti,sci.yaml reference
  MAINTAINERS: update intel,ixp46x-rng.yaml reference
  MAINTAINERS: update nxp,imx8-jpeg.yaml reference
  MAINTAINERS: update gemini.yaml reference
  MAINTAINERS: update brcm,unimac-mdio.yaml reference
  MAINTAINERS: update mtd-physmap.yaml reference
  Documentation: update vcpu-requests.rst reference
  bpftool: update bpftool-cgroup.rst reference
  docs: translations: zn_CN: irq-affinity.rst: add a missing extension
  docs: translations: zh_CN: memory-hotplug.rst: fix a typo
  docs: fs: locks.rst: update comment about mandatory file locking
  fs: remove a comment pointing to the removed mandatory-locking file
  Documentation/process: fix a cross reference
  dt-bindings: mfd: update x-powers,axp152.yaml reference
  regulator: dt-bindings: update samsung,s2mpa01.yaml reference
  regulator: dt-bindings: update samsung,s5m8767.yaml reference
  dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

 Documentation/admin-guide/ramoops.rst         |  2 +-
 Documentation/admin-guide/sysctl/kernel.rst   |  2 +-
 Documentation/bpf/index.rst                   |  2 +-
 .../devicetree/bindings/gpio/gpio-axp209.txt  |  2 +-
 .../bindings/regulator/samsung,s2mpa01.yaml   |  2 +-
 .../bindings/regulator/samsung,s5m8767.yaml   |  2 +-
 Documentation/filesystems/locks.rst           | 17 +++++-----------
 Documentation/process/submitting-patches.rst  |  4 ++--
 .../zh_CN/core-api/irq/irq-affinity.rst       |  2 +-
 .../zh_CN/core-api/memory-hotplug.rst         |  2 +-
 MAINTAINERS                                   | 20 +++++++++----------
 arch/riscv/kvm/vcpu.c                         |  2 +-
 drivers/visorbus/visorbus_main.c              |  2 +-
 fs/locks.c                                    |  1 -
 .../selftests/bpf/test_bpftool_synctypes.py   |  2 +-
 15 files changed, 28 insertions(+), 36 deletions(-)

-- 
2.31.1

[PATCH v3 00/23] Fix some issues at documentation

[Mauro Carvalho Chehab]

Hi Jon,

This series is against today's next (next-20211019) and addresses missing
links to Documentation/*.

The best would be to have the patches applied directly to the trees that
contain the patches that moved/renamed files, and then apply the
remaining ones either later during the merge window or just afterwards,
whatever works best for you.

Regards,
Mauro

Mauro Carvalho Chehab (23):
  visorbus: fix a copyright symbol that was bad encoded
  libbpf: update index.rst reference
  docs: accounting: update delay-accounting.rst reference
  MAINTAINERS: update arm,vic.yaml reference
  MAINTAINERS: update aspeed,i2c.yaml reference
  MAINTAINERS: update faraday,ftrtc010.yaml reference
  MAINTAINERS: update ti,sci.yaml reference
  MAINTAINERS: update intel,ixp46x-rng.yaml reference
  MAINTAINERS: update nxp,imx8-jpeg.yaml reference
  MAINTAINERS: update gemini.yaml reference
  MAINTAINERS: update brcm,unimac-mdio.yaml reference
  MAINTAINERS: update mtd-physmap.yaml reference
  Documentation: update vcpu-requests.rst reference
  bpftool: update bpftool-cgroup.rst reference
  docs: translations: zn_CN: irq-affinity.rst: add a missing extension
  docs: translations: zh_CN: memory-hotplug.rst: fix a typo
  docs: fs: locks.rst: update comment about mandatory file locking
  fs: remove a comment pointing to the removed mandatory-locking file
  Documentation/process: fix a cross reference
  dt-bindings: mfd: update x-powers,axp152.yaml reference
  regulator: dt-bindings: update samsung,s2mpa01.yaml reference
  regulator: dt-bindings: update samsung,s5m8767.yaml reference
  dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

 Documentation/admin-guide/ramoops.rst         |  2 +-
 Documentation/admin-guide/sysctl/kernel.rst   |  2 +-
 Documentation/bpf/index.rst                   |  2 +-
 .../devicetree/bindings/gpio/gpio-axp209.txt  |  2 +-
 .../bindings/regulator/samsung,s2mpa01.yaml   |  2 +-
 .../bindings/regulator/samsung,s5m8767.yaml   |  2 +-
 Documentation/filesystems/locks.rst           | 17 +++++-----------
 Documentation/process/submitting-patches.rst  |  4 ++--
 .../zh_CN/core-api/irq/irq-affinity.rst       |  2 +-
 .../zh_CN/core-api/memory-hotplug.rst         |  2 +-
 MAINTAINERS                                   | 20 +++++++++----------
 arch/riscv/kvm/vcpu.c                         |  2 +-
 drivers/visorbus/visorbus_main.c              |  2 +-
 fs/locks.c                                    |  1 -
 .../selftests/bpf/test_bpftool_synctypes.py   |  2 +-
 15 files changed, 28 insertions(+), 36 deletions(-)

-- 
2.31.1



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH v3 01/23] visorbus: fix a copyright symbol that was bad encoded

[Mauro Carvalho Chehab]

The copyright symbol was badly encoded using the
REPLACEMENT CHARACTER U+fffd ('�'), probably due to some
bad charset conversion.

Fix it.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 drivers/visorbus/visorbus_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/visorbus/visorbus_main.c b/drivers/visorbus/visorbus_main.c
index 152fd29f04f2..0aa4cff670dc 100644
--- a/drivers/visorbus/visorbus_main.c
+++ b/drivers/visorbus/visorbus_main.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Copyright � 2010 - 2015 UNISYS CORPORATION
+ * Copyright © 2010 - 2015 UNISYS CORPORATION
  * All rights reserved.
  */
 
-- 
2.31.1

[PATCH v3 02/23] libbpf: update index.rst reference

[Mauro Carvalho Chehab]

Changeset d20b41115ad5 ("libbpf: Rename libbpf documentation index file")
renamed: Documentation/bpf/libbpf/libbpf.rst
to: Documentation/bpf/libbpf/index.rst.

Update its cross-reference accordingly.

Fixes: d20b41115ad5 ("libbpf: Rename libbpf documentation index file")
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 Documentation/bpf/index.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/bpf/index.rst b/Documentation/bpf/index.rst
index 37f273a7e8b6..610450f59e05 100644
--- a/Documentation/bpf/index.rst
+++ b/Documentation/bpf/index.rst
@@ -15,7 +15,7 @@ that goes into great technical depth about the BPF Architecture.
 libbpf
 ======
 
-Documentation/bpf/libbpf/libbpf.rst is a userspace library for loading and interacting with bpf programs.
+Documentation/bpf/libbpf/index.rst is a userspace library for loading and interacting with bpf programs.
 
 BPF Type Format (BTF)
 =====================
-- 
2.31.1

[PATCH v3 03/23] docs: accounting: update delay-accounting.rst reference

[Mauro Carvalho Chehab]

The file name: accounting/delay-accounting.rst
should be, instead: Documentation/accounting/delay-accounting.rst.

Also, there's no need to use doc:`foo`, as automarkup.py will
automatically handle plain text mentions to Documentation/
files.

So, update its cross-reference accordingly.

Fixes: fcb501704554 ("delayacct: Document task_delayacct sysctl")
Fixes: c3123552aad3 ("docs: accounting: convert to ReST")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 Documentation/admin-guide/sysctl/kernel.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 426162009ce9..0e486f41185e 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -1099,7 +1099,7 @@ task_delayacct
 ===============
 
 Enables/disables task delay accounting (see
-:doc:`accounting/delay-accounting.rst`). Enabling this feature incurs
+Documentation/accounting/delay-accounting.rst. Enabling this feature incurs
 a small amount of overhead in the scheduler but is useful for debugging
 and performance tuning. It is required by some tools such as iotop.
 
-- 
2.31.1

[PATCH v3 04/23] MAINTAINERS: update arm,vic.yaml reference

[Mauro Carvalho Chehab]

Changeset b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
renamed: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
to: Documentation/devicetree/bindings/interrupt-controller/arm,vic.yaml.

Update its cross-reference accordingly.

Fixes: b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index a10b915292e1..22efd0c518a1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1560,7 +1560,7 @@ ARM PRIMECELL VIC PL190/PL192 DRIVER
 M:	Linus Walleij <linus.walleij@linaro.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
-F:	Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
+F:	Documentation/devicetree/bindings/interrupt-controller/arm,vic.yaml
 F:	drivers/irqchip/irq-vic.c
 
 ARM SMC WATCHDOG DRIVER
-- 
2.31.1

Re: [PATCH v3 04/23] MAINTAINERS: update arm,vic.yaml reference

[Linus Walleij]

On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:

> Changeset b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
> renamed: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
> to: Documentation/devicetree/bindings/interrupt-controller/arm,vic.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

I suppose Marc Z could merge this into the irqchips tree?

Yours,
Linus Walleij

Re: [PATCH v3 04/23] MAINTAINERS: update arm,vic.yaml reference

[Rob Herring]

On Sun, Oct 24, 2021 at 5:08 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
>
> > Changeset b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
> > renamed: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
> > to: Documentation/devicetree/bindings/interrupt-controller/arm,vic.yaml.
> >
> > Update its cross-reference accordingly.
> >
> > Fixes: b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> I suppose Marc Z could merge this into the irqchips tree?

I already applied all these MAINTAINERS fixes.

Rob

[PATCH v3 05/23] MAINTAINERS: update aspeed,i2c.yaml reference

[Mauro Carvalho Chehab]

Changeset 810e4441946c ("dt-bindings: aspeed-i2c: Convert txt to yaml format")
renamed: Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
to: Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml.

Update its cross-reference accordingly.

Fixes: 810e4441946c ("dt-bindings: aspeed-i2c: Convert txt to yaml format")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 22efd0c518a1..fb898af23d0a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1758,7 +1758,7 @@ R:	Joel Stanley <joel@jms.id.au>
 L:	linux-i2c@vger.kernel.org
 L:	openbmc@lists.ozlabs.org (moderated for non-subscribers)
 S:	Maintained
-F:	Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
+F:	Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
 F:	Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-i2c-ic.txt
 F:	drivers/i2c/busses/i2c-aspeed.c
 F:	drivers/irqchip/irq-aspeed-i2c-ic.c
-- 
2.31.1

[PATCH v3 06/23] MAINTAINERS: update faraday,ftrtc010.yaml reference

[Mauro Carvalho Chehab]

Changeset 8df65d4adca6 ("dt-bindings: convert rtc/faraday,ftrtc01 to yaml")
renamed: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
to: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml.

Update its cross-reference accordingly.

Fixes: 8df65d4adca6 ("dt-bindings: convert rtc/faraday,ftrtc01 to yaml")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fb898af23d0a..d1721a65d79b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1888,7 +1888,7 @@ T:	git git://github.com/ulli-kroll/linux.git
 F:	Documentation/devicetree/bindings/arm/gemini.txt
 F:	Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt
 F:	Documentation/devicetree/bindings/pinctrl/cortina,gemini-pinctrl.txt
-F:	Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
+F:	Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
 F:	arch/arm/boot/dts/gemini*
 F:	arch/arm/mach-gemini/
 F:	drivers/crypto/gemini/
-- 
2.31.1

Re: [PATCH v3 06/23] MAINTAINERS: update faraday,ftrtc010.yaml reference

[Linus Walleij]

On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:

> Changeset 8df65d4adca6 ("dt-bindings: convert rtc/faraday,ftrtc01 to yaml")
> renamed: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
> to: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: 8df65d4adca6 ("dt-bindings: convert rtc/faraday,ftrtc01 to yaml")
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

[PATCH v3 07/23] MAINTAINERS: update ti,sci.yaml reference

[Mauro Carvalho Chehab]

Changeset 5a9652f6994e ("dt-bindings: arm: keystone: Convert ti,sci to json schema")
renamed: Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
to: Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml.

Update its cross-reference accordingly.

Fixes: 5a9652f6994e ("dt-bindings: arm: keystone: Convert ti,sci to json schema")
Reviewed-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d1721a65d79b..5459f6ec8c10 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18744,7 +18744,7 @@ M:	Santosh Shilimkar <ssantosh@kernel.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/keystone/ti,k3-sci-common.yaml
-F:	Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
+F:	Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
 F:	Documentation/devicetree/bindings/clock/ti,sci-clk.yaml
 F:	Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
 F:	Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml
-- 
2.31.1

[PATCH v3 08/23] MAINTAINERS: update intel,ixp46x-rng.yaml reference

[Mauro Carvalho Chehab]

The file name: Documentation/devicetree/bindings/display/intel,ixp46x-rng.yaml
should be, instead: Documentation/devicetree/bindings/rng/intel,ixp46x-rng.yaml.

Update its cross-reference accordingly.

Fixes: cca061b04c0d ("hw_random: ixp4xx: Add DT bindings")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5459f6ec8c10..843cb9779f4f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9608,7 +9608,7 @@ F:	include/linux/soc/ixp4xx/qmgr.h
 INTEL IXP4XX RANDOM NUMBER GENERATOR SUPPORT
 M:	Deepak Saxena <dsaxena@plexity.net>
 S:	Maintained
-F:	Documentation/devicetree/bindings/display/intel,ixp46x-rng.yaml
+F:	Documentation/devicetree/bindings/rng/intel,ixp46x-rng.yaml
 F:	drivers/char/hw_random/ixp4xx-rng.c
 
 INTEL KEEM BAY DRM DRIVER
-- 
2.31.1

Re: [PATCH v3 08/23] MAINTAINERS: update intel,ixp46x-rng.yaml reference

[Linus Walleij]

On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:

> The file name: Documentation/devicetree/bindings/display/intel,ixp46x-rng.yaml
> should be, instead: Documentation/devicetree/bindings/rng/intel,ixp46x-rng.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: cca061b04c0d ("hw_random: ixp4xx: Add DT bindings")
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

It'd be great if Rob or you can apply this patch, I have sent my ixp4xx
patches upstream already.

Yours,
Linus Walleij

[PATCH v3 09/23] MAINTAINERS: update nxp,imx8-jpeg.yaml reference

[Mauro Carvalho Chehab]

The file name: Documentation/devicetree/bindings/media/imx8-jpeg.yaml
should be, instead: Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml.

Update its cross-reference accordingly.

Fixes: be157db0a3d8 ("media: Add maintainer for IMX jpeg v4l2 driver")
Fixes: b16ed1e66008 ("media: dt-bindings: Add bindings for i.MX8QXP/QM JPEG driver")
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 843cb9779f4f..33147a1495f5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13702,7 +13702,7 @@ M:	Mirela Rabulea <mirela.rabulea@nxp.com>
 R:	NXP Linux Team <linux-imx@nxp.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
-F:	Documentation/devicetree/bindings/media/imx8-jpeg.yaml
+F:	Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
 F:	drivers/media/platform/imx-jpeg
 
 NZXT-KRAKEN2 HARDWARE MONITORING DRIVER
-- 
2.31.1

[PATCH v3 10/23] MAINTAINERS: update gemini.yaml reference

[Mauro Carvalho Chehab]

Changeset 7da6ebf5f5a5 ("dt-bindings: arm: Convert Gemini boards to YAML")
renamed: Documentation/devicetree/bindings/arm/gemini.txt
to: Documentation/devicetree/bindings/arm/gemini.yaml.

Update its cross-reference accordingly.

Fixes: 7da6ebf5f5a5 ("dt-bindings: arm: Convert Gemini boards to YAML")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 33147a1495f5..74428ad1a74d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1885,7 +1885,7 @@ M:	Linus Walleij <linus.walleij@linaro.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 T:	git git://github.com/ulli-kroll/linux.git
-F:	Documentation/devicetree/bindings/arm/gemini.txt
+F:	Documentation/devicetree/bindings/arm/gemini.yaml
 F:	Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt
 F:	Documentation/devicetree/bindings/pinctrl/cortina,gemini-pinctrl.txt
 F:	Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
-- 
2.31.1

Re: [PATCH v3 10/23] MAINTAINERS: update gemini.yaml reference

[Linus Walleij]

On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:

> Changeset 7da6ebf5f5a5 ("dt-bindings: arm: Convert Gemini boards to YAML")
> renamed: Documentation/devicetree/bindings/arm/gemini.txt
> to: Documentation/devicetree/bindings/arm/gemini.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: 7da6ebf5f5a5 ("dt-bindings: arm: Convert Gemini boards to YAML")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

It'd be great if Rob or you can apply this patch, I have sent my Gemini
patches upstream already.

Yours,
Linus Walleij

[PATCH v3 11/23] MAINTAINERS: update brcm,unimac-mdio.yaml reference

[Mauro Carvalho Chehab]

Changeset 5d1c5594b646 ("dt-bindings: net: brcm,unimac-mdio: convert to the json-schema")
renamed: Documentation/devicetree/bindings/net/brcm,unimac-mdio.txt
to: Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml.

Update its cross-reference accordingly.

Fixes: 5d1c5594b646 ("dt-bindings: net: brcm,unimac-mdio: convert to the json-schema")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 74428ad1a74d..66c6c27d2209 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3783,7 +3783,7 @@ L:	bcm-kernel-feedback-list@broadcom.com
 L:	netdev@vger.kernel.org
 S:	Supported
 F:	Documentation/devicetree/bindings/net/brcm,bcmgenet.txt
-F:	Documentation/devicetree/bindings/net/brcm,unimac-mdio.txt
+F:	Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
 F:	drivers/net/ethernet/broadcom/genet/
 F:	drivers/net/ethernet/broadcom/unimac.h
 F:	drivers/net/mdio/mdio-bcm-unimac.c
-- 
2.31.1

Re: [PATCH v3 11/23] MAINTAINERS: update brcm,unimac-mdio.yaml reference

[Florian Fainelli]

On 10/19/21 1:04 AM, Mauro Carvalho Chehab wrote:
> Changeset 5d1c5594b646 ("dt-bindings: net: brcm,unimac-mdio: convert to the json-schema")
> renamed: Documentation/devicetree/bindings/net/brcm,unimac-mdio.txt
> to: Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml.
> 
> Update its cross-reference accordingly.
> 
> Fixes: 5d1c5594b646 ("dt-bindings: net: brcm,unimac-mdio: convert to the json-schema")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!
-- 
Florian

[PATCH v3 12/23] MAINTAINERS: update mtd-physmap.yaml reference

[Mauro Carvalho Chehab]

Changeset 63f8e9e0ac65 ("dt-bindings: mtd: Convert mtd-physmap to DT schema")
renamed: Documentation/devicetree/bindings/mtd/arm-versatile.txt
    and: Documentation/devicetree/bindings/mtd/cypress,hyperflash.txt
to: Documentation/devicetree/bindings/mtd/mtd-physmap.yaml.

Update their cross-references accordingly.

Fixes: 63f8e9e0ac65 ("dt-bindings: mtd: Convert mtd-physmap to DT schema")
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 66c6c27d2209..d74b08c4fb1f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1421,7 +1421,7 @@ F:	Documentation/devicetree/bindings/auxdisplay/arm,versatile-lcd.yaml
 F:	Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
 F:	Documentation/devicetree/bindings/i2c/i2c-versatile.txt
 F:	Documentation/devicetree/bindings/interrupt-controller/arm,versatile-fpga-irq.txt
-F:	Documentation/devicetree/bindings/mtd/arm-versatile.txt
+F:	Documentation/devicetree/bindings/mtd/mtd-physmap.yaml
 F:	arch/arm/boot/dts/arm-realview-*
 F:	arch/arm/boot/dts/integrator*
 F:	arch/arm/boot/dts/versatile*
-- 
2.31.1

Re: [PATCH v3 12/23] MAINTAINERS: update mtd-physmap.yaml reference

[Linus Walleij]

On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:

> Changeset 63f8e9e0ac65 ("dt-bindings: mtd: Convert mtd-physmap to DT schema")
> renamed: Documentation/devicetree/bindings/mtd/arm-versatile.txt
>     and: Documentation/devicetree/bindings/mtd/cypress,hyperflash.txt
> to: Documentation/devicetree/bindings/mtd/mtd-physmap.yaml.
>
> Update their cross-references accordingly.
>
> Fixes: 63f8e9e0ac65 ("dt-bindings: mtd: Convert mtd-physmap to DT schema")
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

[PATCH v3 13/23] Documentation: update vcpu-requests.rst reference

[Mauro Carvalho Chehab]

Changeset 2f5947dfcaec ("Documentation: move Documentation/virtual to Documentation/virt")
renamed: Documentation/virtual/kvm/vcpu-requests.rst
to: Documentation/virt/kvm/vcpu-requests.rst.

Update its cross-reference accordingly.

Fixes: 2f5947dfcaec ("Documentation: move Documentation/virtual to Documentation/virt")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 arch/riscv/kvm/vcpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c
index c44cabce7dd8..260ce0779a32 100644
--- a/arch/riscv/kvm/vcpu.c
+++ b/arch/riscv/kvm/vcpu.c
@@ -912,7 +912,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu)
 		 * Ensure we set mode to IN_GUEST_MODE after we disable
 		 * interrupts and before the final VCPU requests check.
 		 * See the comment in kvm_vcpu_exiting_guest_mode() and
-		 * Documentation/virtual/kvm/vcpu-requests.rst
+		 * Documentation/virt/kvm/vcpu-requests.rst
 		 */
 		vcpu->mode = IN_GUEST_MODE;
 
-- 
2.31.1

[PATCH v3 13/23] Documentation: update vcpu-requests.rst reference

[Mauro Carvalho Chehab]

Changeset 2f5947dfcaec ("Documentation: move Documentation/virtual to Documentation/virt")
renamed: Documentation/virtual/kvm/vcpu-requests.rst
to: Documentation/virt/kvm/vcpu-requests.rst.

Update its cross-reference accordingly.

Fixes: 2f5947dfcaec ("Documentation: move Documentation/virtual to Documentation/virt")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 arch/riscv/kvm/vcpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c
index c44cabce7dd8..260ce0779a32 100644
--- a/arch/riscv/kvm/vcpu.c
+++ b/arch/riscv/kvm/vcpu.c
@@ -912,7 +912,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu)
 		 * Ensure we set mode to IN_GUEST_MODE after we disable
 		 * interrupts and before the final VCPU requests check.
 		 * See the comment in kvm_vcpu_exiting_guest_mode() and
-		 * Documentation/virtual/kvm/vcpu-requests.rst
+		 * Documentation/virt/kvm/vcpu-requests.rst
 		 */
 		vcpu->mode = IN_GUEST_MODE;
 
-- 
2.31.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v3 13/23] Documentation: update vcpu-requests.rst reference

[Anup Patel]

On Tue, Oct 19, 2021 at 1:34 PM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> Changeset 2f5947dfcaec ("Documentation: move Documentation/virtual to Documentation/virt")
> renamed: Documentation/virtual/kvm/vcpu-requests.rst
> to: Documentation/virt/kvm/vcpu-requests.rst.
>
> Update its cross-reference accordingly.
>
> Fixes: 2f5947dfcaec ("Documentation: move Documentation/virtual to Documentation/virt")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---

Looks good to me.

Reviewed-by: Anup Patel <anup.patel@wdc.com>

Regards,
Anup

>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
>
>  arch/riscv/kvm/vcpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c
> index c44cabce7dd8..260ce0779a32 100644
> --- a/arch/riscv/kvm/vcpu.c
> +++ b/arch/riscv/kvm/vcpu.c
> @@ -912,7 +912,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu)
>                  * Ensure we set mode to IN_GUEST_MODE after we disable
>                  * interrupts and before the final VCPU requests check.
>                  * See the comment in kvm_vcpu_exiting_guest_mode() and
> -                * Documentation/virtual/kvm/vcpu-requests.rst
> +                * Documentation/virt/kvm/vcpu-requests.rst
>                  */
>                 vcpu->mode = IN_GUEST_MODE;
>
> --
> 2.31.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v3 13/23] Documentation: update vcpu-requests.rst reference

[Anup Patel]

On Tue, Oct 19, 2021 at 1:34 PM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> Changeset 2f5947dfcaec ("Documentation: move Documentation/virtual to Documentation/virt")
> renamed: Documentation/virtual/kvm/vcpu-requests.rst
> to: Documentation/virt/kvm/vcpu-requests.rst.
>
> Update its cross-reference accordingly.
>
> Fixes: 2f5947dfcaec ("Documentation: move Documentation/virtual to Documentation/virt")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---

Looks good to me.

Reviewed-by: Anup Patel <anup.patel@wdc.com>

Regards,
Anup

>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
>
>  arch/riscv/kvm/vcpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c
> index c44cabce7dd8..260ce0779a32 100644
> --- a/arch/riscv/kvm/vcpu.c
> +++ b/arch/riscv/kvm/vcpu.c
> @@ -912,7 +912,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu)
>                  * Ensure we set mode to IN_GUEST_MODE after we disable
>                  * interrupts and before the final VCPU requests check.
>                  * See the comment in kvm_vcpu_exiting_guest_mode() and
> -                * Documentation/virtual/kvm/vcpu-requests.rst
> +                * Documentation/virt/kvm/vcpu-requests.rst
>                  */
>                 vcpu->mode = IN_GUEST_MODE;
>
> --
> 2.31.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

[Mauro Carvalho Chehab]

The file name: Documentation/bpftool-cgroup.rst
should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.

Update its cross-reference accordingly.

Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
index be54b7335a76..617b8084c440 100755
--- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
+++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
@@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
     """
     An extractor for bpftool-cgroup.rst.
     """
-    filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
+    filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')
 
     def get_attach_types(self):
         return self.get_rst_list('ATTACH_TYPE')
-- 
2.31.1

Re: [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

[Quentin Monnet]

2021-10-19 09:04 UTC+0100 ~ Mauro Carvalho Chehab
<mchehab+huawei@kernel.org>
> The file name: Documentation/bpftool-cgroup.rst
> should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.
> 
> Update its cross-reference accordingly.
> 
> Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
> Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> 
>  tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> index be54b7335a76..617b8084c440 100755
> --- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> +++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> @@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
>      """
>      An extractor for bpftool-cgroup.rst.
>      """
> -    filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
> +    filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')
>  
>      def get_attach_types(self):
>          return self.get_rst_list('ATTACH_TYPE')
> 

No, this change is incorrect. We have discussed it several times before
[0][1]. Please drop this patch.

Quentin

[0]
https://lore.kernel.org/bpf/eb80e8f5-b9d7-5031-8ebb-4595bb295dbf@isovalent.com/
[1]
https://lore.kernel.org/bpf/CAEf4BzZhr+3JzuPvyTozQSts7QixnyY1N8CD+-ZuteHodCpmRA@mail.gmail.com/

Re: [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

[Alexei Starovoitov]

On Tue, Oct 19, 2021 at 2:35 AM Quentin Monnet <quentin@isovalent.com> wrote:
>
> 2021-10-19 09:04 UTC+0100 ~ Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org>
> > The file name: Documentation/bpftool-cgroup.rst
> > should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.
> >
> > Update its cross-reference accordingly.
> >
> > Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
> > Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > ---
> >
> > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> >
> >  tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > index be54b7335a76..617b8084c440 100755
> > --- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > +++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > @@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
> >      """
> >      An extractor for bpftool-cgroup.rst.
> >      """
> > -    filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
> > +    filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')
> >
> >      def get_attach_types(self):
> >          return self.get_rst_list('ATTACH_TYPE')
> >
>
> No, this change is incorrect. We have discussed it several times before
> [0][1]. Please drop this patch.

+1

Re: [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

[Mauro Carvalho Chehab]

Em Tue, 19 Oct 2021 15:31:38 -0700
Alexei Starovoitov <alexei.starovoitov@gmail.com> escreveu:

> On Tue, Oct 19, 2021 at 2:35 AM Quentin Monnet <quentin@isovalent.com> wrote:
> >
> > 2021-10-19 09:04 UTC+0100 ~ Mauro Carvalho Chehab
> > <mchehab+huawei@kernel.org>  
> > > The file name: Documentation/bpftool-cgroup.rst
> > > should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.
> > >
> > > Update its cross-reference accordingly.
> > >
> > > Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
> > > Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > ---
> > >
> > > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > > See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> > >
> > >  tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > > index be54b7335a76..617b8084c440 100755
> > > --- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > > +++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > > @@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
> > >      """
> > >      An extractor for bpftool-cgroup.rst.
> > >      """
> > > -    filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
> > > +    filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')
> > >
> > >      def get_attach_types(self):
> > >          return self.get_rst_list('ATTACH_TYPE')
> > >  
> >
> > No, this change is incorrect. We have discussed it several times before
> > [0][1]. Please drop this patch.  
> 
> +1

Sorry, left-over. I dropped two other patches, but forgot to also drop
this one.

Regards,
Mauro

[PATCH v3 15/23] docs: translations: zn_CN: irq-affinity.rst: add a missing extension

[Mauro Carvalho Chehab]

Without .rst extension, ./scripts/documentation-file-ref-check will produce
a warning, and auto-generating cross-references by automarkup.py may not
work.

Fixes: 8137a49e1567 ("docs/zh_CN: Modify the translator tag and fix the wrong word")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst b/Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst
index 7addd5f27a88..36b085226d0b 100644
--- a/Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst
+++ b/Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst
@@ -1,6 +1,6 @@
 .. include:: ../../disclaimer-zh_CN.rst
 
-:Original: Documentation/core-api/irq/irq-affinity
+:Original: Documentation/core-api/irq/irq-affinity.rst
 
 :翻译:
 
-- 
2.31.1

Re: [PATCH v3 15/23] docs: translations: zn_CN: irq-affinity.rst: add a missing extension

[Jonathan Corbet]

Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:

> Without .rst extension, ./scripts/documentation-file-ref-check will produce
> a warning, and auto-generating cross-references by automarkup.py may not
> work.
>
> Fixes: 8137a49e1567 ("docs/zh_CN: Modify the translator tag and fix the wrong word")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
>
>  Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst b/Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst
> index 7addd5f27a88..36b085226d0b 100644
> --- a/Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst
> +++ b/Documentation/translations/zh_CN/core-api/irq/irq-affinity.rst
> @@ -1,6 +1,6 @@
>  .. include:: ../../disclaimer-zh_CN.rst
>  
> -:Original: Documentation/core-api/irq/irq-affinity
> +:Original: Documentation/core-api/irq/irq-affinity.rst

Applied, thanks.

jon

[PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

[Mauro Carvalho Chehab]

memory_hotplug.rst -> memory-hotplug.rst

Fixes: 620127548a69 ("docs/zh_CN: add core api memory_hotplug translation")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 Documentation/translations/zh_CN/core-api/memory-hotplug.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/core-api/memory-hotplug.rst b/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
index 9a204eb196f2..9b2841fb9a5f 100644
--- a/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
+++ b/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
@@ -1,6 +1,6 @@
 .. include:: ../disclaimer-zh_CN.rst
 
-:Original: Documentation/core-api/memory_hotplug.rst
+:Original: Documentation/core-api/memory-hotplug.rst
 
 :翻译:
 
-- 
2.31.1

Re: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

[Jonathan Corbet]

Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:

> memory_hotplug.rst -> memory-hotplug.rst

Why do I feel we've been switching this around forever...?

> Fixes: 620127548a69 ("docs/zh_CN: add core api memory_hotplug translation")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
>
>  Documentation/translations/zh_CN/core-api/memory-hotplug.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/core-api/memory-hotplug.rst b/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
> index 9a204eb196f2..9b2841fb9a5f 100644
> --- a/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
> +++ b/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
> @@ -1,6 +1,6 @@
>  .. include:: ../disclaimer-zh_CN.rst
>  
> -:Original: Documentation/core-api/memory_hotplug.rst
> +:Original: Documentation/core-api/memory-hotplug.rst
>  
>  :翻译:

Applied, thanks.

jon

Re: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

[Alex Shi]

On Wed, Oct 20, 2021 at 3:08 PM David Hildenbrand <david@redhat.com> wrote:
>
> Dumb question that probably has been asked a couple of times already:
> why do we even maintain a translated doc in-tree?
>
> Every time I do an update on the original doc, I for sure can only guess
> which translated parts need updating. And I really can only update when
> "deleting", not when rewording/adding. So we'll be left with stale doc
> that will have to be updated manually by $whoever.

cc to the translation maintainers and translator would be helpful?

> I don't feel very
> confident about this. No translated doc is better than outdated
> translated doc.

Uh, I don't know other languages, but in Chinese, 15 years before
translated books are still selling well in China. :)
https://item.jd.com/1075130482.html  ->  Linux device driver
https://item.jd.com/10100237.html  -> Understanding linux kernel

Thanks
Alex

>
> This feels like something that should be maintained out of tree. My 2 cents.
>
> --
> Thanks,
>
> David / dhildenb
>

Re: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

[teng sterling]

Alex Shi <seakeel@gmail.com> 于2021年11月1日周一 下午3:48写道：
>
> On Wed, Oct 20, 2021 at 3:08 PM David Hildenbrand <david@redhat.com> wrote:
> >
> > Dumb question that probably has been asked a couple of times already:
> > why do we even maintain a translated doc in-tree?
> >
> > Every time I do an update on the original doc, I for sure can only guess
> > which translated parts need updating. And I really can only update when
Dear David

Thank you very much for your contribution, in fact, we are always updating the
translations and improving the speed of the sync, so If you are not
good at Chinese
and want to get the sync faster, please CC us when you send the patch.

> > "deleting", not when rewording/adding. So we'll be left with stale doc
> > that will have to be updated manually by $whoever.
>
> cc to the translation maintainers and translator would be helpful?
Alex,Maybe we should provide a translation guide in English, e.g::

  Dear developers, if you have trouble updating the Chinese documentation after
  updating the original documentation, please CC the translator of
that documentation
  and the maintainer of the Chinese documentation, and the relevant
documentation
  will be updated soon.

>
> > I don't feel very
> > confident about this. No translated doc is better than outdated
> > translated doc.
>
> Uh, I don't know other languages, but in Chinese, 15 years before
> translated books are still selling well in China. :)
> https://item.jd.com/1075130482.html  ->  Linux device driver
> https://item.jd.com/10100237.html  -> Understanding linux kernel
Yes, I just bought a LDD3 last week.! >_<


Thanks,
Yanteng

Re: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

[David Hildenbrand]

On 01.11.21 14:38, teng sterling wrote:
> Alex Shi <seakeel@gmail.com> 于2021年11月1日周一 下午3:48写道：
>>
>> On Wed, Oct 20, 2021 at 3:08 PM David Hildenbrand <david@redhat.com> wrote:
>>>
>>> Dumb question that probably has been asked a couple of times already:
>>> why do we even maintain a translated doc in-tree?
>>>
>>> Every time I do an update on the original doc, I for sure can only guess
>>> which translated parts need updating. And I really can only update when
> Dear David
> 
> Thank you very much for your contribution, in fact, we are always updating the
> translations and improving the speed of the sync, so If you are not
> good at Chinese
> and want to get the sync faster, please CC us when you send the patch.
> 

It would be great if we would get this suggestion automatically, e.g.,
via get_maintainers.pl --- maybe that's already done, I didn't check.

Personally, I don't speak/read any Chinese, so I'm mostly lost staring
at the Chinese translation. :)


>>> "deleting", not when rewording/adding. So we'll be left with stale doc
>>> that will have to be updated manually by $whoever.
>>
>> cc to the translation maintainers and translator would be helpful?
> Alex,Maybe we should provide a translation guide in English, e.g::
> 
>   Dear developers, if you have trouble updating the Chinese documentation after
>   updating the original documentation, please CC the translator of
> that documentation
>   and the maintainer of the Chinese documentation, and the relevant
> documentation
>   will be updated soon.
> 
>>
>>> I don't feel very
>>> confident about this. No translated doc is better than outdated
>>> translated doc.
>>
>> Uh, I don't know other languages, but in Chinese, 15 years before
>> translated books are still selling well in China. :)
>> https://item.jd.com/1075130482.html  ->  Linux device driver
>> https://item.jd.com/10100237.html  -> Understanding linux kernel
> Yes, I just bought a LDD3 last week.! >_<

Yes, these books in particular are still of a lot of value, although
outdated. :)

The difference is that when you translate a book, there is a
date/version attached, meaning, the original book was for example based
on kernel v2.XXX. Once you translate the book, it's simply based on the
same kernel version.

The in-tree doc is similar. You can access the v5.14 doc for example
easily via https://www.kernel.org/doc/html/v5.14/. And the Chinese
version via https://www.kernel.org/doc/html/v5.14/translations/zh_CN/.

If I as a developer perform a doc update in v5.14, and the translation
isn't updated until the end of the same release, the versioned
documentation will be out of sync. And that happens automatically with a
new release.

With an out-of-tree translation, there wouldn't really be an issue. Once
everything was translated (brought up-to-date), you would mark it has
"fully translated doc of v5.15" manually and release it.

But maybe the translation maintainers already take proper care of
updating any translation just before the new kernel is released.

So just my comment after stumbling over in-tree doc translations.

-- 
Thanks,

David / dhildenb

[PATCH v3 17/23] docs: fs: locks.rst: update comment about mandatory file locking

[Mauro Carvalho Chehab]

The mandatory file locking got removed due to its problems, but
the fs locks documentation still points to it.

Update the text there, informing that it was removed on Kernel
5.14.

Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 Documentation/filesystems/locks.rst | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/Documentation/filesystems/locks.rst b/Documentation/filesystems/locks.rst
index c5ae858b1aac..26429317dbbc 100644
--- a/Documentation/filesystems/locks.rst
+++ b/Documentation/filesystems/locks.rst
@@ -57,16 +57,9 @@ fcntl(), with all the problems that implies.
 1.3 Mandatory Locking As A Mount Option
 ---------------------------------------
 
-Mandatory locking, as described in
-'Documentation/filesystems/mandatory-locking.rst' was prior to this release a
-general configuration option that was valid for all mounted filesystems.  This
-had a number of inherent dangers, not the least of which was the ability to
-freeze an NFS server by asking it to read a file for which a mandatory lock
-existed.
-
-From this release of the kernel, mandatory locking can be turned on and off
-on a per-filesystem basis, using the mount options 'mand' and 'nomand'.
-The default is to disallow mandatory locking. The intention is that
-mandatory locking only be enabled on a local filesystem as the specific need
-arises.
+Mandatory locking was prior to this release a general configuration option
+that was valid for all mounted filesystems.  This had a number of inherent
+dangers, not the least of which was the ability to freeze an NFS server by
+asking it to read a file for which a mandatory lock existed.
 
+Such option was dropped in Kernel v5.14.
-- 
2.31.1

Re: [PATCH v3 17/23] docs: fs: locks.rst: update comment about mandatory file locking

[Jeff Layton]

On Tue, 2021-10-19 at 09:04 +0100, Mauro Carvalho Chehab wrote:
> The mandatory file locking got removed due to its problems, but
> the fs locks documentation still points to it.
> 
> Update the text there, informing that it was removed on Kernel
> 5.14.
> 
> Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> 
>  Documentation/filesystems/locks.rst | 17 +++++------------
>  1 file changed, 5 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/filesystems/locks.rst b/Documentation/filesystems/locks.rst
> index c5ae858b1aac..26429317dbbc 100644
> --- a/Documentation/filesystems/locks.rst
> +++ b/Documentation/filesystems/locks.rst
> @@ -57,16 +57,9 @@ fcntl(), with all the problems that implies.
>  1.3 Mandatory Locking As A Mount Option
>  ---------------------------------------
>  
> -Mandatory locking, as described in
> -'Documentation/filesystems/mandatory-locking.rst' was prior to this release a
> -general configuration option that was valid for all mounted filesystems.  This
> -had a number of inherent dangers, not the least of which was the ability to
> -freeze an NFS server by asking it to read a file for which a mandatory lock
> -existed.
> -
> -From this release of the kernel, mandatory locking can be turned on and off
> -on a per-filesystem basis, using the mount options 'mand' and 'nomand'.
> -The default is to disallow mandatory locking. The intention is that
> -mandatory locking only be enabled on a local filesystem as the specific need
> -arises.
> +Mandatory locking was prior to this release a general configuration option
> +that was valid for all mounted filesystems.  This had a number of inherent
> +dangers, not the least of which was the ability to freeze an NFS server by
> +asking it to read a file for which a mandatory lock existed.
>  
> +Such option was dropped in Kernel v5.14.

Looks good. I'll plan to pick this up and (add a Reported-by for Jon,
who noted this a few days ago).

-- 
Jeff Layton <jlayton@kernel.org>

[PATCH v3 18/23] fs: remove a comment pointing to the removed mandatory-locking file

[Mauro Carvalho Chehab]

The mandatory file locking got removed due to its problems, but
there's still a comment inside fs/locks.c pointing to the removed
doc.

Remove it.

Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 fs/locks.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/locks.c b/fs/locks.c
index d397394633be..94feadcdab4e 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -61,7 +61,6 @@
  *
  *  Initial implementation of mandatory locks. SunOS turned out to be
  *  a rotten model, so I implemented the "obvious" semantics.
- *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
  *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
  *
  *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
-- 
2.31.1

Re: [PATCH v3 18/23] fs: remove a comment pointing to the removed mandatory-locking file

[Jeff Layton]

On Tue, 2021-10-19 at 09:04 +0100, Mauro Carvalho Chehab wrote:
> The mandatory file locking got removed due to its problems, but
> there's still a comment inside fs/locks.c pointing to the removed
> doc.
> 
> Remove it.
> 
> Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> 
>  fs/locks.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/locks.c b/fs/locks.c
> index d397394633be..94feadcdab4e 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -61,7 +61,6 @@
>   *
>   *  Initial implementation of mandatory locks. SunOS turned out to be
>   *  a rotten model, so I implemented the "obvious" semantics.
> - *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
>   *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
>   *
>   *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to

Thanks Mauro. I'll pick this into my locks branch, so it should make
v5.16 as well.
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH v3 18/23] fs: remove a comment pointing to the removed mandatory-locking file

[J. Bruce Fields]

On Tue, Oct 19, 2021 at 06:50:21AM -0400, Jeff Layton wrote:
> On Tue, 2021-10-19 at 09:04 +0100, Mauro Carvalho Chehab wrote:
> > The mandatory file locking got removed due to its problems, but
> > there's still a comment inside fs/locks.c pointing to the removed
> > doc.
> > 
> > Remove it.
> > 
> > Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > ---
> > 
> > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> > 
> >  fs/locks.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/fs/locks.c b/fs/locks.c
> > index d397394633be..94feadcdab4e 100644
> > --- a/fs/locks.c
> > +++ b/fs/locks.c
> > @@ -61,7 +61,6 @@
> >   *
> >   *  Initial implementation of mandatory locks. SunOS turned out to be
> >   *  a rotten model, so I implemented the "obvious" semantics.
> > - *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
> >   *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
> >   *
> >   *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
> 
> Thanks Mauro. I'll pick this into my locks branch, so it should make
> v5.16 as well.

Could we delete the rest too?

We don't do those changelog-style comments any more; they're in the git
history if you need them.  I can sort of get leaving some in out of
respect or if they've still provide some useful information.  But
keeping comments referring to code that doesn't even exist any more just
seems confusing.

--b.

diff --git a/fs/locks.c b/fs/locks.c
index 3d6fb4ae847b..2540b7aedeac 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -59,17 +59,6 @@
  *  once we've checked for blocking and deadlocking.
  *  Andy Walker (andy@lysaker.kvaerner.no), April 03, 1996.
  *
- *  Initial implementation of mandatory locks. SunOS turned out to be
- *  a rotten model, so I implemented the "obvious" semantics.
- *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
- *
- *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
- *  check if a file has mandatory locks, used by mmap(), open() and creat() to
- *  see if system call should be rejected. Ref. HP-UX/SunOS/Solaris Reference
- *  Manual, Section 2.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 09, 1996.
- *
  *  Tidied up block list handling. Added '/proc/locks' interface.
  *  Andy Walker (andy@lysaker.kvaerner.no), April 24, 1996.
  *
@@ -95,10 +84,6 @@
  *  Made the block list a circular list to minimise searching in the list.
  *  Andy Walker (andy@lysaker.kvaerner.no), Sep 25, 1996.
  *
- *  Made mandatory locking a mount option. Default is not to allow mandatory
- *  locking.
- *  Andy Walker (andy@lysaker.kvaerner.no), Oct 04, 1996.
- *
  *  Some adaptations for NFS support.
  *  Olaf Kirch (okir@monad.swb.de), Dec 1996,
  *

Re: [PATCH v3 18/23] fs: remove a comment pointing to the removed mandatory-locking file

[Jeff Layton]

On Tue, 2021-10-19 at 10:14 -0400, J. Bruce Fields wrote:
> On Tue, Oct 19, 2021 at 06:50:21AM -0400, Jeff Layton wrote:
> > On Tue, 2021-10-19 at 09:04 +0100, Mauro Carvalho Chehab wrote:
> > > The mandatory file locking got removed due to its problems, but
> > > there's still a comment inside fs/locks.c pointing to the removed
> > > doc.
> > > 
> > > Remove it.
> > > 
> > > Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > ---
> > > 
> > > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > > See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> > > 
> > >  fs/locks.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/fs/locks.c b/fs/locks.c
> > > index d397394633be..94feadcdab4e 100644
> > > --- a/fs/locks.c
> > > +++ b/fs/locks.c
> > > @@ -61,7 +61,6 @@
> > >   *
> > >   *  Initial implementation of mandatory locks. SunOS turned out to be
> > >   *  a rotten model, so I implemented the "obvious" semantics.
> > > - *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
> > >   *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
> > >   *
> > >   *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
> > 
> > Thanks Mauro. I'll pick this into my locks branch, so it should make
> > v5.16 as well.
> 
> Could we delete the rest too?
> 
> We don't do those changelog-style comments any more; they're in the git
> history if you need them.  I can sort of get leaving some in out of
> respect or if they've still provide some useful information.  But
> keeping comments referring to code that doesn't even exist any more just
> seems confusing.
> 
> --b.
> 
> diff --git a/fs/locks.c b/fs/locks.c
> index 3d6fb4ae847b..2540b7aedeac 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -59,17 +59,6 @@
>   *  once we've checked for blocking and deadlocking.
>   *  Andy Walker (andy@lysaker.kvaerner.no), April 03, 1996.
>   *
> - *  Initial implementation of mandatory locks. SunOS turned out to be
> - *  a rotten model, so I implemented the "obvious" semantics.
> - *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
> - *
> - *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
> - *  check if a file has mandatory locks, used by mmap(), open() and creat() to
> - *  see if system call should be rejected. Ref. HP-UX/SunOS/Solaris Reference
> - *  Manual, Section 2.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 09, 1996.
> - *
>   *  Tidied up block list handling. Added '/proc/locks' interface.
>   *  Andy Walker (andy@lysaker.kvaerner.no), April 24, 1996.
>   *
> @@ -95,10 +84,6 @@
>   *  Made the block list a circular list to minimise searching in the list.
>   *  Andy Walker (andy@lysaker.kvaerner.no), Sep 25, 1996.
>   *
> - *  Made mandatory locking a mount option. Default is not to allow mandatory
> - *  locking.
> - *  Andy Walker (andy@lysaker.kvaerner.no), Oct 04, 1996.
> - *
>   *  Some adaptations for NFS support.
>   *  Olaf Kirch (okir@monad.swb.de), Dec 1996,
>   *

IDK...Do we want to "erase history" selectively like that?

Maybe we should just get rid of the whole pile of "changelog" comments
in fs/locks.c? They aren't terribly useful these days anyhow.

-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH v3 18/23] fs: remove a comment pointing to the removed mandatory-locking file

[J. Bruce Fields]

On Tue, Oct 19, 2021 at 11:46:51AM -0400, Jeff Layton wrote:
> IDK...Do we want to "erase history" selectively like that?

Seems like pretty spotty history anyway, so I don't think it's a
problem, but...

> Maybe we should just get rid of the whole pile of "changelog" comments
> in fs/locks.c? They aren't terribly useful these days anyhow.

...  that'd be fine with me.

I didn't mainly because I thought it'd be good to read through it and
see if there's anything that should be salvaged.

Reading through it now:

The last few paragraphs (under "Locking conflicts and dependencies" were
added more recently by Neil and are still useful.

I'd be OK losing the rest.

It might still be good to have some basic introduction; maybe something
like this?:

--b.

diff --git a/fs/locks.c b/fs/locks.c
index 3d6fb4ae847b..b54813eae44f 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2,117 +2,11 @@
 /*
  *  linux/fs/locks.c
  *
- *  Provide support for fcntl()'s F_GETLK, F_SETLK, and F_SETLKW calls.
- *  Doug Evans (dje@spiff.uucp), August 07, 1992
+ * We implement four types of file locks: BSD locks, posix locks, open
+ * file description locks, and leases.  For details about BSD locks,
+ * see the flock(2) man page; for details about the other three, see
+ * fcntl(2).
  *
- *  Deadlock detection added.
- *  FIXME: one thing isn't handled yet:
- *	- mandatory locks (requires lots of changes elsewhere)
- *  Kelly Carmichael (kelly@[142.24.8.65]), September 17, 1994.
- *
- *  Miscellaneous edits, and a total rewrite of posix_lock_file() code.
- *  Kai Petzke (wpp@marie.physik.tu-berlin.de), 1994
- *
- *  Converted file_lock_table to a linked list from an array, which eliminates
- *  the limits on how many active file locks are open.
- *  Chad Page (pageone@netcom.com), November 27, 1994
- *
- *  Removed dependency on file descriptors. dup()'ed file descriptors now
- *  get the same locks as the original file descriptors, and a close() on
- *  any file descriptor removes ALL the locks on the file for the current
- *  process. Since locks still depend on the process id, locks are inherited
- *  after an exec() but not after a fork(). This agrees with POSIX, and both
- *  BSD and SVR4 practice.
- *  Andy Walker (andy@lysaker.kvaerner.no), February 14, 1995
- *
- *  Scrapped free list which is redundant now that we allocate locks
- *  dynamically with kmalloc()/kfree().
- *  Andy Walker (andy@lysaker.kvaerner.no), February 21, 1995
- *
- *  Implemented two lock personalities - FL_FLOCK and FL_POSIX.
- *
- *  FL_POSIX locks are created with calls to fcntl() and lockf() through the
- *  fcntl() system call. They have the semantics described above.
- *
- *  FL_FLOCK locks are created with calls to flock(), through the flock()
- *  system call, which is new. Old C libraries implement flock() via fcntl()
- *  and will continue to use the old, broken implementation.
- *
- *  FL_FLOCK locks follow the 4.4 BSD flock() semantics. They are associated
- *  with a file pointer (filp). As a result they can be shared by a parent
- *  process and its children after a fork(). They are removed when the last
- *  file descriptor referring to the file pointer is closed (unless explicitly
- *  unlocked).
- *
- *  FL_FLOCK locks never deadlock, an existing lock is always removed before
- *  upgrading from shared to exclusive (or vice versa). When this happens
- *  any processes blocked by the current lock are woken up and allowed to
- *  run before the new lock is applied.
- *  Andy Walker (andy@lysaker.kvaerner.no), June 09, 1995
- *
- *  Removed some race conditions in flock_lock_file(), marked other possible
- *  races. Just grep for FIXME to see them.
- *  Dmitry Gorodchanin (pgmdsg@ibi.com), February 09, 1996.
- *
- *  Addressed Dmitry's concerns. Deadlock checking no longer recursive.
- *  Lock allocation changed to GFP_ATOMIC as we can't afford to sleep
- *  once we've checked for blocking and deadlocking.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 03, 1996.
- *
- *  Initial implementation of mandatory locks. SunOS turned out to be
- *  a rotten model, so I implemented the "obvious" semantics.
- *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
- *
- *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
- *  check if a file has mandatory locks, used by mmap(), open() and creat() to
- *  see if system call should be rejected. Ref. HP-UX/SunOS/Solaris Reference
- *  Manual, Section 2.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 09, 1996.
- *
- *  Tidied up block list handling. Added '/proc/locks' interface.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 24, 1996.
- *
- *  Fixed deadlock condition for pathological code that mixes calls to
- *  flock() and fcntl().
- *  Andy Walker (andy@lysaker.kvaerner.no), April 29, 1996.
- *
- *  Allow only one type of locking scheme (FL_POSIX or FL_FLOCK) to be in use
- *  for a given file at a time. Changed the CONFIG_LOCK_MANDATORY scheme to
- *  guarantee sensible behaviour in the case where file system modules might
- *  be compiled with different options than the kernel itself.
- *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
- *
- *  Added a couple of missing wake_up() calls. Thanks to Thomas Meckel
- *  (Thomas.Meckel@mni.fh-giessen.de) for spotting this.
- *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
- *
- *  Changed FL_POSIX locks to use the block list in the same way as FL_FLOCK
- *  locks. Changed process synchronisation to avoid dereferencing locks that
- *  have already been freed.
- *  Andy Walker (andy@lysaker.kvaerner.no), Sep 21, 1996.
- *
- *  Made the block list a circular list to minimise searching in the list.
- *  Andy Walker (andy@lysaker.kvaerner.no), Sep 25, 1996.
- *
- *  Made mandatory locking a mount option. Default is not to allow mandatory
- *  locking.
- *  Andy Walker (andy@lysaker.kvaerner.no), Oct 04, 1996.
- *
- *  Some adaptations for NFS support.
- *  Olaf Kirch (okir@monad.swb.de), Dec 1996,
- *
- *  Fixed /proc/locks interface so that we can't overrun the buffer we are handed.
- *  Andy Walker (andy@lysaker.kvaerner.no), May 12, 1997.
- *
- *  Use slab allocator instead of kmalloc/kfree.
- *  Use generic list implementation from <linux/list.h>.
- *  Sped up posix_locks_deadlock by only considering blocked locks.
- *  Matthew Wilcox <willy@debian.org>, March, 2000.
- *
- *  Leases and LOCK_MAND
- *  Matthew Wilcox <willy@debian.org>, June, 2000.
- *  Stephen Rothwell <sfr@canb.auug.org.au>, June, 2000.
  *
  * Locking conflicts and dependencies:
  * If multiple threads attempt to lock the same byte (or flock the same file)

Re: [PATCH v3 18/23] fs: remove a comment pointing to the removed mandatory-locking file

[Jeff Layton]

On Tue, 2021-10-19 at 12:16 -0400, J. Bruce Fields wrote:
> On Tue, Oct 19, 2021 at 11:46:51AM -0400, Jeff Layton wrote:
> > IDK...Do we want to "erase history" selectively like that?
> 
> Seems like pretty spotty history anyway, so I don't think it's a
> problem, but...
> 
> > Maybe we should just get rid of the whole pile of "changelog" comments
> > in fs/locks.c? They aren't terribly useful these days anyhow.
> 
> ...  that'd be fine with me.
> 
> I didn't mainly because I thought it'd be good to read through it and
> see if there's anything that should be salvaged.
> 
> Reading through it now:
> 
> The last few paragraphs (under "Locking conflicts and dependencies" were
> added more recently by Neil and are still useful.
> 
> I'd be OK losing the rest.
> 
> It might still be good to have some basic introduction; maybe something
> like this?:
> 
> --b.
> 
> diff --git a/fs/locks.c b/fs/locks.c
> index 3d6fb4ae847b..b54813eae44f 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -2,117 +2,11 @@
>  /*
>   *  linux/fs/locks.c
>   *
> - *  Provide support for fcntl()'s F_GETLK, F_SETLK, and F_SETLKW calls.
> - *  Doug Evans (dje@spiff.uucp), August 07, 1992
> + * We implement four types of file locks: BSD locks, posix locks, open
> + * file description locks, and leases.  For details about BSD locks,
> + * see the flock(2) man page; for details about the other three, see
> + * fcntl(2).
>   *
> - *  Deadlock detection added.
> - *  FIXME: one thing isn't handled yet:
> - *	- mandatory locks (requires lots of changes elsewhere)
> - *  Kelly Carmichael (kelly@[142.24.8.65]), September 17, 1994.
> - *
> - *  Miscellaneous edits, and a total rewrite of posix_lock_file() code.
> - *  Kai Petzke (wpp@marie.physik.tu-berlin.de), 1994
> - *
> - *  Converted file_lock_table to a linked list from an array, which eliminates
> - *  the limits on how many active file locks are open.
> - *  Chad Page (pageone@netcom.com), November 27, 1994
> - *
> - *  Removed dependency on file descriptors. dup()'ed file descriptors now
> - *  get the same locks as the original file descriptors, and a close() on
> - *  any file descriptor removes ALL the locks on the file for the current
> - *  process. Since locks still depend on the process id, locks are inherited
> - *  after an exec() but not after a fork(). This agrees with POSIX, and both
> - *  BSD and SVR4 practice.
> - *  Andy Walker (andy@lysaker.kvaerner.no), February 14, 1995
> - *
> - *  Scrapped free list which is redundant now that we allocate locks
> - *  dynamically with kmalloc()/kfree().
> - *  Andy Walker (andy@lysaker.kvaerner.no), February 21, 1995
> - *
> - *  Implemented two lock personalities - FL_FLOCK and FL_POSIX.
> - *
> - *  FL_POSIX locks are created with calls to fcntl() and lockf() through the
> - *  fcntl() system call. They have the semantics described above.
> - *
> - *  FL_FLOCK locks are created with calls to flock(), through the flock()
> - *  system call, which is new. Old C libraries implement flock() via fcntl()
> - *  and will continue to use the old, broken implementation.
> - *
> - *  FL_FLOCK locks follow the 4.4 BSD flock() semantics. They are associated
> - *  with a file pointer (filp). As a result they can be shared by a parent
> - *  process and its children after a fork(). They are removed when the last
> - *  file descriptor referring to the file pointer is closed (unless explicitly
> - *  unlocked).
> - *
> - *  FL_FLOCK locks never deadlock, an existing lock is always removed before
> - *  upgrading from shared to exclusive (or vice versa). When this happens
> - *  any processes blocked by the current lock are woken up and allowed to
> - *  run before the new lock is applied.
> - *  Andy Walker (andy@lysaker.kvaerner.no), June 09, 1995
> - *
> - *  Removed some race conditions in flock_lock_file(), marked other possible
> - *  races. Just grep for FIXME to see them.
> - *  Dmitry Gorodchanin (pgmdsg@ibi.com), February 09, 1996.
> - *
> - *  Addressed Dmitry's concerns. Deadlock checking no longer recursive.
> - *  Lock allocation changed to GFP_ATOMIC as we can't afford to sleep
> - *  once we've checked for blocking and deadlocking.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 03, 1996.
> - *
> - *  Initial implementation of mandatory locks. SunOS turned out to be
> - *  a rotten model, so I implemented the "obvious" semantics.
> - *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
> - *
> - *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
> - *  check if a file has mandatory locks, used by mmap(), open() and creat() to
> - *  see if system call should be rejected. Ref. HP-UX/SunOS/Solaris Reference
> - *  Manual, Section 2.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 09, 1996.
> - *
> - *  Tidied up block list handling. Added '/proc/locks' interface.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 24, 1996.
> - *
> - *  Fixed deadlock condition for pathological code that mixes calls to
> - *  flock() and fcntl().
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 29, 1996.
> - *
> - *  Allow only one type of locking scheme (FL_POSIX or FL_FLOCK) to be in use
> - *  for a given file at a time. Changed the CONFIG_LOCK_MANDATORY scheme to
> - *  guarantee sensible behaviour in the case where file system modules might
> - *  be compiled with different options than the kernel itself.
> - *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
> - *
> - *  Added a couple of missing wake_up() calls. Thanks to Thomas Meckel
> - *  (Thomas.Meckel@mni.fh-giessen.de) for spotting this.
> - *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
> - *
> - *  Changed FL_POSIX locks to use the block list in the same way as FL_FLOCK
> - *  locks. Changed process synchronisation to avoid dereferencing locks that
> - *  have already been freed.
> - *  Andy Walker (andy@lysaker.kvaerner.no), Sep 21, 1996.
> - *
> - *  Made the block list a circular list to minimise searching in the list.
> - *  Andy Walker (andy@lysaker.kvaerner.no), Sep 25, 1996.
> - *
> - *  Made mandatory locking a mount option. Default is not to allow mandatory
> - *  locking.
> - *  Andy Walker (andy@lysaker.kvaerner.no), Oct 04, 1996.
> - *
> - *  Some adaptations for NFS support.
> - *  Olaf Kirch (okir@monad.swb.de), Dec 1996,
> - *
> - *  Fixed /proc/locks interface so that we can't overrun the buffer we are handed.
> - *  Andy Walker (andy@lysaker.kvaerner.no), May 12, 1997.
> - *
> - *  Use slab allocator instead of kmalloc/kfree.
> - *  Use generic list implementation from <linux/list.h>.
> - *  Sped up posix_locks_deadlock by only considering blocked locks.
> - *  Matthew Wilcox <willy@debian.org>, March, 2000.
> - *
> - *  Leases and LOCK_MAND
> - *  Matthew Wilcox <willy@debian.org>, June, 2000.
> - *  Stephen Rothwell <sfr@canb.auug.org.au>, June, 2000.
>   *
>   * Locking conflicts and dependencies:
>   * If multiple threads attempt to lock the same byte (or flock the same file)

Yeah, I think that looks great. Send it with a changelog and I'll pull
it into the branch I have feeding into -next.

Thanks,
-- 
Jeff Layton <jlayton@kernel.org>

[PATCH] locks: remove changelog comments

[J. Bruce Fields]

From: "J. Bruce Fields" <bfields@redhat.com>

This is only of historical interest, and anyone interested in the
history can dig out an old version of locks.c from from git.

Triggered by the observation that it references the now-removed
Documentation/filesystems/mandatory-locking.rst.

Reported-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 fs/locks.c | 114 ++---------------------------------------------------
 1 file changed, 4 insertions(+), 110 deletions(-)

On Tue, Oct 19, 2021 at 12:27:55PM -0400, Jeff Layton wrote:
> Yeah, I think that looks great. Send it with a changelog and I'll pull
> it into the branch I have feeding into -next.

OK!--b.

diff --git a/fs/locks.c b/fs/locks.c
index 3d6fb4ae847b..b54813eae44f 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2,117 +2,11 @@
 /*
  *  linux/fs/locks.c
  *
- *  Provide support for fcntl()'s F_GETLK, F_SETLK, and F_SETLKW calls.
- *  Doug Evans (dje@spiff.uucp), August 07, 1992
+ * We implement four types of file locks: BSD locks, posix locks, open
+ * file description locks, and leases.  For details about BSD locks,
+ * see the flock(2) man page; for details about the other three, see
+ * fcntl(2).
  *
- *  Deadlock detection added.
- *  FIXME: one thing isn't handled yet:
- *	- mandatory locks (requires lots of changes elsewhere)
- *  Kelly Carmichael (kelly@[142.24.8.65]), September 17, 1994.
- *
- *  Miscellaneous edits, and a total rewrite of posix_lock_file() code.
- *  Kai Petzke (wpp@marie.physik.tu-berlin.de), 1994
- *
- *  Converted file_lock_table to a linked list from an array, which eliminates
- *  the limits on how many active file locks are open.
- *  Chad Page (pageone@netcom.com), November 27, 1994
- *
- *  Removed dependency on file descriptors. dup()'ed file descriptors now
- *  get the same locks as the original file descriptors, and a close() on
- *  any file descriptor removes ALL the locks on the file for the current
- *  process. Since locks still depend on the process id, locks are inherited
- *  after an exec() but not after a fork(). This agrees with POSIX, and both
- *  BSD and SVR4 practice.
- *  Andy Walker (andy@lysaker.kvaerner.no), February 14, 1995
- *
- *  Scrapped free list which is redundant now that we allocate locks
- *  dynamically with kmalloc()/kfree().
- *  Andy Walker (andy@lysaker.kvaerner.no), February 21, 1995
- *
- *  Implemented two lock personalities - FL_FLOCK and FL_POSIX.
- *
- *  FL_POSIX locks are created with calls to fcntl() and lockf() through the
- *  fcntl() system call. They have the semantics described above.
- *
- *  FL_FLOCK locks are created with calls to flock(), through the flock()
- *  system call, which is new. Old C libraries implement flock() via fcntl()
- *  and will continue to use the old, broken implementation.
- *
- *  FL_FLOCK locks follow the 4.4 BSD flock() semantics. They are associated
- *  with a file pointer (filp). As a result they can be shared by a parent
- *  process and its children after a fork(). They are removed when the last
- *  file descriptor referring to the file pointer is closed (unless explicitly
- *  unlocked).
- *
- *  FL_FLOCK locks never deadlock, an existing lock is always removed before
- *  upgrading from shared to exclusive (or vice versa). When this happens
- *  any processes blocked by the current lock are woken up and allowed to
- *  run before the new lock is applied.
- *  Andy Walker (andy@lysaker.kvaerner.no), June 09, 1995
- *
- *  Removed some race conditions in flock_lock_file(), marked other possible
- *  races. Just grep for FIXME to see them.
- *  Dmitry Gorodchanin (pgmdsg@ibi.com), February 09, 1996.
- *
- *  Addressed Dmitry's concerns. Deadlock checking no longer recursive.
- *  Lock allocation changed to GFP_ATOMIC as we can't afford to sleep
- *  once we've checked for blocking and deadlocking.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 03, 1996.
- *
- *  Initial implementation of mandatory locks. SunOS turned out to be
- *  a rotten model, so I implemented the "obvious" semantics.
- *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
- *
- *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
- *  check if a file has mandatory locks, used by mmap(), open() and creat() to
- *  see if system call should be rejected. Ref. HP-UX/SunOS/Solaris Reference
- *  Manual, Section 2.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 09, 1996.
- *
- *  Tidied up block list handling. Added '/proc/locks' interface.
- *  Andy Walker (andy@lysaker.kvaerner.no), April 24, 1996.
- *
- *  Fixed deadlock condition for pathological code that mixes calls to
- *  flock() and fcntl().
- *  Andy Walker (andy@lysaker.kvaerner.no), April 29, 1996.
- *
- *  Allow only one type of locking scheme (FL_POSIX or FL_FLOCK) to be in use
- *  for a given file at a time. Changed the CONFIG_LOCK_MANDATORY scheme to
- *  guarantee sensible behaviour in the case where file system modules might
- *  be compiled with different options than the kernel itself.
- *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
- *
- *  Added a couple of missing wake_up() calls. Thanks to Thomas Meckel
- *  (Thomas.Meckel@mni.fh-giessen.de) for spotting this.
- *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
- *
- *  Changed FL_POSIX locks to use the block list in the same way as FL_FLOCK
- *  locks. Changed process synchronisation to avoid dereferencing locks that
- *  have already been freed.
- *  Andy Walker (andy@lysaker.kvaerner.no), Sep 21, 1996.
- *
- *  Made the block list a circular list to minimise searching in the list.
- *  Andy Walker (andy@lysaker.kvaerner.no), Sep 25, 1996.
- *
- *  Made mandatory locking a mount option. Default is not to allow mandatory
- *  locking.
- *  Andy Walker (andy@lysaker.kvaerner.no), Oct 04, 1996.
- *
- *  Some adaptations for NFS support.
- *  Olaf Kirch (okir@monad.swb.de), Dec 1996,
- *
- *  Fixed /proc/locks interface so that we can't overrun the buffer we are handed.
- *  Andy Walker (andy@lysaker.kvaerner.no), May 12, 1997.
- *
- *  Use slab allocator instead of kmalloc/kfree.
- *  Use generic list implementation from <linux/list.h>.
- *  Sped up posix_locks_deadlock by only considering blocked locks.
- *  Matthew Wilcox <willy@debian.org>, March, 2000.
- *
- *  Leases and LOCK_MAND
- *  Matthew Wilcox <willy@debian.org>, June, 2000.
- *  Stephen Rothwell <sfr@canb.auug.org.au>, June, 2000.
  *
  * Locking conflicts and dependencies:
  * If multiple threads attempt to lock the same byte (or flock the same file)
-- 
2.31.1

Re: [PATCH] locks: remove changelog comments

[Jeff Layton]

On Tue, 2021-10-19 at 13:38 -0400, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
> 
> This is only of historical interest, and anyone interested in the
> history can dig out an old version of locks.c from from git.
> 
> Triggered by the observation that it references the now-removed
> Documentation/filesystems/mandatory-locking.rst.
> 
> Reported-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
>  fs/locks.c | 114 ++---------------------------------------------------
>  1 file changed, 4 insertions(+), 110 deletions(-)
> 
> On Tue, Oct 19, 2021 at 12:27:55PM -0400, Jeff Layton wrote:
> > Yeah, I think that looks great. Send it with a changelog and I'll pull
> > it into the branch I have feeding into -next.
> 
> OK!--b.
> 
> diff --git a/fs/locks.c b/fs/locks.c
> index 3d6fb4ae847b..b54813eae44f 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -2,117 +2,11 @@
>  /*
>   *  linux/fs/locks.c
>   *
> - *  Provide support for fcntl()'s F_GETLK, F_SETLK, and F_SETLKW calls.
> - *  Doug Evans (dje@spiff.uucp), August 07, 1992
> + * We implement four types of file locks: BSD locks, posix locks, open
> + * file description locks, and leases.  For details about BSD locks,
> + * see the flock(2) man page; for details about the other three, see
> + * fcntl(2).
>   *
> - *  Deadlock detection added.
> - *  FIXME: one thing isn't handled yet:
> - *	- mandatory locks (requires lots of changes elsewhere)
> - *  Kelly Carmichael (kelly@[142.24.8.65]), September 17, 1994.
> - *
> - *  Miscellaneous edits, and a total rewrite of posix_lock_file() code.
> - *  Kai Petzke (wpp@marie.physik.tu-berlin.de), 1994
> - *
> - *  Converted file_lock_table to a linked list from an array, which eliminates
> - *  the limits on how many active file locks are open.
> - *  Chad Page (pageone@netcom.com), November 27, 1994
> - *
> - *  Removed dependency on file descriptors. dup()'ed file descriptors now
> - *  get the same locks as the original file descriptors, and a close() on
> - *  any file descriptor removes ALL the locks on the file for the current
> - *  process. Since locks still depend on the process id, locks are inherited
> - *  after an exec() but not after a fork(). This agrees with POSIX, and both
> - *  BSD and SVR4 practice.
> - *  Andy Walker (andy@lysaker.kvaerner.no), February 14, 1995
> - *
> - *  Scrapped free list which is redundant now that we allocate locks
> - *  dynamically with kmalloc()/kfree().
> - *  Andy Walker (andy@lysaker.kvaerner.no), February 21, 1995
> - *
> - *  Implemented two lock personalities - FL_FLOCK and FL_POSIX.
> - *
> - *  FL_POSIX locks are created with calls to fcntl() and lockf() through the
> - *  fcntl() system call. They have the semantics described above.
> - *
> - *  FL_FLOCK locks are created with calls to flock(), through the flock()
> - *  system call, which is new. Old C libraries implement flock() via fcntl()
> - *  and will continue to use the old, broken implementation.
> - *
> - *  FL_FLOCK locks follow the 4.4 BSD flock() semantics. They are associated
> - *  with a file pointer (filp). As a result they can be shared by a parent
> - *  process and its children after a fork(). They are removed when the last
> - *  file descriptor referring to the file pointer is closed (unless explicitly
> - *  unlocked).
> - *
> - *  FL_FLOCK locks never deadlock, an existing lock is always removed before
> - *  upgrading from shared to exclusive (or vice versa). When this happens
> - *  any processes blocked by the current lock are woken up and allowed to
> - *  run before the new lock is applied.
> - *  Andy Walker (andy@lysaker.kvaerner.no), June 09, 1995
> - *
> - *  Removed some race conditions in flock_lock_file(), marked other possible
> - *  races. Just grep for FIXME to see them.
> - *  Dmitry Gorodchanin (pgmdsg@ibi.com), February 09, 1996.
> - *
> - *  Addressed Dmitry's concerns. Deadlock checking no longer recursive.
> - *  Lock allocation changed to GFP_ATOMIC as we can't afford to sleep
> - *  once we've checked for blocking and deadlocking.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 03, 1996.
> - *
> - *  Initial implementation of mandatory locks. SunOS turned out to be
> - *  a rotten model, so I implemented the "obvious" semantics.
> - *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
> - *
> - *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
> - *  check if a file has mandatory locks, used by mmap(), open() and creat() to
> - *  see if system call should be rejected. Ref. HP-UX/SunOS/Solaris Reference
> - *  Manual, Section 2.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 09, 1996.
> - *
> - *  Tidied up block list handling. Added '/proc/locks' interface.
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 24, 1996.
> - *
> - *  Fixed deadlock condition for pathological code that mixes calls to
> - *  flock() and fcntl().
> - *  Andy Walker (andy@lysaker.kvaerner.no), April 29, 1996.
> - *
> - *  Allow only one type of locking scheme (FL_POSIX or FL_FLOCK) to be in use
> - *  for a given file at a time. Changed the CONFIG_LOCK_MANDATORY scheme to
> - *  guarantee sensible behaviour in the case where file system modules might
> - *  be compiled with different options than the kernel itself.
> - *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
> - *
> - *  Added a couple of missing wake_up() calls. Thanks to Thomas Meckel
> - *  (Thomas.Meckel@mni.fh-giessen.de) for spotting this.
> - *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
> - *
> - *  Changed FL_POSIX locks to use the block list in the same way as FL_FLOCK
> - *  locks. Changed process synchronisation to avoid dereferencing locks that
> - *  have already been freed.
> - *  Andy Walker (andy@lysaker.kvaerner.no), Sep 21, 1996.
> - *
> - *  Made the block list a circular list to minimise searching in the list.
> - *  Andy Walker (andy@lysaker.kvaerner.no), Sep 25, 1996.
> - *
> - *  Made mandatory locking a mount option. Default is not to allow mandatory
> - *  locking.
> - *  Andy Walker (andy@lysaker.kvaerner.no), Oct 04, 1996.
> - *
> - *  Some adaptations for NFS support.
> - *  Olaf Kirch (okir@monad.swb.de), Dec 1996,
> - *
> - *  Fixed /proc/locks interface so that we can't overrun the buffer we are handed.
> - *  Andy Walker (andy@lysaker.kvaerner.no), May 12, 1997.
> - *
> - *  Use slab allocator instead of kmalloc/kfree.
> - *  Use generic list implementation from <linux/list.h>.
> - *  Sped up posix_locks_deadlock by only considering blocked locks.
> - *  Matthew Wilcox <willy@debian.org>, March, 2000.
> - *
> - *  Leases and LOCK_MAND
> - *  Matthew Wilcox <willy@debian.org>, June, 2000.
> - *  Stephen Rothwell <sfr@canb.auug.org.au>, June, 2000.
>   *
>   * Locking conflicts and dependencies:
>   * If multiple threads attempt to lock the same byte (or flock the same file)

Thanks, Bruce (and Mauro). Applied to the locks-next branch (and I
dropped Mauro's patch that touched the same area). It should make v5.16.

Cheers,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH] locks: remove changelog comments

[Mauro Carvalho Chehab]

Em Tue, 19 Oct 2021 14:14:08 -0400
Jeff Layton <jlayton@kernel.org> escreveu:

> On Tue, 2021-10-19 at 13:38 -0400, J. Bruce Fields wrote:
> > From: "J. Bruce Fields" <bfields@redhat.com>
> > 
> > This is only of historical interest, and anyone interested in the
> > history can dig out an old version of locks.c from from git.
> > 
> > Triggered by the observation that it references the now-removed
> > Documentation/filesystems/mandatory-locking.rst.
> > 
> > Reported-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> > ---
> >  fs/locks.c | 114 ++---------------------------------------------------
> >  1 file changed, 4 insertions(+), 110 deletions(-)
> > 
> > On Tue, Oct 19, 2021 at 12:27:55PM -0400, Jeff Layton wrote:  
> > > Yeah, I think that looks great. Send it with a changelog and I'll pull
> > > it into the branch I have feeding into -next.  
> > 
> > OK!--b.
> > 
> > diff --git a/fs/locks.c b/fs/locks.c
> > index 3d6fb4ae847b..b54813eae44f 100644
> > --- a/fs/locks.c
> > +++ b/fs/locks.c
> > @@ -2,117 +2,11 @@
> >  /*
> >   *  linux/fs/locks.c
> >   *
> > - *  Provide support for fcntl()'s F_GETLK, F_SETLK, and F_SETLKW calls.
> > - *  Doug Evans (dje@spiff.uucp), August 07, 1992
> > + * We implement four types of file locks: BSD locks, posix locks, open
> > + * file description locks, and leases.  For details about BSD locks,
> > + * see the flock(2) man page; for details about the other three, see
> > + * fcntl(2).
> >   *
> > - *  Deadlock detection added.
> > - *  FIXME: one thing isn't handled yet:
> > - *	- mandatory locks (requires lots of changes elsewhere)
> > - *  Kelly Carmichael (kelly@[142.24.8.65]), September 17, 1994.
> > - *
> > - *  Miscellaneous edits, and a total rewrite of posix_lock_file() code.
> > - *  Kai Petzke (wpp@marie.physik.tu-berlin.de), 1994
> > - *
> > - *  Converted file_lock_table to a linked list from an array, which eliminates
> > - *  the limits on how many active file locks are open.
> > - *  Chad Page (pageone@netcom.com), November 27, 1994
> > - *
> > - *  Removed dependency on file descriptors. dup()'ed file descriptors now
> > - *  get the same locks as the original file descriptors, and a close() on
> > - *  any file descriptor removes ALL the locks on the file for the current
> > - *  process. Since locks still depend on the process id, locks are inherited
> > - *  after an exec() but not after a fork(). This agrees with POSIX, and both
> > - *  BSD and SVR4 practice.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), February 14, 1995
> > - *
> > - *  Scrapped free list which is redundant now that we allocate locks
> > - *  dynamically with kmalloc()/kfree().
> > - *  Andy Walker (andy@lysaker.kvaerner.no), February 21, 1995
> > - *
> > - *  Implemented two lock personalities - FL_FLOCK and FL_POSIX.
> > - *
> > - *  FL_POSIX locks are created with calls to fcntl() and lockf() through the
> > - *  fcntl() system call. They have the semantics described above.
> > - *
> > - *  FL_FLOCK locks are created with calls to flock(), through the flock()
> > - *  system call, which is new. Old C libraries implement flock() via fcntl()
> > - *  and will continue to use the old, broken implementation.
> > - *
> > - *  FL_FLOCK locks follow the 4.4 BSD flock() semantics. They are associated
> > - *  with a file pointer (filp). As a result they can be shared by a parent
> > - *  process and its children after a fork(). They are removed when the last
> > - *  file descriptor referring to the file pointer is closed (unless explicitly
> > - *  unlocked).
> > - *
> > - *  FL_FLOCK locks never deadlock, an existing lock is always removed before
> > - *  upgrading from shared to exclusive (or vice versa). When this happens
> > - *  any processes blocked by the current lock are woken up and allowed to
> > - *  run before the new lock is applied.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), June 09, 1995
> > - *
> > - *  Removed some race conditions in flock_lock_file(), marked other possible
> > - *  races. Just grep for FIXME to see them.
> > - *  Dmitry Gorodchanin (pgmdsg@ibi.com), February 09, 1996.
> > - *
> > - *  Addressed Dmitry's concerns. Deadlock checking no longer recursive.
> > - *  Lock allocation changed to GFP_ATOMIC as we can't afford to sleep
> > - *  once we've checked for blocking and deadlocking.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), April 03, 1996.
> > - *
> > - *  Initial implementation of mandatory locks. SunOS turned out to be
> > - *  a rotten model, so I implemented the "obvious" semantics.
> > - *  See 'Documentation/filesystems/mandatory-locking.rst' for details.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
> > - *
> > - *  Don't allow mandatory locks on mmap()'ed files. Added simple functions to
> > - *  check if a file has mandatory locks, used by mmap(), open() and creat() to
> > - *  see if system call should be rejected. Ref. HP-UX/SunOS/Solaris Reference
> > - *  Manual, Section 2.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), April 09, 1996.
> > - *
> > - *  Tidied up block list handling. Added '/proc/locks' interface.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), April 24, 1996.
> > - *
> > - *  Fixed deadlock condition for pathological code that mixes calls to
> > - *  flock() and fcntl().
> > - *  Andy Walker (andy@lysaker.kvaerner.no), April 29, 1996.
> > - *
> > - *  Allow only one type of locking scheme (FL_POSIX or FL_FLOCK) to be in use
> > - *  for a given file at a time. Changed the CONFIG_LOCK_MANDATORY scheme to
> > - *  guarantee sensible behaviour in the case where file system modules might
> > - *  be compiled with different options than the kernel itself.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
> > - *
> > - *  Added a couple of missing wake_up() calls. Thanks to Thomas Meckel
> > - *  (Thomas.Meckel@mni.fh-giessen.de) for spotting this.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), May 15, 1996.
> > - *
> > - *  Changed FL_POSIX locks to use the block list in the same way as FL_FLOCK
> > - *  locks. Changed process synchronisation to avoid dereferencing locks that
> > - *  have already been freed.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), Sep 21, 1996.
> > - *
> > - *  Made the block list a circular list to minimise searching in the list.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), Sep 25, 1996.
> > - *
> > - *  Made mandatory locking a mount option. Default is not to allow mandatory
> > - *  locking.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), Oct 04, 1996.
> > - *
> > - *  Some adaptations for NFS support.
> > - *  Olaf Kirch (okir@monad.swb.de), Dec 1996,
> > - *
> > - *  Fixed /proc/locks interface so that we can't overrun the buffer we are handed.
> > - *  Andy Walker (andy@lysaker.kvaerner.no), May 12, 1997.
> > - *
> > - *  Use slab allocator instead of kmalloc/kfree.
> > - *  Use generic list implementation from <linux/list.h>.
> > - *  Sped up posix_locks_deadlock by only considering blocked locks.
> > - *  Matthew Wilcox <willy@debian.org>, March, 2000.
> > - *
> > - *  Leases and LOCK_MAND
> > - *  Matthew Wilcox <willy@debian.org>, June, 2000.
> > - *  Stephen Rothwell <sfr@canb.auug.org.au>, June, 2000.
> >   *
> >   * Locking conflicts and dependencies:
> >   * If multiple threads attempt to lock the same byte (or flock the same file)  
> 
> Thanks, Bruce (and Mauro). Applied to the locks-next branch (and I
> dropped Mauro's patch that touched the same area). It should make v5.16.

Thanks! Yeah, it looks a lot cleaner without those changelog-style
comments.

> 
> Cheers,

[PATCH v3 19/23] Documentation/process: fix a cross reference

[Mauro Carvalho Chehab]

The cross-reference for the handbooks section works. However, it is
meant to describe the path inside the Kernel's doc where the section
is, but there's an space instead of a dash, plus it lacks the .rst at
the end, which makes:

	./scripts/documentation-file-ref-check

to complain.

Fixes: 604370e106cc ("Documentation/process: Add maintainer handbooks section")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 Documentation/process/submitting-patches.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index b0f31aa82fcd..22d876eda6ef 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -22,8 +22,8 @@ use it, it will make your life as a kernel developer and in general much
 easier.
 
 Some subsystems and maintainer trees have additional information about
-their workflow and expectations, see :ref:`Documentation/process/maintainer
-handbooks <maintainer_handbooks_main>`.
+their workflow and expectations, see
+:ref:`Documentation/process/maintainer-handbooks.rst <maintainer_handbooks_main>`.
 
 Obtain a current source tree
 ----------------------------
-- 
2.31.1

[PATCH v3 20/23] dt-bindings: mfd: update x-powers,axp152.yaml reference

[Mauro Carvalho Chehab]

Changeset f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
renamed: Documentation/devicetree/bindings/mfd/axp20x.txt
to: Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml.

Update its cross-reference accordingly.

Fixes: f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
index fc42b2caa06d..538f04e60ff9 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
@@ -17,7 +17,7 @@ Required properties:
 - gpio-controller: Marks the device node as a GPIO controller.
 
 This node must be a subnode of the axp20x PMIC, documented in
-Documentation/devicetree/bindings/mfd/axp20x.txt
+Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
 
 Example:
 
-- 
2.31.1

Re: [PATCH v3 20/23] dt-bindings: mfd: update x-powers,axp152.yaml reference

[Chen-Yu Tsai]

On Tue, Oct 19, 2021 at 4:04 PM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> Changeset f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
> renamed: Documentation/devicetree/bindings/mfd/axp20x.txt
> to: Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Acked-by: Chen-Yu Tsai <wens@csie.org>

Re: [PATCH v3 20/23] dt-bindings: mfd: update x-powers,axp152.yaml reference

[Lee Jones]

On Tue, 19 Oct 2021, Mauro Carvalho Chehab wrote:

> Changeset f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
> renamed: Documentation/devicetree/bindings/mfd/axp20x.txt
> to: Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml.
> 
> Update its cross-reference accordingly.
> 
> Fixes: f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> 
>  Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 2 +-

This file no longer exists.

If it's still relevant, please rebase onto Linux -next and resubmit.

See this commit for details:

  dt-bindings: gpio: Convert X-Powers AXP209 GPIO binding to a schema

>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> index fc42b2caa06d..538f04e60ff9 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> @@ -17,7 +17,7 @@ Required properties:
>  - gpio-controller: Marks the device node as a GPIO controller.
>  
>  This node must be a subnode of the axp20x PMIC, documented in
> -Documentation/devicetree/bindings/mfd/axp20x.txt
> +Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>  
>  Example:
>  

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

[Mauro Carvalho Chehab]

The file name: Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml
should be, instead: Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml.

Update its cross-reference accordingly.

Fixes: a52afb0f54fa ("regulator: dt-bindings: samsung,s2mpa01: convert to dtschema")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 .../devicetree/bindings/regulator/samsung,s2mpa01.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
index 0627dec513da..0a564319f4b2 100644
--- a/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
+++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
@@ -15,7 +15,7 @@ description: |
 
   The S2MPA01 provides buck and LDO regulators.
 
-  See also Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml for
+  See also Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml for
   additional information and example.
 
 patternProperties:
-- 
2.31.1

Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

[Krzysztof Kozlowski]

On 19/10/2021 10:04, Mauro Carvalho Chehab wrote:
> The file name: Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml
> should be, instead: Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml.
> 
> Update its cross-reference accordingly.
> 
> Fixes: a52afb0f54fa ("regulator: dt-bindings: samsung,s2mpa01: convert to dtschema")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> 
>  .../devicetree/bindings/regulator/samsung,s2mpa01.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
> index 0627dec513da..0a564319f4b2 100644
> --- a/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
> @@ -15,7 +15,7 @@ description: |
>  
>    The S2MPA01 provides buck and LDO regulators.
>  
> -  See also Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml for
> +  See also Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml for
>    additional information and example.
>  

Hi Mauro,

Thanks for the patch but it is incorrect. Old path is proper, just the
patch waits on merging.

For this one: NAK.

Best regards,
Krzysztof

Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

On Tue, Oct 19, 2021 at 09:04:20AM +0100, Mauro Carvalho Chehab wrote:

> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

It'd be a bit easier to put a note in here about what the dependencies
are rather than forcing people to go out to a link to figure out what's
going on unless it's complicated.  For a case like this where there's no
dependencies or real relationship between the patches it's probably
better to just not thread everything and send the patches separately to
everyone, the threading is just adding noise and confusion.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

[Mauro Carvalho Chehab]

Em Tue, 19 Oct 2021 13:04:59 +0100
Mark Brown <broonie@kernel.org> escreveu:

> On Tue, Oct 19, 2021 at 09:04:20AM +0100, Mauro Carvalho Chehab wrote:
> 
> > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/  
> 
> It'd be a bit easier to put a note in here about what the dependencies
> are rather than forcing people to go out to a link to figure out what's
> going on unless it's complicated. 
>
> For a case like this where there's no
> dependencies or real relationship between the patches it's probably
> better to just not thread everything and send the patches separately to
> everyone, the threading is just adding noise and confusion.

It is not that easy, unfortunately. On some cases (specially due to
DT binding renames) some patches change the context of a hunk, affecting
a subsequent patch.

I tried a couple of times in the past to send the patches individually,
but that was messier, as there was harder for people to apply them,
as, instead of running b4 just once to get everything, maintainers
would need to apply each patch individually. Also, there were cases
where the patch order would be relevant, due to context changes.

-

Btw, talking about what it would be easier, the best procedure to
adopt is to run:

	./scripts/documentation-file-ref-check 

Before sending/applying patches touching documents.

That would avoid the need of such fixup patches ;-)

Unfortunately, in the specific case of dt-bindings, things are not
that easy, as doc changes usually go via one tree, while references 
to them come from other places.

Regards,
Mauro

Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

On Wed, Oct 20, 2021 at 07:30:13AM +0100, Mauro Carvalho Chehab wrote:
> Mark Brown <broonie@kernel.org> escreveu:

> > For a case like this where there's no
> > dependencies or real relationship between the patches it's probably
> > better to just not thread everything and send the patches separately to
> > everyone, the threading is just adding noise and confusion.

> It is not that easy, unfortunately. On some cases (specially due to
> DT binding renames) some patches change the context of a hunk, affecting
> a subsequent patch.

If that's the case then the cover letter really needs work to make this
clear, I couldn't tell that there was any risk of dependencies nor would
I expect any for such trivial changes.

> I tried a couple of times in the past to send the patches individually,
> but that was messier, as there was harder for people to apply them,
> as, instead of running b4 just once to get everything, maintainers
> would need to apply each patch individually. Also, there were cases
> where the patch order would be relevant, due to context changes.

You could also send a per subsystem series if there's a concern about it
being hard to pick up individual patches.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

[Rob Herring]

On Wed, Oct 20, 2021 at 07:30:13AM +0100, Mauro Carvalho Chehab wrote:
> Em Tue, 19 Oct 2021 13:04:59 +0100
> Mark Brown <broonie@kernel.org> escreveu:
> 
> > On Tue, Oct 19, 2021 at 09:04:20AM +0100, Mauro Carvalho Chehab wrote:
> > 
> > > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > > See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/  
> > 
> > It'd be a bit easier to put a note in here about what the dependencies
> > are rather than forcing people to go out to a link to figure out what's
> > going on unless it's complicated. 
> >
> > For a case like this where there's no
> > dependencies or real relationship between the patches it's probably
> > better to just not thread everything and send the patches separately to
> > everyone, the threading is just adding noise and confusion.
> 
> It is not that easy, unfortunately. On some cases (specially due to
> DT binding renames) some patches change the context of a hunk, affecting
> a subsequent patch.

Those should be reduced now. I've been checking the renames since early 
August. July really, but MAINTAINERS was not getting checked initially.


> I tried a couple of times in the past to send the patches individually,
> but that was messier, as there was harder for people to apply them,
> as, instead of running b4 just once to get everything, maintainers
> would need to apply each patch individually. Also, there were cases
> where the patch order would be relevant, due to context changes.

Just spliting between in Linus' tree and only in next would help me. The 
former I know I can just apply.

> Btw, talking about what it would be easier, the best procedure to
> adopt is to run:
> 
> 	./scripts/documentation-file-ref-check 
> 
> Before sending/applying patches touching documents.

Good luck with that. :(

> That would avoid the need of such fixup patches ;-)
> 
> Unfortunately, in the specific case of dt-bindings, things are not
> that easy, as doc changes usually go via one tree, while references 
> to them come from other places.
> 
> Regards,
> Mauro
> 

[PATCH v3 22/23] regulator: dt-bindings: update samsung,s5m8767.yaml reference

[Mauro Carvalho Chehab]

The file name: Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
should be, instead: Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml.

Update its cross-reference accordingly.

Fixes: fab58debc137 ("regulator: dt-bindings: samsung,s5m8767: convert to dtschema")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 .../devicetree/bindings/regulator/samsung,s5m8767.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
index 80a63d47790a..4281f670c775 100644
--- a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
+++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
@@ -15,7 +15,7 @@ description: |
 
   The S5M8767 provides buck and LDO regulators.
 
-  See also Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml for
+  See also Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml for
   additional information and example.
 
 patternProperties:
-- 
2.31.1

Re: [PATCH v3 22/23] regulator: dt-bindings: update samsung,s5m8767.yaml reference

[Krzysztof Kozlowski]

On 19/10/2021 10:04, Mauro Carvalho Chehab wrote:
> The file name: Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
> should be, instead: Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml.
> 
> Update its cross-reference accordingly.
> 
> Fixes: fab58debc137 ("regulator: dt-bindings: samsung,s5m8767: convert to dtschema")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> 
>  .../devicetree/bindings/regulator/samsung,s5m8767.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
> index 80a63d47790a..4281f670c775 100644
> --- a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
> @@ -15,7 +15,7 @@ description: |
>  
>    The S5M8767 provides buck and LDO regulators.
>  
> -  See also Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml for
> +  See also Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml for
>    additional information and example.
>  
>  patternProperties:
> 


Hi Mauro,

Thanks for the patch but it is incorrect. Old path is proper, just the
patch waits on merging.

For this one: NAK.

Best regards,
Krzysztof

[PATCH v3 23/23] dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

[Mauro Carvalho Chehab]

Changeset 89a5bf0f22fd ("dt-bindings: reserved-memory: ramoops: Convert txt bindings to yaml")
renamed: Documentation/devicetree/bindings/reserved-memory/ramoops.txt
to: Documentation/devicetree/bindings/reserved-memory/ramoops.yaml.

Update the cross-references accordingly.

Fixes: 89a5bf0f22fd ("dt-bindings: reserved-memory: ramoops: Convert txt bindings to yaml")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/

 Documentation/admin-guide/ramoops.rst | 2 +-
 MAINTAINERS                           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/ramoops.rst b/Documentation/admin-guide/ramoops.rst
index 8f107d8c9261..e9f85142182d 100644
--- a/Documentation/admin-guide/ramoops.rst
+++ b/Documentation/admin-guide/ramoops.rst
@@ -69,7 +69,7 @@ Setting the ramoops parameters can be done in several different manners:
 	mem=128M ramoops.mem_address=0x8000000 ramoops.ecc=1
 
  B. Use Device Tree bindings, as described in
- ``Documentation/devicetree/bindings/reserved-memory/ramoops.txt``.
+ ``Documentation/devicetree/bindings/reserved-memory/ramoops.yaml``.
  For example::
 
 	reserved-memory {
diff --git a/MAINTAINERS b/MAINTAINERS
index d74b08c4fb1f..1dc758a0db58 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15336,7 +15336,7 @@ S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
 F:	Documentation/admin-guide/ramoops.rst
 F:	Documentation/admin-guide/pstore-blk.rst
-F:	Documentation/devicetree/bindings/reserved-memory/ramoops.txt
+F:	Documentation/devicetree/bindings/reserved-memory/ramoops.yaml
 F:	drivers/acpi/apei/erst.c
 F:	drivers/firmware/efi/efi-pstore.c
 F:	fs/pstore/
-- 
2.31.1

Re: [PATCH v3 23/23] dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

[David Heidelberg]

Than you for catching this.

Reviewed-by: David Heidelberg <david@ixit.cz>


Best regards
David Heidelberg

On Tue, Oct 19 2021 at 09:04:22 +0100, Mauro Carvalho Chehab 
<mchehab+huawei@kernel.org> wrote:
> Changeset 89a5bf0f22fd ("dt-bindings: reserved-memory: ramoops: 
> Convert txt bindings to yaml")
> renamed: Documentation/devicetree/bindings/reserved-memory/ramoops.txt
> to: Documentation/devicetree/bindings/reserved-memory/ramoops.yaml.
> 
> Update the cross-references accordingly.
> 
> Fixes: 89a5bf0f22fd ("dt-bindings: reserved-memory: ramoops: Convert 
> txt bindings to yaml")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were 
> C/C on the cover.
> See [PATCH v3 00/23] at: 
> https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> 
>  Documentation/admin-guide/ramoops.rst | 2 +-
>  MAINTAINERS                           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/ramoops.rst 
> b/Documentation/admin-guide/ramoops.rst
> index 8f107d8c9261..e9f85142182d 100644
> --- a/Documentation/admin-guide/ramoops.rst
> +++ b/Documentation/admin-guide/ramoops.rst
> @@ -69,7 +69,7 @@ Setting the ramoops parameters can be done in 
> several different manners:
>  	mem=128M ramoops.mem_address=0x8000000 ramoops.ecc=1
> 
>   B. Use Device Tree bindings, as described in
> - ``Documentation/devicetree/bindings/reserved-memory/ramoops.txt``.
> + ``Documentation/devicetree/bindings/reserved-memory/ramoops.yaml``.
>   For example::
> 
>  	reserved-memory {
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d74b08c4fb1f..1dc758a0db58 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15336,7 +15336,7 @@ S:	Maintained
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git 
> for-next/pstore
>  F:	Documentation/admin-guide/ramoops.rst
>  F:	Documentation/admin-guide/pstore-blk.rst
> -F:	Documentation/devicetree/bindings/reserved-memory/ramoops.txt
> +F:	Documentation/devicetree/bindings/reserved-memory/ramoops.yaml
>  F:	drivers/acpi/apei/erst.c
>  F:	drivers/firmware/efi/efi-pstore.c
>  F:	fs/pstore/
> --
> 2.31.1
> 

Re: [PATCH v3 23/23] dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

[Rob Herring]

On Tue, 19 Oct 2021 09:04:22 +0100, Mauro Carvalho Chehab wrote:
> Changeset 89a5bf0f22fd ("dt-bindings: reserved-memory: ramoops: Convert txt bindings to yaml")
> renamed: Documentation/devicetree/bindings/reserved-memory/ramoops.txt
> to: Documentation/devicetree/bindings/reserved-memory/ramoops.yaml.
> 
> Update the cross-references accordingly.
> 
> Fixes: 89a5bf0f22fd ("dt-bindings: reserved-memory: ramoops: Convert txt bindings to yaml")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> 
>  Documentation/admin-guide/ramoops.rst | 2 +-
>  MAINTAINERS                           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks!

Re: [PATCH v3 00/23] Fix some issues at documentation

[Rob Herring]

On Tue, 19 Oct 2021 09:03:59 +0100, Mauro Carvalho Chehab wrote:
> Hi Jon,
> 
> This series is against today's next (next-20211019) and addresses missing
> links to Documentation/*.
> 
> The best would be to have the patches applied directly to the trees that
> contain the patches that moved/renamed files, and then apply the
> remaining ones either later during the merge window or just afterwards,
> whatever works best for you.
> 
> Regards,
> Mauro
> 
> Mauro Carvalho Chehab (23):
>   visorbus: fix a copyright symbol that was bad encoded
>   libbpf: update index.rst reference
>   docs: accounting: update delay-accounting.rst reference
>   MAINTAINERS: update arm,vic.yaml reference
>   MAINTAINERS: update aspeed,i2c.yaml reference
>   MAINTAINERS: update faraday,ftrtc010.yaml reference
>   MAINTAINERS: update ti,sci.yaml reference
>   MAINTAINERS: update intel,ixp46x-rng.yaml reference
>   MAINTAINERS: update nxp,imx8-jpeg.yaml reference
>   MAINTAINERS: update gemini.yaml reference
>   MAINTAINERS: update brcm,unimac-mdio.yaml reference
>   MAINTAINERS: update mtd-physmap.yaml reference

Applied patches 3-12.

>   Documentation: update vcpu-requests.rst reference
>   bpftool: update bpftool-cgroup.rst reference
>   docs: translations: zn_CN: irq-affinity.rst: add a missing extension
>   docs: translations: zh_CN: memory-hotplug.rst: fix a typo
>   docs: fs: locks.rst: update comment about mandatory file locking
>   fs: remove a comment pointing to the removed mandatory-locking file
>   Documentation/process: fix a cross reference
>   dt-bindings: mfd: update x-powers,axp152.yaml reference
>   regulator: dt-bindings: update samsung,s2mpa01.yaml reference
>   regulator: dt-bindings: update samsung,s5m8767.yaml reference
>   dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

Re: [PATCH v3 00/23] Fix some issues at documentation

[Rob Herring]

On Tue, 19 Oct 2021 09:03:59 +0100, Mauro Carvalho Chehab wrote:
> Hi Jon,
> 
> This series is against today's next (next-20211019) and addresses missing
> links to Documentation/*.
> 
> The best would be to have the patches applied directly to the trees that
> contain the patches that moved/renamed files, and then apply the
> remaining ones either later during the merge window or just afterwards,
> whatever works best for you.
> 
> Regards,
> Mauro
> 
> Mauro Carvalho Chehab (23):
>   visorbus: fix a copyright symbol that was bad encoded
>   libbpf: update index.rst reference
>   docs: accounting: update delay-accounting.rst reference
>   MAINTAINERS: update arm,vic.yaml reference
>   MAINTAINERS: update aspeed,i2c.yaml reference
>   MAINTAINERS: update faraday,ftrtc010.yaml reference
>   MAINTAINERS: update ti,sci.yaml reference
>   MAINTAINERS: update intel,ixp46x-rng.yaml reference
>   MAINTAINERS: update nxp,imx8-jpeg.yaml reference
>   MAINTAINERS: update gemini.yaml reference
>   MAINTAINERS: update brcm,unimac-mdio.yaml reference
>   MAINTAINERS: update mtd-physmap.yaml reference

Applied patches 3-12.

>   Documentation: update vcpu-requests.rst reference
>   bpftool: update bpftool-cgroup.rst reference
>   docs: translations: zn_CN: irq-affinity.rst: add a missing extension
>   docs: translations: zh_CN: memory-hotplug.rst: fix a typo
>   docs: fs: locks.rst: update comment about mandatory file locking
>   fs: remove a comment pointing to the removed mandatory-locking file
>   Documentation/process: fix a cross reference
>   dt-bindings: mfd: update x-powers,axp152.yaml reference
>   regulator: dt-bindings: update samsung,s2mpa01.yaml reference
>   regulator: dt-bindings: update samsung,s5m8767.yaml reference
>   dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv