From: Rong Chen <rong.a.chen@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
Date: Thu, 21 Jan 2021 17:38:55 +0800 [thread overview]
Message-ID: <03812967-a4d2-deb9-63e9-048333988778@intel.com> (raw)
In-Reply-To: <YAgNbE/RcZnwiLK1@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 2093 bytes --]
On 1/20/21 7:01 PM, Greg Kroah-Hartman wrote:
> On Tue, Jan 19, 2021 at 06:41:02PM +0100, Borislav Petkov wrote:
>> On Wed, Jan 20, 2021 at 01:36:14AM +0800, kernel test robot wrote:
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>>> head: e864f43593ccf9180c61738abdf1c1dde091367d
>>> commit: 938de2324afb53acd20893cd8eec8ee6f80de646 [5835/9999] x86/MCE/AMD: Carve out the MC4_MISC thresholding quirk
>>> config: i386-randconfig-r005-20210118 (attached as .config)
>>> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>>> reproduce (this is a W=1 build):
>>> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=938de2324afb53acd20893cd8eec8ee6f80de646
>>> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>>> git fetch --no-tags linux-stable-rc linux-4.19.y
>>> git checkout 938de2324afb53acd20893cd8eec8ee6f80de646
>>> # save the attached .config to linux build tree
>>> make W=1 ARCH=i386
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' [-Wmissing-prototypes]
>>> 552 | void disable_err_thresholding(struct cpuinfo_x86 *c)
>> Why are you running W=1 build tests on stable kernels?
>>
>> Especially -Wmissing-prototypes is a complete waste of time for those.
>>
>> And the fix
>>
>> 47cd84e98f51 ("x86/mce/amd: Make disable_err_thresholding() static")
>>
>> would be a complete waste of backporting bandwidth and it doesn't even
>> fit the stable rules.
> I agree, this noisy checks should be verified that they actually are
> pointing out a real issue before sending them out.
>
> thanks,
>
> greg k-h
Hi all,
Sorry for the noise, we'll disable W=1 for stable kernels firstly.
Best Regards,
Rong Chen
next prev parent reply other threads:[~2021-01-21 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 17:36 [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' kernel test robot
2021-01-19 17:41 ` Borislav Petkov
2021-01-20 11:01 ` Greg Kroah-Hartman
2021-01-21 9:38 ` Rong Chen [this message]
2021-01-21 10:39 ` Borislav Petkov
2021-01-21 12:41 ` Philip Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03812967-a4d2-deb9-63e9-048333988778@intel.com \
--to=rong.a.chen@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.