From: Borislav Petkov <bp@suse.de>
To: kbuild-all@lists.01.org
Subject: Re: [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
Date: Thu, 21 Jan 2021 11:39:08 +0100 [thread overview]
Message-ID: <20210121103908.GB28677@zn.tnic> (raw)
In-Reply-To: <03812967-a4d2-deb9-63e9-048333988778@intel.com>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Thu, Jan 21, 2021 at 05:38:55PM +0800, Rong Chen wrote:
> Sorry for the noise, we'll disable W=1 for stable kernels firstly.
Well, this is the thing: W=1 might make sense *sometimes* because it
enables a couple of warnings. One of them is -Wmissing-prototypes which
doesn't make sense for stable, as explained earlier.
So you need to either
* disable -Wmissing-prototypes only which means stable-specific patch
and stable folks don't like that.
or
* analyze the reports *before* sending them out. You could simply not
send reports which come solely from -Wmissing-prototypes warnings.
or
* patch the stable tree locally with your own patch
or
* ...
It all depends on what is done easier in your infra.
HTH.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2021-01-21 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 17:36 [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' kernel test robot
2021-01-19 17:41 ` Borislav Petkov
2021-01-20 11:01 ` Greg Kroah-Hartman
2021-01-21 9:38 ` Rong Chen
2021-01-21 10:39 ` Borislav Petkov [this message]
2021-01-21 12:41 ` Philip Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121103908.GB28677@zn.tnic \
--to=bp@suse.de \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.