From: Philip Li <philip.li@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
Date: Thu, 21 Jan 2021 20:41:09 +0800 [thread overview]
Message-ID: <20210121124109.GA13998@intel.com> (raw)
In-Reply-To: <20210121103908.GB28677@zn.tnic>
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
On Thu, Jan 21, 2021 at 11:39:08AM +0100, Borislav Petkov wrote:
> On Thu, Jan 21, 2021 at 05:38:55PM +0800, Rong Chen wrote:
> > Sorry for the noise, we'll disable W=1 for stable kernels firstly.
>
> Well, this is the thing: W=1 might make sense *sometimes* because it
> enables a couple of warnings. One of them is -Wmissing-prototypes which
> doesn't make sense for stable, as explained earlier.
Thanks for the input, this helps and we can focus on this warning firstly
to reduce meaningless reports for stable.
>
> So you need to either
>
> * disable -Wmissing-prototypes only which means stable-specific patch
> and stable folks don't like that.
>
> or
>
> * analyze the reports *before* sending them out. You could simply not
> send reports which come solely from -Wmissing-prototypes warnings.
We will look into above 2 options to see which one is easiler to
fit what we have in place. Thanks for your suggestions.
>
> or
>
> * patch the stable tree locally with your own patch
>
> or
>
> * ...
>
> It all depends on what is done easier in your infra.
>
> HTH.
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
prev parent reply other threads:[~2021-01-21 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 17:36 [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' kernel test robot
2021-01-19 17:41 ` Borislav Petkov
2021-01-20 11:01 ` Greg Kroah-Hartman
2021-01-21 9:38 ` Rong Chen
2021-01-21 10:39 ` Borislav Petkov
2021-01-21 12:41 ` Philip Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121124109.GA13998@intel.com \
--to=philip.li@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.