From: Kukjin Kim <kgene.kim@samsung.com> To: "'Tomasz Figa'" <t.figa@samsung.com>, linux-samsung-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "'Marek Szyprowski'" <m.szyprowski@samsung.com>, "'Tomasz Figa'" <tomasz.figa@gmail.com> Subject: RE: [PATCH 6/6] ARM: EXYNOS: Register cpuidle device only on Exynos4210 and 5250 Date: Tue, 08 Jul 2014 23:15:21 +0900 [thread overview] Message-ID: <038b01cf9ab7$0de5a440$29b0ecc0$@samsung.com> (raw) In-Reply-To: <1403618235-19353-7-git-send-email-t.figa@samsung.com> Tomasz Figa wrote: > > Currently, the Exynos cpuidle driver works correctly only on Exynos4210 > and 5250. Trying to use it with just one CPU online on any other Exynos > SoC will lead to system failure, due to unsupported AFTR mode on other > SoCs. This patch fixes the problem by registering the driver only on > supported SoCs and letting others simply use default WFI mode until > support for them is added. > Hmm...I thought other SoCs have no problem on cpuidle except exynos5420 and exynos5440....something like this would be helpful to avoid system failure. But unfortunately this conflicts with Pankaj's cleanup cpufreq_init() and cpuidle_init() patch you've reviewed and I've applied in my local... I'm going to check which exynos is ok on cpuidle and then sort them out. Thanks, Kukjin > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > --- > arch/arm/mach-exynos/exynos.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index f38cf7c..176bbf5 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -173,10 +173,8 @@ static struct platform_device exynos_cpuidle = { > > void __init exynos_cpuidle_init(void) > { > - if (soc_is_exynos5440()) > - return; > - > - platform_device_register(&exynos_cpuidle); > + if (soc_is_exynos4210() || soc_is_exynos5250()) > + platform_device_register(&exynos_cpuidle); > } > > void __init exynos_cpufreq_init(void) > -- > 1.9.3
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/6] ARM: EXYNOS: Register cpuidle device only on Exynos4210 and 5250 Date: Tue, 08 Jul 2014 23:15:21 +0900 [thread overview] Message-ID: <038b01cf9ab7$0de5a440$29b0ecc0$@samsung.com> (raw) In-Reply-To: <1403618235-19353-7-git-send-email-t.figa@samsung.com> Tomasz Figa wrote: > > Currently, the Exynos cpuidle driver works correctly only on Exynos4210 > and 5250. Trying to use it with just one CPU online on any other Exynos > SoC will lead to system failure, due to unsupported AFTR mode on other > SoCs. This patch fixes the problem by registering the driver only on > supported SoCs and letting others simply use default WFI mode until > support for them is added. > Hmm...I thought other SoCs have no problem on cpuidle except exynos5420 and exynos5440....something like this would be helpful to avoid system failure. But unfortunately this conflicts with Pankaj's cleanup cpufreq_init() and cpuidle_init() patch you've reviewed and I've applied in my local... I'm going to check which exynos is ok on cpuidle and then sort them out. Thanks, Kukjin > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > --- > arch/arm/mach-exynos/exynos.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index f38cf7c..176bbf5 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -173,10 +173,8 @@ static struct platform_device exynos_cpuidle = { > > void __init exynos_cpuidle_init(void) > { > - if (soc_is_exynos5440()) > - return; > - > - platform_device_register(&exynos_cpuidle); > + if (soc_is_exynos4210() || soc_is_exynos5250()) > + platform_device_register(&exynos_cpuidle); > } > > void __init exynos_cpufreq_init(void) > -- > 1.9.3
next prev parent reply other threads:[~2014-07-08 14:15 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-24 13:57 [PATCH 0/6] Various Samsung fixes for v3.16-rc3 Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-06-24 13:57 ` [PATCH 1/6] mmc: sdhci-s3c: Fix local I/O clock gating Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-07-14 8:05 ` Jaehoon Chung 2014-07-14 8:05 ` Jaehoon Chung 2014-06-24 13:57 ` [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-07-08 13:21 ` Kukjin Kim 2014-07-08 13:21 ` Kukjin Kim 2014-07-14 9:50 ` Tomasz Figa 2014-07-14 9:50 ` Tomasz Figa 2014-07-14 9:50 ` Tomasz Figa 2014-07-15 18:00 ` Kukjin Kim 2014-07-15 18:00 ` Kukjin Kim 2014-06-24 13:57 ` [PATCH 3/6] clk: samsung: exynos4: Remove SRC_MASK_ISP gates Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-06-25 9:58 ` Daniel Drake 2014-06-25 9:58 ` Daniel Drake 2014-06-25 10:10 ` Tomasz Figa 2014-06-25 10:10 ` Tomasz Figa 2014-06-30 13:50 ` Tomasz Figa 2014-06-30 13:50 ` Tomasz Figa 2014-06-24 13:57 ` [PATCH 4/6] ARM: SAMSUNG: Restore Samsung PM Debug functionality Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-06-25 10:09 ` Daniel Drake 2014-06-25 10:09 ` Daniel Drake 2014-06-25 11:41 ` Tomasz Figa 2014-06-25 11:41 ` Tomasz Figa 2014-06-25 11:43 ` [PATCH v2 " Tomasz Figa 2014-06-25 11:43 ` Tomasz Figa 2014-06-26 9:24 ` Daniel Drake 2014-06-26 9:24 ` Daniel Drake 2014-07-14 9:52 ` Tomasz Figa 2014-07-14 9:52 ` Tomasz Figa 2014-07-08 13:48 ` [PATCH " Kukjin Kim 2014-07-08 13:48 ` Kukjin Kim 2014-07-08 13:54 ` Tomasz Figa 2014-07-08 13:54 ` Tomasz Figa 2014-07-15 18:02 ` Kukjin Kim 2014-07-15 18:02 ` Kukjin Kim 2014-07-15 23:59 ` Tomasz Figa 2014-07-15 23:59 ` Tomasz Figa 2014-07-21 10:30 ` Tomasz Figa 2014-07-21 10:30 ` Tomasz Figa 2014-06-24 13:57 ` [PATCH 5/6] ARM: EXYNOS: Fix suspend/resume sequencies Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-06-24 15:33 ` Abhilash Kesavan 2014-06-24 15:33 ` Abhilash Kesavan 2014-07-08 14:02 ` Kukjin Kim 2014-07-08 14:02 ` Kukjin Kim 2014-06-24 13:57 ` [PATCH 6/6] ARM: EXYNOS: Register cpuidle device only on Exynos4210 and 5250 Tomasz Figa 2014-06-24 13:57 ` Tomasz Figa 2014-07-08 14:15 ` Kukjin Kim [this message] 2014-07-08 14:15 ` Kukjin Kim 2014-07-08 15:45 ` Bartlomiej Zolnierkiewicz 2014-07-08 15:45 ` Bartlomiej Zolnierkiewicz 2014-07-10 13:30 ` Kukjin Kim 2014-07-10 13:30 ` Kukjin Kim 2014-06-25 11:52 ` [PATCH v2 5/6] ARM: EXYNOS: Fix suspend/resume sequences Tomasz Figa 2014-06-25 11:52 ` Tomasz Figa 2014-07-14 9:54 ` Tomasz Figa 2014-07-14 9:54 ` Tomasz Figa 2014-07-15 11:19 ` Bartlomiej Zolnierkiewicz 2014-07-15 11:19 ` Bartlomiej Zolnierkiewicz 2014-07-15 12:15 ` Tomasz Figa 2014-07-15 12:15 ` Tomasz Figa 2014-07-15 14:24 ` [PATCH v3] " Tomasz Figa 2014-07-15 14:24 ` Tomasz Figa 2014-07-15 14:26 ` Tomasz Figa 2014-07-15 14:26 ` Tomasz Figa 2014-07-17 14:42 ` Tomasz Figa 2014-07-17 14:42 ` Tomasz Figa 2014-07-21 10:23 ` Tomasz Figa 2014-07-21 10:23 ` Tomasz Figa 2014-07-15 17:31 ` [PATCH v2 5/6] " Chander Kashyap 2014-07-15 17:31 ` Chander Kashyap 2014-07-15 17:31 ` Chander Kashyap 2014-07-01 13:54 ` [PATCH 0/6] Various Samsung fixes for v3.16-rc3 Tomasz Figa 2014-07-01 13:54 ` Tomasz Figa 2014-07-07 23:25 ` Kukjin Kim 2014-07-07 23:25 ` Kukjin Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='038b01cf9ab7$0de5a440$29b0ecc0$@samsung.com' \ --to=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=t.figa@samsung.com \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.