All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
	"'Tomasz Figa'" <t.figa@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"'Marek Szyprowski'" <m.szyprowski@samsung.com>
Subject: Re: [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code
Date: Wed, 16 Jul 2014 03:00:12 +0900	[thread overview]
Message-ID: <53C56C2C.8010801@samsung.com> (raw)
In-Reply-To: <53C3A7FE.8000401@gmail.com>

On 07/14/14 18:50, Tomasz Figa wrote:
> Hi Kukjin,
>
Hi,

> On 08.07.2014 15:21, Kukjin Kim wrote:
>> Tomasz Figa wrote:
>>>
>>> When CPU topology is specified in device tree, cpu_logical_map() does
>>> not return core ID anymore, but rather full MPIDR value. This breaks
>>> existing calculation of PMU register offsets on Exynos SoCs.
>>>
>>> This patch fixes the problem by adjusting the code to use only core ID
>>> bits of the value returned by cpu_logical_map() to allow CPU topology to
>>> be specified in device tree on Exynos SoCs.
>>>
>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>>
>> Looks good to me, but I think we don't need this fix in 3.16 because the CPU
>> topology is not specified in DT yet...if I'm wrong, please correct me.
>
> CPU topology is already specified in DT for Exynos3250, 5250, 5260, 5410
> and 5420/5800.
>
> This patch also fixes CPU hotplug on SoCs with more than 2 cores,
> because it removes incorrect condition check in platform_do_lowpower().
>
> Please take this fix for next -rc release.
>
Agreed and I've applied this into fixes for 3.16...

Thanks,
Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code
Date: Wed, 16 Jul 2014 03:00:12 +0900	[thread overview]
Message-ID: <53C56C2C.8010801@samsung.com> (raw)
In-Reply-To: <53C3A7FE.8000401@gmail.com>

On 07/14/14 18:50, Tomasz Figa wrote:
> Hi Kukjin,
>
Hi,

> On 08.07.2014 15:21, Kukjin Kim wrote:
>> Tomasz Figa wrote:
>>>
>>> When CPU topology is specified in device tree, cpu_logical_map() does
>>> not return core ID anymore, but rather full MPIDR value. This breaks
>>> existing calculation of PMU register offsets on Exynos SoCs.
>>>
>>> This patch fixes the problem by adjusting the code to use only core ID
>>> bits of the value returned by cpu_logical_map() to allow CPU topology to
>>> be specified in device tree on Exynos SoCs.
>>>
>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>>
>> Looks good to me, but I think we don't need this fix in 3.16 because the CPU
>> topology is not specified in DT yet...if I'm wrong, please correct me.
>
> CPU topology is already specified in DT for Exynos3250, 5250, 5260, 5410
> and 5420/5800.
>
> This patch also fixes CPU hotplug on SoCs with more than 2 cores,
> because it removes incorrect condition check in platform_do_lowpower().
>
> Please take this fix for next -rc release.
>
Agreed and I've applied this into fixes for 3.16...

Thanks,
Kukjin

  reply	other threads:[~2014-07-15 18:00 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 13:57 [PATCH 0/6] Various Samsung fixes for v3.16-rc3 Tomasz Figa
2014-06-24 13:57 ` Tomasz Figa
2014-06-24 13:57 ` [PATCH 1/6] mmc: sdhci-s3c: Fix local I/O clock gating Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-07-14  8:05   ` Jaehoon Chung
2014-07-14  8:05     ` Jaehoon Chung
2014-06-24 13:57 ` [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-07-08 13:21   ` Kukjin Kim
2014-07-08 13:21     ` Kukjin Kim
2014-07-14  9:50     ` Tomasz Figa
2014-07-14  9:50       ` Tomasz Figa
2014-07-14  9:50       ` Tomasz Figa
2014-07-15 18:00       ` Kukjin Kim [this message]
2014-07-15 18:00         ` Kukjin Kim
2014-06-24 13:57 ` [PATCH 3/6] clk: samsung: exynos4: Remove SRC_MASK_ISP gates Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-25  9:58   ` Daniel Drake
2014-06-25  9:58     ` Daniel Drake
2014-06-25 10:10     ` Tomasz Figa
2014-06-25 10:10       ` Tomasz Figa
2014-06-30 13:50   ` Tomasz Figa
2014-06-30 13:50     ` Tomasz Figa
2014-06-24 13:57 ` [PATCH 4/6] ARM: SAMSUNG: Restore Samsung PM Debug functionality Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-25 10:09   ` Daniel Drake
2014-06-25 10:09     ` Daniel Drake
2014-06-25 11:41     ` Tomasz Figa
2014-06-25 11:41       ` Tomasz Figa
2014-06-25 11:43   ` [PATCH v2 " Tomasz Figa
2014-06-25 11:43     ` Tomasz Figa
2014-06-26  9:24     ` Daniel Drake
2014-06-26  9:24       ` Daniel Drake
2014-07-14  9:52     ` Tomasz Figa
2014-07-14  9:52       ` Tomasz Figa
2014-07-08 13:48   ` [PATCH " Kukjin Kim
2014-07-08 13:48     ` Kukjin Kim
2014-07-08 13:54     ` Tomasz Figa
2014-07-08 13:54       ` Tomasz Figa
2014-07-15 18:02       ` Kukjin Kim
2014-07-15 18:02         ` Kukjin Kim
2014-07-15 23:59         ` Tomasz Figa
2014-07-15 23:59           ` Tomasz Figa
2014-07-21 10:30           ` Tomasz Figa
2014-07-21 10:30             ` Tomasz Figa
2014-06-24 13:57 ` [PATCH 5/6] ARM: EXYNOS: Fix suspend/resume sequencies Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-24 15:33   ` Abhilash Kesavan
2014-06-24 15:33     ` Abhilash Kesavan
2014-07-08 14:02   ` Kukjin Kim
2014-07-08 14:02     ` Kukjin Kim
2014-06-24 13:57 ` [PATCH 6/6] ARM: EXYNOS: Register cpuidle device only on Exynos4210 and 5250 Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-07-08 14:15   ` Kukjin Kim
2014-07-08 14:15     ` Kukjin Kim
2014-07-08 15:45     ` Bartlomiej Zolnierkiewicz
2014-07-08 15:45       ` Bartlomiej Zolnierkiewicz
2014-07-10 13:30       ` Kukjin Kim
2014-07-10 13:30         ` Kukjin Kim
2014-06-25 11:52 ` [PATCH v2 5/6] ARM: EXYNOS: Fix suspend/resume sequences Tomasz Figa
2014-06-25 11:52   ` Tomasz Figa
2014-07-14  9:54   ` Tomasz Figa
2014-07-14  9:54     ` Tomasz Figa
2014-07-15 11:19     ` Bartlomiej Zolnierkiewicz
2014-07-15 11:19       ` Bartlomiej Zolnierkiewicz
2014-07-15 12:15       ` Tomasz Figa
2014-07-15 12:15         ` Tomasz Figa
2014-07-15 14:24         ` [PATCH v3] " Tomasz Figa
2014-07-15 14:24           ` Tomasz Figa
2014-07-15 14:26           ` Tomasz Figa
2014-07-15 14:26             ` Tomasz Figa
2014-07-17 14:42             ` Tomasz Figa
2014-07-17 14:42               ` Tomasz Figa
2014-07-21 10:23             ` Tomasz Figa
2014-07-21 10:23               ` Tomasz Figa
2014-07-15 17:31         ` [PATCH v2 5/6] " Chander Kashyap
2014-07-15 17:31           ` Chander Kashyap
2014-07-15 17:31           ` Chander Kashyap
2014-07-01 13:54 ` [PATCH 0/6] Various Samsung fixes for v3.16-rc3 Tomasz Figa
2014-07-01 13:54   ` Tomasz Figa
2014-07-07 23:25   ` Kukjin Kim
2014-07-07 23:25     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C56C2C.8010801@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=t.figa@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.