From: Brijesh Singh <brijesh.singh@amd.com> To: Peter Maydell <peter.maydell@linaro.org> Cc: brijesh.singh@amd.com, QEMU Developers <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@xilinx.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Daniel P . Berrange" <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>, kvm-devel <kvm@vger.kernel.org>, Marcel Apfelbaum <marcel@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Richard Henderson <richard.henderson@linaro.org>, Richard Henderson <rth@twiddle.net>, Stefan Hajnoczi <stefa Subject: Re: [PATCH v5 01/23] memattrs: add debug attribute Date: Fri, 8 Dec 2017 16:57:13 -0600 [thread overview] Message-ID: <053109e5-3b12-b76c-7d87-5f1e4941ebed@amd.com> (raw) In-Reply-To: <CAFEAcA_A9c3QMOJeHK+gyTpwkxo0hpkU9jhCdvQnpfbGBw+Wfg@mail.gmail.com> On 12/8/17 3:55 AM, Peter Maydell wrote: >> If you give me example on how >> to trigger this type of request with debug=1 then I can look into the code >> and see what we can do when memory encryption is enabled. The things like >> read-clears-bits semantics will be tricky. > The question was really whether we want to make this a general > indicator of "this operation was triggered by a debugger" and > expand that to mean "don't do things that mess with the state > of the simulation unexpectedly", or if this is really a very > encrypted-memory specific thing. It can be used as a generic indicator that operation was triggered by a debugger. There is not anything encryption specific. Having said that, in the current patch series I have been only focused on making it work from the gdbstub and HMP point of view. The debug=1 from gdbstub and HMP is tested on both encrypted and non-encrypted guest. If we decide to extend to support other callers (device model etc) then we may need to update memory load/store functions defined in memory_ldst_inc.c to work with debug=1. > By the way, I don't think this: > >> /* Access the guest memory for debug purposes */ >> #define MEMTXATTRS_DEBUG ((MemTxAttrs) { .debug = 1 }) > is a great idea. Callers that care about the transaction > attributes should just specify them properly. MEMTXATTRS_UNSPECIFIED > is a fallback for the large set of places that don't care at all. OK, I will drop the macro and update the patches in the series to set MemTxAttr.debug = 1 when we do debugger request. thanks --Brijesh
WARNING: multiple messages have this Message-ID (diff)
From: Brijesh Singh <brijesh.singh@amd.com> To: Peter Maydell <peter.maydell@linaro.org> Cc: brijesh.singh@amd.com, QEMU Developers <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@xilinx.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Daniel P . Berrange" <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>, kvm-devel <kvm@vger.kernel.org>, Marcel Apfelbaum <marcel@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Richard Henderson <richard.henderson@linaro.org>, Richard Henderson <rth@twiddle.net>, Stefan Hajnoczi <stefanha@gmail.com>, Thomas Lendacky <Thomas.Lendacky@amd.com>, Borislav Petkov <bp@suse.de> Subject: Re: [Qemu-devel] [PATCH v5 01/23] memattrs: add debug attribute Date: Fri, 8 Dec 2017 16:57:13 -0600 [thread overview] Message-ID: <053109e5-3b12-b76c-7d87-5f1e4941ebed@amd.com> (raw) In-Reply-To: <CAFEAcA_A9c3QMOJeHK+gyTpwkxo0hpkU9jhCdvQnpfbGBw+Wfg@mail.gmail.com> On 12/8/17 3:55 AM, Peter Maydell wrote: >> If you give me example on how >> to trigger this type of request with debug=1 then I can look into the code >> and see what we can do when memory encryption is enabled. The things like >> read-clears-bits semantics will be tricky. > The question was really whether we want to make this a general > indicator of "this operation was triggered by a debugger" and > expand that to mean "don't do things that mess with the state > of the simulation unexpectedly", or if this is really a very > encrypted-memory specific thing. It can be used as a generic indicator that operation was triggered by a debugger. There is not anything encryption specific. Having said that, in the current patch series I have been only focused on making it work from the gdbstub and HMP point of view. The debug=1 from gdbstub and HMP is tested on both encrypted and non-encrypted guest. If we decide to extend to support other callers (device model etc) then we may need to update memory load/store functions defined in memory_ldst_inc.c to work with debug=1. > By the way, I don't think this: > >> /* Access the guest memory for debug purposes */ >> #define MEMTXATTRS_DEBUG ((MemTxAttrs) { .debug = 1 }) > is a great idea. Callers that care about the transaction > attributes should just specify them properly. MEMTXATTRS_UNSPECIFIED > is a fallback for the large set of places that don't care at all. OK, I will drop the macro and update the patches in the series to set MemTxAttr.debug = 1 when we do debugger request. thanks --Brijesh
next prev parent reply other threads:[~2017-12-08 22:57 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-06 20:03 [PATCH v5 00/23] x86: Secure Encrypted Virtualization (AMD) Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 01/23] memattrs: add debug attribute Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 22:03 ` Peter Maydell 2017-12-06 22:03 ` [Qemu-devel] " Peter Maydell 2017-12-07 21:20 ` Brijesh Singh 2017-12-07 21:20 ` [Qemu-devel] " Brijesh Singh 2017-12-08 9:55 ` Peter Maydell 2017-12-08 9:55 ` [Qemu-devel] " Peter Maydell 2017-12-08 10:24 ` Edgar E. Iglesias 2017-12-08 10:24 ` [Qemu-devel] " Edgar E. Iglesias 2017-12-08 22:57 ` Brijesh Singh [this message] 2017-12-08 22:57 ` Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 02/23] exec: add ram_debug_ops support Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 03/23] exec: add debug version of physical memory read and write API Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 04/23] monitor/i386: use debug APIs when accessing guest memory Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 05/23] target/i386: add memory encryption feature cpuid support Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 06/23] machine: add -memory-encryption property Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 07/23] kvm: update kvm.h to include memory encryption ioctls Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 08/23] docs: add AMD Secure Encrypted Virtualization (SEV) Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 09/23] accel: add Secure Encrypted Virtulization (SEV) object Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 10/23] sev: add command to initialize the memory encryption context Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 11/23] sev: register the guest memory range which may contain encrypted data Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 12/23] kvm: introduce memory encryption APIs Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 13/23] hmp: display memory encryption support in 'info kvm' Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 14/23] sev: add command to create launch memory encryption context Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 15/23] sev: add command to encrypt guest memory region Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 16/23] target/i386: encrypt bios rom Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 17/23] qapi: add SEV_MEASUREMENT event Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 18/23] sev: emit the " Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 19/23] sev: Finalize the SEV guest launch flow Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 20/23] hw: i386: set ram_debug_ops when memory encryption is enabled Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 21/23] sev: add debug encrypt and decrypt commands Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 22/23] target/i386: clear C-bit when walking SEV guest page table Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 23/23] sev: add migration blocker Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-07 11:03 ` Dr. David Alan Gilbert 2017-12-07 11:03 ` [Qemu-devel] " Dr. David Alan Gilbert 2017-12-07 11:10 ` Peter Maydell 2017-12-07 11:10 ` [Qemu-devel] " Peter Maydell 2017-12-07 11:27 ` Dr. David Alan Gilbert 2017-12-07 11:27 ` [Qemu-devel] " Dr. David Alan Gilbert 2017-12-07 21:25 ` Brijesh Singh 2017-12-07 21:25 ` [Qemu-devel] " Brijesh Singh 2017-12-07 22:50 ` Brijesh Singh 2017-12-07 22:50 ` [Qemu-devel] " Brijesh Singh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=053109e5-3b12-b76c-7d87-5f1e4941ebed@amd.com \ --to=brijesh.singh@amd.com \ --cc=alistair.francis@xilinx.com \ --cc=armbru@redhat.com \ --cc=berrange@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=cornelia.huck@de.ibm.com \ --cc=crosthwaite.peter@gmail.com \ --cc=dgilbert@redhat.com \ --cc=eblake@redhat.com \ --cc=edgar.iglesias@xilinx.com \ --cc=ehabkost@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=marcel@redhat.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=rth@twiddle.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.