From: Brijesh Singh <brijesh.singh@amd.com> To: qemu-devel@nongnu.org Cc: Alistair Francis <alistair.francis@xilinx.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Daniel P . Berrange" <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Edgar E . Iglesias " <edgar.iglesias@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>, kvm@vger.kernel.org, Marcel Apfelbaum <marcel@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, Richard Henderson <rth@twiddle.net>, Stefan Hajnoczi <stefanha@gmail.com>, Thomas Lendacky < Subject: [PATCH v5 00/23] x86: Secure Encrypted Virtualization (AMD) Date: Wed, 6 Dec 2017 14:03:23 -0600 [thread overview] Message-ID: <20171206200346.116537-1-brijesh.singh@amd.com> (raw) This patch series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. The SEV feature allows the memory contents of a virtual machine (VM) to be transparently encrypted with a key unique to the guest VM. The memory controller contains a high performance encryption engine which can be programmed with multiple keys for use by a different VMs in the system. The programming and management of these keys is handled by the AMD Secure Processor firmware which exposes a commands for these tasks. The KVM SEV patch series [1] introduced a new ioctl (KVM_MEMORY_ENCRYPTION_OP) which is used by qemu to issue the SEV commands to assist performing common hypervisor activities such as a launching, running, snapshooting, migration and debugging guests. The following links provide additional details: AMD Memory Encryption whitepaper: http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_Encryption_Whitepaper_v7-Public.pdf AMD64 Architecture Programmer's Manual: http://support.amd.com/TechDocs/24593.pdf SME is section 7.10 SEV is section 15.34 Secure Encrypted Virutualization Key Management: http://support.amd.com/TechDocs/55766_SEV-KM API_Specification.pdf KVM Forum slides: http://www.linux-kvm.org/images/7/74/02x08A-Thomas_Lendacky-AMDs_Virtualizatoin_Memory_Encryption_Technology.pdf KVM RFC link: [1] https://marc.info/?l=linux-kernel&m=151243663119420&w=2 Video of the KVM Forum Talk: https://www.youtube.com/watch?v=RcvQ1xN55Ew --- Using these patches we have succesfully booted and tested a guest both with and without SEV enabled. TODO: * Add SEV guest migration support * Add SEV guest snapshot and restore support Changes since v4: - extend sev-guest object to add new properties 'dh-cert-file', 'session-file' etc. - emit SEV_MEASUREMENT event when measurement is available - add migration blocker - add memory encryption cpuid support - rebase the series with recent qemu tree Changes since v3: - update to newer SEV spec (0.12 -> 0.14) - update to newer KVM RFC and use KVM_MEMORY_ENCRYPTION_OP ioctl instead of KVM_ISSUE_SEV. - add support to encrypt plfash Changes since v2: - rename ram_ops to ram_debug_ops - use '-' rather than '_' when adding new member in KvmInfo struct - update sev object to use link properties when referencing other objects - use ldq_phys_debug in tlb_info_64 and mem_info_64. - remove sev-guest-policy object, we will revisit it after basic SEV guest support is merged. - remove kernel API from doc and add SEV guest LAUNCH model. The doc will be updated as we integerate the remaining SEV APIs. Changes since v1: - Added Documentation - Added security-policy object. - Drop sev config parsing support and create new objects to get/set SEV specific parameters - Added sev-guest-info object. - Added sev-launch-info object. - Added kvm_memory_encrytion_* APIs. The idea behind this was to allow adding a non SEV memory encrytion object without modifying interfaces. - Drop patch to load OS image at fixed location. - updated LAUNCH_FINISH command structure. Now the structure contains just 'measurement' field. Other fields are not used and will also be removed from newer SEV firmware API spec. Brijesh Singh (23): memattrs: add debug attribute exec: add ram_debug_ops support exec: add debug version of physical memory read and write API monitor/i386: use debug APIs when accessing guest memory target/i386: define memory encryption cpuid support machine: add -memory-encryption property kvm: update kvm.h to include memory encryption ioctls docs: add AMD Secure Encrypted Virtualization (SEV) accel: add Secure Encrypted Virtulization (SEV) object sev: add command to initialize the memory encryption context sev: register the guest memory range which may contain encrypted data kvm: introduce memory encryption APIs hmp: display memory encryption support in 'info kvm' sev: add command to create launch memory encryption context sev: add command to encrypt guest memory region target/i386: encrypt bios rom qapi: add SEV_MEASUREMENT event sev: emit the SEV_MEASUREMENT event sev: Finalize the SEV guest launch flow hw: i386: set ram_debug_ops when memory encryption is enabled sev: add debug encrypt and decrypt commands target/i386: clear C-bit when walking SEV guest page table sev: add migration blocker accel/kvm/Makefile.objs | 2 +- accel/kvm/kvm-all.c | 48 +++ accel/kvm/sev.c | 641 +++++++++++++++++++++++++++++++++++++++++ accel/stubs/kvm-stub.c | 14 + cpus.c | 2 +- disas.c | 2 +- docs/amd-memory-encryption.txt | 109 +++++++ exec.c | 96 +++++- hmp.c | 2 + hw/core/machine.c | 22 ++ hw/i386/pc.c | 9 + hw/i386/pc_sysfw.c | 19 ++ include/exec/cpu-common.h | 15 + include/exec/memattrs.h | 4 + include/exec/memory.h | 27 ++ include/hw/boards.h | 1 + include/sysemu/kvm.h | 25 ++ include/sysemu/sev.h | 77 +++++ linux-headers/linux/kvm.h | 90 ++++++ monitor.c | 2 +- qapi-schema.json | 18 +- qemu-options.hx | 36 +++ qmp.c | 1 + target/i386/cpu.c | 38 ++- target/i386/cpu.h | 6 + target/i386/helper.c | 46 ++- target/i386/monitor.c | 145 ++++++---- 27 files changed, 1409 insertions(+), 88 deletions(-) create mode 100644 accel/kvm/sev.c create mode 100644 docs/amd-memory-encryption.txt create mode 100644 include/sysemu/sev.h -- 2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Brijesh Singh <brijesh.singh@amd.com> To: qemu-devel@nongnu.org Cc: Alistair Francis <alistair.francis@xilinx.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Daniel P . Berrange" <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Edgar E . Iglesias " <edgar.iglesias@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>, kvm@vger.kernel.org, Marcel Apfelbaum <marcel@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, Richard Henderson <rth@twiddle.net>, Stefan Hajnoczi <stefanha@gmail.com>, Thomas Lendacky <Thomas.Lendacky@amd.com>, Borislav Petkov <bp@suse.de>, Brijesh Singh <brijesh.singh@amd.com> Subject: [Qemu-devel] [PATCH v5 00/23] x86: Secure Encrypted Virtualization (AMD) Date: Wed, 6 Dec 2017 14:03:23 -0600 [thread overview] Message-ID: <20171206200346.116537-1-brijesh.singh@amd.com> (raw) This patch series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. The SEV feature allows the memory contents of a virtual machine (VM) to be transparently encrypted with a key unique to the guest VM. The memory controller contains a high performance encryption engine which can be programmed with multiple keys for use by a different VMs in the system. The programming and management of these keys is handled by the AMD Secure Processor firmware which exposes a commands for these tasks. The KVM SEV patch series [1] introduced a new ioctl (KVM_MEMORY_ENCRYPTION_OP) which is used by qemu to issue the SEV commands to assist performing common hypervisor activities such as a launching, running, snapshooting, migration and debugging guests. The following links provide additional details: AMD Memory Encryption whitepaper: http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_Encryption_Whitepaper_v7-Public.pdf AMD64 Architecture Programmer's Manual: http://support.amd.com/TechDocs/24593.pdf SME is section 7.10 SEV is section 15.34 Secure Encrypted Virutualization Key Management: http://support.amd.com/TechDocs/55766_SEV-KM API_Specification.pdf KVM Forum slides: http://www.linux-kvm.org/images/7/74/02x08A-Thomas_Lendacky-AMDs_Virtualizatoin_Memory_Encryption_Technology.pdf KVM RFC link: [1] https://marc.info/?l=linux-kernel&m=151243663119420&w=2 Video of the KVM Forum Talk: https://www.youtube.com/watch?v=RcvQ1xN55Ew --- Using these patches we have succesfully booted and tested a guest both with and without SEV enabled. TODO: * Add SEV guest migration support * Add SEV guest snapshot and restore support Changes since v4: - extend sev-guest object to add new properties 'dh-cert-file', 'session-file' etc. - emit SEV_MEASUREMENT event when measurement is available - add migration blocker - add memory encryption cpuid support - rebase the series with recent qemu tree Changes since v3: - update to newer SEV spec (0.12 -> 0.14) - update to newer KVM RFC and use KVM_MEMORY_ENCRYPTION_OP ioctl instead of KVM_ISSUE_SEV. - add support to encrypt plfash Changes since v2: - rename ram_ops to ram_debug_ops - use '-' rather than '_' when adding new member in KvmInfo struct - update sev object to use link properties when referencing other objects - use ldq_phys_debug in tlb_info_64 and mem_info_64. - remove sev-guest-policy object, we will revisit it after basic SEV guest support is merged. - remove kernel API from doc and add SEV guest LAUNCH model. The doc will be updated as we integerate the remaining SEV APIs. Changes since v1: - Added Documentation - Added security-policy object. - Drop sev config parsing support and create new objects to get/set SEV specific parameters - Added sev-guest-info object. - Added sev-launch-info object. - Added kvm_memory_encrytion_* APIs. The idea behind this was to allow adding a non SEV memory encrytion object without modifying interfaces. - Drop patch to load OS image at fixed location. - updated LAUNCH_FINISH command structure. Now the structure contains just 'measurement' field. Other fields are not used and will also be removed from newer SEV firmware API spec. Brijesh Singh (23): memattrs: add debug attribute exec: add ram_debug_ops support exec: add debug version of physical memory read and write API monitor/i386: use debug APIs when accessing guest memory target/i386: define memory encryption cpuid support machine: add -memory-encryption property kvm: update kvm.h to include memory encryption ioctls docs: add AMD Secure Encrypted Virtualization (SEV) accel: add Secure Encrypted Virtulization (SEV) object sev: add command to initialize the memory encryption context sev: register the guest memory range which may contain encrypted data kvm: introduce memory encryption APIs hmp: display memory encryption support in 'info kvm' sev: add command to create launch memory encryption context sev: add command to encrypt guest memory region target/i386: encrypt bios rom qapi: add SEV_MEASUREMENT event sev: emit the SEV_MEASUREMENT event sev: Finalize the SEV guest launch flow hw: i386: set ram_debug_ops when memory encryption is enabled sev: add debug encrypt and decrypt commands target/i386: clear C-bit when walking SEV guest page table sev: add migration blocker accel/kvm/Makefile.objs | 2 +- accel/kvm/kvm-all.c | 48 +++ accel/kvm/sev.c | 641 +++++++++++++++++++++++++++++++++++++++++ accel/stubs/kvm-stub.c | 14 + cpus.c | 2 +- disas.c | 2 +- docs/amd-memory-encryption.txt | 109 +++++++ exec.c | 96 +++++- hmp.c | 2 + hw/core/machine.c | 22 ++ hw/i386/pc.c | 9 + hw/i386/pc_sysfw.c | 19 ++ include/exec/cpu-common.h | 15 + include/exec/memattrs.h | 4 + include/exec/memory.h | 27 ++ include/hw/boards.h | 1 + include/sysemu/kvm.h | 25 ++ include/sysemu/sev.h | 77 +++++ linux-headers/linux/kvm.h | 90 ++++++ monitor.c | 2 +- qapi-schema.json | 18 +- qemu-options.hx | 36 +++ qmp.c | 1 + target/i386/cpu.c | 38 ++- target/i386/cpu.h | 6 + target/i386/helper.c | 46 ++- target/i386/monitor.c | 145 ++++++---- 27 files changed, 1409 insertions(+), 88 deletions(-) create mode 100644 accel/kvm/sev.c create mode 100644 docs/amd-memory-encryption.txt create mode 100644 include/sysemu/sev.h -- 2.9.5
next reply other threads:[~2017-12-06 20:04 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-06 20:03 Brijesh Singh [this message] 2017-12-06 20:03 ` [Qemu-devel] [PATCH v5 00/23] x86: Secure Encrypted Virtualization (AMD) Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 01/23] memattrs: add debug attribute Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 22:03 ` Peter Maydell 2017-12-06 22:03 ` [Qemu-devel] " Peter Maydell 2017-12-07 21:20 ` Brijesh Singh 2017-12-07 21:20 ` [Qemu-devel] " Brijesh Singh 2017-12-08 9:55 ` Peter Maydell 2017-12-08 9:55 ` [Qemu-devel] " Peter Maydell 2017-12-08 10:24 ` Edgar E. Iglesias 2017-12-08 10:24 ` [Qemu-devel] " Edgar E. Iglesias 2017-12-08 22:57 ` Brijesh Singh 2017-12-08 22:57 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 02/23] exec: add ram_debug_ops support Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 03/23] exec: add debug version of physical memory read and write API Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 04/23] monitor/i386: use debug APIs when accessing guest memory Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 05/23] target/i386: add memory encryption feature cpuid support Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 06/23] machine: add -memory-encryption property Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 07/23] kvm: update kvm.h to include memory encryption ioctls Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 08/23] docs: add AMD Secure Encrypted Virtualization (SEV) Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 09/23] accel: add Secure Encrypted Virtulization (SEV) object Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 10/23] sev: add command to initialize the memory encryption context Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 11/23] sev: register the guest memory range which may contain encrypted data Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 12/23] kvm: introduce memory encryption APIs Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 13/23] hmp: display memory encryption support in 'info kvm' Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 14/23] sev: add command to create launch memory encryption context Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 15/23] sev: add command to encrypt guest memory region Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 16/23] target/i386: encrypt bios rom Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 17/23] qapi: add SEV_MEASUREMENT event Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 18/23] sev: emit the " Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 19/23] sev: Finalize the SEV guest launch flow Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 20/23] hw: i386: set ram_debug_ops when memory encryption is enabled Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 21/23] sev: add debug encrypt and decrypt commands Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 22/23] target/i386: clear C-bit when walking SEV guest page table Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-06 20:03 ` [PATCH v5 23/23] sev: add migration blocker Brijesh Singh 2017-12-06 20:03 ` [Qemu-devel] " Brijesh Singh 2017-12-07 11:03 ` Dr. David Alan Gilbert 2017-12-07 11:03 ` [Qemu-devel] " Dr. David Alan Gilbert 2017-12-07 11:10 ` Peter Maydell 2017-12-07 11:10 ` [Qemu-devel] " Peter Maydell 2017-12-07 11:27 ` Dr. David Alan Gilbert 2017-12-07 11:27 ` [Qemu-devel] " Dr. David Alan Gilbert 2017-12-07 21:25 ` Brijesh Singh 2017-12-07 21:25 ` [Qemu-devel] " Brijesh Singh 2017-12-07 22:50 ` Brijesh Singh 2017-12-07 22:50 ` [Qemu-devel] " Brijesh Singh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171206200346.116537-1-brijesh.singh@amd.com \ --to=brijesh.singh@amd.com \ --cc=alistair.francis@xilinx.com \ --cc=armbru@redhat.com \ --cc=berrange@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=cornelia.huck@de.ibm.com \ --cc=crosthwaite.peter@gmail.com \ --cc=dgilbert@redhat.com \ --cc=eblake@redhat.com \ --cc=edgar.iglesias@xilinx.com \ --cc=ehabkost@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=marcel@redhat.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=rth@twiddle.net \ --cc=stefanha@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.