From: "Andreas Färber" <afaerber@suse.de>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org
Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier
Date: Wed, 1 May 2019 22:20:44 +0200 [thread overview]
Message-ID: <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> (raw)
In-Reply-To: <20190501070707.GA5619@nishad>
+ linux-actions
Am 01.05.19 um 09:07 schrieb Nishad Kamdar:
> This patch corrects the SPDX License Identifier style
> in header files related to Clock Drivers for Actions Semi Socs.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used)
[...]
> drivers/clk/actions/owl-common.h | 2 +-
> drivers/clk/actions/owl-composite.h | 2 +-
> drivers/clk/actions/owl-divider.h | 2 +-
> drivers/clk/actions/owl-factor.h | 2 +-
> drivers/clk/actions/owl-fixed-factor.h | 2 +-
> drivers/clk/actions/owl-gate.h | 2 +-
> drivers/clk/actions/owl-mux.h | 2 +-
> drivers/clk/actions/owl-pll.h | 2 +-
> drivers/clk/actions/owl-reset.h | 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
Where's the practical benefit of this patch? These are all private
headers used from C files, so they can handle C++ comments just fine,
otherwise we would've seen build failures.
I could understand if you were patching files in include/ but not here.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Joe Perches" <joe@perches.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier
Date: Wed, 1 May 2019 22:20:44 +0200 [thread overview]
Message-ID: <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> (raw)
In-Reply-To: <20190501070707.GA5619@nishad>
+ linux-actions
Am 01.05.19 um 09:07 schrieb Nishad Kamdar:
> This patch corrects the SPDX License Identifier style
> in header files related to Clock Drivers for Actions Semi Socs.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used)
[...]
> drivers/clk/actions/owl-common.h | 2 +-
> drivers/clk/actions/owl-composite.h | 2 +-
> drivers/clk/actions/owl-divider.h | 2 +-
> drivers/clk/actions/owl-factor.h | 2 +-
> drivers/clk/actions/owl-fixed-factor.h | 2 +-
> drivers/clk/actions/owl-gate.h | 2 +-
> drivers/clk/actions/owl-mux.h | 2 +-
> drivers/clk/actions/owl-pll.h | 2 +-
> drivers/clk/actions/owl-reset.h | 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
Where's the practical benefit of this patch? These are all private
headers used from C files, so they can handle C++ comments just fine,
otherwise we would've seen build failures.
I could understand if you were patching files in include/ but not here.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-01 20:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 7:07 [PATCH] clk: actions: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-05-01 7:07 ` Nishad Kamdar
2019-05-01 20:02 ` Stephen Boyd
2019-05-01 20:20 ` Andreas Färber [this message]
2019-05-01 20:20 ` Andreas Färber
2019-05-02 7:07 ` Greg Kroah-Hartman
2019-05-02 7:07 ` Greg Kroah-Hartman
2019-05-02 10:25 ` Andreas Färber
2019-05-02 10:25 ` Andreas Färber
2019-05-02 10:38 ` Greg Kroah-Hartman
2019-05-02 10:38 ` Greg Kroah-Hartman
2019-05-02 10:45 ` Andreas Färber
2019-05-02 10:45 ` Andreas Färber
2019-05-02 11:28 ` Greg Kroah-Hartman
2019-05-02 11:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de \
--to=afaerber@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=nishadkamdar@gmail.com \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.