From: "Drokin, Oleg" <oleg.drokin@intel.com> To: Joe Perches <joe@perches.com>, James Simmons <jsimmons@infradead.org> Cc: "<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>, "<lustre-devel@lists.lustre.org>" <lustre-devel@lists.lustre.org> Subject: Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Date: Fri, 1 Apr 2016 14:23:03 +0000 [thread overview] Message-ID: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> (raw) In-Reply-To: <cover.1459515208.git.joe@perches.com> On Apr 1, 2016, at 9:02 AM, Joe Perches wrote: > Question about removing lustre typedefs. > > Various bits of lustre code use a mix of struct foo and foo_t. > > When would be an appropriate time to submit patches similar to > below that individually remove various typedefs from lustre code? I think now is as good time as any. the only small correction is those are LNet typedefs. While LNet is technically part of Lustre, it's a bit of a separate thing useful without Lustre too. I know James is working on cleaning up LNet, but I don't know if he has anything this would be conflicting at this moment or not. Thanks for the patches. I wonder if you are generating them automatically? Because it would be great if it also fixes the alignment issues due to longer definitions, like: --- a/drivers/staging/lustre/lnet/lnet/router_proc.c +++ b/drivers/staging/lustre/lnet/lnet/router_proc.c @@ -307,7 +307,7 @@ static int proc_lnet_routers(struct ctl_table *table, int write, r = the_lnet.ln_routers.next; while (r != &the_lnet.ln_routers) { - lnet_peer_t *lp = list_entry(r, lnet_peer_t, + struct lnet_peer *lp = list_entry(r, struct lnet_peer, lp_rtr_list); that would need a separate patch to fix later. > > These are pretty trivial to produce and verify so there's no > particular hurry to do them now but applying them will require > resync points for active and actually useful developers. > > A few scripted examples are done: > > Joe Perches (3): > staging: lustre: Remove typedef lnet_peer_t > staging: lustre: Remove typedef lnd_t > staging: lustre: Remove typedef lnet_msg_t > > .../staging/lustre/include/linux/lnet/lib-lnet.h | 62 +++++++-------- > .../staging/lustre/include/linux/lnet/lib-types.h | 22 +++--- > .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 +- > .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 6 +- > .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 8 +- > .../staging/lustre/lnet/klnds/socklnd/socklnd.c | 2 +- > .../staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 +- > .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 6 +- > drivers/staging/lustre/lnet/lnet/api-ni.c | 16 ++-- > drivers/staging/lustre/lnet/lnet/lib-move.c | 92 +++++++++++----------- > drivers/staging/lustre/lnet/lnet/lib-msg.c | 24 +++--- > drivers/staging/lustre/lnet/lnet/lib-ptl.c | 4 +- > drivers/staging/lustre/lnet/lnet/lo.c | 8 +- > drivers/staging/lustre/lnet/lnet/peer.c | 30 +++---- > drivers/staging/lustre/lnet/lnet/router.c | 28 +++---- > drivers/staging/lustre/lnet/lnet/router_proc.c | 4 +- > 16 files changed, 161 insertions(+), 161 deletions(-) > > -- > 2.8.0.rc4.16.g56331f8 > > _______________________________________________ > lustre-devel mailing list > lustre-devel@lists.lustre.org > http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
WARNING: multiple messages have this Message-ID (diff)
From: Drokin, Oleg <oleg.drokin@intel.com> To: Joe Perches <joe@perches.com>, James Simmons <jsimmons@infradead.org> Cc: "<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>, "<lustre-devel@lists.lustre.org>" <lustre-devel@lists.lustre.org> Subject: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Date: Fri, 1 Apr 2016 14:23:03 +0000 [thread overview] Message-ID: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> (raw) In-Reply-To: <cover.1459515208.git.joe@perches.com> On Apr 1, 2016, at 9:02 AM, Joe Perches wrote: > Question about removing lustre typedefs. > > Various bits of lustre code use a mix of struct foo and foo_t. > > When would be an appropriate time to submit patches similar to > below that individually remove various typedefs from lustre code? I think now is as good time as any. the only small correction is those are LNet typedefs. While LNet is technically part of Lustre, it's a bit of a separate thing useful without Lustre too. I know James is working on cleaning up LNet, but I don't know if he has anything this would be conflicting at this moment or not. Thanks for the patches. I wonder if you are generating them automatically? Because it would be great if it also fixes the alignment issues due to longer definitions, like: --- a/drivers/staging/lustre/lnet/lnet/router_proc.c +++ b/drivers/staging/lustre/lnet/lnet/router_proc.c @@ -307,7 +307,7 @@ static int proc_lnet_routers(struct ctl_table *table, int write, r = the_lnet.ln_routers.next; while (r != &the_lnet.ln_routers) { - lnet_peer_t *lp = list_entry(r, lnet_peer_t, + struct lnet_peer *lp = list_entry(r, struct lnet_peer, lp_rtr_list); that would need a separate patch to fix later. > > These are pretty trivial to produce and verify so there's no > particular hurry to do them now but applying them will require > resync points for active and actually useful developers. > > A few scripted examples are done: > > Joe Perches (3): > staging: lustre: Remove typedef lnet_peer_t > staging: lustre: Remove typedef lnd_t > staging: lustre: Remove typedef lnet_msg_t > > .../staging/lustre/include/linux/lnet/lib-lnet.h | 62 +++++++-------- > .../staging/lustre/include/linux/lnet/lib-types.h | 22 +++--- > .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 +- > .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 6 +- > .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 8 +- > .../staging/lustre/lnet/klnds/socklnd/socklnd.c | 2 +- > .../staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 +- > .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 6 +- > drivers/staging/lustre/lnet/lnet/api-ni.c | 16 ++-- > drivers/staging/lustre/lnet/lnet/lib-move.c | 92 +++++++++++----------- > drivers/staging/lustre/lnet/lnet/lib-msg.c | 24 +++--- > drivers/staging/lustre/lnet/lnet/lib-ptl.c | 4 +- > drivers/staging/lustre/lnet/lnet/lo.c | 8 +- > drivers/staging/lustre/lnet/lnet/peer.c | 30 +++---- > drivers/staging/lustre/lnet/lnet/router.c | 28 +++---- > drivers/staging/lustre/lnet/lnet/router_proc.c | 4 +- > 16 files changed, 161 insertions(+), 161 deletions(-) > > -- > 2.8.0.rc4.16.g56331f8 > > _______________________________________________ > lustre-devel mailing list > lustre-devel at lists.lustre.org > http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
next prev parent reply other threads:[~2016-04-01 14:23 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-01 13:02 [RFC PATCH 0/3] staging: lustre: detypedef Joe Perches 2016-04-01 13:02 ` [lustre-devel] " Joe Perches 2016-04-01 13:02 ` [RFC PATCH 1/3] staging: lustre: Remove typedef lnet_peer_t Joe Perches 2016-04-01 13:02 ` [lustre-devel] " Joe Perches 2016-04-01 13:02 ` [RFC PATCH 2/3] staging: lustre: Remove typedef lnd_t Joe Perches 2016-04-01 13:02 ` [lustre-devel] " Joe Perches 2016-04-01 13:02 ` [RFC PATCH 3/3] staging: lustre: Remove typedef lnet_msg_t Joe Perches 2016-04-01 13:02 ` [lustre-devel] " Joe Perches 2016-04-01 14:23 ` Drokin, Oleg [this message] 2016-04-01 14:23 ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Drokin, Oleg 2016-04-01 18:44 ` Joe Perches 2016-04-01 18:44 ` Joe Perches 2016-04-01 19:14 ` Drokin, Oleg 2016-04-01 19:14 ` Drokin, Oleg 2016-04-01 19:27 ` Joe Perches 2016-04-01 19:27 ` Joe Perches 2016-04-01 19:56 ` James Simmons 2016-04-01 19:56 ` James Simmons 2016-04-01 20:03 ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypede James Simmons 2016-04-01 20:03 ` James Simmons 2016-04-01 19:56 ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef James Simmons 2016-04-01 19:56 ` James Simmons 2016-04-01 19:57 ` James Simmons 2016-04-01 19:57 ` James Simmons 2016-04-01 19:57 ` James Simmons 2016-04-01 19:57 ` James Simmons 2016-04-01 19:59 ` James Simmons 2016-04-01 19:59 ` James Simmons 2016-04-01 15:58 ` Simmons, James A. 2016-04-01 15:58 ` Simmons, James A. 2016-04-01 18:54 ` Joe Perches 2016-04-01 18:54 ` Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com \ --to=oleg.drokin@intel.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=joe@perches.com \ --cc=jsimmons@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lustre-devel@lists.lustre.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.