All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: linux-kernel@vger.kernel.org
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org
Subject: [RFC PATCH 0/3] staging: lustre: detypedef
Date: Fri,  1 Apr 2016 06:02:08 -0700	[thread overview]
Message-ID: <cover.1459515208.git.joe@perches.com> (raw)

Question about removing lustre typedefs.

Various bits of lustre code use a mix of struct foo and foo_t.

When would be an appropriate time to submit patches similar to
below that individually remove various typedefs from lustre code?

These are pretty trivial to produce and verify so there's no
particular hurry to do them now but applying them will require
resync points for active and actually useful developers.

A few scripted examples are done:

Joe Perches (3):
  staging: lustre: Remove typedef lnet_peer_t
  staging: lustre: Remove typedef lnd_t
  staging: lustre: Remove typedef lnet_msg_t

 .../staging/lustre/include/linux/lnet/lib-lnet.h   | 62 +++++++--------
 .../staging/lustre/include/linux/lnet/lib-types.h  | 22 +++---
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c    |  4 +-
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h    |  6 +-
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c |  8 +-
 .../staging/lustre/lnet/klnds/socklnd/socklnd.c    |  2 +-
 .../staging/lustre/lnet/klnds/socklnd/socklnd.h    |  6 +-
 .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c |  6 +-
 drivers/staging/lustre/lnet/lnet/api-ni.c          | 16 ++--
 drivers/staging/lustre/lnet/lnet/lib-move.c        | 92 +++++++++++-----------
 drivers/staging/lustre/lnet/lnet/lib-msg.c         | 24 +++---
 drivers/staging/lustre/lnet/lnet/lib-ptl.c         |  4 +-
 drivers/staging/lustre/lnet/lnet/lo.c              |  8 +-
 drivers/staging/lustre/lnet/lnet/peer.c            | 30 +++----
 drivers/staging/lustre/lnet/lnet/router.c          | 28 +++----
 drivers/staging/lustre/lnet/lnet/router_proc.c     |  4 +-
 16 files changed, 161 insertions(+), 161 deletions(-)

-- 
2.8.0.rc4.16.g56331f8

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: linux-kernel@vger.kernel.org
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org
Subject: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef
Date: Fri,  1 Apr 2016 06:02:08 -0700	[thread overview]
Message-ID: <cover.1459515208.git.joe@perches.com> (raw)

Question about removing lustre typedefs.

Various bits of lustre code use a mix of struct foo and foo_t.

When would be an appropriate time to submit patches similar to
below that individually remove various typedefs from lustre code?

These are pretty trivial to produce and verify so there's no
particular hurry to do them now but applying them will require
resync points for active and actually useful developers.

A few scripted examples are done:

Joe Perches (3):
  staging: lustre: Remove typedef lnet_peer_t
  staging: lustre: Remove typedef lnd_t
  staging: lustre: Remove typedef lnet_msg_t

 .../staging/lustre/include/linux/lnet/lib-lnet.h   | 62 +++++++--------
 .../staging/lustre/include/linux/lnet/lib-types.h  | 22 +++---
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c    |  4 +-
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h    |  6 +-
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c |  8 +-
 .../staging/lustre/lnet/klnds/socklnd/socklnd.c    |  2 +-
 .../staging/lustre/lnet/klnds/socklnd/socklnd.h    |  6 +-
 .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c |  6 +-
 drivers/staging/lustre/lnet/lnet/api-ni.c          | 16 ++--
 drivers/staging/lustre/lnet/lnet/lib-move.c        | 92 +++++++++++-----------
 drivers/staging/lustre/lnet/lnet/lib-msg.c         | 24 +++---
 drivers/staging/lustre/lnet/lnet/lib-ptl.c         |  4 +-
 drivers/staging/lustre/lnet/lnet/lo.c              |  8 +-
 drivers/staging/lustre/lnet/lnet/peer.c            | 30 +++----
 drivers/staging/lustre/lnet/lnet/router.c          | 28 +++----
 drivers/staging/lustre/lnet/lnet/router_proc.c     |  4 +-
 16 files changed, 161 insertions(+), 161 deletions(-)

-- 
2.8.0.rc4.16.g56331f8

             reply	other threads:[~2016-04-01 13:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 13:02 Joe Perches [this message]
2016-04-01 13:02 ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Joe Perches
2016-04-01 13:02 ` [RFC PATCH 1/3] staging: lustre: Remove typedef lnet_peer_t Joe Perches
2016-04-01 13:02   ` [lustre-devel] " Joe Perches
2016-04-01 13:02 ` [RFC PATCH 2/3] staging: lustre: Remove typedef lnd_t Joe Perches
2016-04-01 13:02   ` [lustre-devel] " Joe Perches
2016-04-01 13:02 ` [RFC PATCH 3/3] staging: lustre: Remove typedef lnet_msg_t Joe Perches
2016-04-01 13:02   ` [lustre-devel] " Joe Perches
2016-04-01 14:23 ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Drokin, Oleg
2016-04-01 14:23   ` Drokin, Oleg
2016-04-01 18:44   ` Joe Perches
2016-04-01 18:44     ` Joe Perches
2016-04-01 19:14     ` Drokin, Oleg
2016-04-01 19:14       ` Drokin, Oleg
2016-04-01 19:27       ` Joe Perches
2016-04-01 19:27         ` Joe Perches
2016-04-01 19:56     ` James Simmons
2016-04-01 19:56       ` James Simmons
2016-04-01 20:03       ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypede James Simmons
2016-04-01 20:03         ` James Simmons
2016-04-01 19:56     ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef James Simmons
2016-04-01 19:56       ` James Simmons
2016-04-01 19:57     ` James Simmons
2016-04-01 19:57       ` James Simmons
2016-04-01 19:57     ` James Simmons
2016-04-01 19:57       ` James Simmons
2016-04-01 19:59     ` James Simmons
2016-04-01 19:59       ` James Simmons
2016-04-01 15:58 ` Simmons, James A.
2016-04-01 15:58   ` Simmons, James A.
2016-04-01 18:54   ` Joe Perches
2016-04-01 18:54     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1459515208.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.