All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: "'Eric Dumazet'" <eric.dumazet@gmail.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Alexey Kuznetsov" <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Vlad Yasevich" <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
	syzkaller <syzkaller@googlegroups.com>,
	Kostya Serebryany <kcc@google.com>,
	"Alexander Potapenko" <glider@google.com>,
	Sasha Levin <sasha.levin@oracle.com>
Subject: RE: [PATCH net] ipv6: sctp: clone options to avoid use after free
Date: Wed, 9 Dec 2015 15:49:27 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBE9A61@AcuExch.aculab.com> (raw)
In-Reply-To: <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 665 bytes --]

> SCTP is lacking proper np->opt cloning at accept() time.
> 
> TCP and DCCP use ipv6_dup_options() helper, do the same in SCTP.
> 
> We might later factorize this code in a common helper to avoid
> future mistakes.

I'm wondering what the real impact of this and the other recent
SCTP bugs/patches is on real workloads?
We have enough trouble getting our customers to use kernels
later that the 2.6.18 based RHEL5 - without having to persuade
them to use kernels that contain very recent fixes.

	David

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Eric Dumazet' <eric.dumazet@gmail.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Alexey Kuznetsov" <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Vlad Yasevich" <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
	syzkaller <syzkaller@googlegroups.com>,
	Kostya Serebryany <kcc@google.com>,
	"Alexander Potapenko" <glider@google.com>,
	Sasha Levin <sasha.levin@oracle.com>
Subject: RE: [PATCH net] ipv6: sctp: clone options to avoid use after free
Date: Wed, 9 Dec 2015 15:49:27 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBE9A61@AcuExch.aculab.com> (raw)
In-Reply-To: <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com>

> SCTP is lacking proper np->opt cloning at accept() time.
> 
> TCP and DCCP use ipv6_dup_options() helper, do the same in SCTP.
> 
> We might later factorize this code in a common helper to avoid
> future mistakes.

I'm wondering what the real impact of this and the other recent
SCTP bugs/patches is on real workloads?
We have enough trouble getting our customers to use kernels
later that the 2.6.18 based RHEL5 - without having to persuade
them to use kernels that contain very recent fixes.

	David


WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Eric Dumazet' <eric.dumazet@gmail.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
	syzkaller <syzkaller@googlegroups.com>,
	Kostya Serebryany <kcc@google.com>,
	Alexander Potapenko <glider@google.com>,
	Sasha Levin <sasha.levin@oracle.com>
Subject: RE: [PATCH net] ipv6: sctp: clone options to avoid use after free
Date: Wed, 09 Dec 2015 15:49:27 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBE9A61@AcuExch.aculab.com> (raw)
In-Reply-To: <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com>

PiBTQ1RQIGlzIGxhY2tpbmcgcHJvcGVyIG5wLT5vcHQgY2xvbmluZyBhdCBhY2NlcHQoKSB0aW1l
Lg0KPiANCj4gVENQIGFuZCBEQ0NQIHVzZSBpcHY2X2R1cF9vcHRpb25zKCkgaGVscGVyLCBkbyB0
aGUgc2FtZSBpbiBTQ1RQLg0KPiANCj4gV2UgbWlnaHQgbGF0ZXIgZmFjdG9yaXplIHRoaXMgY29k
ZSBpbiBhIGNvbW1vbiBoZWxwZXIgdG8gYXZvaWQNCj4gZnV0dXJlIG1pc3Rha2VzLg0KDQpJJ20g
d29uZGVyaW5nIHdoYXQgdGhlIHJlYWwgaW1wYWN0IG9mIHRoaXMgYW5kIHRoZSBvdGhlciByZWNl
bnQNClNDVFAgYnVncy9wYXRjaGVzIGlzIG9uIHJlYWwgd29ya2xvYWRzPw0KV2UgaGF2ZSBlbm91
Z2ggdHJvdWJsZSBnZXR0aW5nIG91ciBjdXN0b21lcnMgdG8gdXNlIGtlcm5lbHMNCmxhdGVyIHRo
YXQgdGhlIDIuNi4xOCBiYXNlZCBSSEVMNSAtIHdpdGhvdXQgaGF2aW5nIHRvIHBlcnN1YWRlDQp0
aGVtIHRvIHVzZSBrZXJuZWxzIHRoYXQgY29udGFpbiB2ZXJ5IHJlY2VudCBmaXhlcy4NCg0KCURh
dmlkDQoNCg=

  parent reply	other threads:[~2015-12-09 15:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 14:15 use-after-free in inet6_destroy_sock Dmitry Vyukov
2015-12-09 14:15 ` Dmitry Vyukov
2015-12-09 14:43 ` Eric Dumazet
2015-12-09 14:43   ` Eric Dumazet
2015-12-09 14:59   ` Marcelo Ricardo Leitner
2015-12-09 14:59     ` Marcelo Ricardo Leitner
2015-12-09 15:09     ` Eric Dumazet
2015-12-09 15:09       ` Eric Dumazet
2015-12-09 15:25       ` [PATCH net] ipv6: sctp: clone options to avoid use after free Eric Dumazet
2015-12-09 15:25         ` Eric Dumazet
2015-12-09 15:34         ` Vlad Yasevich
2015-12-09 15:34           ` Vlad Yasevich
2015-12-09 15:49         ` David Laight [this message]
2015-12-09 15:49           ` David Laight
2015-12-09 15:49           ` David Laight
2015-12-09 15:59           ` Eric Dumazet
2015-12-09 15:59             ` Eric Dumazet
2015-12-09 16:31             ` David Laight
2015-12-09 16:31               ` David Laight
2015-12-09 16:31               ` David Laight
2015-12-09 17:11               ` Marcelo Ricardo Leitner
2015-12-09 17:11                 ` Marcelo Ricardo Leitner
2015-12-09 19:19                 ` Daniel Borkmann
2015-12-09 19:19                   ` Daniel Borkmann
2015-12-10 12:26                   ` David Laight
2015-12-10 12:26                     ` David Laight
2015-12-10 12:26                     ` David Laight
2015-12-10 15:58                     ` Eric Dumazet
2015-12-10 15:58                       ` Eric Dumazet
2015-12-10 17:27                       ` David Laight
2015-12-10 17:27                         ` David Laight
2015-12-10 17:27                         ` David Laight
2015-12-12  1:19         ` David Miller
2015-12-12  1:19           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=063D6719AE5E284EB5DD2968C1650D6D1CBE9A61@AcuExch.aculab.com \
    --to=david.laight@aculab.com \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=glider@google.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kcc@google.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=sasha.levin@oracle.com \
    --cc=syzkaller@googlegroups.com \
    --cc=vyasevich@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.