All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: edumazet@google.com, marcelo.leitner@gmail.com,
	dvyukov@google.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, vyasevich@gmail.com,
	nhorman@tuxdriver.com, linux-sctp@vger.kernel.org,
	syzkaller@googlegroups.com, kcc@google.com, glider@google.com,
	sasha.levin@oracle.com
Subject: Re: [PATCH net] ipv6: sctp: clone options to avoid use after free
Date: Fri, 11 Dec 2015 20:19:16 -0500 (EST)	[thread overview]
Message-ID: <20151211.201916.1656429874143124778.davem@davemloft.net> (raw)
In-Reply-To: <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 09 Dec 2015 07:25:06 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> SCTP is lacking proper np->opt cloning at accept() time.
> 
> TCP and DCCP use ipv6_dup_options() helper, do the same
> in SCTP.
> 
> We might later factorize this code in a common helper to avoid
> future mistakes.
> 
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied and queued up for -stable, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: edumazet@google.com, marcelo.leitner@gmail.com,
	dvyukov@google.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, vyasevich@gmail.com,
	nhorman@tuxdriver.com, linux-sctp@vger.kernel.org,
	syzkaller@googlegroups.com, kcc@google.com, glider@google.com,
	sasha.levin@oracle.com
Subject: Re: [PATCH net] ipv6: sctp: clone options to avoid use after free
Date: Sat, 12 Dec 2015 01:19:16 +0000	[thread overview]
Message-ID: <20151211.201916.1656429874143124778.davem@davemloft.net> (raw)
In-Reply-To: <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 09 Dec 2015 07:25:06 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> SCTP is lacking proper np->opt cloning at accept() time.
> 
> TCP and DCCP use ipv6_dup_options() helper, do the same
> in SCTP.
> 
> We might later factorize this code in a common helper to avoid
> future mistakes.
> 
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied and queued up for -stable, thanks.

  parent reply	other threads:[~2015-12-12  1:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 14:15 use-after-free in inet6_destroy_sock Dmitry Vyukov
2015-12-09 14:15 ` Dmitry Vyukov
2015-12-09 14:43 ` Eric Dumazet
2015-12-09 14:43   ` Eric Dumazet
2015-12-09 14:59   ` Marcelo Ricardo Leitner
2015-12-09 14:59     ` Marcelo Ricardo Leitner
2015-12-09 15:09     ` Eric Dumazet
2015-12-09 15:09       ` Eric Dumazet
2015-12-09 15:25       ` [PATCH net] ipv6: sctp: clone options to avoid use after free Eric Dumazet
2015-12-09 15:25         ` Eric Dumazet
2015-12-09 15:34         ` Vlad Yasevich
2015-12-09 15:34           ` Vlad Yasevich
2015-12-09 15:49         ` David Laight
2015-12-09 15:49           ` David Laight
2015-12-09 15:49           ` David Laight
2015-12-09 15:59           ` Eric Dumazet
2015-12-09 15:59             ` Eric Dumazet
2015-12-09 16:31             ` David Laight
2015-12-09 16:31               ` David Laight
2015-12-09 16:31               ` David Laight
2015-12-09 17:11               ` Marcelo Ricardo Leitner
2015-12-09 17:11                 ` Marcelo Ricardo Leitner
2015-12-09 19:19                 ` Daniel Borkmann
2015-12-09 19:19                   ` Daniel Borkmann
2015-12-10 12:26                   ` David Laight
2015-12-10 12:26                     ` David Laight
2015-12-10 12:26                     ` David Laight
2015-12-10 15:58                     ` Eric Dumazet
2015-12-10 15:58                       ` Eric Dumazet
2015-12-10 17:27                       ` David Laight
2015-12-10 17:27                         ` David Laight
2015-12-10 17:27                         ` David Laight
2015-12-12  1:19         ` David Miller [this message]
2015-12-12  1:19           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151211.201916.1656429874143124778.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=glider@google.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kcc@google.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=sasha.levin@oracle.com \
    --cc=syzkaller@googlegroups.com \
    --cc=vyasevich@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.