From: David Laight <David.Laight@ACULAB.COM>
To: "'Doug Berger'" <opendmb@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"rafal@milecki.pl" <rafal@milecki.pl>,
"xow@google.com" <xow@google.com>,
"joel@jms.id.au" <joel@jms.id.au>,
"jon.mason@broadcom.com" <jon.mason@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pgynther@google.com" <pgynther@google.com>,
"jaedon.shin@gmail.com" <jaedon.shin@gmail.com>
Subject: RE: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands
Date: Tue, 14 Mar 2017 11:04:54 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFB052E@AcuExch.aculab.com> (raw)
In-Reply-To: <20170314004142.4746-10-opendmb@gmail.com>
From: Doug Berger
> Sent: 14 March 2017 00:42
> This commit changes the ioctl handling behavior to return the
> EOPNOTSUPP error code instead of the EINVAL error code when an
> unknown ioctl command value is detected.
>
> It also removes some redundant parsing of the ioctl command value
> and allows the SIOCSHWTSTAMP value to be handled.
A better description would seem to be:
Remove checks on ioctl command and just forward all ioctl requests
to phy_mii_ioctl().
I also thought the 'generic' response to an unknown ioctl command
was ENOTTY.
David
next prev parent reply other threads:[~2017-03-14 11:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 0:41 [PATCH net-next 00/12] net: bcmgenet: add support for GENETv5 Doug Berger
2017-03-14 0:41 ` Doug Berger
2017-03-14 0:41 ` [PATCH net-next 01/12] net: phy: bcm-phylib: replace obsolete EEE macro references Doug Berger
2017-03-14 0:49 ` Florian Fainelli
2017-03-14 0:49 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY Doug Berger
2017-03-14 0:50 ` Florian Fainelli
2017-03-14 0:50 ` Florian Fainelli
2017-03-14 1:06 ` Andrew Lunn
2017-03-14 1:06 ` Andrew Lunn
2017-03-14 2:06 ` Doug Berger
2017-03-14 2:43 ` Andrew Lunn
2017-03-14 2:43 ` Andrew Lunn
2017-03-14 17:23 ` Doug Berger
2017-03-14 17:23 ` Doug Berger
2017-03-14 0:41 ` [PATCH net-next 03/12] net: bcmgenet: simplify circular pointer arithmetic Doug Berger
2017-03-14 0:54 ` Florian Fainelli
2017-03-14 0:54 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 04/12] net: bcmgenet: remove meaningless lines Doug Berger
2017-03-14 0:55 ` Florian Fainelli
2017-03-14 0:55 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 05/12] net: bcmgenet: manage dma interrupts in napi code Doug Berger
2017-03-14 0:55 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 06/12] net: bcmgenet: remove handling of wol interrupts from isr0 Doug Berger
2017-03-14 0:41 ` Doug Berger
2017-03-14 0:56 ` Florian Fainelli
2017-03-14 0:56 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 07/12] net: bcmgenet: clear status to reduce spurious interrupts Doug Berger
2017-03-14 0:56 ` Florian Fainelli
2017-03-14 0:56 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim Doug Berger
2017-03-14 0:57 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands Doug Berger
2017-03-14 0:57 ` Florian Fainelli
2017-03-14 11:04 ` David Laight [this message]
2017-03-14 17:31 ` Doug Berger
2017-03-14 0:41 ` [PATCH net-next 10/12] dt-bindings: net: document bcmgenet WoL interrupt Doug Berger
2017-03-14 0:58 ` Florian Fainelli
2017-03-14 0:58 ` Florian Fainelli
2017-03-20 22:09 ` Rob Herring
2017-03-20 22:09 ` Rob Herring
2017-03-14 0:41 ` [PATCH net-next 11/12] dt-bindings: net: update bcmgenet binding for GENETv5 Doug Berger
2017-03-14 0:58 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 12/12] net: bcmgenet: add support for the GENETv5 hardware Doug Berger
2017-03-14 0:59 ` Florian Fainelli
2017-03-14 0:59 ` Florian Fainelli
2017-03-14 4:53 ` [PATCH net-next 00/12] net: bcmgenet: add support for GENETv5 David Miller
2017-03-14 4:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6DCFFB052E@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=joel@jms.id.au \
--cc=jon.mason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pgynther@google.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=xow@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.