All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaofei Tan <tanxiaofei@huawei.com>
To: Johan Hovold <johan@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
	<linuxarm@openeuler.org>
Subject: Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments
Date: Fri, 21 May 2021 10:23:15 +0800	[thread overview]
Message-ID: <07453180-0aa4-e260-a50d-23d27973907b@huawei.com> (raw)
In-Reply-To: <YKZpi8cmH3mtXT99@hovoldconsulting.com>


Hi Johan,

On 2021/5/20 21:52, Johan Hovold wrote:
> On Thu, May 20, 2021 at 09:21:25PM +0800, Xiaofei Tan wrote:
>
>>> Checkpatch already has too many checks IMO and I'm a bit surprised that
>>> it doesn't check this already. Perhaps it's because you used the -f to
>>> run checkpatch on in-kernel code, which you should not.
>>>
>>>>> Second, that sentence is not capitalised so why do add a period?
>>>>>
>>>>
>>>> How about capitalize the sentence, or just remove the period ?
>>>
>>> How about just leaving this unchanged?
>>
>> OK
>> And I will keep the patch 8/9, and combine space issues into
>> one new patch, and remove the others.
>
> Yeah, 8/9 is arguably a fix even if it's for a very minor issue
> (repeated words in a comment).
>
> It doesn't look like any of the white space issues are worth fixing,
> though. Such pedantry can usually be addressed when the code in question
> is being modified for other reasons.
>

OK, it is reasonable. thanks.

> Johan
>
> .
>


WARNING: multiple messages have this Message-ID (diff)
From: Xiaofei Tan <tanxiaofei@huawei.com>
To: Johan Hovold <johan@kernel.org>
Cc: gregkh@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org,
	jirislaby@kernel.org, linux-kernel@vger.kernel.org,
	linuxarm@openeuler.org
Subject: Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments
Date: Fri, 21 May 2021 10:23:15 +0800	[thread overview]
Message-ID: <07453180-0aa4-e260-a50d-23d27973907b@huawei.com> (raw)
In-Reply-To: <YKZpi8cmH3mtXT99@hovoldconsulting.com>


Hi Johan,

On 2021/5/20 21:52, Johan Hovold wrote:
> On Thu, May 20, 2021 at 09:21:25PM +0800, Xiaofei Tan wrote:
>
>>> Checkpatch already has too many checks IMO and I'm a bit surprised that
>>> it doesn't check this already. Perhaps it's because you used the -f to
>>> run checkpatch on in-kernel code, which you should not.
>>>
>>>>> Second, that sentence is not capitalised so why do add a period?
>>>>>
>>>>
>>>> How about capitalize the sentence, or just remove the period ?
>>>
>>> How about just leaving this unchanged?
>>
>> OK
>> And I will keep the patch 8/9, and combine space issues into
>> one new patch, and remove the others.
>
> Yeah, 8/9 is arguably a fix even if it's for a very minor issue
> (repeated words in a comment).
>
> It doesn't look like any of the white space issues are worth fixing,
> though. Such pedantry can usually be addressed when the code in question
> is being modified for other reasons.
>

OK, it is reasonable. thanks.

> Johan
>
> .
>


  reply	other threads:[~2021-05-21  2:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  6:37 [PATCH 0/9] tty: hvc_console: Fix some coding style issues Xiaofei Tan
2021-05-17  6:37 ` Xiaofei Tan
2021-05-17  6:37 ` [PATCH 1/9] tty: hvc_console: Fix spaces required around that '=' Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-17  6:37 ` [PATCH 2/9] tty: hvc_console: Fix "foo * bar" should be "foo *bar" Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-17  6:37 ` [PATCH 3/9] tty: hvc_console: Remove trailing whitespace Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-17  6:37 ` [PATCH 4/9] tty: hvc_console: Fix issues of code indent should use tabs Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-17  6:37 ` [PATCH 5/9] tty: hvc_console: Delete spaces prohibited around open parenthesis '(' and ')' Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-17  6:37 ` [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-17 14:15   ` Johan Hovold
2021-05-17 14:15     ` Johan Hovold
2021-05-18  4:01     ` Xiaofei Tan
2021-05-18  4:01       ` Xiaofei Tan
2021-05-20  8:21       ` Johan Hovold
2021-05-20  8:21         ` Johan Hovold
2021-05-20 13:21         ` Xiaofei Tan
2021-05-20 13:21           ` Xiaofei Tan
2021-05-20 13:52           ` Johan Hovold
2021-05-20 13:52             ` Johan Hovold
2021-05-21  2:23             ` Xiaofei Tan [this message]
2021-05-21  2:23               ` Xiaofei Tan
2021-05-20 15:21         ` Joe Perches
2021-05-20 15:21           ` Joe Perches
2021-05-21  8:44           ` Johan Hovold
2021-05-21  8:44             ` Johan Hovold
2021-05-17  6:37 ` [PATCH 7/9] tty: hvc_console: Add a blank line after declarations Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-17  6:37 ` [PATCH 8/9] tty: hvc_console: Remove the repeated words 'no' and 'from' Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-17  6:37 ` [PATCH 9/9] tty: hvc_console: Move open brace { on the previous line Xiaofei Tan
2021-05-17  6:37   ` Xiaofei Tan
2021-05-20 15:11 ` [PATCH 0/9] tty: hvc_console: Fix some coding style issues Greg KH
2021-05-20 15:11   ` Greg KH
2021-05-21  2:18   ` Xiaofei Tan
2021-05-21  2:18     ` Xiaofei Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07453180-0aa4-e260-a50d-23d27973907b@huawei.com \
    --to=tanxiaofei@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.