From: Jens Axboe <axboe@kernel.dk> To: Arnd Bergmann <arnd@arndb.de> Cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>, linux-aio <linux-aio@kvack.org>, linux-block <linux-block@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Christoph Hellwig <hch@lst.de>, Jeff Moyer <jmoyer@redhat.com>, Avi Kivity <avi@scylladb.com> Subject: Re: [PATCH 13/16] io_uring: add support for pre-mapped user IO buffers Date: Wed, 16 Jan 2019 08:14:17 -0700 [thread overview] Message-ID: <075af26b-c685-a0db-05e4-fa73f8725b8a@kernel.dk> (raw) In-Reply-To: <CAK8P3a3aTZ-VEc=uvOeYov4DiaBN1iNuhR41BfP0Qdf3AXx74w@mail.gmail.com> On 1/16/19 3:53 AM, Arnd Bergmann wrote: > On Tue, Jan 15, 2019 at 3:56 AM Jens Axboe <axboe@kernel.dk> wrote: > >> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h >> index 542757a4c898..e36c264d74e8 100644 >> --- a/include/linux/syscalls.h >> +++ b/include/linux/syscalls.h >> @@ -314,6 +314,8 @@ asmlinkage long sys_io_uring_setup(u32 entries, >> struct io_uring_params __user *p); >> asmlinkage long sys_io_uring_enter(unsigned int fd, u32 to_submit, >> u32 min_complete, u32 flags); >> +asmlinkage long sys_io_uring_register(unsigned int fd, unsigned op, >> + void __user *arg); >> > > Would it be possible to make this a typed pointer instead? If this needs to > be extended later to pass a different structure, a new system call may > be better for consistency than overloading the argument in various > ways. As you can see from the later patch for registering files, it'll be used for other structs too. Feels a little silly to add an extra system call for that. I agree the void * isn't the prettiest thing in the world, but at least it allows us to extend the API without having to add even more system calls down the line. >> + * io_uring_register(2) opcodes and arguments >> + */ >> +#define IORING_REGISTER_BUFFERS 0 >> +#define IORING_UNREGISTER_BUFFERS 1 >> + >> +struct io_uring_register_buffers { >> + union { >> + struct iovec *iovecs; >> + __u64 pad; >> + }; >> + __u32 nr_iovecs; >> +}; > > As before, I'd suggest making this structure compatible between 32-bit > and 64-bit architectectures, by avoiding pointer and implied padding > fields. I'll await an answer to my previous question on that. -- Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk> To: Arnd Bergmann <arnd@arndb.de> Cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>, linux-aio <linux-aio@kvack.org>, linux-block <linux-block@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Christoph Hellwig <hch@lst.de>, Jeff Moyer <jmoyer@redhat.com>, Avi Kivity <avi@scylladb.com> Subject: Re: [PATCH 13/16] io_uring: add support for pre-mapped user IO buffers Date: Wed, 16 Jan 2019 08:14:17 -0700 [thread overview] Message-ID: <075af26b-c685-a0db-05e4-fa73f8725b8a@kernel.dk> (raw) In-Reply-To: <CAK8P3a3aTZ-VEc=uvOeYov4DiaBN1iNuhR41BfP0Qdf3AXx74w@mail.gmail.com> On 1/16/19 3:53 AM, Arnd Bergmann wrote: > On Tue, Jan 15, 2019 at 3:56 AM Jens Axboe <axboe@kernel.dk> wrote: > >> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h >> index 542757a4c898..e36c264d74e8 100644 >> --- a/include/linux/syscalls.h >> +++ b/include/linux/syscalls.h >> @@ -314,6 +314,8 @@ asmlinkage long sys_io_uring_setup(u32 entries, >> struct io_uring_params __user *p); >> asmlinkage long sys_io_uring_enter(unsigned int fd, u32 to_submit, >> u32 min_complete, u32 flags); >> +asmlinkage long sys_io_uring_register(unsigned int fd, unsigned op, >> + void __user *arg); >> > > Would it be possible to make this a typed pointer instead? If this needs to > be extended later to pass a different structure, a new system call may > be better for consistency than overloading the argument in various > ways. As you can see from the later patch for registering files, it'll be used for other structs too. Feels a little silly to add an extra system call for that. I agree the void * isn't the prettiest thing in the world, but at least it allows us to extend the API without having to add even more system calls down the line. >> + * io_uring_register(2) opcodes and arguments >> + */ >> +#define IORING_REGISTER_BUFFERS 0 >> +#define IORING_UNREGISTER_BUFFERS 1 >> + >> +struct io_uring_register_buffers { >> + union { >> + struct iovec *iovecs; >> + __u64 pad; >> + }; >> + __u32 nr_iovecs; >> +}; > > As before, I'd suggest making this structure compatible between 32-bit > and 64-bit architectectures, by avoiding pointer and implied padding > fields. I'll await an answer to my previous question on that. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2019-01-16 15:14 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-15 2:55 (unknown), Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 01/16] fs: add an iopoll method to struct file_operations Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 02/16] block: wire up block device iopoll method Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 03/16] block: add bio_set_polled() helper Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 04/16] iomap: wire up the iopoll method Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 05/16] Add io_uring IO interface Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 16:51 ` Jonathan Corbet 2019-01-15 16:51 ` Jonathan Corbet 2019-01-15 16:55 ` Jens Axboe 2019-01-15 16:55 ` Jens Axboe 2019-01-15 17:26 ` Jens Axboe 2019-01-15 17:26 ` Jens Axboe 2019-01-16 10:41 ` Arnd Bergmann 2019-01-16 10:41 ` Arnd Bergmann 2019-01-16 11:00 ` Arnd Bergmann 2019-01-16 11:00 ` Arnd Bergmann 2019-01-16 15:12 ` Jens Axboe 2019-01-16 15:12 ` Jens Axboe 2019-01-16 15:16 ` Arnd Bergmann 2019-01-16 15:16 ` Arnd Bergmann 2019-01-16 15:25 ` Jens Axboe 2019-01-16 15:25 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 06/16] io_uring: add fsync support Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 07/16] io_uring: support for IO polling Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 08/16] io_uring: add submission side request cache Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 09/16] fs: add fget_many() and fput_many() Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 10/16] io_uring: use fget/fput_many() for file references Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 11/16] io_uring: batch io_kiocb allocation Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 12/16] block: implement bio helper to add iter bvec pages to bio Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 13/16] io_uring: add support for pre-mapped user IO buffers Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-16 10:53 ` Arnd Bergmann 2019-01-16 15:14 ` Jens Axboe [this message] 2019-01-16 15:14 ` Jens Axboe 2019-01-16 15:32 ` Jens Axboe 2019-01-16 15:32 ` Jens Axboe 2019-01-16 15:41 ` Arnd Bergmann 2019-01-16 15:47 ` Jens Axboe 2019-01-16 15:47 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 14/16] io_uring: add submission polling Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 15/16] io_uring: add file registration Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-16 10:45 ` Arnd Bergmann 2019-01-16 10:45 ` Arnd Bergmann 2019-01-16 15:15 ` Jens Axboe 2019-01-16 15:15 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 16/16] io_uring: add io_uring_event cache hit information Jens Axboe 2019-01-15 2:55 ` Jens Axboe -- strict thread matches above, loose matches on Subject: below -- 2019-01-12 21:29 [PATCHSET v3] io_uring IO interface Jens Axboe 2019-01-12 21:30 ` [PATCH 13/16] io_uring: add support for pre-mapped user IO buffers Jens Axboe 2019-01-12 21:30 ` Jens Axboe 2019-01-08 16:56 [PATCHSET v1] io_uring IO interface Jens Axboe 2019-01-08 16:56 ` [PATCH 13/16] io_uring: add support for pre-mapped user IO buffers Jens Axboe 2019-01-08 16:56 ` Jens Axboe 2019-01-09 12:16 ` Christoph Hellwig 2019-01-09 17:06 ` Jens Axboe 2019-01-09 17:06 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=075af26b-c685-a0db-05e4-fa73f8725b8a@kernel.dk \ --to=axboe@kernel.dk \ --cc=arnd@arndb.de \ --cc=avi@scylladb.com \ --cc=hch@lst.de \ --cc=jmoyer@redhat.com \ --cc=linux-aio@kvack.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.