From: Arnd Bergmann <arnd@arndb.de> To: Jens Axboe <axboe@kernel.dk> Cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>, linux-aio <linux-aio@kvack.org>, linux-block <linux-block@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Christoph Hellwig <hch@lst.de>, Jeff Moyer <jmoyer@redhat.com>, Avi Kivity <avi@scylladb.com> Subject: Re: [PATCH 05/16] Add io_uring IO interface Date: Wed, 16 Jan 2019 11:41:48 +0100 [thread overview] Message-ID: <CAK8P3a19ie7wcndDW7oxmUGh5c9aaarJycKBVOQ2F9+eHj=nsg@mail.gmail.com> (raw) In-Reply-To: <20190115025531.13985-6-axboe@kernel.dk> On Tue, Jan 15, 2019 at 3:55 AM Jens Axboe <axboe@kernel.dk> wrote: > > diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl > index 3cf7b533b3d1..194e79c0032e 100644 > --- a/arch/x86/entry/syscalls/syscall_32.tbl > +++ b/arch/x86/entry/syscalls/syscall_32.tbl > @@ -398,3 +398,5 @@ > 384 i386 arch_prctl sys_arch_prctl __ia32_compat_sys_arch_prctl > 385 i386 io_pgetevents sys_io_pgetevents __ia32_compat_sys_io_pgetevents > 386 i386 rseq sys_rseq __ia32_sys_rseq > +387 i386 io_uring_setup sys_io_uring_setup __ia32_compat_sys_io_uring_setup > +388 i386 io_uring_enter sys_io_uring_enter __ia32_sys_io_uring_enter > diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl > index f0b1709a5ffb..453ff7a79002 100644 > --- a/arch/x86/entry/syscalls/syscall_64.tbl > +++ b/arch/x86/entry/syscalls/syscall_64.tbl > @@ -343,6 +343,8 @@ > 332 common statx __x64_sys_statx > 333 common io_pgetevents __x64_sys_io_pgetevents > 334 common rseq __x64_sys_rseq > +335 common io_uring_setup __x64_sys_io_uring_setup > +336 common io_uring_enter __x64_sys_io_uring_enter In my series for the y2038 system calls, I'm trying to move to having the same numbers across all architectures. Unfortunately, that clashes with newly assigned numbers here, so one of us needs to pick new numbers. If my series gets merged without other changes to the numbers, the next available numbers on all architectures become 424 and 425. Could you use those here? > +SYSCALL_DEFINE2(io_uring_setup, u32, entries, > + struct io_uring_params __user *, params) > +{ > + return io_uring_setup(entries, params, false); > +} > + > +#ifdef CONFIG_COMPAT > +COMPAT_SYSCALL_DEFINE2(io_uring_setup, u32, entries, > + struct io_uring_params __user *, params) > +{ > + return io_uring_setup(entries, params, true); > +} > +#endif The compat syscall has the same calling conventions as the native one here, so I think you can just use that directly. > +/* > + * IO submission data structure (Submission Queue Entry) > + */ > +struct io_uring_sqe { > + __u8 opcode; /* type of operation for this sqe */ > + __u8 flags; /* as of now unused */ > + __u16 ioprio; /* ioprio for the request */ > + __s32 fd; /* file descriptor to do IO on */ > + __u64 off; /* offset into file */ > + union { > + void *addr; /* buffer or iovecs */ > + __u64 __pad; > + }; It seems a bit unfortunate to keep the pointer field only almost compatible between 32-bit and 64-bit big-endian architectures, as that requires an in_compat_syscall() check whenever we access the pointer from the kernel. Could you use a __u64 field to store the pointer itself instead? > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c > index ab9d0e3c6d50..ee5e523564bb 100644 > --- a/kernel/sys_ni.c > +++ b/kernel/sys_ni.c > @@ -46,6 +46,8 @@ COND_SYSCALL(io_getevents); > COND_SYSCALL(io_pgetevents); > COND_SYSCALL_COMPAT(io_getevents); > COND_SYSCALL_COMPAT(io_pgetevents); > +COND_SYSCALL(io_uring_setup); > +COND_SYSCALL(io_uring_enter); Unless you remove the compat_sys_io_uring_setup() definition, this should also have a corresponding COND_SYSCALL_COMPAT() entry. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: Jens Axboe <axboe@kernel.dk> Cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>, linux-aio <linux-aio@kvack.org>, linux-block <linux-block@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Christoph Hellwig <hch@lst.de>, Jeff Moyer <jmoyer@redhat.com>, Avi Kivity <avi@scylladb.com> Subject: Re: [PATCH 05/16] Add io_uring IO interface Date: Wed, 16 Jan 2019 11:41:48 +0100 [thread overview] Message-ID: <CAK8P3a19ie7wcndDW7oxmUGh5c9aaarJycKBVOQ2F9+eHj=nsg@mail.gmail.com> (raw) In-Reply-To: <20190115025531.13985-6-axboe@kernel.dk> On Tue, Jan 15, 2019 at 3:55 AM Jens Axboe <axboe@kernel.dk> wrote: > > diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl > index 3cf7b533b3d1..194e79c0032e 100644 > --- a/arch/x86/entry/syscalls/syscall_32.tbl > +++ b/arch/x86/entry/syscalls/syscall_32.tbl > @@ -398,3 +398,5 @@ > 384 i386 arch_prctl sys_arch_prctl __ia32_compat_sys_arch_prctl > 385 i386 io_pgetevents sys_io_pgetevents __ia32_compat_sys_io_pgetevents > 386 i386 rseq sys_rseq __ia32_sys_rseq > +387 i386 io_uring_setup sys_io_uring_setup __ia32_compat_sys_io_uring_setup > +388 i386 io_uring_enter sys_io_uring_enter __ia32_sys_io_uring_enter > diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl > index f0b1709a5ffb..453ff7a79002 100644 > --- a/arch/x86/entry/syscalls/syscall_64.tbl > +++ b/arch/x86/entry/syscalls/syscall_64.tbl > @@ -343,6 +343,8 @@ > 332 common statx __x64_sys_statx > 333 common io_pgetevents __x64_sys_io_pgetevents > 334 common rseq __x64_sys_rseq > +335 common io_uring_setup __x64_sys_io_uring_setup > +336 common io_uring_enter __x64_sys_io_uring_enter In my series for the y2038 system calls, I'm trying to move to having the same numbers across all architectures. Unfortunately, that clashes with newly assigned numbers here, so one of us needs to pick new numbers. If my series gets merged without other changes to the numbers, the next available numbers on all architectures become 424 and 425. Could you use those here? > +SYSCALL_DEFINE2(io_uring_setup, u32, entries, > + struct io_uring_params __user *, params) > +{ > + return io_uring_setup(entries, params, false); > +} > + > +#ifdef CONFIG_COMPAT > +COMPAT_SYSCALL_DEFINE2(io_uring_setup, u32, entries, > + struct io_uring_params __user *, params) > +{ > + return io_uring_setup(entries, params, true); > +} > +#endif The compat syscall has the same calling conventions as the native one here, so I think you can just use that directly. > +/* > + * IO submission data structure (Submission Queue Entry) > + */ > +struct io_uring_sqe { > + __u8 opcode; /* type of operation for this sqe */ > + __u8 flags; /* as of now unused */ > + __u16 ioprio; /* ioprio for the request */ > + __s32 fd; /* file descriptor to do IO on */ > + __u64 off; /* offset into file */ > + union { > + void *addr; /* buffer or iovecs */ > + __u64 __pad; > + }; It seems a bit unfortunate to keep the pointer field only almost compatible between 32-bit and 64-bit big-endian architectures, as that requires an in_compat_syscall() check whenever we access the pointer from the kernel. Could you use a __u64 field to store the pointer itself instead? > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c > index ab9d0e3c6d50..ee5e523564bb 100644 > --- a/kernel/sys_ni.c > +++ b/kernel/sys_ni.c > @@ -46,6 +46,8 @@ COND_SYSCALL(io_getevents); > COND_SYSCALL(io_pgetevents); > COND_SYSCALL_COMPAT(io_getevents); > COND_SYSCALL_COMPAT(io_pgetevents); > +COND_SYSCALL(io_uring_setup); > +COND_SYSCALL(io_uring_enter); Unless you remove the compat_sys_io_uring_setup() definition, this should also have a corresponding COND_SYSCALL_COMPAT() entry. Arnd -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2019-01-16 10:42 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-15 2:55 (unknown), Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 01/16] fs: add an iopoll method to struct file_operations Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 02/16] block: wire up block device iopoll method Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 03/16] block: add bio_set_polled() helper Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 04/16] iomap: wire up the iopoll method Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 05/16] Add io_uring IO interface Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 16:51 ` Jonathan Corbet 2019-01-15 16:51 ` Jonathan Corbet 2019-01-15 16:55 ` Jens Axboe 2019-01-15 16:55 ` Jens Axboe 2019-01-15 17:26 ` Jens Axboe 2019-01-15 17:26 ` Jens Axboe 2019-01-16 10:41 ` Arnd Bergmann [this message] 2019-01-16 10:41 ` Arnd Bergmann 2019-01-16 11:00 ` Arnd Bergmann 2019-01-16 11:00 ` Arnd Bergmann 2019-01-16 15:12 ` Jens Axboe 2019-01-16 15:12 ` Jens Axboe 2019-01-16 15:16 ` Arnd Bergmann 2019-01-16 15:16 ` Arnd Bergmann 2019-01-16 15:25 ` Jens Axboe 2019-01-16 15:25 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 06/16] io_uring: add fsync support Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 07/16] io_uring: support for IO polling Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 08/16] io_uring: add submission side request cache Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 09/16] fs: add fget_many() and fput_many() Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 10/16] io_uring: use fget/fput_many() for file references Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 11/16] io_uring: batch io_kiocb allocation Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 12/16] block: implement bio helper to add iter bvec pages to bio Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 13/16] io_uring: add support for pre-mapped user IO buffers Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-16 10:53 ` Arnd Bergmann 2019-01-16 15:14 ` Jens Axboe 2019-01-16 15:14 ` Jens Axboe 2019-01-16 15:32 ` Jens Axboe 2019-01-16 15:32 ` Jens Axboe 2019-01-16 15:41 ` Arnd Bergmann 2019-01-16 15:47 ` Jens Axboe 2019-01-16 15:47 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 14/16] io_uring: add submission polling Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 15/16] io_uring: add file registration Jens Axboe 2019-01-15 2:55 ` Jens Axboe 2019-01-16 10:45 ` Arnd Bergmann 2019-01-16 10:45 ` Arnd Bergmann 2019-01-16 15:15 ` Jens Axboe 2019-01-16 15:15 ` Jens Axboe 2019-01-15 2:55 ` [PATCH 16/16] io_uring: add io_uring_event cache hit information Jens Axboe 2019-01-15 2:55 ` Jens Axboe -- strict thread matches above, loose matches on Subject: below -- 2019-01-12 21:29 [PATCHSET v3] io_uring IO interface Jens Axboe 2019-01-12 21:30 ` [PATCH 05/16] Add " Jens Axboe 2019-01-12 21:30 ` Jens Axboe 2019-01-08 16:56 [PATCHSET v1] " Jens Axboe 2019-01-08 16:56 ` [PATCH 05/16] Add " Jens Axboe 2019-01-08 16:56 ` Jens Axboe 2019-01-09 12:10 ` Christoph Hellwig 2019-01-09 15:53 ` Jens Axboe 2019-01-09 15:53 ` Jens Axboe 2019-01-09 18:30 ` Christoph Hellwig 2019-01-09 18:30 ` Christoph Hellwig 2019-01-09 20:07 ` Jens Axboe 2019-01-09 20:07 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK8P3a19ie7wcndDW7oxmUGh5c9aaarJycKBVOQ2F9+eHj=nsg@mail.gmail.com' \ --to=arnd@arndb.de \ --cc=avi@scylladb.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=jmoyer@redhat.com \ --cc=linux-aio@kvack.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.