All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>,
	zohar@linux.ibm.com, jejb@linux.ibm.com
Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org,
	op-tee@lists.trustedfirmware.org, corbet@lwn.net,
	janne.karhunen@gmail.com, linux-doc@vger.kernel.org,
	jmorris@namei.org, linux-kernel@vger.kernel.org,
	dhowells@redhat.com, linux-security-module@vger.kernel.org,
	keyrings@vger.kernel.org, Markus.Wamser@mixed-mode.de,
	casey@schaufler-ca.com, linux-integrity@vger.kernel.org,
	jens.wiklander@linaro.org, linux-arm-kernel@lists.infradead.org,
	serge@hallyn.com
Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework
Date: Thu, 14 May 2020 00:25:14 +0000	[thread overview]
Message-ID: <07bb6080f8be9f6613f460e2d6e19f3d456e219c.camel@linux.intel.com> (raw)
In-Reply-To: <1588758017-30426-2-git-send-email-sumit.garg@linaro.org>

On Wed, 2020-05-06 at 15:10 +0530, Sumit Garg wrote:
> Current trusted keys framework is tightly coupled to use TPM device as
> an underlying implementation which makes it difficult for implementations
> like Trusted Execution Environment (TEE) etc. to provide trusked keys
> support in case platform doesn't posses a TPM device.
> 
> So this patch tries to add generic trusted keys framework where underlying
> implemtations like TPM, TEE etc. could be easily plugged-in.
> 
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

I tend to agree how this is implemented and could merge it as such.

I'm just thinking if we could refine this patch in a way that instead of
copying TRUSTED_DEBUG macro we could just replace pr_info() statements
with pr_debug()?

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>,
	zohar@linux.ibm.com, jejb@linux.ibm.com
Cc: dhowells@redhat.com, jens.wiklander@linaro.org, corbet@lwn.net,
	jmorris@namei.org, serge@hallyn.com, casey@schaufler-ca.com,
	janne.karhunen@gmail.com, daniel.thompson@linaro.org,
	Markus.Wamser@mixed-mode.de, keyrings@vger.kernel.org,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	op-tee@lists.trustedfirmware.org, tee-dev@lists.linaro.org
Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework
Date: Thu, 14 May 2020 03:25:14 +0300	[thread overview]
Message-ID: <07bb6080f8be9f6613f460e2d6e19f3d456e219c.camel@linux.intel.com> (raw)
In-Reply-To: <1588758017-30426-2-git-send-email-sumit.garg@linaro.org>

On Wed, 2020-05-06 at 15:10 +0530, Sumit Garg wrote:
> Current trusted keys framework is tightly coupled to use TPM device as
> an underlying implementation which makes it difficult for implementations
> like Trusted Execution Environment (TEE) etc. to provide trusked keys
> support in case platform doesn't posses a TPM device.
> 
> So this patch tries to add generic trusted keys framework where underlying
> implemtations like TPM, TEE etc. could be easily plugged-in.
> 
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

I tend to agree how this is implemented and could merge it as such.

I'm just thinking if we could refine this patch in a way that instead of
copying TRUSTED_DEBUG macro we could just replace pr_info() statements
with pr_debug()?

/Jarkko


WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>,
	zohar@linux.ibm.com, jejb@linux.ibm.com
Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org,
	op-tee@lists.trustedfirmware.org, corbet@lwn.net,
	janne.karhunen@gmail.com, linux-doc@vger.kernel.org,
	jmorris@namei.org, linux-kernel@vger.kernel.org,
	dhowells@redhat.com, linux-security-module@vger.kernel.org,
	keyrings@vger.kernel.org, Markus.Wamser@mixed-mode.de,
	casey@schaufler-ca.com, linux-integrity@vger.kernel.org,
	jens.wiklander@linaro.org, linux-arm-kernel@lists.infradead.org,
	serge@hallyn.com
Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework
Date: Thu, 14 May 2020 03:25:14 +0300	[thread overview]
Message-ID: <07bb6080f8be9f6613f460e2d6e19f3d456e219c.camel@linux.intel.com> (raw)
In-Reply-To: <1588758017-30426-2-git-send-email-sumit.garg@linaro.org>

On Wed, 2020-05-06 at 15:10 +0530, Sumit Garg wrote:
> Current trusted keys framework is tightly coupled to use TPM device as
> an underlying implementation which makes it difficult for implementations
> like Trusted Execution Environment (TEE) etc. to provide trusked keys
> support in case platform doesn't posses a TPM device.
> 
> So this patch tries to add generic trusted keys framework where underlying
> implemtations like TPM, TEE etc. could be easily plugged-in.
> 
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

I tend to agree how this is implemented and could merge it as such.

I'm just thinking if we could refine this patch in a way that instead of
copying TRUSTED_DEBUG macro we could just replace pr_info() statements
with pr_debug()?

/Jarkko


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-14  0:25 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  9:40 [PATCH v4 0/4] Introduce TEE based Trusted Keys support Sumit Garg
2020-05-06  9:52 ` Sumit Garg
2020-05-06  9:40 ` Sumit Garg
2020-05-06  9:40 ` [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework Sumit Garg
2020-05-06  9:52   ` Sumit Garg
2020-05-06  9:40   ` Sumit Garg
2020-05-14  0:25   ` Jarkko Sakkinen [this message]
2020-05-14  0:25     ` Jarkko Sakkinen
2020-05-14  0:25     ` Jarkko Sakkinen
2020-05-14 11:23     ` Sumit Garg
2020-05-14 11:35       ` Sumit Garg
2020-05-14 11:23       ` Sumit Garg
2020-05-15  0:00       ` Jarkko Sakkinen
2020-05-15  0:00         ` Jarkko Sakkinen
2020-05-15  0:00         ` Jarkko Sakkinen
2020-06-01  2:00   ` Jarkko Sakkinen
2020-06-01  2:00     ` Jarkko Sakkinen
2020-06-01  2:00     ` Jarkko Sakkinen
2020-06-01  8:50     ` Sumit Garg
2020-06-01  8:50       ` Sumit Garg
2020-06-01  8:50       ` Sumit Garg
2020-06-02  7:08       ` Jarkko Sakkinen
2020-06-02  7:08         ` Jarkko Sakkinen
2020-06-02  7:08         ` Jarkko Sakkinen
2020-06-01  2:11   ` Jarkko Sakkinen
2020-06-01  2:11     ` Jarkko Sakkinen
2020-06-01  2:11     ` Jarkko Sakkinen
2020-06-01  9:11     ` Sumit Garg
2020-06-01  9:23       ` Sumit Garg
2020-06-01  9:11       ` Sumit Garg
2020-06-02  7:14       ` Jarkko Sakkinen
2020-06-02  7:14         ` Jarkko Sakkinen
2020-06-02  7:14         ` Jarkko Sakkinen
2020-06-02  8:40         ` Sumit Garg
2020-06-02  8:52           ` Sumit Garg
2020-06-02  8:40           ` Sumit Garg
2020-05-06  9:40 ` [PATCH v4 2/4] KEYS: trusted: Introduce TEE based Trusted Keys Sumit Garg
2020-05-06  9:52   ` Sumit Garg
2020-05-06  9:40   ` Sumit Garg
2020-05-14  0:28   ` Jarkko Sakkinen
2020-05-14  0:28     ` Jarkko Sakkinen
2020-05-14  0:28     ` Jarkko Sakkinen
2020-05-14  7:27     ` Sumit Garg
2020-05-14  7:39       ` Sumit Garg
2020-05-14  7:27       ` Sumit Garg
2020-05-14 23:43       ` Jarkko Sakkinen
2020-05-14 23:43         ` Jarkko Sakkinen
2020-05-14 23:43         ` Jarkko Sakkinen
2020-05-06  9:40 ` [PATCH v4 3/4] doc: trusted-encrypted: updates with TEE as a new trust source Sumit Garg
2020-05-06  9:52   ` Sumit Garg
2020-05-06  9:40   ` Sumit Garg
2020-05-14  0:29   ` Jarkko Sakkinen
2020-05-14  0:29     ` Jarkko Sakkinen
2020-05-14  0:29     ` Jarkko Sakkinen
2020-05-06  9:40 ` [PATCH v4 4/4] MAINTAINERS: Add entry for TEE based Trusted Keys Sumit Garg
2020-05-06  9:52   ` Sumit Garg
2020-05-06  9:40   ` Sumit Garg
2020-05-14  0:35   ` Jarkko Sakkinen
2020-05-14  0:35     ` Jarkko Sakkinen
2020-05-14  0:35     ` Jarkko Sakkinen
2020-05-12  9:20 ` [PATCH v4 0/4] Introduce TEE based Trusted Keys support Sumit Garg
2020-05-12  9:32   ` Sumit Garg
2020-05-12  9:20   ` Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07bb6080f8be9f6613f460e2d6e19f3d456e219c.camel@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=Markus.Wamser@mixed-mode.de \
    --cc=casey@schaufler-ca.com \
    --cc=corbet@lwn.net \
    --cc=daniel.thompson@linaro.org \
    --cc=dhowells@redhat.com \
    --cc=janne.karhunen@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=jens.wiklander@linaro.org \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=serge@hallyn.com \
    --cc=sumit.garg@linaro.org \
    --cc=tee-dev@lists.linaro.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.