From: Juergen Gross <jgross@suse.com> To: Daniel Kiper <daniel.kiper@oracle.com> Cc: hans@knorrie.org, grub-devel@gnu.org, phcoder@gmail.com, xen-devel@lists.xen.org Subject: Re: [PATCH v4 10/19] xen: setup hypercall page for PVH Date: Tue, 20 Nov 2018 10:27:35 +0100 [thread overview] Message-ID: <0885fcf7-ce75-6457-d535-d44b2b86f7c4@suse.com> (raw) In-Reply-To: <20181109181249.GD4363@olila.i.net-space.pl> On 09/11/2018 19:12, Daniel Kiper wrote: > On Fri, Nov 02, 2018 at 01:37:29PM +0100, Juergen Gross wrote: >> Add the needed code to setup the hypercall page for calling into the >> Xen hypervisor. >> >> Signed-off-by: Juergen Gross <jgross@suse.com> >> --- >> V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) >> issue panic message (Roger Pau Monné) >> rewrite grub_xen_hypercall to avoid register variables (Daniel Kiper) >> --- >> grub-core/kern/i386/xen/pvh.c | 69 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 69 insertions(+) >> >> diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c >> index ac6181f4e..7e90a4538 100644 >> --- a/grub-core/kern/i386/xen/pvh.c >> +++ b/grub-core/kern/i386/xen/pvh.c >> @@ -20,14 +20,83 @@ >> #include <grub/misc.h> >> #include <grub/memory.h> >> #include <grub/mm.h> >> +#include <grub/i386/cpuid.h> >> +#include <grub/i386/io.h> >> #include <grub/xen.h> >> #include <grub/machine/kernel.h> >> >> +#define XEN_CONSOLE_PORT 0xe9 > > I think that this is not PVH specific thing. Could you move this to > more generic Xen header? > >> grub_uint64_t grub_rsdp_addr; > > Hmmm... It seems to me that immediately after patch #8 GRUB2 build is > broken. Is not it? No. xen-pvh isn't yet selectable. > >> +static char hypercall_page[GRUB_XEN_PAGE_SIZE] >> + __attribute__ ((aligned (GRUB_XEN_PAGE_SIZE))); >> + >> +static grub_uint32_t xen_cpuid_base; >> + >> +static void >> +grub_xen_panic (const char *msg) >> +{ >> + const char *c; >> + >> + for (c = msg; *c; c++) >> + grub_outb (*c, XEN_CONSOLE_PORT); >> + >> + asm volatile ("hlt"); > > Should not you do something similar to grub-core/lib/i386/halt.c:stop() here? Yes, as already replied to Roger. > >> +} >> + >> +static void >> +grub_xen_cpuid_base (void) >> +{ >> + grub_uint32_t base, eax, signature[3]; >> + >> + for (base = 0x40000000; base < 0x40010000; base += 0x100) >> + { >> + grub_cpuid (base, eax, signature[0], signature[1], signature[2]); >> + if (!grub_memcmp ("XenVMMXenVMM", signature, 12) && (eax - base) >= 2) >> + { >> + xen_cpuid_base = base; >> + return; >> + } >> + } >> + >> + grub_xen_panic ("Found no Xen signature.\n"); > > "Found no Xen signature!\nSystem halted!\n" > > Or maybe grub_xen_panic() should always add "System halted!\n". Okay (the latter). > >> +} >> + >> +static void >> +grub_xen_setup_hypercall_page (void) >> +{ >> + grub_uint32_t msr, pfn, eax, ebx, ecx, edx; >> + >> + grub_cpuid (xen_cpuid_base + 2, eax, ebx, ecx, edx); >> + msr = ebx; >> + pfn = (grub_uint32_t) (&hypercall_page[0]); > > Could not you use hypercall_page alone here? Hmm, yes. > >> + >> + asm volatile ("wrmsr" : : "c" (msr), "a" (pfn), "d" (0) : "memory"); >> +} >> + >> +int >> +grub_xen_hypercall (grub_uint32_t callno, grub_uint32_t a0, >> + grub_uint32_t a1, grub_uint32_t a2, >> + grub_uint32_t a3, grub_uint32_t a4, >> + grub_uint32_t a5 __attribute__ ((unused))) >> +{ >> + grub_uint32_t __res, __ign0, __ign1, __ign2, __ign3, __ign4; >> + >> + asm volatile ("call *%[callno]" >> + : "=a" (__res), "=b" (__ign0), "=c" (__ign1), "=d" (__ign2), >> + "=S" (__ign3), "=D" (__ign4) >> + : "1" (a0), "2" (a1), "3" (a2), "4" (a3), "5" (a4), > > I think that you can drop all __ign* variables if you specify proper > registers in input argument. If this does not work you can use "+" > modifier instead of "=" in the output argument. I'll have a try. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Juergen Gross <jgross@suse.com> To: Daniel Kiper <daniel.kiper@oracle.com> Cc: grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com, hans@knorrie.org Subject: Re: [PATCH v4 10/19] xen: setup hypercall page for PVH Date: Tue, 20 Nov 2018 10:27:35 +0100 [thread overview] Message-ID: <0885fcf7-ce75-6457-d535-d44b2b86f7c4@suse.com> (raw) In-Reply-To: <20181109181249.GD4363@olila.i.net-space.pl> On 09/11/2018 19:12, Daniel Kiper wrote: > On Fri, Nov 02, 2018 at 01:37:29PM +0100, Juergen Gross wrote: >> Add the needed code to setup the hypercall page for calling into the >> Xen hypervisor. >> >> Signed-off-by: Juergen Gross <jgross@suse.com> >> --- >> V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) >> issue panic message (Roger Pau Monné) >> rewrite grub_xen_hypercall to avoid register variables (Daniel Kiper) >> --- >> grub-core/kern/i386/xen/pvh.c | 69 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 69 insertions(+) >> >> diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c >> index ac6181f4e..7e90a4538 100644 >> --- a/grub-core/kern/i386/xen/pvh.c >> +++ b/grub-core/kern/i386/xen/pvh.c >> @@ -20,14 +20,83 @@ >> #include <grub/misc.h> >> #include <grub/memory.h> >> #include <grub/mm.h> >> +#include <grub/i386/cpuid.h> >> +#include <grub/i386/io.h> >> #include <grub/xen.h> >> #include <grub/machine/kernel.h> >> >> +#define XEN_CONSOLE_PORT 0xe9 > > I think that this is not PVH specific thing. Could you move this to > more generic Xen header? > >> grub_uint64_t grub_rsdp_addr; > > Hmmm... It seems to me that immediately after patch #8 GRUB2 build is > broken. Is not it? No. xen-pvh isn't yet selectable. > >> +static char hypercall_page[GRUB_XEN_PAGE_SIZE] >> + __attribute__ ((aligned (GRUB_XEN_PAGE_SIZE))); >> + >> +static grub_uint32_t xen_cpuid_base; >> + >> +static void >> +grub_xen_panic (const char *msg) >> +{ >> + const char *c; >> + >> + for (c = msg; *c; c++) >> + grub_outb (*c, XEN_CONSOLE_PORT); >> + >> + asm volatile ("hlt"); > > Should not you do something similar to grub-core/lib/i386/halt.c:stop() here? Yes, as already replied to Roger. > >> +} >> + >> +static void >> +grub_xen_cpuid_base (void) >> +{ >> + grub_uint32_t base, eax, signature[3]; >> + >> + for (base = 0x40000000; base < 0x40010000; base += 0x100) >> + { >> + grub_cpuid (base, eax, signature[0], signature[1], signature[2]); >> + if (!grub_memcmp ("XenVMMXenVMM", signature, 12) && (eax - base) >= 2) >> + { >> + xen_cpuid_base = base; >> + return; >> + } >> + } >> + >> + grub_xen_panic ("Found no Xen signature.\n"); > > "Found no Xen signature!\nSystem halted!\n" > > Or maybe grub_xen_panic() should always add "System halted!\n". Okay (the latter). > >> +} >> + >> +static void >> +grub_xen_setup_hypercall_page (void) >> +{ >> + grub_uint32_t msr, pfn, eax, ebx, ecx, edx; >> + >> + grub_cpuid (xen_cpuid_base + 2, eax, ebx, ecx, edx); >> + msr = ebx; >> + pfn = (grub_uint32_t) (&hypercall_page[0]); > > Could not you use hypercall_page alone here? Hmm, yes. > >> + >> + asm volatile ("wrmsr" : : "c" (msr), "a" (pfn), "d" (0) : "memory"); >> +} >> + >> +int >> +grub_xen_hypercall (grub_uint32_t callno, grub_uint32_t a0, >> + grub_uint32_t a1, grub_uint32_t a2, >> + grub_uint32_t a3, grub_uint32_t a4, >> + grub_uint32_t a5 __attribute__ ((unused))) >> +{ >> + grub_uint32_t __res, __ign0, __ign1, __ign2, __ign3, __ign4; >> + >> + asm volatile ("call *%[callno]" >> + : "=a" (__res), "=b" (__ign0), "=c" (__ign1), "=d" (__ign2), >> + "=S" (__ign3), "=D" (__ign4) >> + : "1" (a0), "2" (a1), "3" (a2), "4" (a3), "5" (a4), > > I think that you can drop all __ign* variables if you specify proper > registers in input argument. If this does not work you can use "+" > modifier instead of "=" in the output argument. I'll have a try. Juergen
next prev parent reply other threads:[~2018-11-20 9:27 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-02 12:37 [PATCH v4 00/19] xen: add pvh guest support Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 01/19] xen: add some xen headers Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 02/19] loader/linux: support passing rsdp address via boot params Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-07 11:36 ` Daniel Kiper 2018-11-07 11:36 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 03/19] xen: carve out grant tab initialization into dedicated function Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 04/19] xen: prepare common code for Xen PVH support Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-07 12:10 ` Daniel Kiper 2018-11-07 12:10 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 05/19] xen: add some dummy headers for PVH mode Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-07 12:21 ` Daniel Kiper 2018-11-07 12:21 ` Daniel Kiper 2018-11-07 14:49 ` Juergen Gross 2018-11-08 15:36 ` Daniel Kiper 2018-11-08 15:36 ` Daniel Kiper 2018-11-08 15:40 ` Juergen Gross 2018-11-08 15:40 ` Juergen Gross 2018-11-07 14:49 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 06/19] xen: rearrange xen/init.c to prepare it for Xen " Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 07/19] xen: add PVH specific defines to offset.h Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-07 12:27 ` Daniel Kiper 2018-11-07 12:27 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 08/19] xen: add basic hooks for PVH in current code Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-08 15:45 ` Daniel Kiper 2018-11-08 19:23 ` [Xen-devel] " Juergen Gross 2018-11-09 17:55 ` Daniel Kiper 2018-11-09 17:55 ` Daniel Kiper 2018-11-08 19:23 ` Juergen Gross 2018-11-08 15:45 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 09/19] xen: add PVH boot entry code Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-08 15:53 ` Daniel Kiper 2018-11-08 15:53 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 10/19] xen: setup hypercall page for PVH Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 18:12 ` Daniel Kiper 2018-11-09 18:12 ` Daniel Kiper 2018-11-20 9:27 ` Juergen Gross [this message] 2018-11-20 9:27 ` Juergen Gross 2018-11-21 13:58 ` Juergen Gross 2018-11-21 13:58 ` [Xen-devel] " Juergen Gross 2018-11-15 8:33 ` Roger Pau Monné 2018-11-20 9:16 ` Juergen Gross 2018-11-20 9:16 ` Juergen Gross 2018-11-15 8:33 ` Roger Pau Monné 2018-11-02 12:37 ` [PATCH v4 11/19] xen: get memory map from hypervisor " Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 18:35 ` Daniel Kiper 2018-11-09 18:35 ` Daniel Kiper 2018-11-15 9:36 ` [Xen-devel] " Roger Pau Monné 2018-11-21 8:52 ` Juergen Gross 2018-11-21 8:52 ` Juergen Gross 2018-11-15 9:36 ` Roger Pau Monné 2018-11-02 12:37 ` [PATCH v4 12/19] xen: add PCI MMIO areas to memory map Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 19:14 ` Daniel Kiper 2018-11-14 12:49 ` Roger Pau Monné 2018-11-14 12:49 ` [Xen-devel] " Roger Pau Monné 2018-11-14 15:30 ` Daniel Kiper 2018-11-14 15:30 ` Daniel Kiper 2018-11-09 19:14 ` Daniel Kiper 2018-11-14 12:48 ` Roger Pau Monné 2018-11-14 12:48 ` [Xen-devel] " Roger Pau Monné 2018-11-21 9:02 ` Juergen Gross 2018-11-21 9:02 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 13/19] xen: setup Xen specific data for PVH Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 19:47 ` Daniel Kiper 2018-11-09 19:47 ` Daniel Kiper 2018-11-15 10:03 ` [Xen-devel] " Roger Pau Monné 2018-11-21 9:07 ` Juergen Gross 2018-11-21 9:07 ` Juergen Gross 2018-11-15 10:03 ` Roger Pau Monné 2018-11-02 12:37 ` [PATCH v4 14/19] xen: init memory regions " Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 19:56 ` Daniel Kiper 2018-11-09 19:56 ` Daniel Kiper 2018-11-15 10:07 ` Roger Pau Monné 2018-11-15 10:07 ` [Xen-devel] " Roger Pau Monné 2018-11-02 12:37 ` [PATCH v4 15/19] xen_pvh: add build runes for grub-core Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 16/19] grub-module-verifier: Ignore all_video for xenpvh Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 17/19] xen_pvh: support building a standalone image Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 20:06 ` Daniel Kiper 2018-11-09 20:06 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 18/19] xen_pvh: support grub-install for xen_pvh Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 19/19] xen_pvh: add support to configure Juergen Gross 2018-11-02 12:37 ` Juergen Gross
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0885fcf7-ce75-6457-d535-d44b2b86f7c4@suse.com \ --to=jgross@suse.com \ --cc=daniel.kiper@oracle.com \ --cc=grub-devel@gnu.org \ --cc=hans@knorrie.org \ --cc=phcoder@gmail.com \ --cc=xen-devel@lists.xen.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.