From: Juergen Gross <jgross@suse.com> To: grub-devel@gnu.org Cc: hans@knorrie.org, phcoder@gmail.com, daniel.kiper@oracle.com, Juergen Gross <jgross@suse.com>, xen-devel@lists.xen.org Subject: [PATCH v4 06/19] xen: rearrange xen/init.c to prepare it for Xen PVH mode Date: Fri, 2 Nov 2018 13:37:25 +0100 [thread overview] Message-ID: <20181102123738.16395-7-jgross@suse.com> (raw) In-Reply-To: <20181102123738.16395-1-jgross@suse.com> Rearrange grub-core/kern/xen/init.c to prepare adding PVH mode support to it. This includes putting some code under #ifdef GRUB_MACHINE_XEN as it will not be used when running as PVH. Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> --- grub-core/kern/xen/init.c | 60 +++++++++++++++++++++++++++-------------------- 1 file changed, 34 insertions(+), 26 deletions(-) diff --git a/grub-core/kern/xen/init.c b/grub-core/kern/xen/init.c index 29f5bc23d..10007b411 100644 --- a/grub-core/kern/xen/init.c +++ b/grub-core/kern/xen/init.c @@ -41,9 +41,11 @@ grub_size_t grub_xen_n_allocated_shared_pages; static grub_xen_mfn_t grub_xen_ptr2mfn (void *ptr) { +#ifdef GRUB_MACHINE_XEN grub_xen_mfn_t *mfn_list = (grub_xen_mfn_t *) grub_xen_start_page_addr->mfn_list; return mfn_list[(grub_addr_t) ptr >> GRUB_XEN_LOG_PAGE_SIZE]; +#endif } void * @@ -104,18 +106,6 @@ grub_machine_get_bootlocation (char **device __attribute__ ((unused)), { } -static grub_uint8_t window[GRUB_XEN_PAGE_SIZE] - __attribute__ ((aligned (GRUB_XEN_PAGE_SIZE))); - -#ifdef __x86_64__ -#define NUMBER_OF_LEVELS 4 -#else -#define NUMBER_OF_LEVELS 3 -#endif - -#define LOG_POINTERS_PER_PAGE 9 -#define POINTERS_PER_PAGE (1 << LOG_POINTERS_PER_PAGE) - void grub_xen_store_send (const void *buf_, grub_size_t len) { @@ -337,6 +327,19 @@ grub_xen_setup_gnttab (void) grub_xen_grant_table_op (GNTTABOP_setup_table, &gnttab_setup, 1); } +#ifdef GRUB_MACHINE_XEN +static grub_uint8_t window[GRUB_XEN_PAGE_SIZE] + __attribute__ ((aligned (GRUB_XEN_PAGE_SIZE))); + +#ifdef __x86_64__ +#define NUMBER_OF_LEVELS 4 +#else +#define NUMBER_OF_LEVELS 3 +#endif + +#define LOG_POINTERS_PER_PAGE 9 +#define POINTERS_PER_PAGE (1 << LOG_POINTERS_PER_PAGE) + #define MAX_N_UNUSABLE_PAGES 4 static int @@ -529,13 +532,30 @@ map_all_pages (void) grub_mm_init_region ((void *) heap_start, heap_end - heap_start); } +grub_err_t +grub_machine_mmap_iterate (grub_memory_hook_t hook, void *hook_data) +{ + grub_uint64_t total_pages = grub_xen_start_page_addr->nr_pages; + grub_uint64_t usable_pages = grub_xen_start_page_addr->pt_base >> 12; + if (hook (0, page2offset (usable_pages), GRUB_MEMORY_AVAILABLE, hook_data)) + return GRUB_ERR_NONE; + + hook (page2offset (usable_pages), page2offset (total_pages - usable_pages), + GRUB_MEMORY_RESERVED, hook_data); + + return GRUB_ERR_NONE; +} +#endif + extern char _end[]; void grub_machine_init (void) { +#ifdef GRUB_MACHINE_XEN #ifdef __i386__ grub_xen_vm_assist (VMASST_CMD_enable, VMASST_TYPE_pae_extended_cr3); +#endif #endif grub_modbase = ALIGN_UP ((grub_addr_t) _end @@ -544,7 +564,9 @@ grub_machine_init (void) grub_xen_setup_gnttab (); +#ifdef GRUB_MACHINE_XEN map_all_pages (); +#endif grub_console_init (); @@ -571,17 +593,3 @@ grub_machine_fini (int flags __attribute__ ((unused))) grub_xendisk_fini (); grub_boot_fini (); } - -grub_err_t -grub_machine_mmap_iterate (grub_memory_hook_t hook, void *hook_data) -{ - grub_uint64_t total_pages = grub_xen_start_page_addr->nr_pages; - grub_uint64_t usable_pages = grub_xen_start_page_addr->pt_base >> 12; - if (hook (0, page2offset (usable_pages), GRUB_MEMORY_AVAILABLE, hook_data)) - return GRUB_ERR_NONE; - - hook (page2offset (usable_pages), page2offset (total_pages - usable_pages), - GRUB_MEMORY_RESERVED, hook_data); - - return GRUB_ERR_NONE; -} -- 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Juergen Gross <jgross@suse.com> To: grub-devel@gnu.org Cc: xen-devel@lists.xen.org, phcoder@gmail.com, daniel.kiper@oracle.com, hans@knorrie.org, Juergen Gross <jgross@suse.com> Subject: [PATCH v4 06/19] xen: rearrange xen/init.c to prepare it for Xen PVH mode Date: Fri, 2 Nov 2018 13:37:25 +0100 [thread overview] Message-ID: <20181102123738.16395-7-jgross@suse.com> (raw) In-Reply-To: <20181102123738.16395-1-jgross@suse.com> Rearrange grub-core/kern/xen/init.c to prepare adding PVH mode support to it. This includes putting some code under #ifdef GRUB_MACHINE_XEN as it will not be used when running as PVH. Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> --- grub-core/kern/xen/init.c | 60 +++++++++++++++++++++++++++-------------------- 1 file changed, 34 insertions(+), 26 deletions(-) diff --git a/grub-core/kern/xen/init.c b/grub-core/kern/xen/init.c index 29f5bc23d..10007b411 100644 --- a/grub-core/kern/xen/init.c +++ b/grub-core/kern/xen/init.c @@ -41,9 +41,11 @@ grub_size_t grub_xen_n_allocated_shared_pages; static grub_xen_mfn_t grub_xen_ptr2mfn (void *ptr) { +#ifdef GRUB_MACHINE_XEN grub_xen_mfn_t *mfn_list = (grub_xen_mfn_t *) grub_xen_start_page_addr->mfn_list; return mfn_list[(grub_addr_t) ptr >> GRUB_XEN_LOG_PAGE_SIZE]; +#endif } void * @@ -104,18 +106,6 @@ grub_machine_get_bootlocation (char **device __attribute__ ((unused)), { } -static grub_uint8_t window[GRUB_XEN_PAGE_SIZE] - __attribute__ ((aligned (GRUB_XEN_PAGE_SIZE))); - -#ifdef __x86_64__ -#define NUMBER_OF_LEVELS 4 -#else -#define NUMBER_OF_LEVELS 3 -#endif - -#define LOG_POINTERS_PER_PAGE 9 -#define POINTERS_PER_PAGE (1 << LOG_POINTERS_PER_PAGE) - void grub_xen_store_send (const void *buf_, grub_size_t len) { @@ -337,6 +327,19 @@ grub_xen_setup_gnttab (void) grub_xen_grant_table_op (GNTTABOP_setup_table, &gnttab_setup, 1); } +#ifdef GRUB_MACHINE_XEN +static grub_uint8_t window[GRUB_XEN_PAGE_SIZE] + __attribute__ ((aligned (GRUB_XEN_PAGE_SIZE))); + +#ifdef __x86_64__ +#define NUMBER_OF_LEVELS 4 +#else +#define NUMBER_OF_LEVELS 3 +#endif + +#define LOG_POINTERS_PER_PAGE 9 +#define POINTERS_PER_PAGE (1 << LOG_POINTERS_PER_PAGE) + #define MAX_N_UNUSABLE_PAGES 4 static int @@ -529,13 +532,30 @@ map_all_pages (void) grub_mm_init_region ((void *) heap_start, heap_end - heap_start); } +grub_err_t +grub_machine_mmap_iterate (grub_memory_hook_t hook, void *hook_data) +{ + grub_uint64_t total_pages = grub_xen_start_page_addr->nr_pages; + grub_uint64_t usable_pages = grub_xen_start_page_addr->pt_base >> 12; + if (hook (0, page2offset (usable_pages), GRUB_MEMORY_AVAILABLE, hook_data)) + return GRUB_ERR_NONE; + + hook (page2offset (usable_pages), page2offset (total_pages - usable_pages), + GRUB_MEMORY_RESERVED, hook_data); + + return GRUB_ERR_NONE; +} +#endif + extern char _end[]; void grub_machine_init (void) { +#ifdef GRUB_MACHINE_XEN #ifdef __i386__ grub_xen_vm_assist (VMASST_CMD_enable, VMASST_TYPE_pae_extended_cr3); +#endif #endif grub_modbase = ALIGN_UP ((grub_addr_t) _end @@ -544,7 +564,9 @@ grub_machine_init (void) grub_xen_setup_gnttab (); +#ifdef GRUB_MACHINE_XEN map_all_pages (); +#endif grub_console_init (); @@ -571,17 +593,3 @@ grub_machine_fini (int flags __attribute__ ((unused))) grub_xendisk_fini (); grub_boot_fini (); } - -grub_err_t -grub_machine_mmap_iterate (grub_memory_hook_t hook, void *hook_data) -{ - grub_uint64_t total_pages = grub_xen_start_page_addr->nr_pages; - grub_uint64_t usable_pages = grub_xen_start_page_addr->pt_base >> 12; - if (hook (0, page2offset (usable_pages), GRUB_MEMORY_AVAILABLE, hook_data)) - return GRUB_ERR_NONE; - - hook (page2offset (usable_pages), page2offset (total_pages - usable_pages), - GRUB_MEMORY_RESERVED, hook_data); - - return GRUB_ERR_NONE; -} -- 2.16.4
next prev parent reply other threads:[~2018-11-02 12:37 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-02 12:37 [PATCH v4 00/19] xen: add pvh guest support Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 01/19] xen: add some xen headers Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 02/19] loader/linux: support passing rsdp address via boot params Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-07 11:36 ` Daniel Kiper 2018-11-07 11:36 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 03/19] xen: carve out grant tab initialization into dedicated function Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 04/19] xen: prepare common code for Xen PVH support Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-07 12:10 ` Daniel Kiper 2018-11-07 12:10 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 05/19] xen: add some dummy headers for PVH mode Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-07 12:21 ` Daniel Kiper 2018-11-07 12:21 ` Daniel Kiper 2018-11-07 14:49 ` Juergen Gross 2018-11-08 15:36 ` Daniel Kiper 2018-11-08 15:36 ` Daniel Kiper 2018-11-08 15:40 ` Juergen Gross 2018-11-08 15:40 ` Juergen Gross 2018-11-07 14:49 ` Juergen Gross 2018-11-02 12:37 ` Juergen Gross [this message] 2018-11-02 12:37 ` [PATCH v4 06/19] xen: rearrange xen/init.c to prepare it for Xen " Juergen Gross 2018-11-02 12:37 ` [PATCH v4 07/19] xen: add PVH specific defines to offset.h Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-07 12:27 ` Daniel Kiper 2018-11-07 12:27 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 08/19] xen: add basic hooks for PVH in current code Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-08 15:45 ` Daniel Kiper 2018-11-08 19:23 ` [Xen-devel] " Juergen Gross 2018-11-09 17:55 ` Daniel Kiper 2018-11-09 17:55 ` Daniel Kiper 2018-11-08 19:23 ` Juergen Gross 2018-11-08 15:45 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 09/19] xen: add PVH boot entry code Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-08 15:53 ` Daniel Kiper 2018-11-08 15:53 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 10/19] xen: setup hypercall page for PVH Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 18:12 ` Daniel Kiper 2018-11-09 18:12 ` Daniel Kiper 2018-11-20 9:27 ` Juergen Gross 2018-11-20 9:27 ` Juergen Gross 2018-11-21 13:58 ` Juergen Gross 2018-11-21 13:58 ` [Xen-devel] " Juergen Gross 2018-11-15 8:33 ` Roger Pau Monné 2018-11-20 9:16 ` Juergen Gross 2018-11-20 9:16 ` Juergen Gross 2018-11-15 8:33 ` Roger Pau Monné 2018-11-02 12:37 ` [PATCH v4 11/19] xen: get memory map from hypervisor " Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 18:35 ` Daniel Kiper 2018-11-09 18:35 ` Daniel Kiper 2018-11-15 9:36 ` [Xen-devel] " Roger Pau Monné 2018-11-21 8:52 ` Juergen Gross 2018-11-21 8:52 ` Juergen Gross 2018-11-15 9:36 ` Roger Pau Monné 2018-11-02 12:37 ` [PATCH v4 12/19] xen: add PCI MMIO areas to memory map Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 19:14 ` Daniel Kiper 2018-11-14 12:49 ` Roger Pau Monné 2018-11-14 12:49 ` [Xen-devel] " Roger Pau Monné 2018-11-14 15:30 ` Daniel Kiper 2018-11-14 15:30 ` Daniel Kiper 2018-11-09 19:14 ` Daniel Kiper 2018-11-14 12:48 ` Roger Pau Monné 2018-11-14 12:48 ` [Xen-devel] " Roger Pau Monné 2018-11-21 9:02 ` Juergen Gross 2018-11-21 9:02 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 13/19] xen: setup Xen specific data for PVH Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 19:47 ` Daniel Kiper 2018-11-09 19:47 ` Daniel Kiper 2018-11-15 10:03 ` [Xen-devel] " Roger Pau Monné 2018-11-21 9:07 ` Juergen Gross 2018-11-21 9:07 ` Juergen Gross 2018-11-15 10:03 ` Roger Pau Monné 2018-11-02 12:37 ` [PATCH v4 14/19] xen: init memory regions " Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 19:56 ` Daniel Kiper 2018-11-09 19:56 ` Daniel Kiper 2018-11-15 10:07 ` Roger Pau Monné 2018-11-15 10:07 ` [Xen-devel] " Roger Pau Monné 2018-11-02 12:37 ` [PATCH v4 15/19] xen_pvh: add build runes for grub-core Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 16/19] grub-module-verifier: Ignore all_video for xenpvh Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 17/19] xen_pvh: support building a standalone image Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-09 20:06 ` Daniel Kiper 2018-11-09 20:06 ` Daniel Kiper 2018-11-02 12:37 ` [PATCH v4 18/19] xen_pvh: support grub-install for xen_pvh Juergen Gross 2018-11-02 12:37 ` Juergen Gross 2018-11-02 12:37 ` [PATCH v4 19/19] xen_pvh: add support to configure Juergen Gross 2018-11-02 12:37 ` Juergen Gross
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181102123738.16395-7-jgross@suse.com \ --to=jgross@suse.com \ --cc=daniel.kiper@oracle.com \ --cc=grub-devel@gnu.org \ --cc=hans@knorrie.org \ --cc=phcoder@gmail.com \ --cc=xen-devel@lists.xen.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.