All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak R Varma <drv@mailo.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, mh12gx2825@gmail.com,
	drv@mailo.com
Subject: [PATCH v1 6/6] staging: media: atomisp: replace raw printk() by dev_info()
Date: Wed, 21 Apr 2021 22:29:50 +0530	[thread overview]
Message-ID: <091f7989226169722220e95e0e838d2d139eb286.1619022192.git.drv@mailo.com> (raw)
In-Reply-To: <cover.1619022192.git.drv@mailo.com>

It is better to use dev_info() instead of raw printk() call. This
addresses the checkpatch complain for not using KERN_<LEVEL> facility in
printk() call.

Signed-off-by: Deepak R Varma <drv@mailo.com>
---

Changes in v1:
   - implement following changes suggested by Fabio Aiuto
       a. use dev_info instead of pr_info
       b. update patch log message accordingly


 drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
index b572551f1a0d..7e4e123fdb52 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
@@ -1020,8 +1020,8 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd,
 		return -EINVAL;
 	}
 
-	printk("%s: before gc0310_write_reg_array %s\n", __func__,
-	       gc0310_res[dev->fmt_idx].desc);
+	dev_info(&client->dev, "%s: before gc0310_write_reg_array %s\n",
+		 __func__, gc0310_res[dev->fmt_idx].desc);
 	ret = startup(sd);
 	if (ret) {
 		dev_err(&client->dev, "gc0310 startup err\n");
-- 
2.25.1




WARNING: multiple messages have this Message-ID (diff)
From: Deepak R Varma <drv@mailo.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, mh12gx2825@gmail.com,
	drv@mailo.com
Subject: [PATCH v3 6/6] staging: media: atomisp: replace raw printk() by dev_info()
Date: Wed, 21 Apr 2021 23:50:04 +0530	[thread overview]
Message-ID: <091f7989226169722220e95e0e838d2d139eb286.1619022192.git.drv@mailo.com> (raw)
Message-ID: <20210421182004.tY_LKyC8E6txv8f_QkCYJ82fA31IJsZQd4iXeRj5ews@z> (raw)
In-Reply-To: <cover.1619022192.git.drv@mailo.com>

It is better to use dev_info() instead of raw printk() call. This
addresses the checkpatch complain for not using KERN_<LEVEL> facility in
printk() call.

Suggested-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Signed-off-by: Deepak R Varma <drv@mailo.com>
---

Changes since v2:
   - Tag Fabio Auito for the patch suggestion

Changes in v1:
   - implement following changes suggested by Fabio Aiuto
       a. use dev_info instead of pr_info
       b. update patch log message accordingly


 drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
index b572551f1a0d..7e4e123fdb52 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
@@ -1020,8 +1020,8 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd,
 		return -EINVAL;
 	}
 
-	printk("%s: before gc0310_write_reg_array %s\n", __func__,
-	       gc0310_res[dev->fmt_idx].desc);
+	dev_info(&client->dev, "%s: before gc0310_write_reg_array %s\n",
+		 __func__, gc0310_res[dev->fmt_idx].desc);
 	ret = startup(sd);
 	if (ret) {
 		dev_err(&client->dev, "gc0310 startup err\n");
-- 
2.25.1




  parent reply	other threads:[~2021-04-21 17:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 16:48 [PATCH v1 0/6] staging: media: atomisp: code cleanup fixes Deepak R Varma
2021-04-21 18:11 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:50 ` [PATCH v1 1/6] staging: media: atomisp: improve function argument alignment Deepak R Varma
2021-04-21 18:12   ` [PATCH v3 " Deepak R Varma
2021-04-21 16:52 ` [PATCH v1 2/6] staging: media: atomisp: balance braces around if...else block Deepak R Varma
2021-04-21 18:13   ` [PATCH v3 " Deepak R Varma
2021-04-21 17:06   ` [PATCH v1 " Fabio Aiuto
2021-04-21 16:53 ` [PATCH v1 3/6] staging: media: atomisp: use __func__ over function names Deepak R Varma
2021-04-21 18:14   ` [PATCH v3 " Deepak R Varma
2021-04-21 16:56 ` [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks Deepak R Varma
2021-04-21 18:17   ` [PATCH v3 " Deepak R Varma
2021-04-21 17:10   ` [PATCH v1 " Fabio Aiuto
2021-04-21 17:51     ` Deepak R Varma
2021-04-21 17:54       ` Fabio Aiuto
2021-04-29 10:08   ` Dan Carpenter
2021-04-29 11:31     ` Deepak R Varma
2021-04-29 11:43       ` Dan Carpenter
2021-04-29 11:55         ` Deepak R Varma
2021-04-29 12:54           ` Dan Carpenter
2021-04-21 16:57 ` [PATCH v1 5/6] staging: media: atomisp: fix CamelCase variable naming Deepak R Varma
2021-04-21 18:18   ` [PATCH v3 " Deepak R Varma
2021-04-21 16:59 ` Deepak R Varma [this message]
2021-04-21 18:20   ` [PATCH v3 6/6] staging: media: atomisp: replace raw printk() by dev_info() Deepak R Varma
2021-04-23  9:09 ` [PATCH v3 0/6] staging: media: atomisp: code cleanup fixes Hans Verkuil
2021-04-23 16:50   ` Deepak R Varma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=091f7989226169722220e95e0e838d2d139eb286.1619022192.git.drv@mailo.com \
    --to=drv@mailo.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=mh12gx2825@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.