From: Dan Carpenter <dan.carpenter@oracle.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, mh12gx2825@gmail.com
Subject: Re: [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks
Date: Thu, 29 Apr 2021 13:08:09 +0300 [thread overview]
Message-ID: <20210429100808.GZ1981@kadam> (raw)
In-Reply-To: <efdd8910b519dd55838570c72e3ce35e063f4a11.1619022192.git.drv@mailo.com>
On Wed, Apr 21, 2021 at 10:26:09PM +0530, Deepak R Varma wrote:
> @@ -1044,7 +1048,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
> }
>
> /*
> - // set analog/digital gain
> + * set analog/digital gain
> switch(AnalogGain)
> {
> case 0:
How on earth does this compile?
> @@ -1069,8 +1073,10 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
regards,
dan carpenter
next prev parent reply other threads:[~2021-04-29 13:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 16:48 [PATCH v1 0/6] staging: media: atomisp: code cleanup fixes Deepak R Varma
2021-04-21 18:11 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:50 ` [PATCH v1 1/6] staging: media: atomisp: improve function argument alignment Deepak R Varma
2021-04-21 18:12 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:52 ` [PATCH v1 2/6] staging: media: atomisp: balance braces around if...else block Deepak R Varma
2021-04-21 18:13 ` [PATCH v3 " Deepak R Varma
2021-04-21 17:06 ` [PATCH v1 " Fabio Aiuto
2021-04-21 16:53 ` [PATCH v1 3/6] staging: media: atomisp: use __func__ over function names Deepak R Varma
2021-04-21 18:14 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:56 ` [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks Deepak R Varma
2021-04-21 18:17 ` [PATCH v3 " Deepak R Varma
2021-04-21 17:10 ` [PATCH v1 " Fabio Aiuto
2021-04-21 17:51 ` Deepak R Varma
2021-04-21 17:54 ` Fabio Aiuto
2021-04-29 10:08 ` Dan Carpenter [this message]
2021-04-29 11:31 ` Deepak R Varma
2021-04-29 11:43 ` Dan Carpenter
2021-04-29 11:55 ` Deepak R Varma
2021-04-29 12:54 ` Dan Carpenter
2021-04-21 16:57 ` [PATCH v1 5/6] staging: media: atomisp: fix CamelCase variable naming Deepak R Varma
2021-04-21 18:18 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:59 ` [PATCH v1 6/6] staging: media: atomisp: replace raw printk() by dev_info() Deepak R Varma
2021-04-21 18:20 ` [PATCH v3 " Deepak R Varma
2021-04-23 9:09 ` [PATCH v3 0/6] staging: media: atomisp: code cleanup fixes Hans Verkuil
2021-04-23 16:50 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429100808.GZ1981@kadam \
--to=dan.carpenter@oracle.com \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.