From: Kyle Moffett <mrmacman_g4@mac.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch][1/3] ipc/ BUG -> BUG_ON conversions
Date: Sat, 28 Aug 2004 12:05:10 -0400 [thread overview]
Message-ID: <098EB4E1-F90C-11D8-A7C9-000393ACC76E@mac.com> (raw)
In-Reply-To: <20040828151544.GB12772@fs.tum.de>
On Aug 28, 2004, at 11:15, Adrian Bunk wrote:
> The patch below does BUG -> BUG_ON conversions in ipc/ .
> --- linux-2.6.9-rc1-mm1-full-3.4/ipc/shm.c.old 2004-08-28
> 15:55:28.000000000 +0200
> +++ linux-2.6.9-rc1-mm1-full-3.4/ipc/shm.c 2004-08-28
> 16:02:56.000000000 +0200
> @@ -86,8 +86,7 @@
> static inline void shm_inc (int id) {
> struct shmid_kernel *shp;
>
> - if(!(shp = shm_lock(id)))
> - BUG();
> + BUG_ON(!(shp = shm_lock(id)));
This won't work:
With debugging mode:
if (unlikely(!(shp = shm_lock(id)))) BUG();
Without debugging mode:
do { } while(0)
Anything you put in BUG_ON() must *NOT* have side effects.
> shp->shm_atim = get_seconds();
> shp->shm_lprid = current->tgid;
> shp->shm_nattch++;
> @@ -137,8 +136,7 @@
>
> down (&shm_ids.sem);
> /* remove from the list of attaches of the shm segment */
> - if(!(shp = shm_lock(id)))
> - BUG();
> + BUG_ON(!(shp = shm_lock(id)));
Same here
> shp->shm_lprid = current->tgid;
> shp->shm_dtim = get_seconds();
> shp->shm_nattch--;
> @@ -744,8 +741,7 @@
> up_write(¤t->mm->mmap_sem);
>
> down (&shm_ids.sem);
> - if(!(shp = shm_lock(shmid)))
> - BUG();
> + BUG_ON(!(shp = shm_lock(shmid)));
And here
> shp->shm_nattch--;
> if(shp->shm_nattch == 0 &&
> shp->shm_flags & SHM_DEST)
Cheers,
Kyle Moffett
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a17 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$
L++++(+++) E W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+
PGP+++ t+(+++) 5 X R? tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r
!y?(-)
------END GEEK CODE BLOCK------
next prev parent reply other threads:[~2004-08-28 16:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-28 15:11 [2.6 patch][0/3] BUG -> BUG_ON conversions Adrian Bunk
2004-08-28 15:15 ` [2.6 patch][1/3] ipc/ " Adrian Bunk
2004-08-28 16:05 ` Kyle Moffett [this message]
2004-08-28 16:26 ` Adrian Bunk
2004-08-28 16:50 ` Michael Buesch
2004-08-28 19:58 ` Andrew Morton
2004-08-28 20:22 ` Adrian Bunk
2004-08-28 20:59 ` Jens Axboe
2004-08-28 21:43 ` Matt Mackall
2004-08-28 15:17 ` [2.6 patch][2/3] kernel/ " Adrian Bunk
2004-08-28 16:09 ` Kyle Moffett
2004-08-28 15:18 ` [2.6 patch][3/3] mm/ " Adrian Bunk
2004-08-28 16:32 ` Denis Vlasenko
2004-08-28 20:58 ` Jens Axboe
2004-08-28 21:24 ` Adrian Bunk
2004-08-29 12:03 ` Jens Axboe
2004-08-29 12:18 ` Oliver Neukum
2004-08-29 13:01 ` Jens Axboe
2004-08-29 13:50 ` Adrian Bunk
2004-08-29 14:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=098EB4E1-F90C-11D8-A7C9-000393ACC76E@mac.com \
--to=mrmacman_g4@mac.com \
--cc=akpm@osdl.org \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.