From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
pali.rohar@gmail.com, sre@kernel.org,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
clayton@craftyguy.net, martijn@brixit.nl,
sakari.ailus@linux.intel.com,
Marek Belisko <marek.belisko@open-nandra.com>,
robh+dt@kernel.org, linux-pm@vger.kernel.org,
Marek Belisko <marek.belisko@gmail.com>
Subject: Re: libbattery was Re: [RFC PATCH 5/5] power: generic-adc-battery: Add capacity handling
Date: Wed, 18 Oct 2017 17:47:18 +0200 [thread overview]
Message-ID: <0C0901E1-23E8-4D04-B3A9-8314809A7A6B@goldelico.com> (raw)
In-Reply-To: <20171018132204.GD4394@atomide.com>
> Am 18.10.2017 um 15:22 schrieb Tony Lindgren <tony@atomide.com>:
>
> * H. Nikolaus Schaller <hns@goldelico.com> [171018 05:49]:
>>> Am 18.10.2017 um 14:28 schrieb Pavel Machek <pavel@ucw.cz>:
>>>
>>> So I started something, it is at.
>>>
>>> https://github.com/pavelmachek/libbattery
>>>
>>> My battery on n900 is currently uncalibrated (and charging), still it
>>> gets some kind of estimation:
>>>
>>> Battery -1 %
>>> Seconds -1
>>> State 1
>>> Voltage 3.88 V
>>> Battery 63 %
>>>
>>> Of course, there's a lot more work to be done.
>>
>> Nice start but not a solution to our problem.
>>
>> Our problem is that people simply expect that for example https://packages.debian.org/wheezy/xfce/xfce4-battery-plugin
>> displays the battery percentage.
>
> I think we could make things compatible with various battery apps by
> having libbattery write back the capacity percentage and time remaining
> to the kernel driver via sysfs or a dev entry. Then the kernel interface
> can just display the data to whatever apps.
Hm. That would be quite difficult to understand and maintain code.
Why not have the kernel driver do the simple calculations (they do
not need float) and provide the standard /sys/class/power attribute?
BR,
Nikolaus
WARNING: multiple messages have this Message-ID (diff)
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Tony Lindgren <tony@atomide.com>
Cc: ivo.g.dimitrov.75@gmail.com, sakari.ailus@linux.intel.com,
Marek Belisko <marek.belisko@open-nandra.com>,
khilman@kernel.org, Marek Belisko <marek.belisko@gmail.com>,
linux-pm@vger.kernel.org, aaro.koskinen@iki.fi,
kernel list <linux-kernel@vger.kernel.org>,
sre@kernel.org, martijn@brixit.nl, robh+dt@kernel.org,
abcloriens@gmail.com, Pavel Machek <pavel@ucw.cz>,
pali.rohar@gmail.com,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
clayton@craftyguy.net, linux-omap@vger.kernel.org,
patrikbachan@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
serge@hallyn.com
Subject: Re: libbattery was Re: [RFC PATCH 5/5] power: generic-adc-battery: Add capacity handling
Date: Wed, 18 Oct 2017 17:47:18 +0200 [thread overview]
Message-ID: <0C0901E1-23E8-4D04-B3A9-8314809A7A6B@goldelico.com> (raw)
In-Reply-To: <20171018132204.GD4394@atomide.com>
> Am 18.10.2017 um 15:22 schrieb Tony Lindgren <tony@atomide.com>:
>
> * H. Nikolaus Schaller <hns@goldelico.com> [171018 05:49]:
>>> Am 18.10.2017 um 14:28 schrieb Pavel Machek <pavel@ucw.cz>:
>>>
>>> So I started something, it is at.
>>>
>>> https://github.com/pavelmachek/libbattery
>>>
>>> My battery on n900 is currently uncalibrated (and charging), still it
>>> gets some kind of estimation:
>>>
>>> Battery -1 %
>>> Seconds -1
>>> State 1
>>> Voltage 3.88 V
>>> Battery 63 %
>>>
>>> Of course, there's a lot more work to be done.
>>
>> Nice start but not a solution to our problem.
>>
>> Our problem is that people simply expect that for example https://packages.debian.org/wheezy/xfce/xfce4-battery-plugin
>> displays the battery percentage.
>
> I think we could make things compatible with various battery apps by
> having libbattery write back the capacity percentage and time remaining
> to the kernel driver via sysfs or a dev entry. Then the kernel interface
> can just display the data to whatever apps.
Hm. That would be quite difficult to understand and maintain code.
Why not have the kernel driver do the simple calculations (they do
not need float) and provide the standard /sys/class/power attribute?
BR,
Nikolaus
WARNING: multiple messages have this Message-ID (diff)
From: hns@goldelico.com (H. Nikolaus Schaller)
To: linux-arm-kernel@lists.infradead.org
Subject: libbattery was Re: [RFC PATCH 5/5] power: generic-adc-battery: Add capacity handling
Date: Wed, 18 Oct 2017 17:47:18 +0200 [thread overview]
Message-ID: <0C0901E1-23E8-4D04-B3A9-8314809A7A6B@goldelico.com> (raw)
In-Reply-To: <20171018132204.GD4394@atomide.com>
> Am 18.10.2017 um 15:22 schrieb Tony Lindgren <tony@atomide.com>:
>
> * H. Nikolaus Schaller <hns@goldelico.com> [171018 05:49]:
>>> Am 18.10.2017 um 14:28 schrieb Pavel Machek <pavel@ucw.cz>:
>>>
>>> So I started something, it is at.
>>>
>>> https://github.com/pavelmachek/libbattery
>>>
>>> My battery on n900 is currently uncalibrated (and charging), still it
>>> gets some kind of estimation:
>>>
>>> Battery -1 %
>>> Seconds -1
>>> State 1
>>> Voltage 3.88 V
>>> Battery 63 %
>>>
>>> Of course, there's a lot more work to be done.
>>
>> Nice start but not a solution to our problem.
>>
>> Our problem is that people simply expect that for example https://packages.debian.org/wheezy/xfce/xfce4-battery-plugin
>> displays the battery percentage.
>
> I think we could make things compatible with various battery apps by
> having libbattery write back the capacity percentage and time remaining
> to the kernel driver via sysfs or a dev entry. Then the kernel interface
> can just display the data to whatever apps.
Hm. That would be quite difficult to understand and maintain code.
Why not have the kernel driver do the simple calculations (they do
not need float) and provide the standard /sys/class/power attribute?
BR,
Nikolaus
next prev parent reply other threads:[~2017-10-18 15:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 20:55 [RFC PATCH 0/5] Add formula for LiIon batteries to compute capacity Marek Belisko
2017-08-01 20:55 ` [RFC PATCH 1/5] dt-bindings: power: Add battery types Marek Belisko
2017-08-02 11:38 ` Pavel Machek
2017-08-02 11:43 ` Pavel Machek
2017-08-02 11:47 ` Belisko Marek
2017-08-01 20:55 ` [RFC PATCH 2/5] power: generic-adc-battery: Parse more properties from DT Marek Belisko
2017-08-02 11:56 ` Pavel Machek
2017-08-02 11:57 ` Belisko Marek
2017-08-29 9:45 ` Sebastian Reichel
2017-08-01 20:55 ` [RFC PATCH 3/5] power/generic-adc-battery: Add support for temperature and add check for charge from iio current channel Marek Belisko
2017-08-29 9:54 ` Sebastian Reichel
2017-08-01 20:55 ` [RFC PATCH 4/5] power: Add formula for computing LiIon State of Charge from Voltage Marek Belisko
2017-08-01 20:55 ` [RFC PATCH 5/5] power: generic-adc-battery: Add capacity handling Marek Belisko
2017-08-29 10:11 ` Sebastian Reichel
2017-09-08 11:32 ` libbattery was " Pavel Machek
2017-09-08 13:15 ` H. Nikolaus Schaller
2017-09-08 13:15 ` H. Nikolaus Schaller
2017-10-18 12:28 ` Pavel Machek
2017-10-18 12:28 ` Pavel Machek
2017-10-18 12:28 ` Pavel Machek
2017-10-18 12:48 ` H. Nikolaus Schaller
2017-10-18 12:48 ` H. Nikolaus Schaller
2017-10-18 12:48 ` H. Nikolaus Schaller
2017-10-18 13:09 ` Pavel Machek
2017-10-18 13:09 ` Pavel Machek
2017-10-18 13:22 ` Tony Lindgren
2017-10-18 13:22 ` Tony Lindgren
2017-10-18 13:56 ` Pavel Machek
2017-10-18 13:56 ` Pavel Machek
2017-10-18 15:52 ` H. Nikolaus Schaller
2017-10-18 15:52 ` H. Nikolaus Schaller
2017-10-18 16:13 ` Pavel Machek
2017-10-18 16:13 ` Pavel Machek
2017-10-18 16:48 ` H. Nikolaus Schaller
2017-10-18 16:48 ` H. Nikolaus Schaller
2017-10-18 15:47 ` H. Nikolaus Schaller [this message]
2017-10-18 15:47 ` H. Nikolaus Schaller
2017-10-18 15:47 ` H. Nikolaus Schaller
2017-10-19 16:24 ` Tony Lindgren
2017-10-19 16:24 ` Tony Lindgren
2017-10-19 16:55 ` H. Nikolaus Schaller
2017-10-19 16:55 ` H. Nikolaus Schaller
2017-10-19 17:06 ` Tony Lindgren
2017-10-19 17:06 ` Tony Lindgren
2017-10-19 17:20 ` H. Nikolaus Schaller
2017-10-19 17:20 ` H. Nikolaus Schaller
2017-10-19 17:33 ` Ladislav Michl
2017-10-19 17:33 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C0901E1-23E8-4D04-B3A9-8314809A7A6B@goldelico.com \
--to=hns@goldelico.com \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=clayton@craftyguy.net \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=marek.belisko@open-nandra.com \
--cc=martijn@brixit.nl \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.