Re: [PATCH v8 1/1] plainmount: Support plain encryption mode

[Maxim Fomin <maxim@fomin.one>]

------- Original Message -------
On Saturday, December 24th, 2022 at 2:09 AM, Glenn Washburn <development@efficientek.com> wrote:
> 
> On Fri, 23 Dec 2022 19:54:47 -0600
> Glenn Washburn development@efficientek.com wrote:
> 
> > On Fri, 02 Dec 2022 17:11:23 +0000
> > Maxim Fomin maxim@fomin.one wrote:
> > 
> > > ------- Original Message -------
> > > On Friday, December 2nd, 2022 at 0:00, Glenn Washburn
> > > development@efficientek.com wrote:
> > > 
> > > > I'm now compiling this patch and found a few compile issues below.
> > > > You're compile testing this right?
> > > 
> > > First versions of the patch were tested in pure grub src directory.
> > > Later I switched to directly making and installing GRUB package for
> > > my distro using its source script syntax. It seems this process was
> > > affected by environment options which hided these errors/warnings.
> > > 
> > > I test the patch on my two old laptops - one with UEFI BIOS
> > > (x86_64-efi) and one is pre-UEFI (i386-pc). I was compiling i386-pc
> > > target too, because otherwise the second laptop was unbootable.
> > > During i386-pc compilation I noticed some warnings related to
> > > 'PRIuGRUB_XXX' macros which were absent during efi target
> > > compilation. I noticed that there are similar warnings in other
> > > modules and decided that there are issues with 'PRIuGRUB_XXX' macros
> > > at i386-pc platform at global level. In any case, these issues
> > > didn't cause compilation fail in my working environment because I
> > > would not be able to compile and boot pre-UEFI lap. Do you use
> > > -Werror?
> > 
> > I didn't see this until just now. In case you're still interested, no
> > I don't use -Werror or any special compiler flags. And I'm using gcc
> > version 10.2.1 from a Debian 11 container.
> 
> 
> Correction, -Werror is being used. Perhaps that's a default compiler
> flag on Debian systems.
> 
> Glenn
> 

This explains why you have found these issues. However, it does not explain
how you can compile grub with -Werror because currently there are following
warnings in x86_64-efi mode:
grub-core/lib/libgcrypt-grub/mpi/mpi-internal.h:150:24: warning: variable ‘_ql’ set but not used [-Wunused-but-set-variable]
grub-core/lib/libgcrypt-grub/mpi/mpih-div.c:53:9: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]

When I was working with the patch earlier this year I remember having these
and several more warnings which prevented me from using -Werror. Back then
I have removed the switch and have forgotten about this issue completely.

Best regards,
Maxim Fomin