[PATCH] tile: fix build failure

[PATCH] tile: fix build failure

[Sudip Mukherjee]

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

The build of tilegx allmodconfig was failing with errors like:
../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
 static inline u64 mul_u32_u32(u32 a, u32 b)
               ^~~
../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                               ^~~
../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                                      ^~~
In file included from ../fs/ubifs/ubifs.h:26:0,
                 from ../fs/ubifs/shrinker.c:42:
../include/linux/math64.h: In function 'mul_u64_u32_shr':
../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
	function 'mul_u32_u32' [-Werror=implicit-function-declaration]

The simplest solution was to include the types header file.

Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends")
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/194717687

 arch/tile/include/asm/div64.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/tile/include/asm/div64.h b/arch/tile/include/asm/div64.h
index bf61619..b1c885d 100644
--- a/arch/tile/include/asm/div64.h
+++ b/arch/tile/include/asm/div64.h
@@ -1,6 +1,7 @@
 #ifndef _ASM_TILE_DIV64_H
 #define _ASM_TILE_DIV64_H
 
+#include <linux/types.h>
 #ifdef __tilegx__
 static inline u64 mul_u32_u32(u32 a, u32 b)
 {
-- 
2.7.4

Re: [PATCH] tile: fix build failure

[Chris Metcalf]

On 1/24/2017 11:39 AM, Sudip Mukherjee wrote:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>
> The build of tilegx allmodconfig was failing with errors like:
> ../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
>   static inline u64 mul_u32_u32(u32 a, u32 b)
>                 ^~~
> ../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
>   static inline u64 mul_u32_u32(u32 a, u32 b)
>                                 ^~~
> ../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
>   static inline u64 mul_u32_u32(u32 a, u32 b)
>                                        ^~~
> In file included from ../fs/ubifs/ubifs.h:26:0,
>                   from ../fs/ubifs/shrinker.c:42:
> ../include/linux/math64.h: In function 'mul_u64_u32_shr':
> ../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
> 	function 'mul_u32_u32' [-Werror=implicit-function-declaration]
>
> The simplest solution was to include the types header file.
>
> Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends")
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>
> build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/194717687
>
>   arch/tile/include/asm/div64.h | 1 +
>   1 file changed, 1 insertion(+)

Acked-by: Chris Metcalf <cmetcalf@mellanox.com>

-- 
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com

Re: [PATCH] tile: fix build failure

[Sudip Mukherjee]

On Tuesday 24 January 2017 04:56 PM, Chris Metcalf wrote:
> On 1/24/2017 11:39 AM, Sudip Mukherjee wrote:
>> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>>
>> The build of tilegx allmodconfig was failing with errors like:
>> ../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
>>   static inline u64 mul_u32_u32(u32 a, u32 b)
>>                 ^~~
>> ../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
>>   static inline u64 mul_u32_u32(u32 a, u32 b)
>>                                 ^~~
>> ../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
>>   static inline u64 mul_u32_u32(u32 a, u32 b)
>>                                        ^~~
>> In file included from ../fs/ubifs/ubifs.h:26:0,
>>                   from ../fs/ubifs/shrinker.c:42:
>> ../include/linux/math64.h: In function 'mul_u64_u32_shr':
>> ../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
>>     function 'mul_u32_u32' [-Werror=implicit-function-declaration]
>>
>> The simplest solution was to include the types header file.
>>
>> Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and
>> friends")
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>> ---
>>
>> build log is at:
>> https://travis-ci.org/sudipm-mukherjee/parport/jobs/194717687
>>
>>   arch/tile/include/asm/div64.h | 1 +
>>   1 file changed, 1 insertion(+)
>
> Acked-by: Chris Metcalf <cmetcalf@mellanox.com>
>

linux-next is still failing for this error. Who will pick this up?

Regards
Sudip

Re: [PATCH] tile: fix build failure

[Stephen Rothwell]

Hi Sudip,

On Mon, 13 Feb 2017 22:58:40 +0000 Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>
> On Tuesday 24 January 2017 04:56 PM, Chris Metcalf wrote:
> > On 1/24/2017 11:39 AM, Sudip Mukherjee wrote:  
> >> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> >>
> >> The build of tilegx allmodconfig was failing with errors like:
> >> ../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
> >>   static inline u64 mul_u32_u32(u32 a, u32 b)
> >>                 ^~~
> >> ../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
> >>   static inline u64 mul_u32_u32(u32 a, u32 b)
> >>                                 ^~~
> >> ../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
> >>   static inline u64 mul_u32_u32(u32 a, u32 b)
> >>                                        ^~~
> >> In file included from ../fs/ubifs/ubifs.h:26:0,
> >>                   from ../fs/ubifs/shrinker.c:42:
> >> ../include/linux/math64.h: In function 'mul_u64_u32_shr':
> >> ../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
> >>     function 'mul_u32_u32' [-Werror=implicit-function-declaration]
> >>
> >> The simplest solution was to include the types header file.
> >>
> >> Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and
> >> friends")
> >> Cc: Peter Zijlstra <peterz@infradead.org>
> >> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> >> ---
> >>
> >> build log is at:
> >> https://travis-ci.org/sudipm-mukherjee/parport/jobs/194717687
> >>
> >>   arch/tile/include/asm/div64.h | 1 +
> >>   1 file changed, 1 insertion(+)  
> >
> > Acked-by: Chris Metcalf <cmetcalf@mellanox.com>
> >  
> 
> linux-next is still failing for this error. Who will pick this up?

Presumably the tip tree (timers/core).  Added Thomas to cc.

-- 
Cheers,
Stephen Rothwell

[tip:timers/core] math64, tile: Fix build failure

[tip-bot for Sudip Mukherjee]

Commit-ID:  dba9a0babdd938a51d11ae81f9c40d07ca613f43
Gitweb:     http://git.kernel.org/tip/dba9a0babdd938a51d11ae81f9c40d07ca613f43
Author:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>
AuthorDate: Tue, 24 Jan 2017 16:39:21 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 14 Feb 2017 09:39:13 +0100

math64, tile: Fix build failure

The build of tilegx allmodconfig fails with:
../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
 static inline u64 mul_u32_u32(u32 a, u32 b)
               ^~~
../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                               ^~~
../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                                      ^~~
In file included from ../fs/ubifs/ubifs.h:26:0,
                 from ../fs/ubifs/shrinker.c:42:
../include/linux/math64.h: In function 'mul_u64_u32_shr':
../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
	function 'mul_u32_u32' [-Werror=implicit-function-declaration]

Include the linux/types.h in tiles div64.h to slve the problem.

Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends")
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: http://lkml.kernel.org/r/1485275961-20112-1-git-send-email-sudip.mukherjee@codethink.co.uk
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/tile/include/asm/div64.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/tile/include/asm/div64.h b/arch/tile/include/asm/div64.h
index bf61619..9f765cd 100644
--- a/arch/tile/include/asm/div64.h
+++ b/arch/tile/include/asm/div64.h
@@ -1,6 +1,8 @@
 #ifndef _ASM_TILE_DIV64_H
 #define _ASM_TILE_DIV64_H
 
+#include <linux/types.h>
+
 #ifdef __tilegx__
 static inline u64 mul_u32_u32(u32 a, u32 b)
 {

Re: [PATCH] tile: fix build failure

[Thomas Gleixner]

On Tue, 14 Feb 2017, Stephen Rothwell wrote:
> > linux-next is still failing for this error. Who will pick this up?
> 
> Presumably the tip tree (timers/core).  Added Thomas to cc.

Applied.

Re: [PATCH] tile: fix build failure

[Sudip Mukherjee]

On Tue, Sep 08, 2015 at 01:44:26PM -0400, Chris Metcalf wrote:
> On 09/07/2015 10:36 AM, Sudip Mukherjee wrote:
> >When building with allmodconfig the build was failing with the error:
> >
> >arch/tile/kernel/usb.c:70:1: warning: data definition has no type or storage class [enabled by default]
> >arch/tile/kernel/usb.c:70:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int]
> >arch/tile/kernel/usb.c:70:1: warning: parameter names (without types) in function declaration [enabled by default]
> >arch/tile/kernel/usb.c:63:19: warning: 'tilegx_usb_init' defined but not used [-Wunused-function]
> >
> >Include linux/module.h to resolve the build failure.
> >
> >Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >---
> >  arch/tile/kernel/usb.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Thanks, taken into the tile tree.
Hi,
I think it is still not sent to Linus. 4.3-rc3 also failed allmodconfig on
tile and tilegx with same error.

regards
sudip

Re: [PATCH] tile: fix build failure

[Chris Metcalf]

On 09/07/2015 10:36 AM, Sudip Mukherjee wrote:
> When building with allmodconfig the build was failing with the error:
>
> arch/tile/kernel/usb.c:70:1: warning: data definition has no type or storage class [enabled by default]
> arch/tile/kernel/usb.c:70:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int]
> arch/tile/kernel/usb.c:70:1: warning: parameter names (without types) in function declaration [enabled by default]
> arch/tile/kernel/usb.c:63:19: warning: 'tilegx_usb_init' defined but not used [-Wunused-function]
>
> Include linux/module.h to resolve the build failure.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>   arch/tile/kernel/usb.c | 1 +
>   1 file changed, 1 insertion(+)

Thanks, taken into the tile tree.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

[PATCH] tile: fix build failure

[Sudip Mukherjee]

When building with allmodconfig the build was failing with the error:

arch/tile/kernel/usb.c:70:1: warning: data definition has no type or storage class [enabled by default]
arch/tile/kernel/usb.c:70:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int]
arch/tile/kernel/usb.c:70:1: warning: parameter names (without types) in function declaration [enabled by default]
arch/tile/kernel/usb.c:63:19: warning: 'tilegx_usb_init' defined but not used [-Wunused-function]

Include linux/module.h to resolve the build failure.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 arch/tile/kernel/usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/tile/kernel/usb.c b/arch/tile/kernel/usb.c
index f0da5a2..9f1e05e 100644
--- a/arch/tile/kernel/usb.c
+++ b/arch/tile/kernel/usb.c
@@ -22,6 +22,7 @@
 #include <linux/platform_device.h>
 #include <linux/usb/tilegx.h>
 #include <linux/init.h>
+#include <linux/module.h>
 #include <linux/types.h>
 
 static u64 ehci_dmamask = DMA_BIT_MASK(32);
-- 
1.9.1