All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jianlong Huang <jianlong.huang@starfivetech.com>,
	Hal Feng <hal.feng@starfivetech.com>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-gpio@vger.kernel.org
Cc: Conor Dooley <conor@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: pinctrl: Add StarFive JH7110 pinctrl definitions
Date: Tue, 29 Nov 2022 17:02:39 +0100	[thread overview]
Message-ID: <0a8c3ed4-c16a-4014-94f6-cf177630e605@linaro.org> (raw)
In-Reply-To: <8677051a-604a-210c-066c-75db444d6f09@starfivetech.com>

On 29/11/2022 16:58, Jianlong Huang wrote:
>>>
>>> Drivers rarely reference macros directly, mostly parsing dts and writing them to registers.
>>
>> So drivers do not use macros? Then there is no reason to store them in
>> bindings? What do you "bind" if there is no usage (and we do not talk
>> about DTS...)?
>>
> 
> Where do you suggest to store these macros used in DTS?

Sometimes they do not need storing. If they are worth, then in the DTS
headers. Few platforms (Samsung, All of NXP, Mediatek, Sama5/Atmel) are
doing it already.

Best regards,
Krzysztof


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jianlong Huang <jianlong.huang@starfivetech.com>,
	Hal Feng <hal.feng@starfivetech.com>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-gpio@vger.kernel.org
Cc: Conor Dooley <conor@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: pinctrl: Add StarFive JH7110 pinctrl definitions
Date: Tue, 29 Nov 2022 17:02:39 +0100	[thread overview]
Message-ID: <0a8c3ed4-c16a-4014-94f6-cf177630e605@linaro.org> (raw)
In-Reply-To: <8677051a-604a-210c-066c-75db444d6f09@starfivetech.com>

On 29/11/2022 16:58, Jianlong Huang wrote:
>>>
>>> Drivers rarely reference macros directly, mostly parsing dts and writing them to registers.
>>
>> So drivers do not use macros? Then there is no reason to store them in
>> bindings? What do you "bind" if there is no usage (and we do not talk
>> about DTS...)?
>>
> 
> Where do you suggest to store these macros used in DTS?

Sometimes they do not need storing. If they are worth, then in the DTS
headers. Few platforms (Samsung, All of NXP, Mediatek, Sama5/Atmel) are
doing it already.

Best regards,
Krzysztof


  reply	other threads:[~2022-11-29 16:03 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18  1:11 [PATCH v2 0/5] Basic pinctrl support for StarFive JH7110 RISC-V SoC Hal Feng
2022-11-18  1:11 ` Hal Feng
2022-11-18  1:11 ` [PATCH v2 1/5] dt-bindings: pinctrl: Add StarFive JH7110 pinctrl definitions Hal Feng
2022-11-18  1:11   ` Hal Feng
2022-11-21  8:38   ` Krzysztof Kozlowski
2022-11-21  8:38     ` Krzysztof Kozlowski
2022-11-21  8:39     ` Krzysztof Kozlowski
2022-11-21  8:39       ` Krzysztof Kozlowski
2022-11-28  0:48       ` Jianlong Huang
2022-11-28  0:48         ` Jianlong Huang
2022-11-28  8:32         ` Krzysztof Kozlowski
2022-11-28  8:32           ` Krzysztof Kozlowski
2022-11-29  1:47           ` Jianlong Huang
2022-11-29  1:47             ` Jianlong Huang
2022-11-29  7:49             ` Krzysztof Kozlowski
2022-11-29  7:49               ` Krzysztof Kozlowski
2022-11-29 14:46               ` Jianlong Huang
2022-11-29 14:46                 ` Jianlong Huang
2022-11-29 14:58                 ` Krzysztof Kozlowski
2022-11-29 14:58                   ` Krzysztof Kozlowski
2022-11-29 15:58                   ` Jianlong Huang
2022-11-29 15:58                     ` Jianlong Huang
2022-11-29 16:02                     ` Krzysztof Kozlowski [this message]
2022-11-29 16:02                       ` Krzysztof Kozlowski
2022-12-01  9:31                   ` Jianlong Huang
2022-12-01  9:31                     ` Jianlong Huang
2022-12-07 13:14   ` Emil Renner Berthing
2022-12-07 13:14     ` Emil Renner Berthing
2022-11-18  1:11 ` [PATCH v2 2/5] dt-bindings: pinctrl: Add StarFive JH7110 sys pinctrl Hal Feng
2022-11-18  1:11   ` Hal Feng
2022-11-18  3:56   ` Rob Herring
2022-11-18  3:56     ` Rob Herring
2022-11-18  6:56     ` Hal Feng
2022-11-18  6:56       ` Hal Feng
2022-11-21  8:43   ` Krzysztof Kozlowski
2022-11-21  8:43     ` Krzysztof Kozlowski
2022-11-28  1:04     ` Jianlong Huang
2022-11-28  1:04       ` Jianlong Huang
2022-12-07 13:18       ` Emil Renner Berthing
2022-12-07 13:18         ` Emil Renner Berthing
2022-12-09  3:13   ` Icenowy Zheng
2022-12-09  3:13     ` Icenowy Zheng
2022-11-18  1:11 ` [PATCH v2 3/5] dt-bindings: pinctrl: Add StarFive JH7110 aon pinctrl Hal Feng
2022-11-18  1:11   ` Hal Feng
2022-11-21  8:44   ` Krzysztof Kozlowski
2022-11-21  8:44     ` Krzysztof Kozlowski
2022-11-28  1:15     ` Jianlong Huang
2022-11-28  1:15       ` Jianlong Huang
2022-12-07 13:21       ` Emil Renner Berthing
2022-12-07 13:21         ` Emil Renner Berthing
2022-11-18  1:11 ` [PATCH v2 4/5] pinctrl: starfive: Add StarFive JH7110 sys controller driver Hal Feng
2022-11-18  1:11   ` Hal Feng
2022-12-07 13:47   ` Emil Renner Berthing
2022-12-07 13:47     ` Emil Renner Berthing
2022-11-18  1:11 ` [PATCH v2 5/5] pinctrl: starfive: Add StarFive JH7110 aon " Hal Feng
2022-11-18  1:11   ` Hal Feng
2022-11-18  7:17 ` [PATCH v2 0/5] Basic pinctrl support for StarFive JH7110 RISC-V SoC Hal Feng
2022-11-18  7:17   ` Hal Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a8c3ed4-c16a-4014-94f6-cf177630e605@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=hal.feng@starfivetech.com \
    --cc=jianlong.huang@starfivetech.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.