All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Dan Carpenter <dan.carpenter@oracle.com>, kbuild@lists.01.org
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)
Date: Mon, 29 Nov 2021 10:24:15 +0800	[thread overview]
Message-ID: <0b6aec80835439afe62010a4228fc1af49f68e2b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <202111250652.KJ5iJFpx-lkp@intel.com>

Hi Dan,

> smatch warnings:
> net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)

Thanks for the report! I've sent a fix, you're CCed.

However, I can 't seem to recreate the smatch warning; could you include
the build command you're using for these? I've tried with

    make [...] C=1 CHECK=/path/to/smatch

using smatch 4f2585888, but that doesn't report the error you've listed
there. Do I need any specific CHECKFLAGS?

Cheers,


Jeremy


WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: kbuild-all@lists.01.org
Subject: Re: net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)
Date: Mon, 29 Nov 2021 10:24:15 +0800	[thread overview]
Message-ID: <0b6aec80835439afe62010a4228fc1af49f68e2b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <202111250652.KJ5iJFpx-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

Hi Dan,

> smatch warnings:
> net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)

Thanks for the report! I've sent a fix, you're CCed.

However, I can 't seem to recreate the smatch warning; could you include
the build command you're using for these? I've tried with

    make [...] C=1 CHECK=/path/to/smatch

using smatch 4f2585888, but that doesn't report the error you've listed
there. Do I need any specific CHECKFLAGS?

Cheers,


Jeremy

  reply	other threads:[~2021-11-29  2:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 22:21 net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb) kernel test robot
2021-11-25  7:05 ` Dan Carpenter
2021-11-25  7:05 ` Dan Carpenter
2021-11-29  2:24 ` Jeremy Kerr [this message]
2021-11-29  2:24   ` Jeremy Kerr
2021-11-29  7:53   ` Dan Carpenter
2021-11-29  7:53     ` Dan Carpenter
2021-11-29  7:53     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b6aec80835439afe62010a4228fc1af49f68e2b.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=dan.carpenter@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.