All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Jeremy Kerr <jk@codeconstruct.com.au>
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)
Date: Thu, 25 Nov 2021 10:05:17 +0300	[thread overview]
Message-ID: <202111250652.KJ5iJFpx-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5f53fa508db098c9d372423a6dac31c8a5679cdf
commit: ded21b72299529cc143a4213ea0ec4b0c620b8eb mctp: Add test utils
config: x86_64-randconfig-m001-20211122 (https://download.01.org/0day-ci/archive/20211125/202111250652.KJ5iJFpx-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)

vim +15 net/mctp/test/utils.c

ded21b72299529c Jeremy Kerr 2021-10-03  12  static netdev_tx_t mctp_test_dev_tx(struct sk_buff *skb,
ded21b72299529c Jeremy Kerr 2021-10-03  13  				    struct net_device *ndev)
ded21b72299529c Jeremy Kerr 2021-10-03  14  {
ded21b72299529c Jeremy Kerr 2021-10-03 @15  	kfree(skb);

This should be kfree_skb(skb);

ded21b72299529c Jeremy Kerr 2021-10-03  16  	return NETDEV_TX_OK;
ded21b72299529c Jeremy Kerr 2021-10-03  17  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)
Date: Thu, 25 Nov 2021 06:21:27 +0800	[thread overview]
Message-ID: <202111250652.KJ5iJFpx-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Jeremy Kerr <jk@codeconstruct.com.au>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5f53fa508db098c9d372423a6dac31c8a5679cdf
commit: ded21b72299529cc143a4213ea0ec4b0c620b8eb mctp: Add test utils
date:   7 weeks ago
:::::: branch date: 4 hours ago
:::::: commit date: 7 weeks ago
config: x86_64-randconfig-m001-20211122 (https://download.01.org/0day-ci/archive/20211125/202111250652.KJ5iJFpx-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)

vim +15 net/mctp/test/utils.c

ded21b72299529c Jeremy Kerr 2021-10-03  11  
ded21b72299529c Jeremy Kerr 2021-10-03  12  static netdev_tx_t mctp_test_dev_tx(struct sk_buff *skb,
ded21b72299529c Jeremy Kerr 2021-10-03  13  				    struct net_device *ndev)
ded21b72299529c Jeremy Kerr 2021-10-03  14  {
ded21b72299529c Jeremy Kerr 2021-10-03 @15  	kfree(skb);
ded21b72299529c Jeremy Kerr 2021-10-03  16  	return NETDEV_TX_OK;
ded21b72299529c Jeremy Kerr 2021-10-03  17  }
ded21b72299529c Jeremy Kerr 2021-10-03  18  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)
Date: Thu, 25 Nov 2021 10:05:17 +0300	[thread overview]
Message-ID: <202111250652.KJ5iJFpx-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5f53fa508db098c9d372423a6dac31c8a5679cdf
commit: ded21b72299529cc143a4213ea0ec4b0c620b8eb mctp: Add test utils
config: x86_64-randconfig-m001-20211122 (https://download.01.org/0day-ci/archive/20211125/202111250652.KJ5iJFpx-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)

vim +15 net/mctp/test/utils.c

ded21b72299529c Jeremy Kerr 2021-10-03  12  static netdev_tx_t mctp_test_dev_tx(struct sk_buff *skb,
ded21b72299529c Jeremy Kerr 2021-10-03  13  				    struct net_device *ndev)
ded21b72299529c Jeremy Kerr 2021-10-03  14  {
ded21b72299529c Jeremy Kerr 2021-10-03 @15  	kfree(skb);

This should be kfree_skb(skb);

ded21b72299529c Jeremy Kerr 2021-10-03  16  	return NETDEV_TX_OK;
ded21b72299529c Jeremy Kerr 2021-10-03  17  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

             reply	other threads:[~2021-11-25  7:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 22:21 kernel test robot [this message]
2021-11-25  7:05 ` net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb) Dan Carpenter
2021-11-25  7:05 ` Dan Carpenter
2021-11-29  2:24 ` Jeremy Kerr
2021-11-29  2:24   ` Jeremy Kerr
2021-11-29  7:53   ` Dan Carpenter
2021-11-29  7:53     ` Dan Carpenter
2021-11-29  7:53     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111250652.KJ5iJFpx-lkp@intel.com \
    --to=dan.carpenter@oracle.com \
    --cc=jk@codeconstruct.com.au \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.