From: Wols Lists <antlists@youngman.org.uk>
To: Paul Menzel <pmenzel@molgen.mpg.de>, Song Liu <song@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-raid@vger.kernel.org,
Matt Brown <matthew.brown.dev@gmail.com>
Subject: Re: [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3
Date: Tue, 8 Feb 2022 18:44:41 +0000 [thread overview]
Message-ID: <0c20be6e-87f2-b9dc-4c9a-85680ba10417@youngman.org.uk> (raw)
In-Reply-To: <20220126114144.370517-1-pmenzel@molgen.mpg.de>
On 26/01/2022 11:41, Paul Menzel wrote:
> So, do the same as commit 9564a8cf422d (Kbuild: fix # escaping in .cmd
> files for future Make) and commit 929bef467771 (bpf: Use $(pound) instead
> of \# in Makefiles) and define and use a `$(pound)` variable.
Ouch!
In the English (as opposed to American) speaking world this will be very
confusing! The pound sign is £ not #.
If this is not dictated by some sort of upstream PLEASE can we make it
$(hash) not $(pound)
Cheers,
Wol
WARNING: multiple messages have this Message-ID (diff)
From: Wols Lists <antlists@youngman.org.uk>
To: Paul Menzel <pmenzel@molgen.mpg.de>, Song Liu <song@kernel.org>
Cc: linux-raid@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Matt Brown <matthew.brown.dev@gmail.com>
Subject: Re: [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3
Date: Tue, 8 Feb 2022 18:44:41 +0000 [thread overview]
Message-ID: <0c20be6e-87f2-b9dc-4c9a-85680ba10417@youngman.org.uk> (raw)
In-Reply-To: <20220126114144.370517-1-pmenzel@molgen.mpg.de>
On 26/01/2022 11:41, Paul Menzel wrote:
> So, do the same as commit 9564a8cf422d (Kbuild: fix # escaping in .cmd
> files for future Make) and commit 929bef467771 (bpf: Use $(pound) instead
> of \# in Makefiles) and define and use a `$(pound)` variable.
Ouch!
In the English (as opposed to American) speaking world this will be very
confusing! The pound sign is £ not #.
If this is not dictated by some sort of upstream PLEASE can we make it
$(hash) not $(pound)
Cheers,
Wol
next prev parent reply other threads:[~2022-02-08 18:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 11:41 [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3 Paul Menzel
2022-01-26 11:41 ` Paul Menzel
2022-01-26 11:41 ` [PATCH 2/3] lib/raid6: Include <asm/ppc-opcode.h> for `VPERMXOR` Paul Menzel
2022-01-26 11:41 ` Paul Menzel
2022-01-26 11:41 ` [PATCH 3/3] lib/raid6/test: Rename variable to avoid `raid6_call` name clash Paul Menzel
2022-01-26 11:41 ` Paul Menzel
2022-01-26 12:06 ` [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3 David Laight
2022-01-26 12:06 ` David Laight
2022-01-26 12:12 ` Paul Menzel
2022-01-26 12:12 ` Paul Menzel
2022-01-26 19:29 ` Tim Small
2022-01-26 19:29 ` Tim Small
2022-01-26 14:38 ` a pound's a pound the whole world 'round (was "Re: [PATCH 1/3] ... Use `$(pound)` instead ...") David T-G
2022-02-08 6:43 ` [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3 Song Liu
2022-02-08 6:43 ` Song Liu
2022-02-08 18:44 ` Wols Lists [this message]
2022-02-08 18:44 ` Wols Lists
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c20be6e-87f2-b9dc-4c9a-85680ba10417@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=linux-raid@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthew.brown.dev@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=pmenzel@molgen.mpg.de \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.