From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Song Liu <song@kernel.org>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-raid@vger.kernel.org,
Matt Brown <matthew.brown.dev@gmail.com>
Subject: [PATCH 2/3] lib/raid6: Include <asm/ppc-opcode.h> for `VPERMXOR`
Date: Wed, 26 Jan 2022 12:41:43 +0100 [thread overview]
Message-ID: <20220126114144.370517-2-pmenzel@molgen.mpg.de> (raw)
In-Reply-To: <20220126114144.370517-1-pmenzel@molgen.mpg.de>
On Ubuntu 21.10 (ppc64le) building `raid6test` with gcc (Ubuntu
11.2.0-7ubuntu2) 11.2.0 fails with the error below.
gcc -I.. -I ../../../include -g -O2 -I../../../arch/powerpc/include -DCONFIG_ALTIVEC -c -o vpermxor1.o vpermxor1.c
vpermxor1.c: In function ‘raid6_vpermxor1_gen_syndrome_real’:
vpermxor1.c:64:29: error: expected string literal before ‘VPERMXOR’
64 | asm(VPERMXOR(%0,%1,%2,%3):"=v"(wq0):"v"(gf_high), "v"(gf_low), "v"(wq0));
| ^~~~~~~~
make: *** [Makefile:58: vpermxor1.o] Error 1
So, include the header `asm/ppc-opcode.h` defining this macro also when
not building the Linux kernel but only this too.
Cc: Matt Brown <matthew.brown.dev@gmail.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
lib/raid6/vpermxor.uc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/raid6/vpermxor.uc b/lib/raid6/vpermxor.uc
index 10475dc423c1..1bfb127fbfe8 100644
--- a/lib/raid6/vpermxor.uc
+++ b/lib/raid6/vpermxor.uc
@@ -24,9 +24,9 @@
#ifdef CONFIG_ALTIVEC
#include <altivec.h>
+#include <asm/ppc-opcode.h>
#ifdef __KERNEL__
#include <asm/cputable.h>
-#include <asm/ppc-opcode.h>
#include <asm/switch_to.h>
#endif
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Song Liu <song@kernel.org>
Cc: linux-raid@vger.kernel.org, Paul Menzel <pmenzel@molgen.mpg.de>,
Matt Brown <matthew.brown.dev@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 2/3] lib/raid6: Include <asm/ppc-opcode.h> for `VPERMXOR`
Date: Wed, 26 Jan 2022 12:41:43 +0100 [thread overview]
Message-ID: <20220126114144.370517-2-pmenzel@molgen.mpg.de> (raw)
In-Reply-To: <20220126114144.370517-1-pmenzel@molgen.mpg.de>
On Ubuntu 21.10 (ppc64le) building `raid6test` with gcc (Ubuntu
11.2.0-7ubuntu2) 11.2.0 fails with the error below.
gcc -I.. -I ../../../include -g -O2 -I../../../arch/powerpc/include -DCONFIG_ALTIVEC -c -o vpermxor1.o vpermxor1.c
vpermxor1.c: In function ‘raid6_vpermxor1_gen_syndrome_real’:
vpermxor1.c:64:29: error: expected string literal before ‘VPERMXOR’
64 | asm(VPERMXOR(%0,%1,%2,%3):"=v"(wq0):"v"(gf_high), "v"(gf_low), "v"(wq0));
| ^~~~~~~~
make: *** [Makefile:58: vpermxor1.o] Error 1
So, include the header `asm/ppc-opcode.h` defining this macro also when
not building the Linux kernel but only this too.
Cc: Matt Brown <matthew.brown.dev@gmail.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
lib/raid6/vpermxor.uc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/raid6/vpermxor.uc b/lib/raid6/vpermxor.uc
index 10475dc423c1..1bfb127fbfe8 100644
--- a/lib/raid6/vpermxor.uc
+++ b/lib/raid6/vpermxor.uc
@@ -24,9 +24,9 @@
#ifdef CONFIG_ALTIVEC
#include <altivec.h>
+#include <asm/ppc-opcode.h>
#ifdef __KERNEL__
#include <asm/cputable.h>
-#include <asm/ppc-opcode.h>
#include <asm/switch_to.h>
#endif
--
2.34.1
next prev parent reply other threads:[~2022-01-26 11:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 11:41 [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3 Paul Menzel
2022-01-26 11:41 ` Paul Menzel
2022-01-26 11:41 ` Paul Menzel [this message]
2022-01-26 11:41 ` [PATCH 2/3] lib/raid6: Include <asm/ppc-opcode.h> for `VPERMXOR` Paul Menzel
2022-01-26 11:41 ` [PATCH 3/3] lib/raid6/test: Rename variable to avoid `raid6_call` name clash Paul Menzel
2022-01-26 11:41 ` Paul Menzel
2022-01-26 12:06 ` [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3 David Laight
2022-01-26 12:06 ` David Laight
2022-01-26 12:12 ` Paul Menzel
2022-01-26 12:12 ` Paul Menzel
2022-01-26 19:29 ` Tim Small
2022-01-26 19:29 ` Tim Small
2022-01-26 14:38 ` a pound's a pound the whole world 'round (was "Re: [PATCH 1/3] ... Use `$(pound)` instead ...") David T-G
2022-02-08 6:43 ` [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3 Song Liu
2022-02-08 6:43 ` Song Liu
2022-02-08 18:44 ` Wols Lists
2022-02-08 18:44 ` Wols Lists
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126114144.370517-2-pmenzel@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=linux-raid@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthew.brown.dev@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.