From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>, Oleksii <oleksii.kurochko@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1] xen/arm: align *(.proc.info) in the linker script
Date: Thu, 2 Mar 2023 12:21:12 +0100 [thread overview]
Message-ID: <0c401165-6057-2a4c-249a-be877741180b@suse.com> (raw)
In-Reply-To: <7e69d61b-60ca-b93a-36d3-77a1a3e550ec@xen.org>
On 02.03.2023 12:01, Julien Grall wrote:
> On 02/03/2023 09:45, Jan Beulich wrote:
>> On 01.03.2023 21:38, Julien Grall wrote:
>>> I managed to reproduce it. It looks like that after your bug patch,
>>> *(.rodata.*) will not be end on a 4-byte boundary. Before your patch,
>>> all the messages will be in .rodata.str. Now they are in .bug_frames.*,
>>> so there some difference in .rodata.*.
>>
>> Strings in .bug_frames.*? This sounds like a mistake, which - if indeed
>> the case - will want investigating before the conversion series is
>> actually considered for committing.
>
> No. I misread the code. But there are definitely a difference in size:
>
> Before:
>
> Section Headers:
> [Nr] Name Type Addr Off Size ES Flg
> Lk Inf Al
> [ 0] NULL 00000000 000000 000000 00
> 0 0 0
> [ 1] .text PROGBITS 00200000 008000 07e7a8 00 WAX
> 0 0 32
> [ 2] .rodata PROGBITS 0027f000 087000 02acc8 00 A
> 0 0 16
>[...]
> After:
>
> [Nr] Name Type Addr Off Size ES Flg
> Lk Inf Al
> [ 0] NULL 00000000 000000 000000 00
> 0 0 0
> [ 1] .text PROGBITS 00200000 008000 07e670 00 WAX
> 0 0 32
> [ 2] .rodata PROGBITS 0027f000 087000 02b3e8 00 A
> 0 0 16
I still find this concerning (as in: at least needing explanation), as
the bug frame representation shrinks in size: Entries for assertions
remain to be 4 ".long"-s, while all other entries use only two now. So
in a release build the size of all .bug_frame.* together should halve,
while in debug builds it should shrink at least some. And Oleksii's
series doesn't add meaningful other contributions to .rodata, iirc.
Jan
next prev parent reply other threads:[~2023-03-02 11:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 16:14 [PATCH v1] xen/arm: align *(.proc.info) in the linker script Oleksii Kurochko
2023-03-01 16:21 ` Julien Grall
2023-03-01 16:38 ` Oleksii
2023-03-01 17:50 ` Julien Grall
2023-03-01 20:38 ` Julien Grall
2023-03-02 7:34 ` Oleksii
2023-03-02 14:50 ` Julien Grall
2023-03-02 17:24 ` Oleksii
2023-03-02 9:45 ` Jan Beulich
2023-03-02 11:01 ` Julien Grall
2023-03-02 11:21 ` Jan Beulich [this message]
2023-03-02 12:51 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c401165-6057-2a4c-249a-be877741180b@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.