All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
	xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v1] xen/arm: align *(.proc.info) in the linker script
Date: Wed, 1 Mar 2023 16:21:42 +0000	[thread overview]
Message-ID: <370809af-75e6-546a-53e4-71a76444f367@xen.org> (raw)
In-Reply-To: <74973920d8722df3ce533979314564f331acf16e.1677687247.git.oleksii.kurochko@gmail.com>

Hi Oleksii,

On 01/03/2023 16:14, Oleksii Kurochko wrote:
> During testing of bug.h's macros generic implementation yocto-qemuarm
> job crashed with data abort:

The commit message is lacking some information. You are telling us that 
there is an error when building with your series, but this doesn't tell 
me why this is the correct fix.

This is also why I asked to have the xen binary because I want to check 
whether this was a latent bug in Xen or your series effectively 
introduce a bug.

Note that regardless what I just wrote this is a good idea to align 
__proc_info_start. I will try to have a closer look later and propose a 
commit message and/or any action for your other series.

Cheers,

-- 
Julien Grall


  reply	other threads:[~2023-03-01 16:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01 16:14 [PATCH v1] xen/arm: align *(.proc.info) in the linker script Oleksii Kurochko
2023-03-01 16:21 ` Julien Grall [this message]
2023-03-01 16:38   ` Oleksii
2023-03-01 17:50     ` Julien Grall
2023-03-01 20:38       ` Julien Grall
2023-03-02  7:34         ` Oleksii
2023-03-02 14:50           ` Julien Grall
2023-03-02 17:24             ` Oleksii
2023-03-02  9:45         ` Jan Beulich
2023-03-02 11:01           ` Julien Grall
2023-03-02 11:21             ` Jan Beulich
2023-03-02 12:51               ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=370809af-75e6-546a-53e4-71a76444f367@xen.org \
    --to=julien@xen.org \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.