From: govinds@codeaurora.org To: Arend van Spriel <arend.vanspriel@broadcom.com> Cc: Sebastian Gottschall <s.gottschall@dd-wrt.com>, Kalle Valo <kvalo@codeaurora.org>, pillair@codeaurora.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2 4/4] ath10k: Enable sta idle power save Date: Fri, 20 Apr 2018 18:13:39 +0530 [thread overview] Message-ID: <0c70fb177d5ca9be7b81384b06d60949@codeaurora.org> (raw) In-Reply-To: <5AD9A1DF.6060007@broadcom.com> On 2018-04-20 13:46, Arend van Spriel wrote: > On 4/20/2018 9:21 AM, Sebastian Gottschall wrote: >> >>>> Yes this is WIFI chip set level power-save(based on idleness) and >>>> not >>>> related to protocol power save. FW will turn off/scale down the >>>> resources(clock/rails) based on opportunity(when ever idle mode is >>>> detected). This power save is mostly done in disconnected state. I >>>> am >>>> not really sure when framework/user-space triggers power-save >>>> config(iw dev <devname> set power_save on/off). Then doing this from >>>> user-space will be unnecessarily toggling this config or may not be >>>> setting at disconnected state. >>> I think that 'set power_save' commands affects struct >>> ieee80211_bss_conf::ps parameter and I don't think it should be used >>> in >>> this case. We already have ath10k_config_ps() for 802.11 level of >>> power >>> saving. >>> >>> Arend again proposed runtime-pm with which I'm not very familiar. But >>> why would we want to disable this? Doesn't it make sense to have this >>> feature always enabled to save power? wcn3990 is a chip for a mobile >>> device anyway. >> it might be made for mobile devices but who knows how it is used by >> the >> market. I guess having this enabled by default is safe as WMI_PDEV_PARAM_UNSUPPORTED protects for those version which does not support this pdev param. > Reading the explanation above it does not make sense to use > runtime-pm. That would only come into play if the host driver would > actually control the resources being turned off/scaled down. > > So this is purely reducing power-consumption of the chip. However, it > would be good to know the consequences in terms of responsiveness to > firmware commands for instance when requesting a scan operation. Exit latency is around 8-10 ms, so i guess this delta should be ok. > Another thing to consider is to provide user-space with possibility to > change this configuration (maybe through debugfs?). In case any one wants to measure power no's with/without this config, just giving provision to disable may be useful. BR, Govind
WARNING: multiple messages have this Message-ID (diff)
From: govinds@codeaurora.org To: Arend van Spriel <arend.vanspriel@broadcom.com> Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, pillair@codeaurora.org, Kalle Valo <kvalo@codeaurora.org>, Sebastian Gottschall <s.gottschall@dd-wrt.com> Subject: Re: [PATCH v2 4/4] ath10k: Enable sta idle power save Date: Fri, 20 Apr 2018 18:13:39 +0530 [thread overview] Message-ID: <0c70fb177d5ca9be7b81384b06d60949@codeaurora.org> (raw) In-Reply-To: <5AD9A1DF.6060007@broadcom.com> On 2018-04-20 13:46, Arend van Spriel wrote: > On 4/20/2018 9:21 AM, Sebastian Gottschall wrote: >> >>>> Yes this is WIFI chip set level power-save(based on idleness) and >>>> not >>>> related to protocol power save. FW will turn off/scale down the >>>> resources(clock/rails) based on opportunity(when ever idle mode is >>>> detected). This power save is mostly done in disconnected state. I >>>> am >>>> not really sure when framework/user-space triggers power-save >>>> config(iw dev <devname> set power_save on/off). Then doing this from >>>> user-space will be unnecessarily toggling this config or may not be >>>> setting at disconnected state. >>> I think that 'set power_save' commands affects struct >>> ieee80211_bss_conf::ps parameter and I don't think it should be used >>> in >>> this case. We already have ath10k_config_ps() for 802.11 level of >>> power >>> saving. >>> >>> Arend again proposed runtime-pm with which I'm not very familiar. But >>> why would we want to disable this? Doesn't it make sense to have this >>> feature always enabled to save power? wcn3990 is a chip for a mobile >>> device anyway. >> it might be made for mobile devices but who knows how it is used by >> the >> market. I guess having this enabled by default is safe as WMI_PDEV_PARAM_UNSUPPORTED protects for those version which does not support this pdev param. > Reading the explanation above it does not make sense to use > runtime-pm. That would only come into play if the host driver would > actually control the resources being turned off/scaled down. > > So this is purely reducing power-consumption of the chip. However, it > would be good to know the consequences in terms of responsiveness to > firmware commands for instance when requesting a scan operation. Exit latency is around 8-10 ms, so i guess this delta should be ok. > Another thing to consider is to provide user-space with possibility to > change this configuration (maybe through debugfs?). In case any one wants to measure power no's with/without this config, just giving provision to disable may be useful. BR, Govind _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-04-20 12:43 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-17 12:06 [PATCH v2 0/4] Support for STA idle mode power save(IMPS) pillair 2018-04-17 12:06 ` pillair 2018-04-17 12:06 ` [PATCH v2 1/4] ath10k: Add hw params for shadow register support pillair 2018-04-17 12:06 ` pillair 2018-04-24 6:05 ` [v2,1/4] " Kalle Valo 2018-04-24 6:05 ` Kalle Valo 2018-04-17 12:06 ` [PATCH v2 2/4] ath10k: Add support for shadow register for WNC3990 pillair 2018-04-17 12:06 ` pillair 2018-04-17 12:07 ` [PATCH v2 3/4] ath10k: Enable SRRI/DRRI support on ddr for WCN3990 pillair 2018-04-17 12:07 ` pillair 2018-04-17 12:07 ` [PATCH v2 4/4] ath10k: Enable sta idle power save pillair 2018-04-17 12:07 ` pillair 2018-04-18 7:06 ` Sebastian Gottschall 2018-04-18 7:06 ` Sebastian Gottschall 2018-04-18 13:07 ` govinds 2018-04-18 13:07 ` govinds 2018-04-18 13:16 ` Kalle Valo 2018-04-18 13:16 ` Kalle Valo 2018-04-18 14:44 ` Arend van Spriel 2018-04-18 14:44 ` Arend van Spriel 2018-04-19 4:32 ` govinds 2018-04-19 4:32 ` govinds 2018-04-19 16:36 ` Kalle Valo 2018-04-19 16:36 ` Kalle Valo 2018-04-19 17:00 ` Adrian Chadd 2018-04-19 17:00 ` Adrian Chadd 2018-04-20 7:21 ` Sebastian Gottschall 2018-04-20 7:21 ` Sebastian Gottschall 2018-04-20 8:16 ` Arend van Spriel 2018-04-20 8:16 ` Arend van Spriel 2018-04-20 12:43 ` govinds [this message] 2018-04-20 12:43 ` govinds 2018-04-23 15:50 ` Kalle Valo 2018-04-23 15:50 ` Kalle Valo 2018-04-23 16:17 ` 9984 with 10.4.3.5.3-0057 crashes Sebastian Gottschall 2018-04-24 5:27 ` Kalle Valo 2018-04-24 6:08 ` Sebastian Gottschall 2018-04-25 15:23 ` Kalle Valo 2018-04-26 6:23 ` Sebastian Gottschall 2018-04-26 7:36 ` Sebastian Gottschall 2018-04-23 16:41 ` [PATCH v2 4/4] ath10k: Enable sta idle power save Adrian Chadd 2018-04-23 16:41 ` Adrian Chadd 2018-04-24 5:35 ` Kalle Valo 2018-04-24 5:35 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0c70fb177d5ca9be7b81384b06d60949@codeaurora.org \ --to=govinds@codeaurora.org \ --cc=arend.vanspriel@broadcom.com \ --cc=ath10k@lists.infradead.org \ --cc=kvalo@codeaurora.org \ --cc=linux-wireless@vger.kernel.org \ --cc=pillair@codeaurora.org \ --cc=s.gottschall@dd-wrt.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.