All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: Kalle Valo <kvalo@codeaurora.org>, govinds@codeaurora.org
Cc: pillair@codeaurora.org, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org, arend.vanspriel@broadcom.com
Subject: Re: [PATCH v2 4/4] ath10k: Enable sta idle power save
Date: Fri, 20 Apr 2018 09:21:33 +0200	[thread overview]
Message-ID: <c48c1bae-04c9-55d0-fdb9-d9ae8f7cb843@dd-wrt.com> (raw)
In-Reply-To: <8736zrjgq6.fsf@kamboji.qca.qualcomm.com>


>> Yes this is WIFI chip set level power-save(based on idleness) and not
>> related to protocol power save. FW will turn off/scale down the
>> resources(clock/rails) based on opportunity(when ever idle mode is
>> detected). This power save is mostly done in disconnected state. I am
>> not really sure when framework/user-space triggers power-save
>> config(iw dev <devname> set power_save on/off). Then doing this from
>> user-space will be unnecessarily toggling this config or may not be
>> setting at disconnected state.
> I think that 'set power_save' commands affects struct
> ieee80211_bss_conf::ps parameter and I don't think it should be used in
> this case. We already have ath10k_config_ps() for 802.11 level of power
> saving.
>
> Arend again proposed runtime-pm with which I'm not very familiar. But
> why would we want to disable this? Doesn't it make sense to have this
> feature always enabled to save power? wcn3990 is a chip for a mobile
> device anyway.
it might be made for mobile devices but who knows how it is used by the 
market.

Sebastian
>

-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: Kalle Valo <kvalo@codeaurora.org>, govinds@codeaurora.org
Cc: linux-wireless@vger.kernel.org, arend.vanspriel@broadcom.com,
	pillair@codeaurora.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 4/4] ath10k: Enable sta idle power save
Date: Fri, 20 Apr 2018 09:21:33 +0200	[thread overview]
Message-ID: <c48c1bae-04c9-55d0-fdb9-d9ae8f7cb843@dd-wrt.com> (raw)
In-Reply-To: <8736zrjgq6.fsf@kamboji.qca.qualcomm.com>


>> Yes this is WIFI chip set level power-save(based on idleness) and not
>> related to protocol power save. FW will turn off/scale down the
>> resources(clock/rails) based on opportunity(when ever idle mode is
>> detected). This power save is mostly done in disconnected state. I am
>> not really sure when framework/user-space triggers power-save
>> config(iw dev <devname> set power_save on/off). Then doing this from
>> user-space will be unnecessarily toggling this config or may not be
>> setting at disconnected state.
> I think that 'set power_save' commands affects struct
> ieee80211_bss_conf::ps parameter and I don't think it should be used in
> this case. We already have ath10k_config_ps() for 802.11 level of power
> saving.
>
> Arend again proposed runtime-pm with which I'm not very familiar. But
> why would we want to disable this? Doesn't it make sense to have this
> feature always enabled to save power? wcn3990 is a chip for a mobile
> device anyway.
it might be made for mobile devices but who knows how it is used by the 
market.

Sebastian
>

-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2018-04-20  7:21 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 12:06 [PATCH v2 0/4] Support for STA idle mode power save(IMPS) pillair
2018-04-17 12:06 ` pillair
2018-04-17 12:06 ` [PATCH v2 1/4] ath10k: Add hw params for shadow register support pillair
2018-04-17 12:06   ` pillair
2018-04-24  6:05   ` [v2,1/4] " Kalle Valo
2018-04-24  6:05   ` Kalle Valo
2018-04-17 12:06 ` [PATCH v2 2/4] ath10k: Add support for shadow register for WNC3990 pillair
2018-04-17 12:06   ` pillair
2018-04-17 12:07 ` [PATCH v2 3/4] ath10k: Enable SRRI/DRRI support on ddr for WCN3990 pillair
2018-04-17 12:07   ` pillair
2018-04-17 12:07 ` [PATCH v2 4/4] ath10k: Enable sta idle power save pillair
2018-04-17 12:07   ` pillair
2018-04-18  7:06   ` Sebastian Gottschall
2018-04-18  7:06     ` Sebastian Gottschall
2018-04-18 13:07     ` govinds
2018-04-18 13:07       ` govinds
2018-04-18 13:16       ` Kalle Valo
2018-04-18 13:16         ` Kalle Valo
2018-04-18 14:44         ` Arend van Spriel
2018-04-18 14:44           ` Arend van Spriel
2018-04-19  4:32         ` govinds
2018-04-19  4:32           ` govinds
2018-04-19 16:36           ` Kalle Valo
2018-04-19 16:36             ` Kalle Valo
2018-04-19 17:00             ` Adrian Chadd
2018-04-19 17:00               ` Adrian Chadd
2018-04-20  7:21             ` Sebastian Gottschall [this message]
2018-04-20  7:21               ` Sebastian Gottschall
2018-04-20  8:16               ` Arend van Spriel
2018-04-20  8:16                 ` Arend van Spriel
2018-04-20 12:43                 ` govinds
2018-04-20 12:43                   ` govinds
2018-04-23 15:50                 ` Kalle Valo
2018-04-23 15:50                   ` Kalle Valo
2018-04-23 16:17                   ` 9984 with 10.4.3.5.3-0057 crashes Sebastian Gottschall
2018-04-24  5:27                     ` Kalle Valo
2018-04-24  6:08                       ` Sebastian Gottschall
2018-04-25 15:23                         ` Kalle Valo
2018-04-26  6:23                           ` Sebastian Gottschall
2018-04-26  7:36                           ` Sebastian Gottschall
2018-04-23 16:41                   ` [PATCH v2 4/4] ath10k: Enable sta idle power save Adrian Chadd
2018-04-23 16:41                     ` Adrian Chadd
2018-04-24  5:35                     ` Kalle Valo
2018-04-24  5:35                       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c48c1bae-04c9-55d0-fdb9-d9ae8f7cb843@dd-wrt.com \
    --to=s.gottschall@dd-wrt.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=ath10k@lists.infradead.org \
    --cc=govinds@codeaurora.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pillair@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.