All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: kernel test robot <lkp@intel.com>,
	Xianting Tian <xianting.tian@linux.alibaba.com>,
	gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de,
	osandov@fb.com
Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
	linuxppc-dev@lists.ozlabs.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars()
Date: Fri, 13 Aug 2021 07:53:51 +0200	[thread overview]
Message-ID: <0c808001-7643-fdcf-66ba-738654ec0c21@kernel.org> (raw)
In-Reply-To: <202108122040.lBf24DNp-lkp@intel.com>

Hi,

On 12. 08. 21, 14:26, kernel test robot wrote:
>>> drivers/tty/hvc/hvc_console.c:190:26: warning: variable 'hp' is uninitialized when used here [-Wuninitialized]
>             spin_unlock_irqrestore(&hp->c_lock, flags);
>                                     ^~
>     drivers/tty/hvc/hvc_console.c:149:23: note: initialize the variable 'hp' to silence this warning
>             struct hvc_struct *hp;
>                                  ^
>                                   = NULL

So you clearly didn't test your change as it would crash quite 
instantly. I wonder, where do you intend to get hp from in the 
console::print() hook?

thanks,
-- 
js
suse labs

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@kernel.org>
To: kernel test robot <lkp@intel.com>,
	Xianting Tian <xianting.tian@linux.alibaba.com>,
	gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de,
	osandov@fb.com
Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars()
Date: Fri, 13 Aug 2021 07:53:51 +0200	[thread overview]
Message-ID: <0c808001-7643-fdcf-66ba-738654ec0c21@kernel.org> (raw)
In-Reply-To: <202108122040.lBf24DNp-lkp@intel.com>

Hi,

On 12. 08. 21, 14:26, kernel test robot wrote:
>>> drivers/tty/hvc/hvc_console.c:190:26: warning: variable 'hp' is uninitialized when used here [-Wuninitialized]
>             spin_unlock_irqrestore(&hp->c_lock, flags);
>                                     ^~
>     drivers/tty/hvc/hvc_console.c:149:23: note: initialize the variable 'hp' to silence this warning
>             struct hvc_struct *hp;
>                                  ^
>                                   = NULL

So you clearly didn't test your change as it would crash quite 
instantly. I wonder, where do you intend to get hp from in the 
console::print() hook?

thanks,
-- 
js
suse labs

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars()
Date: Fri, 13 Aug 2021 07:53:51 +0200	[thread overview]
Message-ID: <0c808001-7643-fdcf-66ba-738654ec0c21@kernel.org> (raw)
In-Reply-To: <202108122040.lBf24DNp-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Hi,

On 12. 08. 21, 14:26, kernel test robot wrote:
>>> drivers/tty/hvc/hvc_console.c:190:26: warning: variable 'hp' is uninitialized when used here [-Wuninitialized]
>             spin_unlock_irqrestore(&hp->c_lock, flags);
>                                     ^~
>     drivers/tty/hvc/hvc_console.c:149:23: note: initialize the variable 'hp' to silence this warning
>             struct hvc_struct *hp;
>                                  ^
>                                   = NULL

So you clearly didn't test your change as it would crash quite 
instantly. I wonder, where do you intend to get hp from in the 
console::print() hook?

thanks,
-- 
js
suse labs

  reply	other threads:[~2021-08-13  5:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  9:45 [PATCH v6 0/2] make hvc pass dma capable memory to its backend Xianting Tian
2021-08-12  9:45 ` Xianting Tian
2021-08-12  9:45 ` [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars() Xianting Tian
2021-08-12  9:45   ` Xianting Tian
2021-08-12 12:26   ` kernel test robot
2021-08-12 12:26     ` kernel test robot
2021-08-12 12:26     ` kernel test robot
2021-08-12 12:26     ` kernel test robot
2021-08-13  5:53     ` Jiri Slaby [this message]
2021-08-13  5:53       ` Jiri Slaby
2021-08-13  5:53       ` Jiri Slaby
2021-08-13  6:04       ` Xianting TIan
2021-08-13  6:04         ` Xianting TIan
2021-08-13  6:04         ` Xianting TIan
2021-08-13 16:07       ` Xianting TIan
2021-08-13 16:07         ` Xianting TIan
2021-08-13 16:07         ` Xianting TIan
2021-08-13  7:27   ` Greg KH
2021-08-13  7:27     ` Greg KH
2021-08-13  7:27     ` Greg KH
2021-08-13 11:27     ` Xianting TIan
2021-08-13 11:27       ` Xianting TIan
2021-08-12  9:45 ` [PATCH v6 2/2] virtio-console: remove unnecessary kmemdup() Xianting Tian
2021-08-12  9:45   ` Xianting Tian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c808001-7643-fdcf-66ba-738654ec0c21@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=amit@kernel.org \
    --cc=arnd@arndb.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lkp@intel.com \
    --cc=osandov@fb.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xianting.tian@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.