All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <quic_cang@quicinc.com>,
	mani@kernel.org, adrian.hunter@intel.com, cmd4@qualcomm.com,
	beanhuo@micron.com, avri.altman@wdc.com,
	junwoo80.lee@samsung.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Stanley Chu" <stanley.chu@mediatek.com>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Nitin Rawat" <quic_nitirawa@quicinc.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Brian Masney" <bmasney@redhat.com>,
	"moderated list:ARM/SAMSUNG S3C,
	S5P AND EXYNOS ARM ARCHITECTURES"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/SAMSUNG S3C,
	S5P AND EXYNOS ARM ARCHITECTURES"
	<linux-samsung-soc@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER
	DRIVER..." <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v6 01/10] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params
Date: Wed, 29 Nov 2023 10:11:38 -0800	[thread overview]
Message-ID: <0cc74796-2369-4c02-a78f-4f1d5e8337dc@acm.org> (raw)
In-Reply-To: <1701246516-11626-2-git-send-email-quic_cang@quicinc.com>

On 11/29/23 00:28, Can Guo wrote:
> Structure ufs_dev_params is actually used in UFS host vendor drivers to
> declare host specific power mode parameters, like ufs_<vendor>_params or
> host_cap, which makes the code not very straightforward to read. Rename the
> structure ufs_dev_params to ufs_host_params and unify the declarations in
> all vendor drivers to host_params.
> 
> In addition, rename the two functions ufshcd_init_pwr_dev_param() and
> ufshcd_get_pwr_dev_param() which work based on the ufs_host_params to
> ufshcd_init_host_params() and ufshcd_negotiate_pwr_params() respectively to
> avoid confusions.
> 
> This change does not change any functionalities or logic.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <quic_cang@quicinc.com>,
	mani@kernel.org, adrian.hunter@intel.com, cmd4@qualcomm.com,
	beanhuo@micron.com, avri.altman@wdc.com,
	junwoo80.lee@samsung.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Stanley Chu" <stanley.chu@mediatek.com>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Nitin Rawat" <quic_nitirawa@quicinc.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Brian Masney" <bmasney@redhat.com>,
	"moderated list:ARM/SAMSUNG S3C,
	S5P AND EXYNOS ARM ARCHITECTURES"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/SAMSUNG S3C,
	S5P AND EXYNOS ARM ARCHITECTURES"
	<linux-samsung-soc@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER
	DRIVER..." <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v6 01/10] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params
Date: Wed, 29 Nov 2023 10:11:38 -0800	[thread overview]
Message-ID: <0cc74796-2369-4c02-a78f-4f1d5e8337dc@acm.org> (raw)
In-Reply-To: <1701246516-11626-2-git-send-email-quic_cang@quicinc.com>

On 11/29/23 00:28, Can Guo wrote:
> Structure ufs_dev_params is actually used in UFS host vendor drivers to
> declare host specific power mode parameters, like ufs_<vendor>_params or
> host_cap, which makes the code not very straightforward to read. Rename the
> structure ufs_dev_params to ufs_host_params and unify the declarations in
> all vendor drivers to host_params.
> 
> In addition, rename the two functions ufshcd_init_pwr_dev_param() and
> ufshcd_get_pwr_dev_param() which work based on the ufs_host_params to
> ufshcd_init_host_params() and ufshcd_negotiate_pwr_params() respectively to
> avoid confusions.
> 
> This change does not change any functionalities or logic.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-11-29 18:11 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29  8:28 [PATCH v6 00/10] Enable HS-G5 support on SM8550 Can Guo
2023-11-29  8:28 ` Can Guo
2023-11-29  8:28 ` [PATCH v6 01/10] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params Can Guo
2023-11-29  8:28   ` Can Guo
2023-11-29 18:11   ` Bart Van Assche [this message]
2023-11-29 18:11     ` Bart Van Assche
2023-11-29  8:28 ` [PATCH v6 02/10] scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param() Can Guo
2023-11-29 20:48   ` Andrew Halaney
2023-11-29  8:28 ` [PATCH v6 03/10] scsi: ufs: ufs-qcom: Setup host power mode during init Can Guo
2023-11-29  8:28 ` [PATCH v6 04/10] scsi: ufs: ufs-qcom: Allow the first init start with the maximum supported gear Can Guo
2023-11-30  6:42   ` Manivannan Sadhasivam
2023-11-30  7:44     ` Can Guo
2023-11-29  8:28 ` [PATCH v6 05/10] scsi: ufs: ufs-qcom: Limit HS-G5 Rate-A to hosts with HW version 5 Can Guo
2023-11-29  8:28 ` [PATCH v6 06/10] scsi: ufs: ufs-qcom: Set initial PHY gear to max HS gear for HW ver 4 and newer Can Guo
2023-11-30  5:52   ` Nitin Rawat
2023-11-30  6:47   ` Manivannan Sadhasivam
2023-11-30  7:49     ` Can Guo
2023-11-29  8:28 ` [PATCH v6 07/10] phy: qualcomm: phy-qcom-qmp-ufs: Rectify SM8550 UFS HS-G4 PHY Settings Can Guo
2023-11-29  8:28   ` Can Guo
2023-11-29  8:28 ` [PATCH v6 08/10] phy: qualcomm: phy-qcom-qmp-ufs: Add High Speed Gear 5 support for SM8550 Can Guo
2023-11-29  8:28   ` Can Guo
2023-11-30  7:12   ` Manivannan Sadhasivam
2023-11-30  7:12     ` Manivannan Sadhasivam
2023-11-30  8:14     ` Can Guo
2023-11-30  8:14       ` Can Guo
2023-11-30  8:38       ` Manivannan Sadhasivam
2023-11-30  8:38         ` Manivannan Sadhasivam
2023-11-30  8:49         ` Can Guo
2023-11-30  8:49           ` Can Guo
2023-11-30  9:34           ` Manivannan Sadhasivam
2023-11-30  9:34             ` Manivannan Sadhasivam
2023-11-30  9:35             ` Can Guo
2023-11-30  9:35               ` Can Guo
2023-11-29  8:28 ` [PATCH v6 09/10] scsi: ufs: ufs-qcom: Check return value of phy_set_mode_ext() Can Guo
2023-11-29  8:38   ` Nitin Rawat
2023-11-30  7:16   ` Manivannan Sadhasivam
2023-11-30  8:19     ` Can Guo
2023-11-29  8:28 ` [PATCH v6 10/10] scsi: ufs: ufs-qcom: Add support for UFS device version detection Can Guo
2023-11-29 19:04   ` Eric Chanudet
2023-11-30  7:28     ` Manivannan Sadhasivam
2023-11-30  7:25   ` Manivannan Sadhasivam
2023-11-30  8:21     ` Can Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cc74796-2369-4c02-a78f-4f1d5e8337dc@acm.org \
    --to=bvanassche@acm.org \
    --cc=adrian.hunter@intel.com \
    --cc=agross@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bmasney@redhat.com \
    --cc=cmd4@qualcomm.com \
    --cc=jejb@linux.ibm.com \
    --cc=junwoo80.lee@samsung.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=stanley.chu@mediatek.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.